aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/LocalFilesEditor
diff options
context:
space:
mode:
authormistic100 <mistic@piwigo.org>2013-10-19 17:43:04 +0000
committermistic100 <mistic@piwigo.org>2013-10-19 17:43:04 +0000
commitae707279a1945e383c312cd648d288606a79e341 (patch)
tree917bdc6e0609ed0eefed5f3693de3a017685acc4 /plugins/LocalFilesEditor
parent35ff1b7c1f933799397a0ce0a6723cf82f416ff3 (diff)
remove all array_push (50% slower than []) + some changes missing for feature:2978
git-svn-id: http://piwigo.org/svn/trunk@25018 68402e56-0260-453c-a942-63ccdbb3a9ee
Diffstat (limited to 'plugins/LocalFilesEditor')
-rw-r--r--plugins/LocalFilesEditor/admin.php13
-rw-r--r--plugins/LocalFilesEditor/include/css.inc.php6
-rw-r--r--plugins/LocalFilesEditor/include/tpl.inc.php8
-rw-r--r--plugins/LocalFilesEditor/main.inc.php9
4 files changed, 16 insertions, 20 deletions
diff --git a/plugins/LocalFilesEditor/admin.php b/plugins/LocalFilesEditor/admin.php
index 71d0e220f..29a5b6324 100644
--- a/plugins/LocalFilesEditor/admin.php
+++ b/plugins/LocalFilesEditor/admin.php
@@ -56,9 +56,8 @@ include_once(LOCALEDIT_PATH.'include/'.$page['tab'].'.inc.php');
if (isset($_POST['restore']))
{
$content_file = file_get_contents(get_bak_file($edited_file));
- array_push($page['infos'],
- l10n('locfiledit_bak_loaded1'),
- l10n('locfiledit_bak_loaded2'));
+ $page['infos'][] = l10n('locfiledit_bak_loaded1'),
+ $page['infos'][] = l10n('locfiledit_bak_loaded2');
}
// +-----------------------------------------------------------------------+
@@ -70,7 +69,7 @@ if (isset($_POST['submit']))
if (!is_webmaster())
{
- array_push($page['errors'], l10n('locfiledit_webmaster_only'));
+ $page['errors'][] = l10n('locfiledit_webmaster_only');
}
else
{
@@ -81,7 +80,7 @@ if (isset($_POST['submit']))
}
if ($content_file === false)
{
- array_push($page['errors'], l10n('locfiledit_syntax_error'));
+ $page['errors'][] = l10n('locfiledit_syntax_error');
}
else
{
@@ -92,7 +91,7 @@ if (isset($_POST['submit']))
if (file_exists($edited_file))
{
@copy($edited_file, get_bak_file($edited_file));
- array_push($page['infos'], l10n('locfiledit_saved_bak', substr(get_bak_file($edited_file), 2)));
+ $page['infos'][] = l10n('locfiledit_saved_bak', substr(get_bak_file($edited_file), 2));
}
if ($file = @fopen($edited_file , "w"))
@@ -104,7 +103,7 @@ if (isset($_POST['submit']))
}
else
{
- array_push($page['errors'], l10n('locfiledit_cant_save'));
+ $page['errors'][] = l10n('locfiledit_cant_save');
}
}
}
diff --git a/plugins/LocalFilesEditor/include/css.inc.php b/plugins/LocalFilesEditor/include/css.inc.php
index e1d70995a..17ea92766 100644
--- a/plugins/LocalFilesEditor/include/css.inc.php
+++ b/plugins/LocalFilesEditor/include/css.inc.php
@@ -64,7 +64,7 @@ $db_themes = $themes->get_db_themes();
$db_theme_ids = array();
foreach ($db_themes as $db_theme)
{
- array_push($db_theme_ids, $db_theme['id']);
+ $db_theme_ids[] = $db_theme['id'];
}
$active_themes = array();
@@ -85,12 +85,12 @@ foreach ($themes->fs_themes as $theme_id => $fs_theme)
}
else
{
- array_push($active_themes, $fs_theme);
+ $active_themes[] = $fs_theme;
}
}
else
{
- array_push($inactive_themes, $fs_theme);
+ $inactive_themes[] = $fs_theme;
}
}
diff --git a/plugins/LocalFilesEditor/include/tpl.inc.php b/plugins/LocalFilesEditor/include/tpl.inc.php
index 4e985ac92..c1079a8e7 100644
--- a/plugins/LocalFilesEditor/include/tpl.inc.php
+++ b/plugins/LocalFilesEditor/include/tpl.inc.php
@@ -39,7 +39,7 @@ if (isset($_POST['create_tpl']))
$filename = $_POST['tpl_name'];
if (empty($filename))
{
- array_push($page['errors'], l10n('locfiledit_empty_filename'));
+ $page['errors'][] = l10n('locfiledit_empty_filename');
}
if (get_extension($filename) != 'tpl')
{
@@ -47,15 +47,15 @@ if (isset($_POST['create_tpl']))
}
if (!preg_match('/^[a-zA-Z0-9-_.]+$/', $filename))
{
- array_push($page['errors'], l10n('locfiledit_filename_error'));
+ $page['errors'][] = l10n('locfiledit_filename_error');
}
if (is_numeric($_POST['tpl_model']) and $_POST['tpl_model'] != '0')
{
- array_push($page['errors'], l10n('locfiledit_model_error'));
+ $page['errors'][] = l10n('locfiledit_model_error');
}
if (file_exists($_POST['tpl_parent'] . '/' . $filename))
{
- array_push($page['errors'], l10n('locfiledit_file_already_exists'));
+ $page['errors'][] = l10n('locfiledit_file_already_exists');
}
if (!empty($page['errors']))
{
diff --git a/plugins/LocalFilesEditor/main.inc.php b/plugins/LocalFilesEditor/main.inc.php
index e0a4eea75..cfe92c8b9 100644
--- a/plugins/LocalFilesEditor/main.inc.php
+++ b/plugins/LocalFilesEditor/main.inc.php
@@ -35,12 +35,9 @@ define('LOCALEDIT_PATH' , PHPWG_PLUGINS_PATH . basename(dirname(__FILE__)) . '/'
function localfiles_admin_menu($menu)
{
- array_push(
- $menu,
- array(
- 'NAME' => 'LocalFiles Editor',
- 'URL' => get_root_url().'admin.php?page=plugin-'.basename(dirname(__FILE__))
- )
+ $menu[] = array(
+ 'NAME' => 'LocalFiles Editor',
+ 'URL' => get_root_url().'admin.php?page=plugin-'.basename(dirname(__FILE__))
);
return $menu;