mirror of
https://github.com/MariaDB/server.git
synced 2025-07-28 22:20:58 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
85 lines
1.9 KiB
Text
85 lines
1.9 KiB
Text
#
|
|
# INSERT LOW_PRIORITY
|
|
#
|
|
--source have_engine.inc
|
|
|
|
# We will be changing the GLOBAL value of low_priority_updates
|
|
# due to bug#64892
|
|
# (Session-level low_priority_updates does not work for INSERT)
|
|
SET @low_prio_updates = @@global.low_priority_updates;
|
|
|
|
# Concurrent insert might interfere
|
|
# with HIGH|LOW_PRIORITY logic
|
|
SET @concur_insert = @@global.concurrent_insert;
|
|
SET GLOBAL concurrent_insert = NEVER;
|
|
|
|
--source create_table.inc
|
|
INSERT INTO t1 (a,b) VALUES (1,'f'),(2,'b');
|
|
|
|
# We will have 3 connections:
|
|
# con1 will start SELECT which should give us enough time;
|
|
# con0 will run INSERT
|
|
# con2 will then start another SELECT.
|
|
# With INSERT LOW_PRIORITY we should see only old rows in both resultsets.
|
|
|
|
--connect (con0,localhost,root,,)
|
|
SET lock_wait_timeout = 4;
|
|
--connect (con1,localhost,root,,)
|
|
SET lock_wait_timeout = 4;
|
|
--connect (con2,localhost,root,,)
|
|
SET lock_wait_timeout = 4;
|
|
|
|
--connection con1
|
|
|
|
--send
|
|
SELECT SLEEP(1) FROM t1;
|
|
|
|
--connection con0
|
|
let $show_statement = SHOW PROCESSLIST;
|
|
let $field = State;
|
|
let $condition = = 'User sleep';
|
|
# We don't need to wait long,
|
|
# thread should show up in the processlist right away
|
|
let $wait_timeout = 2;
|
|
--source include/wait_show_condition.inc
|
|
--send
|
|
INSERT LOW_PRIORITY INTO t1 (a,b) VALUES (3,'z');
|
|
|
|
--connection con2
|
|
|
|
let $condition = = 'Waiting for table level lock';
|
|
let $wait_timeout = 2;
|
|
--source include/wait_show_condition.inc
|
|
if (!$found)
|
|
{
|
|
--let $mysql_errname = timeout in wait_show_condition
|
|
--let $functionality = INSERT LOW_PRIORITY or table locking
|
|
--source unexpected_result.inc
|
|
}
|
|
if ($found)
|
|
{
|
|
--echo # Should return only 2 rows
|
|
SELECT SLEEP(1) FROM t1;
|
|
}
|
|
|
|
--connection con1
|
|
--reap
|
|
|
|
--connection con0
|
|
--reap
|
|
--sorted_result
|
|
SELECT a,b FROM t1;
|
|
|
|
--disconnect con0
|
|
--disconnect con1
|
|
--disconnect con2
|
|
--connection default
|
|
|
|
SET GLOBAL low_priority_updates = @low_prio_updates;
|
|
SET GLOBAL concurrent_insert = @concur_insert;
|
|
|
|
# Cleanup
|
|
DROP TABLE t1;
|
|
|
|
--source cleanup_engine.inc
|
|
|