mirror of
https://github.com/MariaDB/server.git
synced 2025-07-27 21:55:03 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
76 lines
2.4 KiB
Text
76 lines
2.4 KiB
Text
# Session connect attributes test
|
|
--source include/have_perfschema.inc
|
|
|
|
# although the connection attributes transfer code works
|
|
# with embedded P_S is not active, so the test won't run.
|
|
# TODO: remove this when P_S works with embedded.
|
|
--source include/not_embedded.inc
|
|
|
|
# basic performance_schema.session_connect_attrs tests
|
|
|
|
# check the presence of the pre-defined attributes
|
|
--echo # must return 0, 6
|
|
SELECT SUM(ISNULL(ATTR_VALUE)), COUNT(*)
|
|
FROM performance_schema.session_connect_attrs
|
|
WHERE ATTR_NAME IN ('_os', '_client_name', '_pid',
|
|
'_client_version', '_platform', 'program_name')
|
|
AND PROCESSLIST_ID = CONNECTION_ID();
|
|
|
|
# check the presence of the pre-defined attributes
|
|
--echo # must return 1
|
|
SELECT COUNT(DISTINCT PROCESSLIST_ID)
|
|
FROM performance_schema.session_connect_attrs;
|
|
|
|
|
|
# basic performance_schema.session_account_connect_attrs tests
|
|
|
|
# check the presence of the pre-defined attributes
|
|
--echo # must return 0, 6
|
|
SELECT SUM(ISNULL(ATTR_VALUE)), COUNT(*)
|
|
FROM performance_schema.session_account_connect_attrs
|
|
WHERE ATTR_NAME IN ('_os', '_client_name', '_pid',
|
|
'_client_version', '_platform', 'program_name')
|
|
AND PROCESSLIST_ID = CONNECTION_ID();
|
|
|
|
# check the presence of the pre-defined attributes
|
|
--echo # must return 1
|
|
SELECT COUNT(DISTINCT PROCESSLIST_ID)
|
|
FROM performance_schema.session_account_connect_attrs;
|
|
|
|
|
|
|
|
CREATE USER wl5924@localhost;
|
|
|
|
connect(non_privileged_user,localhost,wl5924,,"*NO-ONE*");
|
|
connection default;
|
|
|
|
--echo # must return 1
|
|
SELECT COUNT(DISTINCT PROCESSLIST_ID)
|
|
FROM performance_schema.session_account_connect_attrs;
|
|
|
|
--echo # must return 2
|
|
SELECT COUNT(DISTINCT PROCESSLIST_ID)
|
|
FROM performance_schema.session_connect_attrs;
|
|
|
|
connection non_privileged_user;
|
|
--echo # must return 1
|
|
SELECT COUNT(DISTINCT PROCESSLIST_ID)
|
|
FROM performance_schema.session_account_connect_attrs;
|
|
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT COUNT(DISTINCT PROCESSLIST_ID)
|
|
FROM performance_schema.session_connect_attrs;
|
|
|
|
connection default;
|
|
disconnect non_privileged_user;
|
|
|
|
grant select on performance_schema.* to wl5924@localhost;
|
|
change_user wl5924;
|
|
SELECT SUM(ISNULL(ATTR_VALUE)), COUNT(*)
|
|
FROM performance_schema.session_account_connect_attrs
|
|
WHERE ATTR_NAME IN ('_os', '_client_name', '_pid',
|
|
'_client_version', '_platform', 'program_name')
|
|
AND PROCESSLIST_ID = CONNECTION_ID();
|
|
change_user root,,test;
|
|
|
|
DROP USER wl5924@localhost;
|