mirror of
https://github.com/MariaDB/server.git
synced 2025-07-28 22:20:58 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
235 lines
6.6 KiB
Text
235 lines
6.6 KiB
Text
# *****************************************************************
|
|
# Test spatial index with isolation level Repeatable Read on DML
|
|
# This will also test the no phantom rows happens
|
|
# Check the COUNT(*) and SELECT results before & after COMMIT in
|
|
# the last con1 statement
|
|
# Test at con1: Global Repeatable Read con2 : Sess Read Committed
|
|
# Test at con1: Sess Repeatable Read con2 : Sess Read Committed
|
|
# *****************************************************************
|
|
--source include/have_innodb.inc
|
|
--source include/have_geometry.inc
|
|
--source include/not_embedded.inc
|
|
|
|
# Test Repeatable Read & Read committed at Global, Session levels
|
|
CREATE TABLE tab(c1 int NOT NULL PRIMARY KEY,c2 POINT NOT NULL,
|
|
c3 LINESTRING NOT NULL,c4 POLYGON NOT NULL,c5 GEOMETRY NOT NULL)
|
|
ENGINE=InnoDB;
|
|
|
|
ALTER TABLE tab ADD SPATIAL INDEX idx2(c2);
|
|
|
|
ALTER TABLE tab ADD SPATIAL KEY idx3(c3);
|
|
|
|
ALTER TABLE tab ADD SPATIAL INDEX idx4(c4) COMMENT 'testing spatial index on Polygon';
|
|
|
|
ALTER TABLE tab ADD SPATIAL KEY idx5(c5) COMMENT 'testing spatial index on Geometry';
|
|
|
|
INSERT INTO tab(c1,c2,c3,c4,c5)
|
|
VALUES(1,ST_GeomFromText('POINT(10 10)'),ST_GeomFromText('LINESTRING(5 5,20 20,30 30)'),
|
|
ST_GeomFromText('POLYGON((30 30,40 40,50 50,30 50,30 40,30 30))'),
|
|
ST_GeomFromText('POLYGON((30 30,40 40,50 50,30 50,30 40,30 30))'));
|
|
|
|
# 1 record is expected
|
|
SELECT c1,ST_AsText(c2),ST_AsText(c3),ST_AsText(c4),ST_AsText(c5) FROM tab;
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
--echo "In connection 1"
|
|
connect (con1,localhost,root,,);
|
|
connection con1;
|
|
|
|
SET GLOBAL TRANSACTION ISOLATION LEVEL REPEATABLE READ;
|
|
|
|
SELECT @@transaction_isolation;
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
# 1 record is expected
|
|
SELECT c1,ST_AsText(c2),ST_AsText(c3),ST_AsText(c4),ST_AsText(c5) FROM tab;
|
|
|
|
--echo "In connection 2"
|
|
connect (con2,localhost,root,,);
|
|
connection con2;
|
|
|
|
SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED;
|
|
|
|
SELECT @@transaction_isolation;
|
|
|
|
START TRANSACTION;
|
|
|
|
INSERT INTO tab(c1,c2,c3,c4,c5)
|
|
VALUES(2,ST_GeomFromText('POINT(20 20)'),ST_GeomFromText('LINESTRING(20 20,30 30,40 40)'),
|
|
ST_GeomFromText('POLYGON((40 50,40 70,50 100,70 100,80 80,70 50,40 50))'),
|
|
ST_GeomFromText('POLYGON((40 50,40 70,50 100,70 100,80 80,70 50,40 50))'));
|
|
|
|
SET @g1 = ST_GeomFromText('POLYGON((30 30,40 40,50 50,30 50,30 40,30 30))');
|
|
SET @g2 = ST_GeomFromText('POINT(10 10)');
|
|
|
|
# Record should be updated
|
|
UPDATE tab SET C5 = ST_GeomFromText('POLYGON((300 300,400 400,500 500,300 500,300 400,300 300))')
|
|
WHERE MBREquals(tab.c4, @g1) AND MBREquals(tab.c2, @g2);
|
|
|
|
--echo "In connection 1"
|
|
connection con1;
|
|
|
|
SET @g3 = ST_GeomFromText('POLYGON((40 50,40 70,50 100,70 100,80 80,70 50,40 50))');
|
|
|
|
# No record is expected (No phantom row)
|
|
SELECT c1,ST_AsText(c2),ST_AsText(c4),ST_AsText(c5) FROM tab WHERE MBREquals(tab.c5, @g3);
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
START TRANSACTION;
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
--echo "In connection 2"
|
|
connection con2;
|
|
|
|
# Record count should be 2
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
COMMIT;
|
|
|
|
disconnect con2;
|
|
|
|
--echo "In connection 1"
|
|
connection con1;
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
SET @g4 = ST_GeomFromText('POLYGON((300 300,400 400,500 500,300 500,300 400,300 300))');
|
|
|
|
# No records are expected (No phantom row)
|
|
SELECT ST_AsText(c5) FROM tab WHERE MBREquals(tab.c5, @g4);
|
|
|
|
COMMIT;
|
|
|
|
# The updated record is expected
|
|
SELECT ST_AsText(c5) FROM tab WHERE MBREquals(tab.c5, @g4);
|
|
|
|
# Record count should be 2
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
# 2 records are expected
|
|
SELECT c1,ST_AsText(c2),ST_AsText(c4),ST_AsText(c5) FROM tab;
|
|
|
|
disconnect con1;
|
|
--connection default
|
|
DROP TABLE tab;
|
|
|
|
# Test Repeatable Read & Read committed at Session levels
|
|
CREATE TABLE tab(c1 int NOT NULL PRIMARY KEY,c2 POINT NOT NULL,
|
|
c3 LINESTRING NOT NULL,c4 POLYGON NOT NULL,c5 GEOMETRY NOT NULL)
|
|
ENGINE=InnoDB;
|
|
|
|
ALTER TABLE tab ADD SPATIAL INDEX idx2(c2);
|
|
|
|
ALTER TABLE tab ADD SPATIAL KEY idx3(c3);
|
|
|
|
ALTER TABLE tab ADD SPATIAL INDEX idx4(c4) COMMENT 'testing spatial index on Polygon';
|
|
|
|
ALTER TABLE tab ADD SPATIAL KEY idx5(c5) COMMENT 'testing spatial index on Geometry';
|
|
|
|
INSERT INTO tab(c1,c2,c3,c4,c5)
|
|
VALUES(1,ST_GeomFromText('POINT(10 10)'),ST_GeomFromText('LINESTRING(5 5,20 20,30 30)'),
|
|
ST_GeomFromText('POLYGON((30 30,40 40,50 50,30 50,30 40,30 30))'),
|
|
ST_GeomFromText('POLYGON((30 30,40 40,50 50,30 50,30 40,30 30))'));
|
|
|
|
# 1 record is expected
|
|
SELECT c1,ST_AsText(c2),ST_AsText(c3),ST_AsText(c4),ST_AsText(c5) FROM tab;
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
--echo "In connection 1"
|
|
connect (con1,localhost,root,,);
|
|
connection con1;
|
|
|
|
SET SESSION TRANSACTION ISOLATION LEVEL REPEATABLE READ;
|
|
|
|
SELECT @@transaction_isolation;
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
# 1 record is expected
|
|
SELECT c1,ST_AsText(c2),ST_AsText(c3),ST_AsText(c4),ST_AsText(c5) FROM tab;
|
|
|
|
--echo "In connection 2"
|
|
connect (con2,localhost,root,,);
|
|
connection con2;
|
|
|
|
SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED;
|
|
|
|
SELECT @@transaction_isolation;
|
|
|
|
START TRANSACTION;
|
|
|
|
INSERT INTO tab(c1,c2,c3,c4,c5)
|
|
VALUES(2,ST_GeomFromText('POINT(20 20)'),ST_GeomFromText('LINESTRING(20 20,30 30,40 40)'),
|
|
ST_GeomFromText('POLYGON((40 50,40 70,50 100,70 100,80 80,70 50,40 50))'),
|
|
ST_GeomFromText('POLYGON((40 50,40 70,50 100,70 100,80 80,70 50,40 50))'));
|
|
|
|
SET @g1 = ST_GeomFromText('POLYGON((30 30,40 40,50 50,30 50,30 40,30 30))');
|
|
SET @g2 = ST_GeomFromText('POINT(10 10)');
|
|
|
|
# Record should be updated
|
|
UPDATE tab SET C5 = ST_GeomFromText('POLYGON((300 300,400 400,500 500,300 500,300 400,300 300))')
|
|
WHERE MBREquals(tab.c4, @g1) AND MBREquals(tab.c2, @g2);
|
|
|
|
--echo "In connection 1"
|
|
connection con1;
|
|
|
|
SET @g3 = ST_GeomFromText('POLYGON((40 50,40 70,50 100,70 100,80 80,70 50,40 50))');
|
|
|
|
# No record is expected (No phantom row)
|
|
SELECT c1,ST_AsText(c2),ST_AsText(c4),ST_AsText(c5) FROM tab WHERE MBREquals(tab.c5, @g3);
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
START TRANSACTION;
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
--echo "In connection 2"
|
|
connection con2;
|
|
|
|
# Record count should be 2
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
COMMIT;
|
|
|
|
disconnect con2;
|
|
|
|
--echo "In connection 1"
|
|
connection con1;
|
|
|
|
# Record count should be 1
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
SET @g4 = ST_GeomFromText('POLYGON((300 300,400 400,500 500,300 500,300 400,300 300))');
|
|
|
|
# No records are expected (No phantom row)
|
|
SELECT ST_AsText(c5) FROM tab WHERE MBREquals(tab.c5, @g4);
|
|
|
|
COMMIT;
|
|
|
|
# The updated record is expected
|
|
SELECT ST_AsText(c5) FROM tab WHERE MBREquals(tab.c5, @g4);
|
|
|
|
# Record count should be 2
|
|
SELECT COUNT(*) FROM tab;
|
|
|
|
# 2 records are expected
|
|
SELECT c1,ST_AsText(c2),ST_AsText(c4),ST_AsText(c5) FROM tab;
|
|
|
|
disconnect con1;
|
|
--connection default
|
|
DROP TABLE tab;
|