mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 08:01:35 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
60 lines
1.3 KiB
Text
60 lines
1.3 KiB
Text
--source include/have_innodb.inc
|
|
--source include/have_innodb_16k.inc
|
|
--source include/have_debug.inc
|
|
|
|
--echo #
|
|
--echo # Bug# 20005279 ASSERT !OTHER_LOCK, LOCK_MOVE_REORGANIZE_PAGE()
|
|
--echo #
|
|
|
|
create table t1 (f1 int auto_increment primary key,
|
|
f2 char(255)) engine=innodb;
|
|
|
|
let $inc = 50;
|
|
|
|
start transaction;
|
|
--disable_query_log
|
|
|
|
while ($inc)
|
|
{
|
|
insert into t1(f2) values (repeat('~', 50));
|
|
dec $inc;
|
|
}
|
|
|
|
--enable_query_log
|
|
commit;
|
|
|
|
start transaction;
|
|
select f1, f2 from t1 where f1 = 20 for update;
|
|
|
|
connect (con1,localhost,root,,);
|
|
--send
|
|
select f1 from t1 where f1 = 20 for update;
|
|
|
|
connection default;
|
|
|
|
let $wait_condition=
|
|
select count(*) = 1 from information_schema.processlist
|
|
where INFO = 'select f1 from t1 where f1 = 20 for update';
|
|
|
|
--source include/wait_condition.inc
|
|
|
|
SET @save_dbug = @@debug_dbug;
|
|
SET DEBUG_DBUG = '+d,do_page_reorganize,do_lock_reverse_page_reorganize';
|
|
insert into t1(f2) values (repeat('+', 100));
|
|
SET DEBUG_DBUG = @save_dbug;
|
|
commit;
|
|
|
|
connection con1;
|
|
reap;
|
|
disconnect con1;
|
|
connection default;
|
|
|
|
drop table t1;
|
|
|
|
--echo #
|
|
--echo # MDEV-27993 Assertion failed in btr_page_reorganize_low()
|
|
--echo #
|
|
CREATE TABLE t1(a INT PRIMARY KEY, b INT UNIQUE) ENGINE=InnoDB;
|
|
SET DEBUG_DBUG = '+d,do_page_reorganize';
|
|
INSERT INTO t1 VALUES(0,0);
|
|
DROP TABLE t1;
|