mirror of
https://github.com/MariaDB/server.git
synced 2025-08-02 00:21:35 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
66 lines
1.8 KiB
Text
66 lines
1.8 KiB
Text
--source include/have_innodb.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
connect (con1,localhost,root,,);
|
|
|
|
connect (con2,localhost,root,,);
|
|
connection default;
|
|
|
|
CREATE TABLE t (a INT PRIMARY KEY, c TEXT) ENGINE=InnoDB;
|
|
CREATE TABLE u (a INT PRIMARY KEY, b INT, c INT NOT NULL) ENGINE=InnoDB;
|
|
|
|
INSERT INTO t VALUES (1,'aa');
|
|
BEGIN;
|
|
INSERT INTO u SET a=1, c=1;
|
|
INSERT INTO u SELECT a+1,NULL,a+1 FROM u;
|
|
INSERT INTO u SELECT a+2,NULL,a+2 FROM u;
|
|
INSERT INTO u SELECT a+4,NULL,a+4 FROM u;
|
|
INSERT INTO u SELECT a+8,NULL,a+8 FROM u;
|
|
INSERT INTO u SELECT a+16,NULL,a+16 FROM u;
|
|
INSERT INTO u SELECT a+32,NULL,a+32 FROM u;
|
|
INSERT INTO u SELECT a+64,NULL,a+64 FROM u;
|
|
INSERT INTO u SELECT a+128,NULL,a+64 FROM u;
|
|
INSERT INTO u SELECT a+256,NULL,a+64 FROM u;
|
|
COMMIT;
|
|
|
|
BEGIN;
|
|
DELETE FROM u;
|
|
|
|
connection con2;
|
|
SET DEBUG_SYNC='row_log_apply_before SIGNAL created_u WAIT_FOR dml_done_u';
|
|
--send
|
|
ALTER TABLE u ADD INDEX (c);
|
|
|
|
connection default;
|
|
# Check that the above SELECT is blocked
|
|
let $wait_condition=
|
|
SELECT COUNT(*) = 1 from information_schema.processlist
|
|
WHERE state = 'Waiting for table metadata lock' AND
|
|
info = 'ALTER TABLE u ADD INDEX (c)';
|
|
--source include/wait_condition.inc
|
|
|
|
COMMIT;
|
|
SET DEBUG_SYNC='now WAIT_FOR created_u';
|
|
SELECT state FROM information_schema.processlist
|
|
WHERE info='ALTER TABLE u ADD INDEX (c)';
|
|
|
|
connection con1;
|
|
SET DEBUG_SYNC='row_log_apply_before SIGNAL created_t WAIT_FOR dml_done_t';
|
|
--send
|
|
CREATE INDEX c1 ON t (c(1));
|
|
connection default;
|
|
SET DEBUG_SYNC='now WAIT_FOR created_t';
|
|
UPDATE t SET c='ab';
|
|
# Allow purge to kick in. TODO: Trigger this faster, somehow.
|
|
SELECT SLEEP(10);
|
|
SET DEBUG_SYNC='now SIGNAL dml_done_u';
|
|
connection con2;
|
|
reap;
|
|
SET DEBUG_SYNC='now SIGNAL dml_done_t';
|
|
disconnect con2;
|
|
connection con1;
|
|
reap;
|
|
disconnect con1;
|
|
connection default;
|
|
SET DEBUG_SYNC='RESET';
|
|
DROP TABLE t,u;
|