mirror of
https://github.com/MariaDB/server.git
synced 2025-07-28 14:10:46 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
34 lines
663 B
Text
34 lines
663 B
Text
connect con1,localhost,root,,;
|
|
connect con2,localhost,root,,;
|
|
connection con1;
|
|
CREATE TABLE t1 (a INT) ENGINE=innodb;
|
|
RESET MASTER;
|
|
SET AUTOCOMMIT=0;
|
|
SELECT 1;
|
|
1
|
|
1
|
|
connection con2;
|
|
FLUSH TABLES WITH READ LOCK;
|
|
include/show_binlog_events.inc
|
|
connection con1;
|
|
INSERT INTO t1 VALUES (1);
|
|
connection con2;
|
|
include/show_binlog_events.inc
|
|
UNLOCK TABLES;
|
|
connection con1;
|
|
DROP TABLE t1;
|
|
SET AUTOCOMMIT=1;
|
|
create table t1 (a int) engine=innodb;
|
|
connection con1;
|
|
flush tables with read lock;
|
|
connection con2;
|
|
begin;
|
|
insert into t1 values (1);;
|
|
connection con1;
|
|
unlock tables;
|
|
connection con2;
|
|
commit;
|
|
drop table t1;
|
|
connection default;
|
|
disconnect con1;
|
|
disconnect con2;
|