mirror of
https://github.com/MariaDB/server.git
synced 2025-08-07 11:01:34 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
91 lines
2.4 KiB
Text
91 lines
2.4 KiB
Text
set @old_concurrent_insert= @@global.concurrent_insert;
|
|
set @@global.concurrent_insert= 0;
|
|
create table t1 (
|
|
`a&b` int,
|
|
`a<b` int NOT NULL,
|
|
`a>b` text
|
|
);
|
|
insert into t1 values (1, 2, 'a&b a<b a>b');
|
|
<?xml version="1.0"?>
|
|
|
|
<resultset statement="select * from t1
|
|
" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
|
|
<row>
|
|
<field name="a&b">1</field>
|
|
<field name="a<b">2</field>
|
|
<field name="a>b">a&b a<b a>b</field>
|
|
</row>
|
|
</resultset>
|
|
<?xml version="1.0"?>
|
|
<mysqldump xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
|
|
<database name="test">
|
|
<table_structure name="t1">
|
|
<field Field="a&b" Type="int(11)" Null="YES" Key="" Default="NULL" Extra="" Comment="" />
|
|
<field Field="a<b" Type="int(11)" Null="NO" Key="" Extra="" Comment="" />
|
|
<field Field="a>b" Type="text" Null="YES" Key="" Default="NULL" Extra="" Comment="" />
|
|
</table_structure>
|
|
<table_data name="t1">
|
|
<row>
|
|
<field name="a&b">1</field>
|
|
<field name="a<b">2</field>
|
|
<field name="a>b">a&b a<b a>b</field>
|
|
</row>
|
|
</table_data>
|
|
</database>
|
|
</mysqldump>
|
|
<?xml version="1.0"?>
|
|
|
|
<resultset statement="select count(*) from t1
|
|
" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
|
|
<row>
|
|
<field name="count(*)">1</field>
|
|
</row>
|
|
</resultset>
|
|
<?xml version="1.0"?>
|
|
|
|
<resultset statement="select 1 < 2 from dual
|
|
" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
|
|
<row>
|
|
<field name="1 < 2">1</field>
|
|
</row>
|
|
</resultset>
|
|
<?xml version="1.0"?>
|
|
|
|
<resultset statement="select 1 > 2 from dual
|
|
" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
|
|
<row>
|
|
<field name="1 > 2">0</field>
|
|
</row>
|
|
</resultset>
|
|
<?xml version="1.0"?>
|
|
|
|
<resultset statement="select 1 & 3 from dual
|
|
" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
|
|
<row>
|
|
<field name="1 & 3">1</field>
|
|
</row>
|
|
</resultset>
|
|
<?xml version="1.0"?>
|
|
|
|
<resultset statement="select null from dual
|
|
" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
|
|
<row>
|
|
<field name="NULL" xsi:nil="true" />
|
|
</row>
|
|
</resultset>
|
|
<?xml version="1.0"?>
|
|
|
|
<resultset statement="select 1 limit 0
|
|
" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"></resultset>
|
|
--------------
|
|
select 1 limit 0
|
|
--------------
|
|
|
|
<?xml version="1.0"?>
|
|
|
|
<resultset statement="select 1 limit 0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"></resultset>
|
|
Empty set
|
|
|
|
Bye
|
|
drop table t1;
|
|
set @@global.concurrent_insert= @old_concurrent_insert;
|