mirror of
https://github.com/MariaDB/server.git
synced 2025-02-12 00:15:35 +01:00
dd99780967
PURGE BINARY LOGS did not always purge binary logs. This commit fixes
some of the issues and adds notifications if a binary log cannot be
purged.
User visible changes:
- 'PURGE BINARY LOG TO log_name' and 'PURGE BINARY LOGS BEFORE date'
worked differently. 'TO' ignored 'slave_connections_needed_for_purge'
while 'BEFORE' did not. Now both versions ignores the
'slave_connections_needed_for_purge variable'.
- 'PURGE BINARY LOG..' commands now returns 'note' if a binary log cannot
be deleted like
Note 1375 Binary log 'master-bin.000004' is not purged because it is
the current active binlog
- Automatic binary log purges, based on date or size, will write a
note to the error log if a binary log matching the size or date
cannot yet be deleted.
- If 'slave_connections_needed_for_purge' is set from a config or
command line, it is set to 0 if Galera is enabled and 1 otherwise
(old default). This ensures that automatic binary log purge works
with Galera as before the addition of
'slave_connections_needed_for_purge'.
If the variable is changed to 0, a warning will be printed to the error
log.
Code changes:
- Added THD argument to several purge_logs related functions that needed
THD.
- Added 'interactive' options to purge_logs functions. This allowed
me to remove testing of sql_command == SQLCOM_PURGE.
- Changed purge_logs_before_date() to first check if log is applicable
before calling can_purge_logs(). This ensures we do not get a
notification for logs that does not match the remove criteria.
- MYSQL_BIN_LOG::can_purge_log() will write notifications to the user
or error log if a log cannot yet be removed.
- log_in_use() will return reason why a binary log cannot be removed.
Changes to keep code consistent:
- Moved checking of binlog_format for Galera to be after Galera is
initialized (The old check never worked). If Galera is enabled
we now change the binlog_format to ROW, with a warning, instead of
aborting the server. If this change happens a warning will be printed to
the error log.
- Print a warning if Galera or FLASHBACK changes the binlog_format
to ROW. Before it was done silently.
Reviewed by: Sergei Golubchik <serg@mariadb.com>,
Kristian Nielsen <knielsen@knielsen-hq.org>
42 lines
708 B
Text
42 lines
708 B
Text
connection node_2;
|
|
connection node_1;
|
|
select @@slave_connections_needed_for_purge;
|
|
@@slave_connections_needed_for_purge
|
|
0
|
|
select VARIABLE_NAME, GLOBAL_VALUE, GLOBAL_VALUE_ORIGIN from information_schema.system_variables where variable_name="slave_connections_needed_for_purge";
|
|
VARIABLE_NAME GLOBAL_VALUE GLOBAL_VALUE_ORIGIN
|
|
SLAVE_CONNECTIONS_NEEDED_FOR_PURGE 0 AUTO
|
|
USE test;
|
|
CREATE TABLE t1(c1 INT PRIMARY KEY) ENGINE=INNODB;
|
|
INSERT INTO t1 VALUES (1), (2), (3), (4), (5);
|
|
SELECT * FROM t1;
|
|
c1
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
|
|
# On node_1
|
|
connection node_1;
|
|
SELECT * FROM test.t1;
|
|
c1
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
|
|
# On node_2
|
|
connection node_2;
|
|
SELECT * FROM test.t1;
|
|
c1
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
DROP TABLE t1;
|
|
disconnect node_2;
|
|
disconnect node_1;
|
|
# End of test
|