mariadb/mysql-test/suite/compat/oracle/r
Alexander Barkov 385957a77c MDEV-36053 CURSOR declarations in PACKAGE BODY
This change adds CURSOR declarations inside PACKAGE BODY.

PL/SQL mode:

  SET sql_mode=ORACLE;
  CREATE PACKAGE BODY pkg AS
    CURSOR mc0 IS SELECT c0, c1 FROM t1;
    PROCEDURE p1 AS
      rec mc0%ROWTYPE;
    BEGIN
      OPEN mc0;
      FETCH mc0 INTO rec;
      CLOSE mc0
    END;
  END;
  /

SQL/PSM mode:

  SET sql_mode=DEFAULT;
  CREATE PACKAGE BODY pkg
    mc0 CURSOR FOR SELECT c0, c1 FROM t1;
    PROCEDURE p1()
    BEGIN
      DECLARE rec ROW TYPE OF mc0;
      OPEN mc0;
      FETCH mc0 INTO rec;
      CLOSE mc0
    END;
  END;
  /

PACKAGE BODY cursors like local cursors
(declared inside a FUNCTION or a PROCEDURE) support:
  - OPEN/FETCH/CLOSE
  - FOR rec IN cur - an explicit cursor loop
  - Using a cursor row as an anchored variable data type:
    * DECLARE var cur%ROWTYPE;     -- sql_mode=ORACLE
    * DECLARE var ROW TYPE OF cur; -- sql_mode=DEFAULT

The patch details:

- Changing various class members and function/method parameters which
  store a CURSOR run-time address from "uint" to sp_rcontext_addr.
  A few classes now derive from sp_rcontext_addr instead of having
  a "uint m_cursor;" member.

  This change uses the same idea with what we did for SP variables,
  when we implemented PACKAGE BODY variables a few years ago.

- Fixing the grammar in sql_yacc.yy to allow CURSOR declarations
  inside PACKAGE BODY.

- Moving the C++ code handing the "CLOSE_SYM ident" grammar
  and creating an sp_instr_cclose instance from sql_yacc.yy
  into a new method LEX::sp_close().
  This is to have the grammar file smaller.
  Also, this code has significantly changed anyway.

- Adding a new class sp_pcontext_top. It's used for the top level parse
  context (of an sp_head). Note, its children contexts still use the old
  class sp_pcontext.

  sp_pcontext_top context additionally to sp_pcontext has:

    const sp_head *m_sp; -- The pointer to the sp_head owning this context
    Dynamic_array<sp_pcursor> m_member_cursors; -- PACKAGE BODY wide cursors

  m_sp->m_parent->get_parse_context() is used to find the sp_pcontext
  belonging to the parent PACKAGE BODY from a sp_pcontext_top instance
  belonging to a PROCEDURE/FUNCTION sp_pcontext_top.

- Adding a new member in sp_rcontext:
    Dynamic_array<sp_cursor*> m_member_cursors;
  It's used to store run-time data of PACKAGE BODY wide cursors.

- Adding a new class sp_instr_copen2. It's used to open PACKAGE BODY cursors.
  Unlike the usual cursors, PACKAGE BODY cursors:
  * do not use the cursor stack (sp_rcontext::m_cstack)
  * do not need a preceeding sp_instr_cpush
  * do not need a following sp_instr_cpop

  All cursor information such as "sp_lex_cursor" resides inside
  sp_instr_copen2 itself (rather than inside sp_instr_cpush which is
  used to store "sp_lex_cursor" in case of sp_instr_copen).

  Note, the other cursor related instructions:
    sp_instr_cfetch
    sp_instr_cclose
    sp_instr_cursor_copy_struct
  do not need sp_instr_xxx2 counter-parts.
  Thy just use sp_rcontext_addr to address cursors.

- Adding Sp_rcontext_handler_member
  It's used to handle PACKAGE BODY members:
  cursors and variables declared in the PACKAGE BODY,
  when they are accessed from its executable initialization section:

    CREATE PACKAGE BODY pkg AS
      CURSOR mc0 IS SELECT c0, c1 FROM t1; -- A member (PACKAGE BODY cursor)
      mv0 mc0%ROWTYPE;                     -- A member (PACKAGE BODY variable)
      PROCEDURE p1 AS
      BEGIN
        -- Accessing members from here use sp_rcontext_handler_package_body
        -- (members of the parent PACKAGE BODY)
        OPEN mc0;
        FETCH mc0 INTO mv0;
        CLOSE mc0;
      END;
    BEGIN
      -- NEW:
      -- Accessing members from here use sp_rcontext_handler_member
      -- (PACKAGE BODY own members)
      OPEN mc0;
      FETCH mc0 INTO mv0;
      CLOSE mc0;
    END;
    /

  Member variables and cursor are now marked with the "MEMBER." prefix
  in the "SHOW PACKAGE BODY code" output.
  Some old MTR tests have been re-recorded accordingly.

- Adding new virtual methods into Sp_rcontext_handler:

  virtual const sp_variable *get_pvariable(const sp_pcontext *pctx,
                                           uint offset) const;

  virtual const sp_pcursor *get_pcursor(const sp_pcontext *pctx,
                                        uint offset) const;

  They're used from sp_instr::print() virtual implementations.
  They internally calculate a proper sp_pcontext using as a parameter
  the sp_pcontext pointed by sp_instr::m_ctx.

  For example, Sp_handler_package_body::get_pvariable()/get_pcursor()
  accesses to this sp_pcontext:
      m_ctx->top_context()->m_sp->m_parent->get_parse_context(),
  i.e. the parse context of the PACKAGE BODY which is the parent for
   the current package PROCEDURE of FUNCTION an sp_instr belongs to.

- Adding a new method LEX::find_cursor(). It searches for a cursor in
  this order:
  * Local cursors in the nearst upper BEGIN/END block.
  * A member cursor of the current PACKAGE BODY
    (used from the PACKAGE BODY initialization section)
  * A member cursor of the parrent PACKAGE BODY
    (used from a package PROCEDURE or a package FUNCTION)

  Adding a new method LEX::find_cursor_with_error().
  In case when a cursor is not found, it automatically
  raises the ER_SP_CURSOR_MISMATCH SQL condition into
  the diagnostics area.

- Adding a new method sp_head::add_instr_copenX().
  It creates sp_instr_copen for local cursors,
  or sp_instr_copen2 for non-local cursors.

- Adding a new abstract class sp_lex_cursor_instr.
  It's used a common parent class for a few sp_instr_xxx classes,
  including the new sp_instr_copen2.
  This change is needed to avoid code duplication.

- Adding a new protected method sp_instr::print_cmd_and_var(), to print
  an instruction using this format: "command name@offset".
  It's used from a few implementations of sp_instr_xxx::print(),
  including sp_instr_copen2::print().
  This change is also needed to avoid code duplication.

- Moving the definition of "class Sp_rcontext_handler" from item.h
  into a new file sp_rcontext_handler.h
  This is to maitain header dependencies easier, as well as to move
  declarations not directly related to "class Item" outside of item.h

- Adding a new method sp_pcontext::frame_for_members(), to distinguish
  easier between local cursors/variables and PACKAGE BODY cursors/variables.

- Fixing "struct Lex_for_loop_st" to addionally store
  a const pointer to Sp_rcontext_handler, to distinguish between:
    * FOR rec IN local_cursor
    * FOR rec IN package_body_cursor
2025-06-27 11:17:19 +04:00
..
anonymous_derived.result MDEV-34679 ER_BAD_FIELD uses non-localizable substrings 2024-10-17 21:37:37 +02:00
binlog_ptr_mysqlbinlog.result MDEV-34504 PURGE BINARY LOGS not working anymore 2024-07-10 18:50:08 +03:00
binlog_stm_ps.result
binlog_stm_sp.result
binlog_stm_sp_package.result
column_compression.result Merge branch '10.5' into 10.6 2024-07-18 16:25:33 +02:00
custom_aggregate_functions.result
empty_string_literal.result Merge 10.5 into 10.6 2024-03-27 15:00:56 +02:00
events.result fix tests for embedded 2022-05-18 01:22:29 +02:00
exception.result Merge 10.2 into 10.3 2020-05-25 19:41:58 +03:00
func_add_months.result MDEV-20025: ADD_MONTHS() Oracle function 2021-05-19 22:54:12 +02:00
func_case.result
func_concat.result MDEV-31910 ASAN memcpy-param-overlap upon CONCAT in ORACLE mode 2024-11-06 11:39:50 +04:00
func_decode.result MDEV-27744 LPAD in vcol created in ORACLE mode makes table corrupted in non-ORACLE 2023-11-08 15:01:20 +04:00
func_length.result
func_misc.result MDEV-34679 ER_BAD_FIELD uses non-localizable substrings 2024-10-17 21:37:37 +02:00
func_pad.result MDEV-27744 LPAD in vcol created in ORACLE mode makes table corrupted in non-ORACLE 2023-11-08 15:01:20 +04:00
func_qualified.result MDEV-29095 REGEXP_REPLACE treats empty strings different than REPLACE in ORACLE mode 2024-01-24 10:59:17 +04:00
func_regexp_replace.result MDEV-29095 REGEXP_REPLACE treats empty strings different than REPLACE in ORACLE mode 2024-01-24 10:59:17 +04:00
func_replace.result MDEV-27744 LPAD in vcol created in ORACLE mode makes table corrupted in non-ORACLE 2023-11-08 15:01:20 +04:00
func_substr.result MDEV-27744 LPAD in vcol created in ORACLE mode makes table corrupted in non-ORACLE 2023-11-08 15:01:20 +04:00
func_time.result
func_to_char.result MDEV-36216 TO_CHAR FM format not recognized in SQL_MODE=Oracle 2025-04-16 12:55:49 +04:00
func_trim.result MDEV-27744 LPAD in vcol created in ORACLE mode makes table corrupted in non-ORACLE 2023-11-08 15:01:20 +04:00
gis-debug.result MDEV-20009 Add CAST(expr AS pluggable_type) 2019-07-10 11:55:16 +04:00
gis.result MDEV-33803 Error 4162 "Operator does not exists" is incorrectly-worded 2024-04-03 10:03:02 +11:00
information_schema_parameters.result
keywords.result MDEV-17363 - Compressed columns cannot be restored from dump 2019-06-18 07:48:08 +04:00
minus.result MDEV-20021 sql_mode="oracle" does not support MINUS set operator 2021-05-19 22:54:12 +02:00
misc.result An additional patch for MDEV-27690 Crash on CHARACTER SET csname COLLATE DEFAULT in column definition 2022-04-14 12:22:28 +04:00
mysqldump_restore.result MDEV-17363 - Compressed columns cannot be restored from dump 2019-06-18 07:48:08 +04:00
mysqldump_restore_func_qualified.result MDEV-29968 Functions in default values in tables with some character sets break SHOW CREATE (and mysqldump) 2025-01-17 15:39:55 +04:00
parser.result MDEV-31616 Problems with a stored function EMPTY() on upgrade to 10.6. 2024-01-24 09:59:55 +04:00
plugin.result
ps.result MDEV-34679 ER_BAD_FIELD uses non-localizable substrings 2024-10-17 21:37:37 +02:00
rpl_mariadb_date.result MDEV-29446 Change SHOW CREATE TABLE to display default collation 2022-09-12 22:10:39 +04:00
rpl_sp_package.result MDEV-30662 SQL/PL package body does not appear in I_S.ROUTINES.ROUTINE_DEFINITION 2023-07-14 13:26:26 +04:00
rpl_sp_package_variables.result
sequence.result
sp-anchor-row-type-table.result MDEV-29062 Wrong result set metadata for a mix of INT+ENUM 2022-07-08 15:29:23 +04:00
sp-anonymous.result
sp-code.result MDEV-36053 CURSOR declarations in PACKAGE BODY 2025-06-27 11:17:19 +04:00
sp-cursor-decl.result Merge 10.2 into 10.3 2020-04-15 09:56:03 +03:00
sp-cursor-package-body-attr.result MDEV-36053 CURSOR declarations in PACKAGE BODY 2025-06-27 11:17:19 +04:00
sp-cursor-package-body-code.result MDEV-36053 CURSOR declarations in PACKAGE BODY 2025-06-27 11:17:19 +04:00
sp-cursor-package-body-metadata-change.result MDEV-36053 CURSOR declarations in PACKAGE BODY 2025-06-27 11:17:19 +04:00
sp-cursor-package-body.result MDEV-36053 CURSOR declarations in PACKAGE BODY 2025-06-27 11:17:19 +04:00
sp-cursor-rowtype.result MDEV-34679 ER_BAD_FIELD uses non-localizable substrings 2024-10-17 21:37:37 +02:00
sp-cursor.result MDEV-36047 Package body variables are not allowed as FETCH targets 2025-02-09 13:56:19 +04:00
sp-expr.result
sp-goto-debug.result MDEV-20667 Server crash on pop_cursor 2019-12-12 16:25:16 +04:00
sp-goto.result MDEV-20667 Server crash on pop_cursor 2019-12-12 16:25:16 +04:00
sp-inout.result MDEV-33616 Tests failing on macOS 2024-04-24 08:44:24 -04:00
sp-memory-leak.result MDEV-26186 280 Bytes lost in mysys/array.c, mysys/hash.c, sql/sp.cc, sql/sp.cc, sql/item_create.cc, sql/item_create.cc, sql/sql_yacc.yy:10748 when using oracle sql_mode 2023-07-18 12:19:16 +04:00
sp-package-code.result MDEV-36053 CURSOR declarations in PACKAGE BODY 2025-06-27 11:17:19 +04:00
sp-package-concurrent-dml-db.result
sp-package-concurrent-dml-package.result
sp-package-concurrent-dml-trigger.result
sp-package-concurrent-dml-view.result
sp-package-i_s.result MDEV-30662 SQL/PL package body does not appear in I_S.ROUTINES.ROUTINE_DEFINITION 2023-07-14 13:26:26 +04:00
sp-package-innodb.result Removed "<select expression> INTO <destination>" deprication. 2023-02-03 11:57:50 +03:00
sp-package-mdl.result
sp-package-mysqldump.result Merge branch '11.2' into 11.4 2024-08-04 17:27:48 +02:00
sp-package-security.result MDEV-20076: SHOW GRANTS does not quote role names properly 2020-02-05 17:22:26 +01:00
sp-package.result MDEV-33428 Error messages ER_PACKAGE_ROUTINE_* are not good enough 2024-02-08 16:01:20 +04:00
sp-param.result Merge 10.6 into 10.7 2022-09-21 09:33:07 +03:00
sp-row.result Removed "<select expression> INTO <destination>" deprication. 2023-02-03 11:57:50 +03:00
sp-security.result MDEV-28548: ER_TABLEACCESS_DENIED_ERROR is missing information about DB 2022-09-30 08:48:57 +02:00
sp.result Merge 10.9 into 10.10 2022-09-21 10:59:56 +03:00
statement-expr.result MDEV-20634 Report disallowed subquery errors as such (instead of parse error) 2019-09-20 10:36:20 +04:00
table_value_constr.result Merge branch '10.11' into 11.2 2024-10-29 16:42:46 +01:00
trigger.result
truncate.result
type_blob.result MDEV-20263 sql_mode=ORACLE: BLOB(65535) should not translate to LONGBLOB 2019-08-06 18:02:03 +04:00
type_clob.result
type_date.result Merge remote-tracking branch 'origin/10.4' into 10.5 2022-09-14 16:24:51 +04:00
type_number.result
type_raw.result
type_varchar.result
type_varchar2.result
update.result MDEV-27769 Assertion failed in Field::ptr_in_record upon UPDATE in ORACLE mode 2025-01-26 16:15:46 +01:00
update_innodb.result Removed "<select expression> INTO <destination>" deprication. 2023-02-03 11:57:50 +03:00
variables.result
vcol.result
vcol_innodb.result MDEV-27744 LPAD in vcol created in ORACLE mode makes table corrupted in non-ORACLE 2023-11-08 15:01:20 +04:00
versioning.result
win.result