mirror of
https://github.com/MariaDB/server.git
synced 2025-08-06 02:21:34 +02:00
385957a77c
This change adds CURSOR declarations inside PACKAGE BODY.
PL/SQL mode:
SET sql_mode=ORACLE;
CREATE PACKAGE BODY pkg AS
CURSOR mc0 IS SELECT c0, c1 FROM t1;
PROCEDURE p1 AS
rec mc0%ROWTYPE;
BEGIN
OPEN mc0;
FETCH mc0 INTO rec;
CLOSE mc0
END;
END;
/
SQL/PSM mode:
SET sql_mode=DEFAULT;
CREATE PACKAGE BODY pkg
mc0 CURSOR FOR SELECT c0, c1 FROM t1;
PROCEDURE p1()
BEGIN
DECLARE rec ROW TYPE OF mc0;
OPEN mc0;
FETCH mc0 INTO rec;
CLOSE mc0
END;
END;
/
PACKAGE BODY cursors like local cursors
(declared inside a FUNCTION or a PROCEDURE) support:
- OPEN/FETCH/CLOSE
- FOR rec IN cur - an explicit cursor loop
- Using a cursor row as an anchored variable data type:
* DECLARE var cur%ROWTYPE; -- sql_mode=ORACLE
* DECLARE var ROW TYPE OF cur; -- sql_mode=DEFAULT
The patch details:
- Changing various class members and function/method parameters which
store a CURSOR run-time address from "uint" to sp_rcontext_addr.
A few classes now derive from sp_rcontext_addr instead of having
a "uint m_cursor;" member.
This change uses the same idea with what we did for SP variables,
when we implemented PACKAGE BODY variables a few years ago.
- Fixing the grammar in sql_yacc.yy to allow CURSOR declarations
inside PACKAGE BODY.
- Moving the C++ code handing the "CLOSE_SYM ident" grammar
and creating an sp_instr_cclose instance from sql_yacc.yy
into a new method LEX::sp_close().
This is to have the grammar file smaller.
Also, this code has significantly changed anyway.
- Adding a new class sp_pcontext_top. It's used for the top level parse
context (of an sp_head). Note, its children contexts still use the old
class sp_pcontext.
sp_pcontext_top context additionally to sp_pcontext has:
const sp_head *m_sp; -- The pointer to the sp_head owning this context
Dynamic_array<sp_pcursor> m_member_cursors; -- PACKAGE BODY wide cursors
m_sp->m_parent->get_parse_context() is used to find the sp_pcontext
belonging to the parent PACKAGE BODY from a sp_pcontext_top instance
belonging to a PROCEDURE/FUNCTION sp_pcontext_top.
- Adding a new member in sp_rcontext:
Dynamic_array<sp_cursor*> m_member_cursors;
It's used to store run-time data of PACKAGE BODY wide cursors.
- Adding a new class sp_instr_copen2. It's used to open PACKAGE BODY cursors.
Unlike the usual cursors, PACKAGE BODY cursors:
* do not use the cursor stack (sp_rcontext::m_cstack)
* do not need a preceeding sp_instr_cpush
* do not need a following sp_instr_cpop
All cursor information such as "sp_lex_cursor" resides inside
sp_instr_copen2 itself (rather than inside sp_instr_cpush which is
used to store "sp_lex_cursor" in case of sp_instr_copen).
Note, the other cursor related instructions:
sp_instr_cfetch
sp_instr_cclose
sp_instr_cursor_copy_struct
do not need sp_instr_xxx2 counter-parts.
Thy just use sp_rcontext_addr to address cursors.
- Adding Sp_rcontext_handler_member
It's used to handle PACKAGE BODY members:
cursors and variables declared in the PACKAGE BODY,
when they are accessed from its executable initialization section:
CREATE PACKAGE BODY pkg AS
CURSOR mc0 IS SELECT c0, c1 FROM t1; -- A member (PACKAGE BODY cursor)
mv0 mc0%ROWTYPE; -- A member (PACKAGE BODY variable)
PROCEDURE p1 AS
BEGIN
-- Accessing members from here use sp_rcontext_handler_package_body
-- (members of the parent PACKAGE BODY)
OPEN mc0;
FETCH mc0 INTO mv0;
CLOSE mc0;
END;
BEGIN
-- NEW:
-- Accessing members from here use sp_rcontext_handler_member
-- (PACKAGE BODY own members)
OPEN mc0;
FETCH mc0 INTO mv0;
CLOSE mc0;
END;
/
Member variables and cursor are now marked with the "MEMBER." prefix
in the "SHOW PACKAGE BODY code" output.
Some old MTR tests have been re-recorded accordingly.
- Adding new virtual methods into Sp_rcontext_handler:
virtual const sp_variable *get_pvariable(const sp_pcontext *pctx,
uint offset) const;
virtual const sp_pcursor *get_pcursor(const sp_pcontext *pctx,
uint offset) const;
They're used from sp_instr::print() virtual implementations.
They internally calculate a proper sp_pcontext using as a parameter
the sp_pcontext pointed by sp_instr::m_ctx.
For example, Sp_handler_package_body::get_pvariable()/get_pcursor()
accesses to this sp_pcontext:
m_ctx->top_context()->m_sp->m_parent->get_parse_context(),
i.e. the parse context of the PACKAGE BODY which is the parent for
the current package PROCEDURE of FUNCTION an sp_instr belongs to.
- Adding a new method LEX::find_cursor(). It searches for a cursor in
this order:
* Local cursors in the nearst upper BEGIN/END block.
* A member cursor of the current PACKAGE BODY
(used from the PACKAGE BODY initialization section)
* A member cursor of the parrent PACKAGE BODY
(used from a package PROCEDURE or a package FUNCTION)
Adding a new method LEX::find_cursor_with_error().
In case when a cursor is not found, it automatically
raises the ER_SP_CURSOR_MISMATCH SQL condition into
the diagnostics area.
- Adding a new method sp_head::add_instr_copenX().
It creates sp_instr_copen for local cursors,
or sp_instr_copen2 for non-local cursors.
- Adding a new abstract class sp_lex_cursor_instr.
It's used a common parent class for a few sp_instr_xxx classes,
including the new sp_instr_copen2.
This change is needed to avoid code duplication.
- Adding a new protected method sp_instr::print_cmd_and_var(), to print
an instruction using this format: "command name@offset".
It's used from a few implementations of sp_instr_xxx::print(),
including sp_instr_copen2::print().
This change is also needed to avoid code duplication.
- Moving the definition of "class Sp_rcontext_handler" from item.h
into a new file sp_rcontext_handler.h
This is to maitain header dependencies easier, as well as to move
declarations not directly related to "class Item" outside of item.h
- Adding a new method sp_pcontext::frame_for_members(), to distinguish
easier between local cursors/variables and PACKAGE BODY cursors/variables.
- Fixing "struct Lex_for_loop_st" to addionally store
a const pointer to Sp_rcontext_handler, to distinguish between:
* FOR rec IN local_cursor
* FOR rec IN package_body_cursor
|
||
|---|---|---|
| .. | ||
| collections | ||
| include | ||
| lib | ||
| main | ||
| std_data | ||
| suite | ||
| asan.supp | ||
| CMakeLists.txt | ||
| dgcov.pl | ||
| lsan.supp | ||
| mariadb-stress-test.pl | ||
| mariadb-test-run.pl | ||
| mtr.out-of-source | ||
| purify.supp | ||
| README | ||
| README-gcov | ||
| README.stress | ||
| suite.pm | ||
| valgrind.supp | ||
This directory contains test suites for the MariaDB server. To run currently existing test cases, execute ./mysql-test-run in this directory. Some tests are known to fail on some platforms or be otherwise unreliable. In the file collections/smoke_test there is a list of tests that are expected to be stable. In general you do not have to have to do "make install", and you can have a co-existing MariaDB installation, the tests will not conflict with it. To run the tests in a source directory, you must do "make" first. In Red Hat distributions, you should run the script as user "mysql". The user is created with nologin shell, so the best bet is something like # su - # cd /usr/share/mariadb-test # su -s /bin/bash mysql -c ./mysql-test-run This will use the installed MariaDB executables, but will run a private copy of the server process (using data files within /usr/share/mariadb-test), so you need not start the mysqld service beforehand. You can omit --skip-test-list option if you want to check whether the listed failures occur for you. To clean up afterwards, remove the created "var" subdirectory, e.g. # su -s /bin/bash - mysql -c "rm -rf /usr/share/mariadb-test/var" If tests fail on your system, please read the following manual section for instructions on how to report the problem: https://mariadb.com/kb/en/reporting-bugs If you want to use an already running MySQL server for specific tests, use the --extern option to mysql-test-run. Please note that in this mode, you are expected to provide names of the tests to run. For example, here is the command to run the "alias" and "analyze" tests with an external server: # mariadb-test-run --extern socket=/tmp/mysql.sock alias analyze To match your setup, you might need to provide other relevant options. With no test names on the command line, mysql-test-run will attempt to execute the default set of tests, which will certainly fail, because many tests cannot run with an external server (they need to control the options with which the server is started, restart the server during execution, etc.) You can create your own test cases. To create a test case, create a new file in the main subdirectory using a text editor. The file should have a .test extension. For example: # xemacs t/test_case_name.test In the file, put a set of SQL statements that create some tables, load test data, and run some queries to manipulate it. Your test should begin by dropping the tables you are going to create and end by dropping them again. This ensures that you can run the test over and over again. If you are using mysqltest commands in your test case, you should create the result file as follows: # mariadb-test-run --record test_case_name or # mariadb-test --record < t/test_case_name.test If you only have a simple test case consisting of SQL statements and comments, you can create the result file in one of the following ways: # mariadb-test-run --record test_case_name # mariadb test < t/test_case_name.test > r/test_case_name.result # mariadb-test --record --database test --result-file=r/test_case_name.result < t/test_case_name.test When this is done, take a look at r/test_case_name.result. If the result is incorrect, you have found a bug. In this case, you should edit the test result to the correct results so that we can verify that the bug is corrected in future releases. If you want to submit your test case you can send it to developers@lists.mariadb.org or attach it to a bug report on http://mariadb.org/jira/. If the test case is really big or if it contains 'not public' data, then put your .test file and .result file(s) into a tar.gz archive, add a README that explains the problem, ftp the archive to ftp://ftp.mariadb.org/private and submit a report to https://mariadb.org/jira about it. The latest information about mysql-test-run can be found at: https://mariadb.com/kb/en/mariadb/mysqltest/ If you want to create .rdiff files, check https://mariadb.com/kb/en/mariadb/mysql-test-auxiliary-files/