Jiaye Wu
9eadef013e
Fix UNICODE issue of dlerror
...
Current implementation is conflicting. If UNICODE is defined, FormatMessage() will be FormatMessageW(), and variable win_errormsg with type char can not be passed to it, which should be changed to TCHAR instead. Since we don't use UNICODE here, we can use FormatMessageA() directly to avoid conversion error.
```
my_global.h(1092): error C2664: 'DWORD FormatMessageW(D
WORD,LPCVOID,DWORD,DWORD,LPWSTR,DWORD,va_list *)' : cannot convert argument 5 from 'char [2048]' to 'LPWSTR'
```
2018-12-12 12:36:28 +01:00
Eugene Kosov
d956709b4b
MDEV-17833 ALTER TABLE is not enforcing prefix index size limit
...
ha_innobase::prepare_inplace_alter_table(): check max column length for every
index in a table, not just added in this particular ALTER TABLE with ADD INDEX ones.
2018-12-11 22:03:44 +03:00
Varun Gupta
4886d14827
MDEV-17032: Estimates are higher for partitions of a table with @@use_stat_tables= PREFERABLY
...
The problem here is EITS statistics does not calculate statistics for the partitions of the table.
So a temporary solution would be to not read EITS statistics for partitioned tables.
Also disabling reading of EITS for columns that participate in the partition list of a table.
2018-12-07 19:59:45 +05:30
Marko Mäkelä
12b1ba195c
MDEV-17904 Crash in fts_is_sync_needed() after failed ALTER or CREATE TABLE
...
create_table_def(), ha_innobase::create(): Defer fts_optimize_add_table()
until after the table has been successfully created.
2018-12-07 13:12:39 +02:00
Sergei Golubchik
daca7e70d7
MDEV-17898 FLUSH PRIVILEGES crashes server with segfault
...
merge_role_db_privileges() was remembering pointers into Dynamic_array
acl_dbs, and later was using them, while pushing more elements into the
array. But pushing can cause realloc, and it can invalidate all pointers.
Fix: remember and use indexes of elements, not pointers.
2018-12-06 14:22:07 +01:00
Sergei Golubchik
eed0013bed
correct order of arguments for Dynamic_array<>::CMP_FUNC2
2018-12-06 14:22:07 +01:00
Sergei Golubchik
8a37ce0767
cleanup: DYNAMIC_ARRAY -> Dynamic_array<ACL_DB> acl_dbs
2018-12-06 14:22:07 +01:00
Varun Gupta
17e8570285
Added a testcase for mdev-17734
2018-12-05 19:31:25 +05:30
Varun Gupta
14f6b0cdfd
MDEV-17734: AddressSanitizer: use-after-poison in create_key_parts_for_pseudo_indexes
...
In this case we were trying to access memory for key_parts which we did not
assign for a fields because it did not any EITS statistics.
The check if EITS statistics for a column is avaialable or not was missing.
2018-11-20 20:16:38 +05:30
Oleksandr Byelkin
a84d87fde8
Merge branch '5.5' into 10.0
2018-11-15 13:57:35 +01:00
Alexander Barkov
1956695c69
MDEV-17724 Wrong result for BETWEEN 0 AND 18446744073709551615
...
The fix for "MDEV-17698 MEMORY engine performance regression"
previously fixed this problem.
- Adding the test for MDEV-17724
- Re-recording wrong results for tests:
* engines/iuds/r/insert_number
* engines/iuds/r/update_delete_number
which started to fail since MDEV-17698
2018-11-15 16:45:43 +04:00
Alexander Barkov
7f175595c8
Backport for "MDEV-17698 MEMORY engine performance regression"
...
Also, backporting a part of:
MDEV-11485 Split Item_func_between::val_int() into virtual methods in Type_handler
for easier merge to 10.3.
2018-11-15 06:35:37 +04:00
Oleksandr Byelkin
47274d902e
fix of test suite
2018-11-14 15:46:53 +01:00
Oleksandr Byelkin
6cecb10a2f
MDEV-11167: InnoDB: Warning: using a partial-field key prefix in search, results in assertion failure or "Can't find record" error
...
Fix ha_rnd_init() argument (we do not doing scan but use rnd_pos)
2018-11-07 09:25:12 +01:00
Marko Mäkelä
5f29fdecc0
Merge 5.5 into 10.0
2018-11-07 08:02:18 +02:00
Anel Husakovic
9c026273a9
Add implementation in .h and delete unneccessery printing
2018-11-06 12:07:26 +00:00
Marko Mäkelä
db55b39fb2
Revert some InnoDB/XtraDB changes
...
The relevant InnoDB/XtraDB fixes up to 5.6.42 had already
been applied to MariaDB in commit 30c3d6db32
.
Revert some changes that appeared in
the merge commit 87d852f102
.
2018-11-05 16:47:14 +02:00
Eugene Kosov
03977e8273
MDEV-13671 InnoDB should use case-insensitive column name comparisons like the rest of the server
...
Problem affects INPLACE ALTER rename columns.
innobase_rename_column_try(): some strcmp() was replaced with my_strcasecmp(),
queries to update data dictionary was updated to not match column name case.
2018-11-05 11:59:59 +02:00
Oleksandr Byelkin
b68d8a05d3
MDEV-17401: LOAD DATA from very big file into MyISAM table results in EOF error and corrupt index
...
my_read fixed as in higher versions.
my_pread made as my_read aware of partial read of huge chunks of files
MY_FULL_IO enabled for file operations
2018-11-02 18:01:49 +01:00
Marko Mäkelä
f0cb21ea2e
Remove dead code is_thd_killed()
2018-11-02 12:42:01 +02:00
Sergei Golubchik
b7eca63620
fix the test to clean after itself
...
followup for c32f7ed235
2018-11-01 18:47:53 +01:00
Sergei Golubchik
c32f7ed235
MDEV-17377 invalid gap in auto-increment values after LOAD DATA
...
reset lex->many_values for LOAD DATA, as it's used for
auto-inc range size estimation.
2018-11-01 16:18:17 +01:00
Daniel Bartholomew
9eb8a46790
bump the VERSION
2018-11-01 11:09:32 -04:00
Varun Gupta
38b3e52c3c
MDEV-16695: Estimate for rows of derived tables is very high when we are using index_merge union
...
For index merge union[or sort union], the estimates are not taken into account while calculating the selectivity of
a condition. So instead of showing the estimates of the index merge union[or sort union], it shows estimates equal to
all the records of the table.
The fix for the issue is to include the selectivity of index merge
union[or sort union] while calculating the selectivity of a condition.
2018-11-01 13:20:26 +05:30
Jan Lindström
c4c738e1ef
Revert commit b2f39a5f56
wrong
...
branch.
2018-11-01 09:27:59 +02:00
Jan Lindström
b2f39a5f56
Add missing wsrep.cnf.sh
2018-11-01 09:15:41 +02:00
Takashi Sasaki
9ff9d2303d
test framework manual is moved
2018-11-01 02:22:18 +04:00
Alexander Barkov
75ceb6ff13
MDEV-17298 ASAN unknown-crash / READ of size 1 in my_strntoul_8bit upon INSERT .. SELECT
2018-10-31 14:25:26 +04:00
Sergei Golubchik
09e97299ba
Merge branch '5.5' into 10.0
2018-10-31 00:25:26 +01:00
Sergei Golubchik
31f1fe223e
don't try to build with OpenSSL 1.1+
2018-10-30 22:42:22 +01:00
Sergei Golubchik
250c5aa02c
./mtr --gdb='b mysql_parse;r'
...
--gdb now accepts an argument, it will be passed to gdb as a command.
multiple commands can be separated by a (non-standard and not escapable)
delimiter - semicolon (;).
Old usage with a bare --gdb continues to work too, of course.
Cherry-picked c47c0ca50c
5441bbd3b1
339b905579
2018-10-30 22:42:22 +01:00
Elena Stepanova
a737135ae3
List of unstable tests for 10.0.37 release
2018-10-30 18:15:58 +02:00
Alexey Botchkov
57898316b6
MDEV-17256 Decimal field multiplication bug.
...
We should clear trailing zeroes in frac part. Otherwise
that tail is growing quickly and forces unnecessary truncating of
arguments.
2018-10-30 18:15:41 +04:00
Marko Mäkelä
6ced789186
MDEV-12023 Assertion failure sym_node->table != NULL on startup
...
row_drop_table_for_mysql(): Avoid accessing non-existing dictionary tables.
dict_create_or_check_foreign_constraint_tables(): Add debug instrumentation
for creating and dropping a table before the creation of any non-core
dictionary tables.
trx_purge_add_update_undo_to_history(): Adjust a debug assertion, so that
it will not fail due to the test instrumentation.
2018-10-30 13:29:19 +02:00
Sergei Golubchik
f4b8b6b9a3
MDEV-15919 lower_case_table_names does not behave as expected
...
followup for e31e697f17
Fix the test not to fail on Mac OS X
(lower_case_table_names=0 prevents mysqld from starting on case insensitive
filesystem)
2018-10-29 21:44:38 +01:00
Sergei Golubchik
f30148a740
CONNECT: bintar compilation failure on Mac OS X
2018-10-29 20:00:59 +01:00
Sergei Golubchik
cd0734d6bd
after-merge: enable tests
2018-10-28 10:55:46 +01:00
Olivier Bertrand
70e567f576
Squashed commit of connect/10.0:
...
commit 02d8c21380f
Author: Olivier Bertrand <bertrandop@gmail.com>
Date: Sat Oct 6 16:27:13 2018 +0200
- Fix truncating error messages on first unrecognized latin1 character
modified: storage/connect/ha_connect.cc
- Fix MDEV-17343
Reject multi-table UPDATE/DELETE commands that crash on some systems
modified: storage/connect/ha_connect.cc
modified: storage/connect/tabext.cpp
- Try to fix failing tests (MariaDB version 10.0 only)
modified: storage/connect/mysql-test/connect/disabled.def
- Typo
modified: storage/connect/global.h
commit f83caed8569
Author: Olivier Bertrand <bertrandop@gmail.com>
Date: Tue Sep 25 15:49:26 2018 +0200
- Try to fix failing tests (MariaDB version 10.0 only)
modified: storage/connect/mysql-test/connect/disabled.def
modified: storage/connect/mysql-test/connect/r/grant2.result
modified: storage/connect/mysql-test/connect/r/infoschema2-9739.result
modified: storage/connect/mysql-test/connect/r/mysql_exec.result
commit 9fd6f178846
Author: Olivier Bertrand <bertrandop@gmail.com>
Date: Sun Sep 23 19:45:59 2018 +0200
- Implement the CHECK TABLE statement and accept REPAIR and ANALYZE
modified: storage/connect/connect.cc
modified: storage/connect/ha_connect.cc
modified: storage/connect/ha_connect.h
modified: storage/connect/tabjdbc.cpp
modified: storage/connect/tabmysql.cpp
modified: storage/connect/tabodbc.cpp
- MDEV-17212: Test if NumResultCols is implemented by the data source
modified: storage/connect/odbconn.cpp
- Change error type in Optimize
modified: storage/connect/ha_connect.cc
- Update version date
modified: storage/connect/ha_connect.cc
- Record new result from odbc_postgresql.test
modified: storage/connect/mysql-test/connect/r/odbc_postgresql.result
commit d8cf51319e1
Author: Olivier Bertrand <bertrandop@gmail.com>
Date: Wed Aug 8 12:18:52 2018 +0200
- Comment out failing Cyrillic test in xml2.test
modified: storage/connect/mysql-test/connect/r/xml2.result
modified: storage/connect/mysql-test/connect/t/xml2.test
commit 9df49e21f9e
Author: Olivier Bertrand <bertrandop@gmail.com>
Date: Tue Aug 7 15:01:06 2018 +0200
- Fix MDEV-16672 Connect: Warnings with 10.0
filamtxt.cpp: DOSFAM::RenameTempFile: Change sprintf to snprintf.
filamvct.cpp: VECFAM::RenameTempFile: Change sprintf to snprintf.
javaconn.cpp:
Add JAVAConn::GetUTFString function.
Use it instead of env->GetStringUTFChars.
Fix wrong identation.
javaconn.h: Add GetUTFString declaration.
jdbconn.cpp:
Use GetUTFString function instead of env->GetStringUTFChars.
jmgoconn.cpp:
Use GetUTFString function instead of env->GetStringUTFChars.
Fix wrong identation.
jsonudf.cpp: change 139 to BMX line 4631.
tabjmg.cpp:
Add ReleaseStringUTF.
Fix wrong identation.
tabpivot.cpp: Fix wrong identation.
tabutil.cpp: TDBPRX::GetSubTable: Change sprintf to snprintf.
modified: storage/connect/filamtxt.cpp
modified: storage/connect/filamvct.cpp
modified: storage/connect/javaconn.cpp
modified: storage/connect/javaconn.h
modified: storage/connect/jdbconn.cpp
modified: storage/connect/jmgoconn.cpp
modified: storage/connect/jsonudf.cpp
modified: storage/connect/tabjmg.cpp
modified: storage/connect/tabpivot.cpp
modified: storage/connect/tabutil.cpp
- Fix MDEV-16895 CONNECT engine's get_error_message can cause buffer
overflow and server crash with long queries
ha_connect_cc: Update version.
get_error_message: Remove charset conversion.
modified: storage/connect/ha_connect.cc
- Fix a server crash on inserting bigint to a JDBC table
JDBConn::SetUUID:
Suppress check on ctyp that causes a server crash because ctyp
can be negative and this triggers an DEBUG_ASSERT on return.
modified: storage/connect/jdbconn.cpp
- Delete an assert(qrp) from JCATPARM *AllocCatInfo that is called with
qrp=NULL from JDBConn::SetUUID. Also delete a clone of this function
that was duplicated in javaconn.cpp.
modified: storage/connect/javaconn.cpp
modified: storage/connect/jdbconn.cpp
- Update some disabled tests and results to avoid failure
modified: storage/connect/mysql-test/connect/r/jdbc.result
modified: storage/connect/mysql-test/connect/r/json_java_2.result
modified: storage/connect/mysql-test/connect/r/json_java_3.result
modified: storage/connect/mysql-test/connect/r/mongo_java_2.result
modified: storage/connect/mysql-test/connect/r/mongo_java_3.result
modified: storage/connect/mysql-test/connect/t/json_java_2.test
modified: storage/connect/mysql-test/connect/t/json_java_3.test
modified: storage/connect/mysql-test/connect/t/mongo_java_2.test
modified: storage/connect/mysql-test/connect/t/mongo_java_3.test
commit 415273eb193
Author: Olivier Bertrand <bertrandop@gmail.com>
Date: Thu Jun 28 19:37:49 2018 +0200
- Fix MDEV-16167 Cannot insert unsigned values into a VEC table
modified: storage/connect/filamvct.cpp
modified: storage/connect/tabvct.cpp
commit 9ffcb68a9f2
Author: Olivier Bertrand <bertrandop@gmail.com>
Date: Mon May 7 22:43:43 2018 +0200
- Fix MDEV-15735 CONNECT [filamtxt.cpp:429]: Suspicious condition
modified: storage/connect/filamtxt.cpp
- Fix compiler warnings
modified: storage/connect/domdoc.cpp
modified: storage/connect/ha_connect.cc
modified: storage/connect/json.h
modified: storage/connect/jsonudf.cpp
modified: storage/connect/tabext.cpp
modified: storage/connect/tabjson.cpp
modified: storage/connect/tabjson.h
- Miscelleanous from 10.3
modified: storage/connect/ha_connect.cc
modified: storage/connect/mycat.cc
modified: storage/connect/user_connect.cc
2018-10-28 10:41:31 +01:00
Sergei Golubchik
411a2540ee
CONNECT: don't mix bundled zlib and system libxml2
...
System libxml2 uses system zlib, it might conflicts with the bundled.
In particular, on centos5 old system zlib conflicts with the newer
(after c54271723c
) bundled zlib which causes CONNECT to crash
on xml tests.
2018-10-28 10:09:58 +01:00
Sergei Golubchik
3e2394a56b
Merge branch 'merge/merge-perfschema-5.6' into 10.0
2018-10-28 10:06:23 +01:00
Sergei Golubchik
1bad8f9df3
Merge branch 'merge/merge-xtradb-5.6' into 10.0
2018-10-28 10:04:36 +01:00
Sergei Golubchik
87d852f102
Merge branch 'merge/merge-innodb-5.6' into 10.0
2018-10-28 01:22:18 +02:00
Sergei Golubchik
a9a0d0c372
5.6.42
2018-10-27 21:06:41 +02:00
Sergei Golubchik
da34c7de5d
5.6.42
2018-10-27 21:05:16 +02:00
Sergei Golubchik
bbcb173436
5.6.41-84.1
2018-10-27 20:53:19 +02:00
Sergei Golubchik
37ab7e4596
Merge branch '5.5' into 10.0
2018-10-27 20:46:38 +02:00
Daniel Bartholomew
65cfc5873e
bump the VERSION
2018-10-26 04:00:00 -04:00
Marko Mäkelä
30c3d6db32
MDEV-17533 Merge new release of InnoDB 5.6.42 to 10.0
...
Also, add a test for a bug that does not seem to affect MariaDB.
2018-10-25 13:05:23 +03:00
Marko Mäkelä
2549f98289
MDEV-17532 Performance_schema reports wrong directory for the temporary files of ALTER TABLE…ALGORITHM=INPLACE
...
row_merge_file_create_low(): Pass the directory of the temporary file
to the PSI_FILE_CALL.
2018-10-25 13:04:41 +03:00
Marko Mäkelä
5dd3b52f95
MDEV-17531 Crash in RENAME TABLE with FOREIGN KEY and FULLTEXT INDEX
...
In RENAME TABLE, when an error occurs while renaming FOREIGN KEY
constraint, that error would be overwritten when renaming the
InnoDB internal tables related to FULLTEXT INDEX.
row_rename_table_for_mysql(): Do not attempt to rename the internal
tables if an error already occurred.
This problem was originally reported as Oracle Bug#27545888.
2018-10-25 13:03:29 +03:00