Commit graph

54040 commits

Author SHA1 Message Date
unknown
390b57f2ac Merge pilot.mysql.com:/data/msvensson/mysql/my50-bt-36463
into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.1-bugteam


client/mysqltest.c:
  Auto merged
dbug/dbug.c:
  Auto merged
mysql-test/mysql-test-run.pl:
  Auto merged
client/mysql_upgrade.c:
  SCCS merged
2008-05-02 19:42:34 +02:00
unknown
6add5be771 Bug#36469 mysql_upgrade does not use --tmpdir
client/mysql_upgrade.c:
  Add --tmpdir option to mysql_upgrade and use it when creating temporary files.
mysql-test/mysql-test-run.pl:
  Pass --tmpdir to mysql_upgrade
2008-05-02 14:41:19 +02:00
unknown
7f5119d3e5 Bug#35986 valgrind warning in DbugParse for empty string in SET GLOBAL DEBUG=""
- Code in DbugParse was reading from beyond end of the control string


dbug/dbug.c:
  Don't try to parse control strings that hasn't got any tokens
  or is zero size
2008-05-02 12:49:31 +02:00
unknown
cde8f109b9 Bug#36465 mysqltest should always use the --tmpdir
client/mysqltest.c:
  Use the --tmpdir location to create temporary files
2008-05-02 11:22:10 +02:00
unknown
9018c56ac4 Bug#36463 mysql-test-run.pl should always use the --tmpdi
mysql-test/mysql-test-run.pl:
  Use the requested tmpdir in 'collect_mysqld_features', create
  it if it does not already exists
2008-05-02 09:13:43 +02:00
unknown
ca0939d57d Merge pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/build_work/mysql-5.0-trigs
into  pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/build_work/mysql-5.1-trigs
2008-05-01 12:36:56 -04:00
unknown
abf8b70a0a Merge bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam
into  pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/build_work/mysql-5.0-trigs
2008-05-01 12:15:38 -04:00
unknown
b837c42041 Merge bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam
into  pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/build_work/mysql-5.1-trigs


client/mysqltest.c:
  Auto merged
2008-05-01 11:58:39 -04:00
unknown
5cda5240a6 Merge pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/build_work/mysql-5.0-trigs
into  pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/build_work/mysql-5.1-trigs


client/mysqltest.c:
  Auto merged
2008-05-01 11:37:34 -04:00
unknown
38c28141a8 Bug#36026 - Test funcs_1.<engine>_trig_03 failing on Windows
Bug#36028 - Test funcs_1.<engine>_trig_03e failing on Windows
Bug#36029 - Test funcs_1.<engine>_trig_0407 failing on Windows
Bug#36030 - Test funcs_1.<engine>_trig_08 failing on Windows

Adding $MASTER_MYSOCK to init_win_path()
When path names are short, master.sock ends up in MYSQL_TMP_DIR, but with longer path names,
master.sock ends up in /tmp/<random_string>/ and these tests will fail due to path delimiter difference.

New changeset to start with 5.0 -- Not all of these tests are present in 5.0, but want to keep mysqltest the same
2008-05-01 11:36:03 -04:00
unknown
6ef8efd4d5 Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam
into  magare.gmz:/home/kgeorge/mysql/autopush/B36041-5.1-bugteam
2008-05-01 17:51:26 +03:00
unknown
a2c99f5977 Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam
into  magare.gmz:/home/kgeorge/mysql/autopush/B36041-5.1-bugteam
2008-05-01 16:34:14 +03:00
unknown
803d77f84f Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam
into  magare.gmz:/home/kgeorge/mysql/autopush/B35298-5.1-bugteam


configure.in:
  Auto merged
2008-05-01 16:15:38 +03:00
unknown
4f3549638a Merge bk-internal:/home/bk/mysql-5.0-bugteam
into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam


configure.in:
  merge 5.0-bugteam to 5.1-bugteam
2008-05-01 15:59:51 +03:00
unknown
0e287a9c9c Merge magare.gmz:/home/kgeorge/mysql/work/B35298-5.0-bugteam
into  magare.gmz:/home/kgeorge/mysql/work/B35298-5.1-bugteam


mysql-test/r/func_gconcat.result:
  Auto merged
mysql-test/t/func_gconcat.test:
  Auto merged
sql/item_sum.cc:
  Auto merged
configure.in:
  merge 5.0-bugteam to 5.1-bugteam
2008-05-01 14:54:59 +03:00
unknown
1a68ec2809 Fix for bug #35298: GROUP_CONCAT with DISTINCT can crash the server
The bug is a regression introduced by the patch for bug32798.

The code in Item_func_group_concat::clear() relied on the 'distinct'
variable to check if 'unique_filter' was initialized. That, however,
is not always valid because Item_func_group_concat::setup() can do
shortcuts in some cases w/o initializing 'unique_filter'.

Fixed by checking the value of 'unique_filter' instead of 'distinct'
before dereferencing.


mysql-test/r/func_gconcat.result:
  Added test cases for bugs #35298 and #36024.
mysql-test/t/func_gconcat.test:
  Added test cases for bugs #35298 and #36024.
sql/item_sum.cc:
  Check if unique_filter != NULL before dereferencing it. Non-zero value
  of distinct does not always mean that unique_filter is initialized
  because Item_func_group_concat::setup() can do shortcuts is some cases
2008-05-01 13:49:26 +03:00
unknown
cf2b2cc506 Merge bk-internal:/home/bk/mysql-5.0
into  magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam
2008-05-01 13:40:56 +03:00
unknown
fefb7c6be6 Merge bk-internal:/home/bk/mysql-5.1
into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam


mysql-test/t/disabled.def:
  Auto merged
2008-05-01 13:25:38 +03:00
unknown
a701a84998 Use ulonglong to store row count in libmysld Protocol_text::remove_last_row()
(fix warnings).


libmysqld/lib_sql.cc:
  Use ulonglong to store row count in Protocol_text::remove_last_row()
  (fix warnings).
2008-04-30 19:14:41 -06:00
unknown
87298f01bf Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1-build
into  ramayana.hindu.god:/home/tsmith/m/bk/build/51


mysql-test/t/disabled.def:
  manual merge
2008-04-30 18:30:08 -06:00
unknown
157c8ccf3b Handle a few failing test cases
mysql-test/r/group_concat_max_len_func.result:
  Properly restore global group_concat_max_len value at end of test
mysql-test/t/disabled.def:
  Re-disable user_limits test; it is still failing randomly (bug 33696)
mysql-test/t/group_concat_max_len_func.test:
  Update test results
2008-04-30 17:39:51 -06:00
unknown
03896b376a Merge hh-nb.hungers:/work/trees/mysql-5.1-build-src-clean
into  hh-nb.hungers:/work/merge/mysql-5.1-build


mysql-test/t/disabled.def:
  Auto merged
2008-04-30 18:50:18 +02:00
unknown
a0f58065d9 the query_cache_wlock_invalidate_func fails due to bug 35390 and is therefore disabled. 2008-04-30 18:45:20 +02:00
unknown
368542d47b Merge mysql.com:/Users/davi/mysql/bugs/35788-5.1
into  mysql.com:/Users/davi/mysql/mysql-5.1-bugteam
2008-04-30 13:00:21 -03:00
unknown
57ae28ab95 Bug#35788 A few tests fail due to concurrent inserts
The problem is that since MyISAM's concurrent_insert is on by
default some concurrent SELECT statements might not see changes
made by INSERT statements in other connections, even if the
INSERT statement has returned.

The solution is to disable concurrent_insert so that INSERT
statements returns after the data is actually visible to other
statements.


mysql-test/r/client_xml.result:
  Update test case result.
mysql-test/r/federated.result:
  Update test case result.
mysql-test/r/federated_bug_25714.result:
  Update test case result.
mysql-test/t/client_xml.test:
  Disable concurrent insert and restore old value at the
  end of the test so it doesn't affect other tests.
mysql-test/t/federated.test:
  Disable concurrent insert and restore old value at the
  end of the test so it doesn't affect other tests.
mysql-test/t/federated_bug_25714.test:
  Disable concurrent insert and restore old value at the
  end of the test so it doesn't affect other tests.
2008-04-30 10:28:19 -03:00
unknown
06ddedd731 Merge bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam
into  mysql.com:/Users/davi/mysql/mysql-5.1-bugteam
2008-04-30 10:15:32 -03:00
unknown
888b92f1ed Merge hh-nb.hungers:/work/trees/mysql-5.1-build-src-clean
into  hh-nb.hungers:/work/merge/mysql-5.1-build


BitKeeper/deleted/.del-myisam_use_mmap_basic.result:
  Delete: mysql-test/r/myisam_use_mmap_basic.result
BitKeeper/deleted/.del-myisam_use_mmap_basic.test:
  Delete: mysql-test/t/myisam_use_mmap_basic.test
2008-04-30 15:09:51 +02:00
unknown
f2c82e48b2 Fix for bug 35988. 2008-04-30 14:49:37 +02:00
unknown
775a0682a6 Merge ramayana.hindu.god:/home/tsmith/m/bk/bugteam/mrg/51
into  ramayana.hindu.god:/home/tsmith/m/bk/build/51


mysql-test/suite/rpl/r/rpl_packet.result:
  Auto merged
mysql-test/suite/rpl/t/disabled.def:
  Auto merged
mysql-test/suite/rpl/t/rpl_packet.test:
  Auto merged
2008-04-29 20:56:44 -06:00
unknown
1e7bc4618b Merge ramayana.hindu.god:/home/tsmith/m/bk/bugteam/51
into  ramayana.hindu.god:/home/tsmith/m/bk/build/51


mysql-test/mysql-test-run.pl:
  Auto merged
mysql-test/suite/funcs_1/datadict/processlist_val.inc:
  Auto merged
mysql-test/t/disabled.def:
  Auto merged
mysql-test/suite/rpl/t/disabled.def:
  SCCS merged
2008-04-29 20:55:48 -06:00
unknown
86e6ea34ec Merge ramayana.hindu.god:/home/tsmith/m/bk/bugteam/51
into  ramayana.hindu.god:/home/tsmith/m/bk/bugteam/mrg/51
2008-04-29 20:50:04 -06:00
unknown
6e6d60732b Bug #36041: mysql-test-run doesn't seem to string match
100% effectively on Windows

The mysqltest docs state that the 'replace_result' command
doesn't perform any escape processing.
However the current implementation was processing backslash 
escapes in the from/to strings.
This prevents replacing e.g. patch on windows (where backslash
is used as a path separator).
Fixed by removing the backslash escape processing from 
'replace_result'.


client/mysqltest.c:
  Bug #36041: remove the escape processing from --replace_result
mysql-test/r/mysqltest.result:
  Bug #36041: test case
mysql-test/t/mysqltest.test:
  Bug #36041: test case
2008-04-29 19:08:52 +03:00
unknown
26888186c5 Merge mysqldev@production:my/build-200803311521-5.1.24-rc/mysql-5.1-release
into  ramayana.hindu.god:/home/tsmith/m/bk/bugteam/mrg/51


mysql-test/suite/rpl/r/rpl_packet.result:
  Auto merged
mysql-test/suite/rpl/t/rpl_packet.test:
  Auto merged
mysql-test/suite/rpl/t/disabled.def:
  SCCS merged
2008-04-28 21:23:29 -06:00
unknown
f4bd5105e2 Backport kostja's fix for Bug#32724 "innodb_mysql.test fails randomly".
Enable back the disabled test case.


mysql-test/include/mix1.inc:
  Fix a race condition in the test, causing a sporadic failure.
mysql-test/r/innodb_mysql.result:
  Update test case result.
mysql-test/t/disabled.def:
  Enable the test case innodb_mysql.
sql/sql_parse.cc:
  Fix the random failure of innodb_mysql test. The failure is not
  random any more after a patch for Bug 12713 added asserts around
  handler commit.
2008-04-29 00:03:19 -03:00
unknown
2ea403e19c Merge amd64.(none):/src/rel_clean_up/my50-rel_clean_up
into  amd64.(none):/src/rel_clean_up/my51-rel_clean_up


include/my_global.h:
  Auto merged
2008-04-28 15:03:07 -04:00
unknown
da7b9c5882 Merge amd64.(none):/src/rel_clean_up/my50-release
into  amd64.(none):/src/rel_clean_up/my50-rel_clean_up
2008-04-28 15:00:31 -04:00
unknown
57036d8a71 Correct failing build. 2008-04-28 14:58:32 -04:00
unknown
525ecab122 Merge amd64.(none):/src/rel_clean_up/my50-rel_clean_up
into  amd64.(none):/src/rel_clean_up/my51-rel_clean_up


mysql-test/r/type_decimal.result:
  Auto merged
mysql-test/t/type_decimal.test:
  Auto merged
sql/my_decimal.h:
  Auto merged
2008-04-28 14:12:52 -04:00
unknown
28a0898257 Merge bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam
into  amd64.(none):/src/rel_clean_up/my51-rel_clean_up
2008-04-28 14:04:03 -04:00
unknown
96e405b662 Merge bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam
into  amd64.(none):/src/rel_clean_up/my50-rel_clean_up
2008-04-28 13:58:19 -04:00
unknown
90ecda4a2e Merge amd64.(none):/src/rel_clean_up/my50-rel_clean_up
into  amd64.(none):/src/rel_clean_up/my51-rel_clean_up


mysys/thr_alarm.c:
  Auto merged
2008-04-28 13:42:59 -04:00
unknown
e20145f626 Merge amd64.(none):/src/rel_clean_up/my50-release
into  amd64.(none):/src/rel_clean_up/my50-rel_clean_up
2008-04-28 13:41:50 -04:00
unknown
8def2e0993 Avoid compilation problem on AIX. 2008-04-28 13:41:12 -04:00
unknown
5141601a97 Merge host.loc:/work/bugs/5.1-bugteam-36006
into  host.loc:/work/bk/5.1-bugteam
2008-04-28 08:29:58 +05:00
unknown
92098d5d66 Bug#36032 - Test funcs_1.processlist_priv_ps fails on Windows
Bug#36033 - Test funcs_1.processlist_val_ps fails on Windows
Bug#36034 - Test parts.part_supported_sql_func_<eng> fails on Windows
Bug#36036 - Test parts.partition_alter1_<eng> fails on Windows
Bug#36037 - Test parts.partition_alter2_<eng> fails on Windows
Bug#36038 - Test parts.partition_basic_<engine> failing on Windows
Bug#36039 - Test parts.partition_engine_<eng> fails on Windows
Bug#36040 - Test parts.partition_syntax_<eng> fails on Windows

Changeset to fix multiple 5.1.24-rc build bugs on Windows platforms.

Many of these bugs had the same root causes.


mysql-test/mysql-test-run.pl:
  Bug#36034 - Test parts.partition_supported_sql_func_<eng> fails on Windows
  
  Kent suggested these changes to ensure all contents of mysql-test/std_data are copied to std_data_ln on Windows (no symlinks)
mysql-test/suite/funcs_1/datadict/processlist_priv.inc:
  Bug#36032 - Test funcs_1.processlist_priv_ps fails on Windows
  
  Altered .inc file to include HOST column in the --replace_column clauses.
  
  Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
mysql-test/suite/funcs_1/datadict/processlist_val.inc:
  Bug#36033 - Test funcs_1.processlist_val_ps fails on Windows
  
  Altered .inc file to include HOST column in the --replace_column clauses.
  
  Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
mysql-test/suite/funcs_1/r/processlist_priv_no_prot.result:
  Bug#36032 - Test funcs_1.processlist_priv_ps fails on Windows
  
  Altered .inc file to include HOST column in the --replace_column clauses.
  
  Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
  
  -reran .result file to account for change in --replace_column calls
mysql-test/suite/funcs_1/r/processlist_priv_ps.result:
  Bug#36032 - Test funcs_1.processlist_priv_ps fails on Windows
  
  Altered .inc file to include HOST column in the --replace_column clauses.
  
  Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
  
  -reran .result file to account for change in --replace_column calls
mysql-test/suite/funcs_1/r/processlist_val_no_prot.result:
  Bug#36033 - Test funcs_1.processlist_val_ps fails on Windows
  
  Altered .inc file to include HOST column in the --replace_column clauses.
  
  Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
  
  Reran .result file to account for changes to --replace_column clauses
mysql-test/suite/funcs_1/r/processlist_val_ps.result:
  Bug#36033 - Test funcs_1.processlist_val_ps fails on Windows
  
  Altered .inc file to include HOST column in the --replace_column clauses.
  
  Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
  
  Reran .result file to account for changes to --replace_column clauses
mysql-test/suite/parts/inc/partition_layout_check1.inc:
  Bug#36036 - Test parts.partition_alter1_<eng> fails on Windows
  Bug#36037 - Test parts.partition_alter2_<eng> fails on Windows
  Bug#36038 - Test parts.partition_basic_<engine> failing on Windows
  Bug#36039 - Test parts.partition_engine_<eng> fails on Windows
  Bug#36040 - Test parts.partition_syntax_<eng> fails on Windows
  
  Added replace_result clause to account for Windows' use of '\r' vs. '\n'
  
  This difference was causing failures on Windows.
  
  Also, mleich added some changes to remove some -ls clauses that weren't necessary
mysql-test/suite/parts/inc/partition_layout_check2.inc:
  Bug#36036 - Test parts.partition_alter1_<eng> fails on Windows
  Bug#36037 - Test parts.partition_alter2_<eng> fails on Windows
  Bug#36038 - Test parts.partition_basic_<engine> failing on Windows
  Bug#36039 - Test parts.partition_engine_<eng> fails on Windows
  Bug#36040 - Test parts.partition_syntax_<eng> fails on Windows
  
  Added replace_result clause to account for Windows' use of '\r' vs. '\n'
  
  This difference was causing failures on Windows.
  
  Also, mleich added some changes to remove some -ls clauses that weren't necessary
mysql-test/suite/parts/r/partition_basic_symlink_myisam.result:
  changes by mleich to remove unneeded use of -ls clause in .result file 
  
  These clauses were removed from partition_layout_check1.inc and partition_layout_check2.inc
2008-04-26 19:52:43 -04:00
unknown
5b8cdbf4a6 Fixed bug#36006: Optimizer does table scan for SELECT COUNT(*)
for ENGINE=MRG_MYISAM (should be optimized out).

Before WL#3281 MERGE engine had the HA_NOT_EXACT_COUNT flag
unset, and it worked with COUNT optimization as desired.
After the removal of the HA_NOT_EXACT_COUNT flag neither
HA_STATS_RECORDS_IS_EXACT (opposite to former HA_NOT_EXACT_COUNT
flag) nor modern HA_HAS_RECORDS flag were not added to MERGE
table flag mask.

1. The HA_HAS_RECORDS table flag has been set.
2. The ha_myisammrg::records method has been overridden to
   calculate total number of records in underlying tables.



storage/myisammrg/myrg_records.c:
  Fixed bug#36006: Optimizer does table scan for select count(*).
  The myrg_records function has been added to calculate total number
  of records in underlying tables.
include/myisammrg.h:
  Fixed bug#36006: Optimizer does table scan for select count(*).
  The myrg_records function declaration has been added.
mysql-test/r/merge.result:
  Added test case for bug#36006.
mysql-test/t/merge.test:
  Added test case for bug#36006.
storage/myisammrg/CMakeLists.txt:
  Fixed bug#36006: Optimizer does table scan for select count(*).
  New myrg_records.c file has been added.
storage/myisammrg/Makefile.am:
  Fixed bug#36006: Optimizer does table scan for select count(*).
  New myrg_records.c file has been added.
storage/myisammrg/ha_myisammrg.cc:
  Fixed bug#36006: Optimizer does table scan for select count(*).
  The ha_myisammrg::records method has been overridden.
storage/myisammrg/ha_myisammrg.h:
  Fixed bug#36006: Optimizer does table scan for select count(*).
  1. The HA_HAS_RECORDS table flag has been set.
  2. The ha_myisammrg::records method has been overridden.
2008-04-26 02:45:58 +05:00
unknown
2a1ba656b4 Merge olga.mysql.com:/home/igor/mysql-5.1-bugteam
into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-bug35844


sql/sql_select.cc:
  Auto merged
2008-04-24 14:19:44 -07:00
unknown
89b866e7bf Bug#36023: Incorrect handling of zero length caused an assertion to fail.
When a zero length is provided to the my_decimal_length_to_precision
function along with unsigned_flag set to false it returns a negative value.
For queries that employs temporary tables may cause failed assertion or
excessive memory consumption while temporary table creation.

Now the my_decimal_length_to_precision and the my_decimal_precision_to_length
functions take unsigned_flag into account only if the length/precision
argument is non-zero.


mysql-test/t/type_decimal.test:
  Added a test case for the bug#36023: Incorrect handling of zero length caused
   an assertion to fail.
mysql-test/r/type_decimal.result:
  Added a test case for the bug#36023: Incorrect handling of zero length caused
   an assertion to fail.
sql/my_decimal.h:
  Bug#36023: Incorrect handling of zero length caused an assertion to fail.
  Now the my_decimal_length_to_precision and the my_decimal_precision_to_length
  functions take unsigned_flag into account only if the length/precision
  argument is non-zero.
2008-04-25 00:39:37 +04:00
unknown
34efb0fdab Merge zippy.cornsilk.net:/home/cmiller/work/mysql/bug35157/my51-bug35157
into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.1-build


client/mysqldump.c:
  Auto merged
mysql-test/r/mysqldump.result:
  Auto merged
2008-04-24 10:50:38 -04:00
unknown
9cb63bfbdd Enabled rpl: rpl_view, rpl_ndb_multi, rpl_log_pos
and main: user_limits, concurrent_innodb, lowercase_table3, ctype_create 
tests.


mysql-test/suite/ndb/t/disabled.def:
  Removed test commented.
mysql-test/suite/rpl/t/disabled.def:
  Enabled rpl_view, rpl_ndb_multi, rpl_log_pos tests.
mysql-test/t/disabled.def:
  Enabled user_limits, concurrent_innodb, lowercase_table3, ctype_create tests.
2008-04-24 16:43:08 +05:00