Now one need only SELECT privilege for tables that are only read in
UPDATE statements with many tables. (Bug #2377).
sql/sql_acl.cc:
Comment cleanup
sql/sql_parse.cc:
Merged duplicate code.
Removed some outdated 'tables->db' tests.
Check privileges for multi-updates properly (Bug #2377)
sql/sql_show.cc:
Remove disabled code
sql/sql_update.cc:
Ensure that privileges are tested properly for multi-table-updates
tests/grant.pl:
Added more tests
tests/grant.res:
updated results
client/mysqldump.c:
Better help for flush-logs
mysql-test/r/lock.result:
Test for LOCK TABLES ; INSERT ... SELECT
mysql-test/t/lock.test:
Test for LOCK TABLES ; INSERT ... SELECT
Fix optimizer tuning bug when first used key part was a constant. (Bug #1679)
innobase/dict/dict0dict.c:
Fixed parsing of column names and foreign key constraints to handle quoted identifiers and identifiers with space. (Bug #1725)
mysql-test/r/innodb.result:
Test of innodb internal parsing
mysql-test/t/innodb.test:
Test of innodb internal parsing
sql/sql_class.cc:
Safety fix for select into outfile and select into dumpfile. Before calling send_error() could cause end_io_cache() to be called several times.
sql/sql_class.h:
Add path to dumpfile so that we can delete the generated file if something goes wrong.
sql/sql_select.cc:
Fix optimizer tuning bug when first used key part was a constant.
Previously all keys that had this key part first was regarded as equal, even if the query used more key parts for some of the keys.
Now we use the range optimizer results to just limit the number of estimated rows if not all key parts where constants.
(Bug #1679)
when we open the HEAP table for the first time since server restart,
in hp_open(), we set a flag to propagate this info to the handler level
which then writes a DELETE FROM this_heap_table to the binlog.
It is not a perfect solution for the bug, because between the server start and
the first open of the table, the slave still had old data in his table so
a SELECT on the slave may show wrong content. But if there is a --init-file
to populate the HEAP table on master as startup, then this is a safe fix
(I'll put a note about init-file in the HEAP section of the manual).
heap/hp_info.c:
new info variable implicit_emptied
heap/hp_open.c:
If this is the first open of the HEAP table, it means it is empty,
so we mark it.
include/heap.h:
new variables implicit_emptied
(we need one in HEAPINFO for the hp_info() call).
sql/ha_heap.cc:
report info to upper level
sql/handler.h:
new info 'implicit_emptied' in the handler level; only HEAP uses it.
sql/sql_base.cc:
When a HEAP table is opened for the first time, write a DELETE FROM to the binlog,
for replication and mysqlbinlog|mysql.
Monty: I added the
entry->file->implicit_emptied= 0;
(as long as replicate-*-table rules were defined, multi-table DELETE was never
replicated by the slave).
sql/sql_parse.cc:
For a multi-table DELETE, there are two lists of tables:
- 'tables' contains the tables in the FROM. They have 'updating==0'.
- 'thd->lex.auxilliary_table_list.first' contains the tables between the DELETE and the FROM. They have 'updating==1'.
So the bug was that the slave only tests 'tables' and as all its elements have updating==0,
tables_ok() always returns 0.
So for a multi DELETE the slave now tests the 2nd list too.
I started with the other tip of the sausage: I thought of changing multi DELETE to use
only one list (given that 'updating' can be used to separate it in two when needed)
(with one list we wouldn't need to change the slave code), but finally hit the unicity
check in add_table_to_list() which started to return ER_NONUNIQ_TABLE (logical).
This fixed problem with index reads on character fields with BDB tables. (Bug #2509)
BitKeeper/etc/ignore:
added man/*.1
mysql-test/r/bdb.result:
New test
mysql-test/r/myisam.result:
More tests
mysql-test/t/bdb.test:
Test for idnex only read
mysql-test/t/myisam.test:
More test to verify pushed bug fix
sql/ha_berkeley.h:
Mark that strings may change on index only reads
sql/item_strfunc.cc:
Cleanup
sql/table.cc:
Allow index only reads on binary strings
Fix bug: InnoDB row count and index cardinality estimates wrapped over at 512 million in 32-bit computers
innobase/btr/btr0cur.c:
Fix bug: InnoDB row count and index cardinality estimates wrapped over at 512 million in 32-bit computers
reset errors (in thd) before executing the event. Otherwise if an event is ignored
because of replicate-*-table rules (error ER_SLAVE_IGNORED_TABLE) this error code
may remain in thd->net and the next event may pick it.
sql/log_event.cc:
Reset errors (in thd) before executing the event. Otherwise if an event is ignored
because of replicate-*-table rules (error ER_SLAVE_IGNORED_TABLE) this error code
may remain in thd->net and the next event may pick it.
Fix bug #2483 with InnoDB, UNIQUE secondary index, and NULL values in that unique index; with the IS NULL predicate, InnoDB returned only the first matching row, though there can be many
innobase/row/row0sel.c:
Fix bug #2483 with InnoDB, UNIQUE secondary index, and NULL values in that unique index; with the IS NULL predicate, InnoDB returned only the first matching row, though there can be many
innobase/include/data0data.h:
Fix bug #2483 with InnoDB, UNIQUE secondary index, and NULL values in that unique index; with the IS NULL predicate, InnoDB returned only the first matching row, though there can be many
innobase/include/data0data.ic:
Fix bug #2483 with InnoDB, UNIQUE secondary index, and NULL values in that unique index; with the IS NULL predicate, InnoDB returned only the first matching row, though there can be many
<monty> ramil, in MySQL/MyISAM we should only strip end space, not 'space-like' characters.
<monty> This is according to SQL; When doing a comparision end space and only end space are ignored.
myisam/mi_key.c:
a proper fix for the bug #2298 Trailing whitespace inconsistently handled in WHERE clause.
myisam/mi_search.c:
a proper fix for the bug #2298 Trailing whitespace inconsistently handled in WHERE clause.
mysql-test/r/select.result:
test case for the bug #2298 Trailing whitespace inconsistently handled in WHERE clause.
mysql-test/t/select.test:
test case for the bug #2298 Trailing whitespace inconsistently handled in WHERE clause.
sql/sql_string.cc:
a proper fix for the bug #2298 Trailing whitespace inconsistently handled in WHERE clause.
spec file after the build as RPM has its own option for this
Build-tools/Do-rpm:
- remove unnecessary code to delete the source tarball and spec file
after the build as RPM has its own option for this
manpage) turned out as a major overhaul of all man pages:
- renamed all *.1 files to *.1.in to act as templates which are being
processed at build time
- replaced some hard-coded values with place holder that are being
replaced with the proper values at build time
- Updated list of available man pages in the SEE ALSO section and added a
hint to the manual for more details
- Added a BUGS section to all pages, referring to the bugs DB
- Updated some obsolete URLs and mail addresses
The actual content of these man pages should probably be cross-checked for
correctness, though...
man/Makefile.am:
- Replace some hard-coded values in the man pages with the proper values
at build time instead. Instead of the *.1 files, we now add the *.1.in
files (the templates) to the source distribution and generate the *.1
files during make.
man/isamchk.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/isamlog.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysql_fix_privilege_tables.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysql_zap.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysqlaccess.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysqladmin.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysqld.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysqld_multi.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysqld_safe.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysqldump.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysqlshow.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/perror.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/replace.1.in:
- replaced some hard-coded values (e.g. Version numbers) with variables
which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
man/mysql.1.in:
- replaced some hard-coded values (e.g. Version numbers, path names) with
variables which are replaced with the proper values at build time
- Updated list of other man pages listed in SEE ALSO
- Added BUGS section, referring to the bugs database
- Updated URL and Mail address
I remove the --old-rpl-compat which produces broken binlogs readable
neither by 4.0 nor by 3.23.
This option is a leftover of the early replication of 4.0.0, when
it was still partly compatible with 3.23.
I explained this to the user in the bug report.
sql/mysqld.cc:
removing --old-rpl-compat
sql/sql_load.cc:
removing --old-rpl-compat
sql/sql_repl.h:
removing --old-rpl-compat
started via mysqld_safe (BUG#2114) Thanks to Rodrigo Marchant for the
suggestion
scripts/mysqld_safe.sh:
- fixed early removing of socket file when multiple instances of mysqld are
started via the script (BUG#2114) Thanks to Rodrigo Marchant for the
suggestion
Fix bug: FOREIGN KEY ... ON UPDATE/DELETE NO ACTION must check the foreign key constraint, not ignore it. Peter Gulutzan said that NO ACTION should check the constraint as deferred, at the end of the SQL statement, while RESTRICT should check it immediately. Since we do not have defered constraints in InnoDB, this bug fix makes InnoDB to check NO ACTION constraints immediately, like it checks RESTRICT constraints.
innobase/row/row0ins.c:
Fix bug: FOREIGN KEY ... ON UPDATE/DELETE NO ACTION must check the foreign key constraint, not ignore it. Peter Gulutzan said that NO ACTION should check the constraint as deferred, at the end of the SQL statement, while RESTRICT should check it immediately. Since we do not have defered constraints in InnoDB, this bug fix makes InnoDB to check NO ACTION constraints immediately, like it checks RESTRICT constraints.
for the MySQL root user (BUG#2375)
scripts/mysql_install_db.sh:
- improved wording on what to do to set the password for the MySQL root
user (BUG#2375)
