diff options
author | rfeng <rfeng@13f79535-47bb-0310-9956-ffa450edef68> | 2009-11-09 19:13:30 +0000 |
---|---|---|
committer | rfeng <rfeng@13f79535-47bb-0310-9956-ffa450edef68> | 2009-11-09 19:13:30 +0000 |
commit | f2f0a208b009dc706fbf0e71308afb89c212c7a9 (patch) | |
tree | f29343da4d6ec258d39e288057202e6ed14b0dbf /branches/sca-java-1.5.2/modules | |
parent | 8be9672804ac30d0681bae0043dfcfa06c19f71b (diff) |
Turn the IdentityHashMap into a ConcurrentHashMap to avoid expensive synchronizations (merge from 1.x)
git-svn-id: http://svn.us.apache.org/repos/asf/tuscany@834178 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'branches/sca-java-1.5.2/modules')
-rw-r--r-- | branches/sca-java-1.5.2/modules/core/src/main/java/org/apache/tuscany/sca/core/assembly/RuntimeWireImpl.java | 47 |
1 files changed, 23 insertions, 24 deletions
diff --git a/branches/sca-java-1.5.2/modules/core/src/main/java/org/apache/tuscany/sca/core/assembly/RuntimeWireImpl.java b/branches/sca-java-1.5.2/modules/core/src/main/java/org/apache/tuscany/sca/core/assembly/RuntimeWireImpl.java index cc71374296..4a90d47fa9 100644 --- a/branches/sca-java-1.5.2/modules/core/src/main/java/org/apache/tuscany/sca/core/assembly/RuntimeWireImpl.java +++ b/branches/sca-java-1.5.2/modules/core/src/main/java/org/apache/tuscany/sca/core/assembly/RuntimeWireImpl.java @@ -21,9 +21,9 @@ package org.apache.tuscany.sca.core.assembly; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; -import java.util.IdentityHashMap; import java.util.List; import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; import org.apache.tuscany.sca.assembly.Binding; import org.apache.tuscany.sca.assembly.Component; @@ -82,8 +82,8 @@ public class RuntimeWireImpl implements RuntimeWire { private List<InvocationChain> chains; private InvocationChain bindingInvocationChain; // Cache - private transient final Map<Operation, InvocationChain> invocationChainMap = - new IdentityHashMap<Operation, InvocationChain>(); + private transient final Map<Integer, InvocationChain> invocationChainMap = + new ConcurrentHashMap<Integer, InvocationChain>(); /** @@ -135,29 +135,28 @@ public class RuntimeWireImpl implements RuntimeWire { } public InvocationChain getInvocationChain(Operation operation) { - synchronized (invocationChainMap) { - InvocationChain cached = invocationChainMap.get(operation); - if (cached == null) { - for (InvocationChain chain : getInvocationChains()) { - Operation op = null; - if (wireSource.getContract() != null) { - // Reference chain - op = chain.getSourceOperation(); - } else { - // Service chain - op = chain.getTargetOperation(); - } - if (interfaceContractMapper.isCompatible(operation, op, op.getInterface().isRemotable())) { - invocationChainMap.put(operation, chain); - return chain; - } + Integer id = operation == null ? new Integer(0) : new Integer(System.identityHashCode(operation)); + InvocationChain cached = invocationChainMap.get(id); + if (cached == null) { + for (InvocationChain chain : getInvocationChains()) { + Operation op = null; + if (wireSource.getContract() != null) { + // Reference chain + op = chain.getSourceOperation(); + } else { + // Service chain + op = chain.getTargetOperation(); + } + if (interfaceContractMapper.isCompatible(operation, op, op.getInterface().isRemotable())) { + invocationChainMap.put(id, chain); + return chain; } - invocationChainMap.put(operation, null); - return null; - - } else { - return cached; } + invocationChainMap.put(id, null); + return null; + + } else { + return cached; } } |