Moved the error message to TextInputLayout in the ChangePasswordActivity

3 files changed, 86 insertions, 12 deletions

diff --git a/src/main/java/de/pixart/messenger/ui/ChangePasswordActivity.java b/src/main/java/de/pixart/messenger/ui/ChangePasswordActivity.java
index b73393b0c..f6bec9838 100644
--- a/src/main/java/de/pixart/messenger/ui/ChangePasswordActivity.java
+++ b/src/main/java/de/pixart/messenger/ui/ChangePasswordActivity.java
@@ -2,6 +2,7 @@ package de.pixart.messenger.ui;
 
 import android.content.Intent;
 import android.os.Bundle;
+import android.support.design.widget.TextInputLayout;
 import android.view.View;
 import android.widget.Button;
 import android.widget.EditText;
@@ -10,6 +11,7 @@ import android.widget.Toast;
 import de.pixart.messenger.R;
 import de.pixart.messenger.entities.Account;
 import de.pixart.messenger.services.XmppConnectionService;
+import de.pixart.messenger.ui.widget.DisabledActionModeCallback;
 
 public class ChangePasswordActivity extends XmppActivity implements XmppConnectionService.OnAccountPasswordChanged {
 
@@ -22,13 +24,15 @@ public class ChangePasswordActivity extends XmppActivity implements XmppConnecti
                 final String newPassword = mNewPassword.getText().toString();
                 if (!mAccount.isOptionSet(Account.OPTION_MAGIC_CREATE) && !currentPassword.equals(mAccount.getPassword())) {
                     mCurrentPassword.requestFocus();
-                    mCurrentPassword.setError(getString(R.string.account_status_unauthorized));
+                    mCurrentPasswordLayout.setError(getString(R.string.account_status_unauthorized));
+                    removeErrorsOnAllBut(mCurrentPasswordLayout);
                 } else if (newPassword.trim().isEmpty()) {
                     mNewPassword.requestFocus();
-                    mNewPassword.setError(getString(R.string.password_should_not_be_empty));
+                    mNewPasswordLayout.setError(getString(R.string.password_should_not_be_empty));
+                    removeErrorsOnAllBut(mNewPasswordLayout);
                 } else {
-                    mCurrentPassword.setError(null);
-                    mNewPassword.setError(null);
+                    mCurrentPasswordLayout.setError(null);
+                    mNewPasswordLayout.setError(null);
                     xmppConnectionService.updateAccountPasswordOnServer(mAccount, newPassword, ChangePasswordActivity.this);
                     mChangePasswordButton.setEnabled(false);
                     mChangePasswordButton.setTextColor(getSecondaryTextColor());
@@ -40,6 +44,8 @@ public class ChangePasswordActivity extends XmppActivity implements XmppConnecti
     private EditText mCurrentPassword;
     private EditText mNewPassword;
     private Account mAccount;
+    private TextInputLayout mNewPasswordLayout;
+	private TextInputLayout mCurrentPasswordLayout;
 
     @Override
     void onBackendConnected() {
@@ -65,7 +71,9 @@ public class ChangePasswordActivity extends XmppActivity implements XmppConnecti
         this.mChangePasswordButton = findViewById(R.id.right_button);
         this.mChangePasswordButton.setOnClickListener(this.mOnChangePasswordButtonClicked);
         this.mCurrentPassword = findViewById(R.id.current_password);
+        this.mCurrentPassword.setCustomSelectionActionModeCallback(new DisabledActionModeCallback());
         this.mNewPassword = findViewById(R.id.new_password);
+        this.mNewPassword.setCustomSelectionActionModeCallback(new DisabledActionModeCallback());
     }
 
     @Override
@@ -92,18 +100,27 @@ public class ChangePasswordActivity extends XmppActivity implements XmppConnecti
 
     @Override
     public void onPasswordChangeFailed() {
-        runOnUiThread(new Runnable() {
-            @Override
-            public void run() {
-                mNewPassword.setError(getString(R.string.could_not_change_password));
-                mChangePasswordButton.setEnabled(true);
-                mChangePasswordButton.setTextColor(getPrimaryTextColor());
-                mChangePasswordButton.setText(R.string.change_password);
-            }
+        runOnUiThread(() -> {
+            mNewPasswordLayout.setError(getString(R.string.could_not_change_password));
+            mChangePasswordButton.setEnabled(true);
+            mChangePasswordButton.setTextColor(getPrimaryTextColor());
+            mChangePasswordButton.setText(R.string.change_password);
         });
 
     }
 
+    private void removeErrorsOnAllBut(TextInputLayout exception) {
+        if (this.mCurrentPasswordLayout != exception) {
+            this.mCurrentPasswordLayout.setErrorEnabled(false);
+            this.mCurrentPasswordLayout.setError(null);
+        }
+        if (this.mNewPasswordLayout != exception) {
+            this.mNewPasswordLayout.setErrorEnabled(false);
+            this.mNewPasswordLayout.setError(null);
+        }
+
+    }
+
     public void refreshUiReal() {
 
     }
diff --git a/src/main/java/de/pixart/messenger/ui/widget/DisabledActionModeCallback.java b/src/main/java/de/pixart/messenger/ui/widget/DisabledActionModeCallback.java
new file mode 100644
index 000000000..5acf3a666
--- /dev/null
+++ b/src/main/java/de/pixart/messenger/ui/widget/DisabledActionModeCallback.java
@@ -0,0 +1,55 @@
+/*
+ * Copyright (c) 2018, Daniel Gultsch All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without modification,
+ * are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice, this
+ * list of conditions and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation and/or
+ * other materials provided with the distribution.
+ *
+ * 3. Neither the name of the copyright holder nor the names of its contributors
+ * may be used to endorse or promote products derived from this software without
+ * specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
+ * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+package de.pixart.messenger.ui.widget;
+
+import android.view.ActionMode;
+import android.view.Menu;
+import android.view.MenuItem;
+
+public class DisabledActionModeCallback implements ActionMode.Callback {
+    @Override
+    public boolean onCreateActionMode(ActionMode mode, Menu menu) {
+        return false;
+    }
+
+    @Override
+    public boolean onPrepareActionMode(ActionMode mode, Menu menu) {
+        return false;
+    }
+
+    @Override
+    public boolean onActionItemClicked(ActionMode mode, MenuItem item) {
+        return false;
+    }
+
+    @Override
+    public void onDestroyActionMode(ActionMode mode) {
+
+    }
+}
\ No newline at end of file
diff --git a/src/main/res/layout/activity_change_password.xml b/src/main/res/layout/activity_change_password.xml
index d8e7d1785..1dfdc8309 100644
--- a/src/main/res/layout/activity_change_password.xml
+++ b/src/main/res/layout/activity_change_password.xml
@@ -26,6 +26,7 @@
 
 
                 <android.support.design.widget.TextInputLayout
+                    android:id="@+id/current_password_layout"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     app:passwordToggleDrawable="@drawable/visibility_toggle_drawable"
@@ -45,6 +46,7 @@
                 </android.support.design.widget.TextInputLayout>
 
                 <android.support.design.widget.TextInputLayout
+                    android:id="@+id/new_password_layout"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     app:passwordToggleDrawable="@drawable/visibility_toggle_drawable"