Fix session logic: enforce same type of encryption

1 files changed, 3 insertions, 25 deletions

diff --git a/src/main/java/eu/siacs/conversations/ui/adapter/MessageAdapter.java b/src/main/java/eu/siacs/conversations/ui/adapter/MessageAdapter.java
index 4d1260e83..76da42c4c 100644
--- a/src/main/java/eu/siacs/conversations/ui/adapter/MessageAdapter.java
+++ b/src/main/java/eu/siacs/conversations/ui/adapter/MessageAdapter.java
@@ -569,32 +569,10 @@ public class MessageAdapter extends ArrayAdapter<Message> {
 		}
 
 		if (type == RECEIVED) {
-			boolean wasEncrypted = false;
-			for (Message iterator = message.prev(); iterator != null; iterator = iterator.prev()){
-				if (iterator.getEncryption() != Message.ENCRYPTION_NONE) {
-					wasEncrypted = true;
-					break;
-				}
-				if (!iterator.isCarbon() && iterator.getType() == SENT) {
-					break;
-				}
-			}
-			boolean willBeEncrypted = conversation.getNextEncryption(false) != Message.ENCRYPTION_NONE;
-			for (Message iterator = message.next(); iterator != null; iterator = iterator.next()){
-				if (iterator.getEncryption() != Message.ENCRYPTION_NONE) {
-					willBeEncrypted = true;
-					break;
-				}
-				if (!iterator.isCarbon() && iterator.getType() == SENT) {
-					break;
-				}
-			}
-
-			if ( willBeEncrypted && wasEncrypted
-					&& message.getEncryption() == Message.ENCRYPTION_NONE) {
-				viewHolder.message_box.setBackgroundResource(R.drawable.message_bubble_received_warning);
-			} else {
+			if(message.isValidInSession()) {
 				viewHolder.message_box.setBackgroundResource(R.drawable.message_bubble_received);
+			} else {
+				viewHolder.message_box.setBackgroundResource(R.drawable.message_bubble_received_warning);
 			}
 		}