diff options
author | Christian Schneppe <christian@pix-art.de> | 2019-07-01 08:12:58 +0200 |
---|---|---|
committer | Christian Schneppe <christian@pix-art.de> | 2019-07-01 08:12:58 +0200 |
commit | 226d45a136d84ac8a95d25aa0c083c4fc471f1f4 (patch) | |
tree | 33e6c499120575ccda9b9f329bc114fa1c03096c /src/main/java/de/pixart/messenger/services | |
parent | 6d24ce7a1869a20c674771b37f8fc8b65db765ed (diff) |
code cleanup & small fixes
Diffstat (limited to 'src/main/java/de/pixart/messenger/services')
-rw-r--r-- | src/main/java/de/pixart/messenger/services/ImportBackupService.java | 6 | ||||
-rw-r--r-- | src/main/java/de/pixart/messenger/services/XmppConnectionService.java | 21 |
2 files changed, 11 insertions, 16 deletions
diff --git a/src/main/java/de/pixart/messenger/services/ImportBackupService.java b/src/main/java/de/pixart/messenger/services/ImportBackupService.java index 1b28640e5..9a1ddece2 100644 --- a/src/main/java/de/pixart/messenger/services/ImportBackupService.java +++ b/src/main/java/de/pixart/messenger/services/ImportBackupService.java @@ -197,11 +197,7 @@ public class ImportBackupService extends Service { } catch (Exception e) { Throwable throwable = e.getCause(); final boolean reasonWasCrypto; - if (throwable instanceof BadPaddingException) { - reasonWasCrypto = true; - } else { - reasonWasCrypto = false; - } + reasonWasCrypto = throwable instanceof BadPaddingException; synchronized (mOnBackupProcessedListeners) { for (OnBackupProcessed l : mOnBackupProcessedListeners) { if (reasonWasCrypto) { diff --git a/src/main/java/de/pixart/messenger/services/XmppConnectionService.java b/src/main/java/de/pixart/messenger/services/XmppConnectionService.java index 09739530d..bad55aed9 100644 --- a/src/main/java/de/pixart/messenger/services/XmppConnectionService.java +++ b/src/main/java/de/pixart/messenger/services/XmppConnectionService.java @@ -768,7 +768,7 @@ public class XmppConnectionService extends Service { private void deleteWebpreviewCache() { long start = SystemClock.elapsedRealtime(); try { - final String path = getApplicationContext().getCacheDir() + "/" + RICH_LINK_METADATA; + final String path = getApplicationContext().getCacheDir() + File.separator + RICH_LINK_METADATA; final Calendar time = Calendar.getInstance(); time.add(Calendar.DAY_OF_YEAR, -7); final File directory = new File(path); @@ -776,18 +776,17 @@ public class XmppConnectionService extends Service { return; } final File[] files = directory.listFiles(); - if (files == null) { - return; - } - int count = 0; - for (File file : files) { - Date lastModified = new Date(file.lastModified()); - if (lastModified.before(time.getTime())) { - file.delete(); - count++; + if (files != null) { + int count = 0; + for (File file : files) { + Date lastModified = new Date(file.lastModified()); + if (lastModified.before(time.getTime())) { + file.delete(); + count++; + } } + Log.d(Config.LOGTAG, "Deleted " + count + " expired webpreview cache files in " + (SystemClock.elapsedRealtime() - start) + "ms"); } - Log.d(Config.LOGTAG, "Deleted " + count + " expired webpreview cache files in " + (SystemClock.elapsedRealtime() - start) + "ms"); } catch (Exception e) { Log.d(Config.LOGTAG, "Deleted no expired webpreview cache files because of " + e + " in " + (SystemClock.elapsedRealtime() - start) + "ms"); } |