thedevstack/PiratX
2
0
Fork 0
forked from mirror/monocles_chat_clean
Code Issues 10 Pull requests 1 Wiki Activity Actions 1

Differentiate "XmppConnectionService.getKnownHosts" by usage #11

New issue
Open
opened 2025-01-20 08:38:19 +01:00 by tristan · 0 comments
tristan commented 2025-01-20 08:38:19 +01:00
Owner
Copy link

Currently XmppConnectionService.getKnownHosts is used in two use cases:

  • Create new / edit account to show possible JID Domains (EditAccountActivity)
  • Entering a JID in "add to block list", "choose contact" or "start conversation" EnterJidDialog

In the latter the current implementation searching through known hosts in contact list might be appropriate but in the first scenario it's simply bad.

Currently [XmppConnectionService.getKnownHosts](https://git.fucktheforce.de/thedevstack/PiratX/src/branch/master/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java#L5654) is used in two use cases: * Create new / edit account to show possible JID Domains [(EditAccountActivity)]([url](https://git.fucktheforce.de/thedevstack/PiratX/src/branch/master/src/main/java/eu/siacs/conversations/ui/EditAccountActivity.java#L1041)) * Entering a JID in "add to block list", "choose contact" or "start conversation" [EnterJidDialog]([url](https://git.fucktheforce.de/thedevstack/PiratX/src/branch/master/src/main/java/eu/siacs/conversations/ui/EnterJidDialog.java#L334)) In the latter the current implementation searching through known hosts in contact list might be appropriate but in the first scenario it's simply bad.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
No results found.
Labels
Clear labels   
update fork
No labels
update fork
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: thedevstack/PiratX#11
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?