From f1f59e937a3529b6342f1f23c7dda598d379e643 Mon Sep 17 00:00:00 2001 From: plegall Date: Sun, 28 Feb 2010 20:58:45 +0000 Subject: improvement: avoid the use of @ instead of a real test git-svn-id: http://piwigo.org/svn/branches/2.0@5003 68402e56-0260-453c-a942-63ccdbb3a9ee --- admin/cat_list.php | 2 +- admin/element_set.php | 2 +- admin/element_set_global.php | 8 ++++---- admin/picture_modify.php | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) (limited to 'admin') diff --git a/admin/cat_list.php b/admin/cat_list.php index 1aac22f0d..426293e7f 100644 --- a/admin/cat_list.php +++ b/admin/cat_list.php @@ -69,7 +69,7 @@ function save_categories_order($categories) // | initialization | // +-----------------------------------------------------------------------+ -check_input_parameter('parent_id', @$_GET['parent_id'], false, PATTERN_ID); +check_input_parameter('parent_id', $_GET, false, PATTERN_ID); $categories = array(); diff --git a/admin/element_set.php b/admin/element_set.php index bc722887b..d6eec5437 100644 --- a/admin/element_set.php +++ b/admin/element_set.php @@ -39,7 +39,7 @@ include_once(PHPWG_ROOT_PATH.'admin/include/functions.php'); // +-----------------------------------------------------------------------+ check_status(ACCESS_ADMINISTRATOR); -check_input_parameter('selection', @$_POST['selection'], true, PATTERN_ID); +check_input_parameter('selection', $_POST, true, PATTERN_ID); // +-----------------------------------------------------------------------+ // | caddie management | diff --git a/admin/element_set_global.php b/admin/element_set_global.php index 7bc8afe50..4264a0aa5 100644 --- a/admin/element_set_global.php +++ b/admin/element_set_global.php @@ -44,10 +44,10 @@ check_status(ACCESS_ADMINISTRATOR); // +-----------------------------------------------------------------------+ // the $_POST['selection'] was already checked in element_set.php -check_input_parameter('add_tags', @$_POST['add_tags'], true, PATTERN_ID); -check_input_parameter('del_tags', @$_POST['del_tags'], true, PATTERN_ID); -check_input_parameter('associate', @$_POST['associate'], false, PATTERN_ID); -check_input_parameter('dissociate', @$_POST['dissociate'], false, PATTERN_ID); +check_input_parameter('add_tags', $_POST, true, PATTERN_ID); +check_input_parameter('del_tags', $_POST, true, PATTERN_ID); +check_input_parameter('associate', $_POST, false, PATTERN_ID); +check_input_parameter('dissociate', $_POST, false, PATTERN_ID); if (isset($_POST['delete'])) { diff --git a/admin/picture_modify.php b/admin/picture_modify.php index 71b0d7777..60aabc7bf 100644 --- a/admin/picture_modify.php +++ b/admin/picture_modify.php @@ -33,8 +33,8 @@ include_once(PHPWG_ROOT_PATH.'admin/include/functions.php'); // +-----------------------------------------------------------------------+ check_status(ACCESS_ADMINISTRATOR); -check_input_parameter('image_id', $_GET['image_id'], false, PATTERN_ID); -check_input_parameter('cat_id', @$_GET['cat_id'], false, PATTERN_ID); +check_input_parameter('image_id', $_GET, false, PATTERN_ID); +check_input_parameter('cat_id', $_GET, false, PATTERN_ID); // +-----------------------------------------------------------------------+ // | synchronize metadata | -- cgit v1.2.3