From 4002f708e1b701a800b3d6968d12ab9a49c2d071 Mon Sep 17 00:00:00 2001
From: rvelices
Date: Thu, 4 Sep 2008 00:57:55 +0000
Subject: - remove hello_world plugin (not working anymore) - web service
method images.add works only for admins now - fix template-common js web
service calls did not have the parameters url encoded - improve admin
user_list - submitting the form with no user selected triggers a javascript
alert (had fun with jquery selectors)
git-svn-id: http://piwigo.org/svn/trunk@2496 68402e56-0260-453c-a942-63ccdbb3a9ee
---
admin/template/yoga/admin/user_list.tpl | 15 +++++++++
include/ws_functions.inc.php | 20 +++++++-----
plugins/hello_world/index.php | 30 ------------------
plugins/hello_world/main.inc.php | 56 ---------------------------------
template-common/scripts.js | 7 ++---
5 files changed, 30 insertions(+), 98 deletions(-)
delete mode 100644 plugins/hello_world/index.php
delete mode 100644 plugins/hello_world/main.inc.php
diff --git a/admin/template/yoga/admin/user_list.tpl b/admin/template/yoga/admin/user_list.tpl
index 602576ef9..5ad163be8 100644
--- a/admin/template/yoga/admin/user_list.tpl
+++ b/admin/template/yoga/admin/user_list.tpl
@@ -307,3 +307,18 @@
+
+
+
\ No newline at end of file
diff --git a/include/ws_functions.inc.php b/include/ws_functions.inc.php
index 015f3d391..116db6687 100644
--- a/include/ws_functions.inc.php
+++ b/include/ws_functions.inc.php
@@ -918,14 +918,18 @@ UPDATE '.IMAGES_TABLE.'
function ws_images_add($params, &$service)
{
global $conf;
-
+ if (!is_admin() || is_adviser() )
+ {
+ return new PwgError(401, 'Access denied');
+ }
+
// name
// category_id
// file_content
// file_sum
// thumbnail_content
// thumbnail_sum
-
+
// $fh_log = fopen('/tmp/php.log', 'w');
// fwrite($fh_log, time()."\n");
// fwrite($fh_log, 'input: '.$params['file_sum']."\n");
@@ -934,7 +938,7 @@ function ws_images_add($params, &$service)
// current date
list($dbnow) = mysql_fetch_row(pwg_query('SELECT NOW();'));
list($year, $month, $day) = preg_split('/[^\d]/', $dbnow, 4);
-
+
$upload_dir = sprintf(
PHPWG_ROOT_PATH.'upload/%s/%s/%s',
$year,
@@ -942,8 +946,8 @@ function ws_images_add($params, &$service)
$day
);
- fwrite($fh_log, $upload_dir."\n");
-
+ //fwrite($fh_log, $upload_dir."\n");
+
if (!is_dir($upload_dir)) {
umask(0000);
$recursive = true;
@@ -954,7 +958,7 @@ function ws_images_add($params, &$service)
$random_string = substr($params['file_sum'], 0, 8);
$filename_wo_ext = $date_string.'-'.$random_string;
-
+
$file_path = $upload_dir.'/'.$filename_wo_ext.'.jpg';
$fh_file = fopen($file_path, 'w');
fwrite($fh_file, base64_decode($params['file_content']));
@@ -967,7 +971,7 @@ function ws_images_add($params, &$service)
umask(0000);
mkdir($thumbnail_dir, 0777);
}
-
+
$thumbnail_path = sprintf(
'%s/%s%s.%s',
$thumbnail_dir,
@@ -1011,7 +1015,7 @@ function ws_images_add($params, &$service)
array_keys($insert),
array($insert)
);
-
+
// fclose($fh_log);
}
diff --git a/plugins/hello_world/index.php b/plugins/hello_world/index.php
deleted file mode 100644
index c15b15795..000000000
--- a/plugins/hello_world/index.php
+++ /dev/null
@@ -1,30 +0,0 @@
-
diff --git a/plugins/hello_world/main.inc.php b/plugins/hello_world/main.inc.php
deleted file mode 100644
index 07808d0d9..000000000
--- a/plugins/hello_world/main.inc.php
+++ /dev/null
@@ -1,56 +0,0 @@
-assign( 'PAGE_BANNER',
- '"'.$page['page_banner'].'" from Piwigo plugin!
');
-}
-
-?>
\ No newline at end of file
diff --git a/template-common/scripts.js b/template-common/scripts.js
index e7fa7e9b5..4e5ef822f 100644
--- a/template-common/scripts.js
+++ b/template-common/scripts.js
@@ -120,10 +120,10 @@ PwgWS.prototype = {
if ( typeof parameters[property] == 'object' && parameters[property])
{
for (var i=0; i