remove all array_push (50% slower than []) + some changes missing for feature:2978

git-svn-id: http://piwigo.org/svn/trunk@25018 68402e56-0260-453c-a942-63ccdbb3a9ee

1 files changed, 9 insertions, 12 deletions

diff --git a/admin/themes_new.php b/admin/themes_new.php
index 13252f629..528b5ec93 100644
--- a/admin/themes_new.php
+++ b/admin/themes_new.php
@@ -50,7 +50,7 @@ if (isset($_GET['revision']) and isset($_GET['extension']))
 {
   if (!is_webmaster())
   {
-    array_push($page['errors'], l10n('Webmaster status is required.'));
+    $page['errors'][] = l10n('Webmaster status is required.');
   }
   else
   {
@@ -75,28 +75,25 @@ if (isset($_GET['installstatus']))
   switch ($_GET['installstatus'])
   {
     case 'ok':
-      array_push(
-        $page['infos'],
-        l10n('Theme has been successfully installed')
-        );
+      $page['infos'][] = l10n('Theme has been successfully installed');
       break;
 
     case 'temp_path_error':
-      array_push($page['errors'], l10n('Can\'t create temporary file.'));
+      $page['errors'][] = l10n('Can\'t create temporary file.');
       break;
 
     case 'dl_archive_error':
-      array_push($page['errors'], l10n('Can\'t download archive.'));
+      $page['errors'][] = l10n('Can\'t download archive.');
       break;
 
     case 'archive_error':
-      array_push($page['errors'], l10n('Can\'t read or extract archive.'));
+      $page['errors'][] = l10n('Can\'t read or extract archive.');
       break;
 
     default:
-      array_push(
-        $page['errors'],
-        l10n('An error occured during extraction (%s).', htmlspecialchars($_GET['installstatus']))
+      $page['errors'][] = l10n(
+        'An error occured during extraction (%s).',
+        htmlspecialchars($_GET['installstatus'])
         );
   }  
 }
@@ -130,7 +127,7 @@ if ($themes->get_server_themes(true)) // only new themes
 }
 else
 {
-  array_push($page['errors'], l10n('Can\'t connect to server.'));
+  $page['errors'][] = l10n('Can\'t connect to server.');
 }
 
 $template->assign('default_screenshot',