remove all array_push (50% slower than []) + some changes missing for feature:2978

git-svn-id: http://piwigo.org/svn/trunk@25018 68402e56-0260-453c-a942-63ccdbb3a9ee

1 files changed, 7 insertions, 13 deletions

diff --git a/admin/include/photos_add_direct_prepare.inc.php b/admin/include/photos_add_direct_prepare.inc.php
index 4f5f61187..fb5331a47 100644
--- a/admin/include/photos_add_direct_prepare.inc.php
+++ b/admin/include/photos_add_direct_prepare.inc.php
@@ -209,12 +209,12 @@ $setup_errors = array();
 $error_message = ready_for_upload_message();
 if (!empty($error_message))
 {
-  array_push($setup_errors, $error_message);
+  $setup_errors[] = $error_message;
 }
 
 if (!function_exists('gd_info'))
 {
-  array_push($setup_errors, l10n('GD library is missing'));
+  $setup_errors[] = l10n('GD library is missing');
 }
 
 $template->assign(
@@ -235,21 +235,15 @@ if (!isset($_SESSION['upload_hide_warnings']))
   
   if ($conf['use_exif'] and !function_exists('read_exif_data'))
   {
-    array_push(
-      $setup_warnings,
-      l10n('Exif extension not available, admin should disable exif use')
-      );
+    $setup_warnings[] = l10n('Exif extension not available, admin should disable exif use');
   }
 
   if (get_ini_size('upload_max_filesize') > get_ini_size('post_max_size'))
   {
-    array_push(
-      $setup_warnings,
-      sprintf(
-        l10n('In your php.ini file, the upload_max_filesize (%sB) is bigger than post_max_size (%sB), you should change this setting'),
-        get_ini_size('upload_max_filesize', false),
-        get_ini_size('post_max_size', false)
-        )
+    $setup_warnings[] = l10n(
+      'In your php.ini file, the upload_max_filesize (%sB) is bigger than post_max_size (%sB), you should change this setting',
+      get_ini_size('upload_max_filesize', false),
+      get_ini_size('post_max_size', false)
       );
   }
   $template->assign(