aboutsummaryrefslogtreecommitdiffstats
path: root/admin/configuration.php
diff options
context:
space:
mode:
authormistic100 <mistic@piwigo.org>2012-06-22 21:42:52 +0000
committermistic100 <mistic@piwigo.org>2012-06-22 21:42:52 +0000
commit86358b6c878e22f78e465b58e6bbadbb24bd674d (patch)
tree44a6725622017ca623a9925be6e195cc70826bb5 /admin/configuration.php
parent015e2f5ac87ac5cc4674997252c39058f6374829 (diff)
merge r15950 from trunk
bug 2659: Possible misconfiguration of ORDER BY + missing language string git-svn-id: http://piwigo.org/svn/branches/2.4@15951 68402e56-0260-453c-a942-63ccdbb3a9ee
Diffstat (limited to '')
-rw-r--r--admin/configuration.php42
1 files changed, 28 insertions, 14 deletions
diff --git a/admin/configuration.php b/admin/configuration.php
index 60da0ae0e..21e5c2b4d 100644
--- a/admin/configuration.php
+++ b/admin/configuration.php
@@ -145,25 +145,39 @@ if (isset($_POST['submit']))
if ( !isset($conf['order_by_custom']) and !isset($conf['order_by_inside_category_custom']) )
{
if ( !empty($_POST['order_by']) )
- {
- // limit to the number of available parameters
- $order_by = $order_by_inside_category = array_slice($_POST['order_by'], 0, ceil(count($sort_fields)/2));
-
- // there is no rank outside categories
- unset($order_by[ array_search('rank ASC', $order_by) ]);
-
- // must define a default order_by if user want to order by rank only
- if ( count($order_by) == 0 )
+ {
+ foreach ($_POST['order_by'] as $i => $val)
+ {
+ if (empty($val)) unset($_POST['order_by'][$i]);
+ }
+ if ( !count($_POST['order_by']) )
+ {
+ array_push($page['errors'], l10n('No order field selected'));
+ }
+ else
{
- $order_by = array('id ASC');
+ // limit to the number of available parameters
+ $order_by = $order_by_inside_category = array_slice($_POST['order_by'], 0, ceil(count($sort_fields)/2));
+
+ // there is no rank outside categories
+ if ( ($i = array_search('rank ASC', $order_by)) !== false)
+ {
+ unset($order_by[$i]);
+ }
+
+ // must define a default order_by if user want to order by rank only
+ if ( count($order_by) == 0 )
+ {
+ $order_by = array('id ASC');
+ }
+
+ $_POST['order_by'] = 'ORDER BY '.implode(', ', $order_by);
+ $_POST['order_by_inside_category'] = 'ORDER BY '.implode(', ', $order_by_inside_category);
}
-
- $_POST['order_by'] = 'ORDER BY '.implode(', ', $order_by);
- $_POST['order_by_inside_category'] = 'ORDER BY '.implode(', ', $order_by_inside_category);
}
else
{
- array_push($page['errors'], l10n('No field selected'));
+ array_push($page['errors'], l10n('No order field selected'));
}
}