- security : add some control to download url. Somebody sould take it over for other controls

git-svn-id: http://piwigo.org/svn/trunk@1187 68402e56-0260-453c-a942-63ccdbb3a9ee

1 files changed, 5 insertions, 2 deletions

diff --git a/action.php b/action.php
index ef635a4d1..c20b07d3a 100644
--- a/action.php
+++ b/action.php
@@ -65,8 +65,11 @@ function force_download ($filename)
 //--------------------------------------------------------- download big picture
 if ( isset( $_GET['dwn'] ) )
 {
-//TODO : verify the path begins with './gallerie' and doesn't contains any '..'
-// in order to avoid hacking atempts
+//TODO : verify the path begins with something in galleries_url and that user has access rights to the picture
+// in order to avoid hacking atempts by forged url
+  if (preg_match('/\.\./',$_GET['dwn'])) {
+    die('Hacking attempt!');
+  }
   force_download($_GET['dwn']);
 }