mirror/monocles_chat_clean
1
0
Fork 1
Code Activity

disable 'leave before join'

Browse source 
leaving a MUC before joining it was a work around for servers that did not treat a
<x/> join as a full join and didn’t send the full user list if they thought the user was
still in the room.
this happens if Conversations restarts after an inproper disconnect. The MUC will think
the user is still in the room.

however nowadays most modern servers will treat <x/> joins as full joins. on the user hand
leave before join would trigger flood prevention on ejabberds and race the first message
with the actual join (making the message arrive before the user is considered in the room)

(cherry picked from commit 7fb617e39a97c62cf8df2e16f3bc10546ce0c742)
This commit is contained in:
Daniel Gultsch 2020-09-02 10:14:00 +02:00 • committed by Christian Schneppe
parent cba3fc75f0
commit 8bb68ff128
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/main/java/eu/siacs/conversations/Config.java
View file

@ -136,7 +136,7 @@ public final class Config {
public static final boolean ONLY_INTERNAL_STORAGE = false; //use internal storage instead of sdcard to save attachments
public static final boolean IGNORE_ID_REWRITE_IN_MUC = true;
public static final boolean MUC_LEAVE_BEFORE_JOIN = true;
public static final boolean MUC_LEAVE_BEFORE_JOIN = false;
public static final boolean USE_LMC_VERSION_1_1 = true;