mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
97fcafb9ec
write_record() when performing REPLACE has an optimization: - if the unique violation happened in the last unique key, then do UPDATE - otherwise, do DELETE+INSERT This patch changes the way of detecting if this optimization can be applied if the table has long (hash based) unique (i.e. UNIQUE..USING HASH) constraints. Problem: The old condition did not take into account that TABLE_SHARE and TABLE see long uniques differently: - TABLE_SHARE sees as HA_KEY_ALG_LONG_HASH and HA_NOSAME - TABLE sees as usual non-unique indexes So the old condition could erroneously decide that the UPDATE optimization is possible when there are still some unique hash constraints in the table. Fix: - If the current key is a long unique, it now works as follows: UPDATE can be done if the current long unique is the last long unique, and there are no in-engine (normal) uniques. - For in-engine uniques nothing changes, it still works as before: If the current key is an in-engine (normal) unique: UPDATE can be done if it is the last normal unique.
68 lines
1.8 KiB
Text
68 lines
1.8 KiB
Text
if (`SELECT $SP_PROTOCOL > 0`)
|
|
{
|
|
--skip Test requires: sp-protocol disabled
|
|
}
|
|
|
|
|
|
--echo #
|
|
--echo # Start of 10.5 tests
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # MDEV-32837 long unique does not work like unique key when using replace
|
|
--echo #
|
|
|
|
# This test produces different Handler commands in the SHOW STATUS output
|
|
# with --sp-protocol. So it's here, in this *.test file with --sp-protocol disabled.
|
|
|
|
--echo #
|
|
--echo # Normal unique key + long unique key
|
|
--echo #
|
|
|
|
CREATE TABLE t1 (a INT PRIMARY KEY, b INT, c INT, UNIQUE KEY `test` (b,c) USING HASH) ENGINE=MyISAM;
|
|
INSERT INTO t1 VALUES (1,1,1),(2,2,2);
|
|
FLUSH STATUS;
|
|
REPLACE INTO t1 VALUES (3,1,1);
|
|
SHOW STATUS WHERE Variable_name LIKE 'handler%' AND Value>0;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
FLUSH STATUS;
|
|
REPLACE INTO t1 VALUES (3,2,2);
|
|
SHOW STATUS WHERE Variable_name LIKE 'handler%' AND Value>0;
|
|
SELECT * FROM t1;
|
|
DROP TABLE t1;
|
|
|
|
--echo #
|
|
--echo # Two long unique keys
|
|
--echo #
|
|
|
|
CREATE TABLE t1 (a INT, b INT, c INT, UNIQUE KEY a (a) USING HASH,UNIQUE KEY `test` (b,c) USING HASH) ENGINE=MyISAM;
|
|
INSERT INTO t1 VALUES (1,1,1),(2,2,2);
|
|
FLUSH STATUS;
|
|
REPLACE INTO t1 VALUES (3,1,1);
|
|
SHOW STATUS WHERE Variable_name LIKE 'handler%' AND Value>0;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
FLUSH STATUS;
|
|
REPLACE INTO t1 VALUES (3,2,2);
|
|
SHOW STATUS WHERE Variable_name LIKE 'handler%' AND Value>0;
|
|
SELECT * FROM t1;
|
|
DROP TABLE t1;
|
|
|
|
--echo #
|
|
--echo # One long unique key
|
|
--echo #
|
|
|
|
CREATE TABLE t1 (a INT, b INT, c INT, UNIQUE KEY `test` (b,c) USING HASH) ENGINE=MyISAM;
|
|
INSERT INTO t1 VALUES (1,1,1),(2,2,2);
|
|
FLUSH STATUS;
|
|
REPLACE INTO t1 VALUES (3,1,1);
|
|
SHOW STATUS WHERE Variable_name LIKE 'handler%' AND Value>0;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
FLUSH STATUS;
|
|
REPLACE INTO t1 VALUES (3,2,2);
|
|
SHOW STATUS WHERE Variable_name LIKE 'handler%' AND Value>0;
|
|
SELECT * FROM t1;
|
|
DROP TABLE t1;
|
|
|
|
--echo #
|
|
--echo # End of 10.5 tests
|
|
--echo #
|