mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 05:52:27 +01:00
fc34cd1c21
A failed REVOKE statement is logged with error=0, thus causing the slave to stop. The slave should not stop as this was an expected error. Given that the execution failed on the master as well the error code should be logged so that the slave can replay the statement, get an error and compare with the master's execution outcome. If errors match, then slave can proceed with replication, as the error it got, when replaying the statement, was expected. In this particular case, the bug surfaces because the error code is pushed to the THD diagnostics area after writing the event to the binary log. Therefore, it would be logged with the THD diagnostics area clean, hence its error code would not contain the correct code. We fix this by moving the error reporting ahead of the call to the routine that writes the event to the binary log.
348 lines
10 KiB
Text
348 lines
10 KiB
Text
# Works in statement-based and row-based binlogging.
|
|
# Test that GRANT and other user management commands are replicated to the slave
|
|
|
|
-- source include/master-slave.inc
|
|
|
|
# do not be influenced by other tests.
|
|
connection master;
|
|
delete from mysql.user where user=_binary'rpl_do_grant';
|
|
delete from mysql.db where user=_binary'rpl_do_grant';
|
|
flush privileges;
|
|
save_master_pos;
|
|
connection slave;
|
|
sync_with_master;
|
|
# if these DELETE did nothing on the master, we need to do them manually on the
|
|
# slave.
|
|
delete from mysql.user where user=_binary'rpl_ignore_grant';
|
|
delete from mysql.db where user=_binary'rpl_ignore_grant';
|
|
flush privileges;
|
|
|
|
# test replication of GRANT
|
|
connection master;
|
|
grant select on *.* to rpl_do_grant@localhost;
|
|
grant drop on test.* to rpl_do_grant@localhost;
|
|
save_master_pos;
|
|
connection slave;
|
|
sync_with_master;
|
|
show grants for rpl_do_grant@localhost;
|
|
|
|
# test replication of SET PASSWORD
|
|
connection master;
|
|
set password for rpl_do_grant@localhost=password("does it work?");
|
|
save_master_pos;
|
|
connection slave;
|
|
sync_with_master;
|
|
select password<>_binary'' from mysql.user where user=_binary'rpl_do_grant';
|
|
|
|
#
|
|
# Bug#24158 SET PASSWORD in binary log fails under ANSI_QUOTES
|
|
#
|
|
connection master;
|
|
update mysql.user set password='' where user='rpl_do_grant';
|
|
flush privileges;
|
|
select password<>'' from mysql.user where user='rpl_do_grant';
|
|
set sql_mode='ANSI_QUOTES';
|
|
set password for rpl_do_grant@localhost=password('does it work?');
|
|
set sql_mode='';
|
|
save_master_pos;
|
|
connection slave;
|
|
sync_with_master;
|
|
select password<>'' from mysql.user where user='rpl_do_grant';
|
|
|
|
|
|
# clear what we have done, to not influence other tests.
|
|
connection master;
|
|
delete from mysql.user where user=_binary'rpl_do_grant';
|
|
delete from mysql.db where user=_binary'rpl_do_grant';
|
|
flush privileges;
|
|
sync_slave_with_master;
|
|
# The mysql database is not replicated, so we have to do the deletes
|
|
# manually on the slave as well.
|
|
delete from mysql.user where user=_binary'rpl_do_grant';
|
|
delete from mysql.db where user=_binary'rpl_do_grant';
|
|
flush privileges;
|
|
|
|
# End of 4.1 tests
|
|
|
|
connection master;
|
|
--error 1141
|
|
show grants for rpl_do_grant@localhost;
|
|
connection slave;
|
|
--error 1141
|
|
show grants for rpl_do_grant@localhost;
|
|
|
|
connection master;
|
|
create user rpl_do_grant@localhost;
|
|
show grants for rpl_do_grant@localhost;
|
|
--error 1141
|
|
show grants for rpl_do_grant2@localhost;
|
|
sync_slave_with_master;
|
|
show grants for rpl_do_grant@localhost;
|
|
--error 1141
|
|
show grants for rpl_do_grant2@localhost;
|
|
|
|
connection master;
|
|
rename user rpl_do_grant@localhost to rpl_do_grant2@localhost;
|
|
show grants for rpl_do_grant2@localhost;
|
|
sync_slave_with_master;
|
|
show grants for rpl_do_grant2@localhost;
|
|
|
|
connection master;
|
|
grant DELETE,INSERT on mysqltest1.* to rpl_do_grant2@localhost;
|
|
show grants for rpl_do_grant2@localhost;
|
|
sync_slave_with_master;
|
|
show grants for rpl_do_grant2@localhost;
|
|
|
|
connection master;
|
|
revoke DELETE on mysqltest1.* from rpl_do_grant2@localhost;
|
|
show grants for rpl_do_grant2@localhost;
|
|
sync_slave_with_master;
|
|
show grants for rpl_do_grant2@localhost;
|
|
|
|
connection master;
|
|
revoke all privileges, grant option from rpl_do_grant2@localhost;
|
|
show grants for rpl_do_grant2@localhost;
|
|
sync_slave_with_master;
|
|
show grants for rpl_do_grant2@localhost;
|
|
|
|
connection master;
|
|
drop user rpl_do_grant2@localhost;
|
|
--error 1141
|
|
show grants for rpl_do_grant2@localhost;
|
|
sync_slave_with_master;
|
|
--error 1141
|
|
show grants for rpl_do_grant2@localhost;
|
|
|
|
#####################################################
|
|
# Purpose
|
|
# Test whether mysql.procs_priv get replicated
|
|
# Related bugs:
|
|
# BUG42217 mysql.procs_priv does not get replicated
|
|
#####################################################
|
|
connection master;
|
|
|
|
--disable_warnings
|
|
DROP DATABASE IF EXISTS bug42217_db;
|
|
--enable_warnings
|
|
CREATE DATABASE bug42217_db;
|
|
|
|
GRANT CREATE ROUTINE ON bug42217_db.* TO 'create_rout_db'@'localhost'
|
|
IDENTIFIED BY 'create_rout_db' WITH GRANT OPTION;
|
|
|
|
-- sync_slave_with_master
|
|
-- connection master
|
|
|
|
connect (create_rout_db_master, localhost, create_rout_db, create_rout_db, bug42217_db,$MASTER_MYPORT,);
|
|
connect (create_rout_db_slave, localhost, create_rout_db, create_rout_db, bug42217_db, $SLAVE_MYPORT,);
|
|
|
|
connection create_rout_db_master;
|
|
|
|
|
|
USE bug42217_db;
|
|
|
|
DELIMITER //;
|
|
CREATE FUNCTION upgrade_del_func() RETURNS CHAR(30)
|
|
BEGIN
|
|
RETURN "INSIDE upgrade_del_func()";
|
|
END//
|
|
|
|
DELIMITER ;//
|
|
|
|
connection master;
|
|
|
|
USE bug42217_db;
|
|
--replace_column 8 #
|
|
SELECT * FROM mysql.procs_priv;
|
|
SELECT upgrade_del_func();
|
|
|
|
sync_slave_with_master;
|
|
--replace_column 8 #
|
|
SELECT * FROM mysql.procs_priv;
|
|
SHOW GRANTS FOR 'create_rout_db'@'localhost';
|
|
|
|
USE bug42217_db;
|
|
SHOW CREATE FUNCTION upgrade_del_func;
|
|
SELECT upgrade_del_func();
|
|
|
|
--echo "Check whether the definer user will be able to execute the replicated routine on slave"
|
|
connection create_rout_db_slave;
|
|
USE bug42217_db;
|
|
SHOW CREATE FUNCTION upgrade_del_func;
|
|
SELECT upgrade_del_func();
|
|
|
|
connection slave;
|
|
DELETE FROM mysql.procs_priv;
|
|
FLUSH PRIVILEGES;
|
|
USE bug42217_db;
|
|
--echo "Can't execute the replicated routine on slave like before after procs privilege is deleted "
|
|
--error 1370
|
|
SELECT upgrade_del_func();
|
|
|
|
--echo "Test the user who creates a function on master doesn't exist on slave."
|
|
--echo "Hence SQL thread ACL_GLOBAL privilege jumps in and no mysql.procs_priv is inserted"
|
|
DROP USER 'create_rout_db'@'localhost';
|
|
|
|
connection create_rout_db_master;
|
|
DELIMITER //;
|
|
CREATE FUNCTION upgrade_alter_func() RETURNS CHAR(30)
|
|
BEGIN
|
|
RETURN "INSIDE upgrade_alter_func()";
|
|
END//
|
|
DELIMITER ;//
|
|
|
|
connection master;
|
|
SELECT upgrade_alter_func();
|
|
|
|
sync_slave_with_master;
|
|
SHOW CREATE FUNCTION upgrade_alter_func;
|
|
--echo "Should no privilege record for upgrade_alter_func in mysql.procs_priv"
|
|
--replace_column 8 #
|
|
SELECT * FROM mysql.procs_priv;
|
|
--error 1449
|
|
SELECT upgrade_alter_func();
|
|
|
|
###### CLEAN UP SECTION ##############
|
|
disconnect create_rout_db_master;
|
|
disconnect create_rout_db_slave;
|
|
connection master;
|
|
USE bug42217_db;
|
|
DROP FUNCTION upgrade_del_func;
|
|
DROP FUNCTION upgrade_alter_func;
|
|
DROP DATABASE bug42217_db;
|
|
DROP USER 'create_rout_db'@'localhost';
|
|
|
|
call mtr.add_suppression("Slave: Operation DROP USER failed for 'create_rout_db'@'localhost' Error_code: 1396");
|
|
connection slave;
|
|
USE mtr;
|
|
call mtr.add_suppression("Slave: Operation DROP USER failed for 'create_rout_db'@'localhost' Error_code: 1396");
|
|
|
|
# BUG#49119: Master crashes when executing 'REVOKE ... ON
|
|
# {PROCEDURE|FUNCTION} FROM ...'
|
|
#
|
|
# The tests are divided into two test cases:
|
|
#
|
|
# i) a test case that mimics the one in the bug report.
|
|
#
|
|
# - We show that, despite the fact, that a revoke command fails
|
|
# when binlogging is active, the master will not hit an
|
|
# assertion.
|
|
#
|
|
# ii) a test case that partially succeeds on the master will also
|
|
# partially succeed on the slave.
|
|
#
|
|
# - The revoke statement that partially succeeds tries to revoke
|
|
# an EXECUTE grant for two users, and only one of the user has
|
|
# the specific grant. This will cause mysql to drop one of the
|
|
# grants and report error for the statement. The slave should
|
|
# also drop the grants that the master succeed and the SQL
|
|
# thread should not stop on statement failure.
|
|
|
|
-- echo ######## BUG#49119 #######
|
|
-- echo ### i) test case from the 'how to repeat section'
|
|
-- source include/master-slave-reset.inc
|
|
-- connection master
|
|
|
|
CREATE TABLE t1(c1 INT);
|
|
DELIMITER |;
|
|
CREATE PROCEDURE p1() SELECT * FROM t1 |
|
|
DELIMITER ;|
|
|
-- error ER_NONEXISTING_PROC_GRANT
|
|
REVOKE EXECUTE ON PROCEDURE p1 FROM 'root'@'localhost';
|
|
|
|
-- sync_slave_with_master
|
|
|
|
-- connection master
|
|
DROP TABLE t1;
|
|
DROP PROCEDURE p1;
|
|
|
|
-- sync_slave_with_master
|
|
|
|
-- echo ### ii) Test case in which REVOKE partially succeeds
|
|
|
|
-- connection master
|
|
-- source include/master-slave-reset.inc
|
|
-- connection master
|
|
|
|
CREATE TABLE t1(c1 INT);
|
|
DELIMITER |;
|
|
CREATE PROCEDURE p1() SELECT * FROM t1 |
|
|
DELIMITER ;|
|
|
|
|
CREATE USER 'user49119'@'localhost';
|
|
GRANT EXECUTE ON PROCEDURE p1 TO 'user49119'@'localhost';
|
|
|
|
-- echo ##############################################################
|
|
-- echo ### Showing grants for both users: root and user49119 (master)
|
|
SHOW GRANTS FOR 'user49119'@'localhost';
|
|
SHOW GRANTS FOR CURRENT_USER;
|
|
-- echo ##############################################################
|
|
|
|
-- sync_slave_with_master
|
|
|
|
-- echo ##############################################################
|
|
-- echo ### Showing grants for both users: root and user49119 (master)
|
|
SHOW GRANTS FOR 'user49119'@'localhost';
|
|
SHOW GRANTS FOR CURRENT_USER;
|
|
-- echo ##############################################################
|
|
|
|
-- connection master
|
|
|
|
-- echo ## This statement will make the revoke fail because root has no
|
|
-- echo ## execute grant. However, it will still revoke the grant for
|
|
-- echo ## user49119.
|
|
-- error ER_NONEXISTING_PROC_GRANT
|
|
REVOKE EXECUTE ON PROCEDURE p1 FROM 'user49119'@'localhost', 'root'@'localhost';
|
|
|
|
-- echo ##############################################################
|
|
-- echo ### Showing grants for both users: root and user49119 (master)
|
|
-- echo ### after revoke statement failure
|
|
SHOW GRANTS FOR 'user49119'@'localhost';
|
|
SHOW GRANTS FOR CURRENT_USER;
|
|
-- echo ##############################################################
|
|
|
|
-- sync_slave_with_master
|
|
|
|
-- echo #############################################################
|
|
-- echo ### Showing grants for both users: root and user49119 (slave)
|
|
-- echo ### after revoke statement failure (should match
|
|
SHOW GRANTS FOR 'user49119'@'localhost';
|
|
SHOW GRANTS FOR CURRENT_USER;
|
|
-- echo ##############################################################
|
|
|
|
-- connection master
|
|
DROP TABLE t1;
|
|
DROP PROCEDURE p1;
|
|
DROP USER 'user49119'@'localhost';
|
|
|
|
-- sync_slave_with_master
|
|
|
|
#
|
|
# Bug #51987 revoke privileges logs wrong error code
|
|
#
|
|
|
|
-- connection master
|
|
-- source include/master-slave-reset.inc
|
|
-- connection master
|
|
|
|
grant all on *.* to foo@"1.2.3.4";
|
|
-- error ER_REVOKE_GRANTS
|
|
revoke all privileges, grant option from "foo";
|
|
|
|
## assertion: revoke is logged
|
|
-- source include/show_binlog_events.inc
|
|
|
|
-- sync_slave_with_master
|
|
|
|
## assertion: slave replicates revoke and does not fail because master
|
|
## logged revoke with correct expected error code
|
|
-- let $err= query_get_value(SHOW SLAVE STATUS, Last_SQL_Errno, 1)
|
|
if ($err)
|
|
{
|
|
-- die UNEXPECTED ERROR AT SLAVE: $err
|
|
}
|
|
|
|
-- connection master
|
|
DROP USER foo@"1.2.3.4";
|
|
-- sync_slave_with_master
|
|
|
|
--echo "End of test"
|