mirror of
https://github.com/MariaDB/server.git
synced 2025-02-01 03:21:53 +01:00
9ba731c299
transaction BUG#52616 Temp table prevents switch binlog format from STATEMENT to ROW Before the WL#2687 and BUG#46364, every non-transactional change that happened after a transactional change was written to trx-cache and flushed upon committing the transaction. WL#2687 and BUG#46364 changed this behavior and non-transactional changes are now written to the binary log upon committing the statement. A binary log event is identified as transactional or non-transactional through a flag in the Log_event which is set taking into account the underlie storage engine on what it is stems from. In the current bug, this flag was not being set properly when the DROP TEMPORARY TABLE was executed. However, while fixing this bug we figured out that changes to temporary tables should be always written to the trx-cache if there is an on-going transaction. Otherwise, binlog events in the reversed order would be produced. Regarding concurrency, keeping changes to temporary tables in the trx-cache is also safe as temporary tables are only visible to the owner connection. In this patch, we classify the following statements as unsafe: 1 - INSERT INTO t_myisam SELECT * FROM t_myisam_temp 2 - INSERT INTO t_myisam_temp SELECT * FROM t_myisam 3 - CREATE TEMPORARY TABLE t_myisam_temp SELECT * FROM t_myisam On the other hand, the following statements are classified as safe: 1 - INSERT INTO t_innodb SELECT * FROM t_myisam_temp 2 - INSERT INTO t_myisam_temp SELECT * FROM t_innodb The patch also guarantees that transactions that have a DROP TEMPORARY are always written to the binary log regardless of the mode and the outcome: commit or rollback. In particular, the DROP TEMPORARY is extended with the IF EXISTS clause when the current statement logging format is set to row. Finally, the patch allows to switch from STATEMENT to MIXED/ROW when there are temporary tables but the contrary is not possible.
39 lines
1.3 KiB
Text
39 lines
1.3 KiB
Text
# Testcase for BUG#4551
|
|
# The bug was that when the table was TEMPORARY, it was not deleted if
|
|
# the CREATE SELECT failed (the code intended too, but it actually
|
|
# didn't). And as the CREATE TEMPORARY TABLE was not written to the
|
|
# binlog if it was a transactional table, it resulted in an
|
|
# inconsistency between binlog and the internal list of temp tables.
|
|
|
|
# This does not work for RBR yet.
|
|
--source include/have_binlog_format_mixed_or_statement.inc
|
|
|
|
--disable_query_log
|
|
CALL mtr.add_suppression("Unsafe statement binlogged in statement format since BINLOG_FORMAT = STATEMENT");
|
|
--enable_query_log
|
|
|
|
-- source include/have_innodb.inc
|
|
--disable_warnings
|
|
drop table if exists t1, t2;
|
|
--enable_warnings
|
|
CREATE TABLE t1 ( a int );
|
|
INSERT INTO t1 VALUES (1),(2),(1);
|
|
--error ER_DUP_ENTRY
|
|
CREATE TABLE t2 ( PRIMARY KEY (a) ) ENGINE=INNODB SELECT a FROM t1;
|
|
--error 1146
|
|
select * from t2;
|
|
--error ER_DUP_ENTRY
|
|
CREATE TEMPORARY TABLE t2 ( PRIMARY KEY (a) ) ENGINE=INNODB SELECT a FROM t1;
|
|
--error 1146
|
|
select * from t2;
|
|
--error ER_DUP_ENTRY
|
|
CREATE TABLE t2 ( PRIMARY KEY (a) ) ENGINE=MYISAM SELECT a FROM t1;
|
|
--error 1146
|
|
select * from t2;
|
|
--error ER_DUP_ENTRY
|
|
CREATE TEMPORARY TABLE t2 ( PRIMARY KEY (a) ) ENGINE=MYISAM SELECT a FROM t1;
|
|
--error 1146
|
|
select * from t2;
|
|
drop table t1;
|
|
|
|
# End of 4.1 tests
|