mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 10:31:54 +01:00
3cef4f8f0f
We implement an idea that was suggested by Michael 'Monty' Widenius in October 2017: When InnoDB is inserting into an empty table or partition, we can write a single undo log record TRX_UNDO_EMPTY, which will cause ROLLBACK to clear the table. For this to work, the insert into an empty table or partition must be covered by an exclusive table lock that will be held until the transaction has been committed or rolled back, or the INSERT operation has been rolled back (and the table is empty again), in lock_table_x_unlock(). Clustered index records that are covered by the TRX_UNDO_EMPTY record will carry DB_TRX_ID=0 and DB_ROLL_PTR=1<<55, and thus they cannot be distinguished from what MDEV-12288 leaves behind after purging the history of row-logged operations. Concurrent non-locking reads must be adjusted: If the read view was created before the INSERT into an empty table, then we must continue to imagine that the table is empty, and not try to read any records. If the read view was created after the INSERT was committed, then all records must be visible normally. To implement this, we introduce the field dict_table_t::bulk_trx_id. This special handling only applies to the very first INSERT statement of a transaction for the empty table or partition. If a subsequent statement in the transaction is modifying the initially empty table again, we must enable row-level undo logging, so that we will be able to roll back to the start of the statement in case of an error (such as duplicate key). INSERT IGNORE will continue to use row-level logging and locking, because implementing it would require the ability to roll back the latest row. Since the undo log that we write only allows us to roll back the entire statement, we cannot support INSERT IGNORE. We will introduce a handler::extra() parameter HA_EXTRA_IGNORE_INSERT to indicate to storage engines that INSERT IGNORE is being executed. In many test cases, we add an extra record to the table, so that during the 'interesting' part of the test, row-level locking and logging will be used. Replicas will continue to use row-level logging and locking until MDEV-24622 has been addressed. Likewise, this optimization will be disabled in Galera cluster until MDEV-24623 enables it. dict_table_t::bulk_trx_id: The latest active or committed transaction that initiated an insert into an empty table or partition. Protected by exclusive table lock and a clustered index leaf page latch. ins_node_t::bulk_insert: Whether bulk insert was initiated. trx_t::mod_tables: Use C++11 style accessors (emplace instead of insert). Unlike earlier, this collection will cover also temporary tables. trx_mod_table_time_t: Add start_bulk_insert(), end_bulk_insert(), is_bulk_insert(), was_bulk_insert(). trx_undo_report_row_operation(): Before accessing any undo log pages, invoke trx->mod_tables.emplace() in order to determine whether undo logging was disabled, or whether this is the first INSERT and we are supposed to write a TRX_UNDO_EMPTY record. row_ins_clust_index_entry_low(): If we are inserting into an empty clustered index leaf page, set the ins_node_t::bulk_insert flag for the subsequent trx_undo_report_row_operation() call. lock_rec_insert_check_and_lock(), lock_prdt_insert_check_and_lock(): Remove the redundant parameter 'flags' that can be checked in the caller. btr_cur_ins_lock_and_undo(): Simplify the logic. Correctly write DB_TRX_ID,DB_ROLL_PTR after invoking trx_undo_report_row_operation(). trx_mark_sql_stat_end(), ha_innobase::extra(HA_EXTRA_IGNORE_INSERT), ha_innobase::external_lock(): Invoke trx_t::end_bulk_insert() so that the next statement will not be covered by table-level undo logging. ReadView::changes_visible(trx_id_t) const: New accessor for the case where the trx_id_t is not read from a potentially corrupted index page but directly from the memory. In this case, we can skip a sanity check. row_sel(), row_sel_try_search_shortcut(), row_search_mvcc(): row_sel_try_search_shortcut_for_mysql(), row_merge_read_clustered_index(): Check dict_table_t::bulk_trx_id. row_sel_clust_sees(): Replaces lock_clust_rec_cons_read_sees(). lock_sec_rec_cons_read_sees(): Replaced with lower-level code. btr_root_page_init(): Refactored from btr_create(). dict_index_t::clear(), dict_table_t::clear(): Empty an index or table, for the ROLLBACK of an INSERT operation. ROW_T_EMPTY, ROW_OP_EMPTY: Note a concurrent ROLLBACK of an INSERT into an empty table. This is joint work with Thirunarayanan Balathandayuthapani, who created a working prototype. Thanks to Matthias Leich for extensive testing.
163 lines
4 KiB
Text
163 lines
4 KiB
Text
set global innodb_table_locks=1;
|
|
select @@innodb_table_locks;
|
|
@@innodb_table_locks
|
|
1
|
|
set @@innodb_table_locks=1;
|
|
connect con1,localhost,root,,;
|
|
create table t1 (id integer, x integer) engine=INNODB;
|
|
insert into t1 values(0, 0);
|
|
set autocommit=0;
|
|
SELECT * from t1 where id = 0 FOR UPDATE;
|
|
id x
|
|
0 0
|
|
connect con2,localhost,root,,;
|
|
set autocommit=0;
|
|
lock table t1 write;
|
|
connection con1;
|
|
update t1 set x=1 where id = 0;
|
|
select * from t1;
|
|
id x
|
|
0 1
|
|
commit;
|
|
connection con2;
|
|
update t1 set x=2 where id = 0;
|
|
commit;
|
|
unlock tables;
|
|
connection con1;
|
|
select * from t1;
|
|
id x
|
|
0 2
|
|
commit;
|
|
drop table t1;
|
|
#
|
|
# Old lock method (where LOCK TABLE was ignored by InnoDB) no longer
|
|
# works when LOCK TABLE ... WRITE is used due to fix for bugs #46272
|
|
# "MySQL 5.4.4, new MDL: unnecessary and bug #37346 "innodb does not
|
|
# detect deadlock between update and alter table".
|
|
# After WL#6671 "Improve scalability by not using thr_lock.c locks
|
|
# for InnoDB tables" was implemented it no longer works for LOCK TABLES
|
|
# ,,, READ as well.
|
|
# LOCK TABLES locks are now completely handled by MDL subsystem.
|
|
#
|
|
set @@innodb_table_locks=0;
|
|
create table t1 (id integer primary key, x integer) engine=INNODB;
|
|
insert into t1 values(0, 0),(1,1),(2,2);
|
|
commit;
|
|
SELECT * from t1 where id = 0 FOR UPDATE;
|
|
id x
|
|
0 0
|
|
connection con2;
|
|
set autocommit=0;
|
|
set @@innodb_table_locks=0;
|
|
# The following statement should block because SQL-level lock
|
|
# is taken on t1 which will wait until concurrent transaction
|
|
# is commited.
|
|
# Sending:
|
|
lock table t1 write;;
|
|
connection con1;
|
|
# Wait until LOCK TABLE is blocked on SQL-level lock.
|
|
# We should be able to do UPDATEs and SELECTs within transaction.
|
|
update t1 set x=1 where id = 0;
|
|
select * from t1;
|
|
id x
|
|
0 1
|
|
1 1
|
|
2 2
|
|
# Unblock LOCK TABLE.
|
|
commit;
|
|
connection con2;
|
|
# Reap LOCK TABLE.
|
|
unlock tables;
|
|
connection con1;
|
|
select * from t1 where id = 0 for update;
|
|
id x
|
|
0 1
|
|
connection con2;
|
|
# The following statement should block because SQL-level lock
|
|
# is taken on t1 which will wait until concurrent transaction
|
|
# is commited.
|
|
# Sending:
|
|
lock table t1 read;;
|
|
connection con1;
|
|
# Wait until LOCK TABLE is blocked on SQL-level lock.
|
|
# We should be able to do UPDATEs and SELECTs within transaction.
|
|
update t1 set x=2 where id = 0;
|
|
select * from t1;
|
|
id x
|
|
0 2
|
|
1 1
|
|
2 2
|
|
# Unblock LOCK TABLE.
|
|
commit;
|
|
connection con2;
|
|
# Reap LOCK TABLE.
|
|
unlock tables;
|
|
connection default;
|
|
drop table t1;
|
|
#
|
|
#Bug#12842206 INNODB LOCKING REGRESSION FOR INSERT IGNORE
|
|
#fixed by re-fixing Bug#7975
|
|
#aka Bug#11759688 52020: InnoDB can still deadlock on just INSERT...
|
|
#
|
|
connection default;
|
|
CREATE TABLE t1 (a INT PRIMARY KEY, b INT NOT NULL) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES(3,1);
|
|
BEGIN;
|
|
INSERT IGNORE INTO t1 VALUES(3,14);
|
|
Warnings:
|
|
Warning 1062 Duplicate entry '3' for key 'PRIMARY'
|
|
connection con1;
|
|
BEGIN;
|
|
INSERT IGNORE INTO t1 VALUES(3,23);
|
|
Warnings:
|
|
Warning 1062 Duplicate entry '3' for key 'PRIMARY'
|
|
SELECT * FROM t1 FOR UPDATE;
|
|
connection con2;
|
|
disconnect con2;
|
|
connection default;
|
|
COMMIT;
|
|
connection con1;
|
|
a b
|
|
3 1
|
|
COMMIT;
|
|
connection default;
|
|
DROP TABLE t1;
|
|
#
|
|
# MDEV-11080 InnoDB: Failing assertion:
|
|
# table->n_waiting_or_granted_auto_inc_locks > 0
|
|
#
|
|
CREATE TABLE t1 (pk INTEGER AUTO_INCREMENT PRIMARY KEY) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (NULL),(NULL);
|
|
CREATE TABLE t2 LIKE t1;
|
|
BEGIN;
|
|
connection con1;
|
|
BEGIN;
|
|
DELETE FROM t2;
|
|
connection default;
|
|
LOCK TABLE t2 READ;;
|
|
connection con1;
|
|
SET innodb_lock_wait_timeout= 1, lock_wait_timeout= 2;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
COMMIT;
|
|
connection default;
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1, t2;
|
|
#
|
|
# MDEV-16709 InnoDB: Error: trx already had an AUTO-INC lock
|
|
#
|
|
CREATE TABLE t1 (pk INT AUTO_INCREMENT PRIMARY KEY) ENGINE=InnoDB
|
|
PARTITION BY key (pk) PARTITIONS 2;
|
|
INSERT INTO t1 VALUES(100);
|
|
INSERT INTO t1 VALUES(101);
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3),(4),(5),(6);
|
|
CREATE TABLE t3 (b INT) ENGINE=InnoDB;
|
|
INSERT INTO t3 VALUES (1),(2),(3),(4),(5),(6),(7),(8),(9);
|
|
connection con1;
|
|
INSERT t1 SELECT NULL FROM t2;
|
|
connection default;
|
|
INSERT t1 SELECT NULL FROM t3;
|
|
connection con1;
|
|
disconnect con1;
|
|
connection default;
|
|
DROP TABLE t1, t2, t3;
|