mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
ae05097714
This error was discovered while working on
MDEV-30540 Wrong result with IN list length reaching
IN_PREDICATE_CONVERSION_THRESHOLD
If there is read error from handler::ha_rnd_next() during a recursive
query, st_select_lex_unit::exec_recursive() will crash as it will try to
get the error code from a structure that was deleted by the callee.
The code was using the construct:
sl->join->exec();
saved_error=sl->join->error;
This does not work as sl->join was freed by the exec() and sl->join would
be set to 0.
Fixed by having JOIN::exec() return the error code.
The included test case simulates the error in ha_rnd_next(), which causes
a crash without the patch.
scovered whle working on
MDEV-30540 Wrong result with IN list length reaching
IN_PREDICATE_CONVERSION_THRESHOLD
If there is read error from handler::ha_rnd_next() during a recursive
query, st_select_lex_unit::exec_recursive() will crash as it will try to
get the error code from a structure that was deleted by the callee.
The code was using the construct:
sl->join->exec();
saved_error=sl->join->error;
This does not work as sl->join was freed by the exec() and sl->join was
set to 0.
Fixed by having JOIN::exec() return the error code.
The included test case simulates the error in ha_rnd_next(), which causes
a crash without the patch.
40 lines
1.3 KiB
C
40 lines
1.3 KiB
C
#ifndef DEBUG_INCLUDED
|
|
#define DEBUG_INCLUDED
|
|
|
|
/* Copyright (c) 2021, MariaDB Corporation
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
|
|
|
|
/**
|
|
@file
|
|
|
|
Declarations for debug_crash_here and other future mariadb server debug
|
|
functionality.
|
|
*/
|
|
|
|
/* debug_crash_here() functionallity.
|
|
See mysql_test/suite/atomic/create_table.test for an example of how it
|
|
can be used
|
|
*/
|
|
|
|
#ifndef DBUG_OFF
|
|
void debug_crash_here(const char *keyword);
|
|
bool debug_simulate_error(const char *keyword, uint error);
|
|
bool debug_decrement_counter(const LEX_CSTRING *name);
|
|
#else
|
|
#define debug_crash_here(A) do { } while(0)
|
|
#define debug_simulate_error(A, B) 0
|
|
#endif
|
|
|
|
#endif /* DEBUG_INCLUDED */
|