mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
f252f9248a
The following type conversions was done: - Changed byte to uchar - Changed gptr to uchar* - Change my_string to char * - Change my_size_t to size_t - Change size_s to size_t Removed declaration of byte, gptr, my_string, my_size_t and size_s. Following function parameter changes was done: - All string functions in mysys/strings was changed to use size_t instead of uint for string lengths. - All read()/write() functions changed to use size_t (including vio). - All protocoll functions changed to use size_t instead of uint - Functions that used a pointer to a string length was changed to use size_t* - Changed malloc(), free() and related functions from using gptr to use void * as this requires fewer casts in the code and is more in line with how the standard functions work. - Added extra length argument to dirname_part() to return the length of the created string. - Changed (at least) following functions to take uchar* as argument: - db_dump() - my_net_write() - net_write_command() - net_store_data() - DBUG_DUMP() - decimal2bin() & bin2decimal() - Changed my_compress() and my_uncompress() to use size_t. Changed one argument to my_uncompress() from a pointer to a value as we only return one value (makes function easier to use). - Changed type of 'pack_data' argument to packfrm() to avoid casts. - Changed in readfrm() and writefrom(), ha_discover and handler::discover() the type for argument 'frmdata' to uchar** to avoid casts. - Changed most Field functions to use uchar* instead of char* (reduced a lot of casts). - Changed field->val_xxx(xxx, new_ptr) to take const pointers. Other changes: - Removed a lot of not needed casts - Added a few new cast required by other changes - Added some cast to my_multi_malloc() arguments for safety (as string lengths needs to be uint, not size_t). - Fixed all calls to hash-get-key functions to use size_t*. (Needed to be done explicitely as this conflict was often hided by casting the function to hash_get_key). - Changed some buffers to memory regions to uchar* to avoid casts. - Changed some string lengths from uint to size_t. - Changed field->ptr to be uchar* instead of char*. This allowed us to get rid of a lot of casts. - Some changes from true -> TRUE, false -> FALSE, unsigned char -> uchar - Include zlib.h in some files as we needed declaration of crc32() - Changed MY_FILE_ERROR to be (size_t) -1. - Changed many variables to hold the result of my_read() / my_write() to be size_t. This was needed to properly detect errors (which are returned as (size_t) -1). - Removed some very old VMS code - Changed packfrm()/unpackfrm() to not be depending on uint size (portability fix) - Removed windows specific code to restore cursor position as this causes slowdown on windows and we should not mix read() and pread() calls anyway as this is not thread safe. Updated function comment to reflect this. Changed function that depended on original behavior of my_pwrite() to itself restore the cursor position (one such case). - Added some missing checking of return value of malloc(). - Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid 'long' overflow. - Changed type of table_def::m_size from my_size_t to ulong to reflect that m_size is the number of elements in the array, not a string/memory length. - Moved THD::max_row_length() to table.cc (as it's not depending on THD). Inlined max_row_length_blob() into this function. - More function comments - Fixed some compiler warnings when compiled without partitions. - Removed setting of LEX_STRING() arguments in declaration (portability fix). - Some trivial indentation/variable name changes. - Some trivial code simplifications: - Replaced some calls to alloc_root + memcpy to use strmake_root()/strdup_root(). - Changed some calls from memdup() to strmake() (Safety fix) - Simpler loops in client-simple.c BitKeeper/etc/ignore: added libmysqld/ha_ndbcluster_cond.cc --- added debian/defs.mk debian/control client/completion_hash.cc: Remove not needed casts client/my_readline.h: Remove some old types client/mysql.cc: Simplify types client/mysql_upgrade.c: Remove some old types Update call to dirname_part client/mysqladmin.cc: Remove some old types client/mysqlbinlog.cc: Remove some old types Change some buffers to be uchar to avoid casts client/mysqlcheck.c: Remove some old types client/mysqldump.c: Remove some old types Remove some not needed casts Change some string lengths to size_t client/mysqlimport.c: Remove some old types client/mysqlshow.c: Remove some old types client/mysqlslap.c: Remove some old types Remove some not needed casts client/mysqltest.c: Removed some old types Removed some not needed casts Updated hash-get-key function arguments Updated parameters to dirname_part() client/readline.cc: Removed some old types Removed some not needed casts Changed some string lengths to use size_t client/sql_string.cc: Removed some old types dbug/dbug.c: Removed some old types Changed some string lengths to use size_t Changed some prototypes to avoid casts extra/comp_err.c: Removed some old types extra/innochecksum.c: Removed some old types extra/my_print_defaults.c: Removed some old types extra/mysql_waitpid.c: Removed some old types extra/perror.c: Removed some old types extra/replace.c: Removed some old types Updated parameters to dirname_part() extra/resolve_stack_dump.c: Removed some old types extra/resolveip.c: Removed some old types include/config-win.h: Removed some old types include/decimal.h: Changed binary strings to be uchar* instead of char* include/ft_global.h: Removed some old types include/hash.h: Removed some old types include/heap.h: Removed some old types Changed records_under_level to be 'ulong' instead of 'uint' to clarify usage of variable include/keycache.h: Removed some old types include/m_ctype.h: Removed some old types Changed some string lengths to use size_t Changed character length functions to return uint unsigned char -> uchar include/m_string.h: Removed some old types Changed some string lengths to use size_t include/my_alloc.h: Changed some string lengths to use size_t include/my_base.h: Removed some old types include/my_dbug.h: Removed some old types Changed some string lengths to use size_t Changed db_dump() to take uchar * as argument for memory to reduce number of casts in usage include/my_getopt.h: Removed some old types include/my_global.h: Removed old types: my_size_t -> size_t byte -> uchar gptr -> uchar * include/my_list.h: Removed some old types include/my_nosys.h: Removed some old types include/my_pthread.h: Removed some old types include/my_sys.h: Removed some old types Changed MY_FILE_ERROR to be in line with new definitions of my_write()/my_read() Changed some string lengths to use size_t my_malloc() / my_free() now uses void * Updated parameters to dirname_part() & my_uncompress() include/my_tree.h: Removed some old types include/my_trie.h: Removed some old types include/my_user.h: Changed some string lengths to use size_t include/my_vle.h: Removed some old types include/my_xml.h: Removed some old types Changed some string lengths to use size_t include/myisam.h: Removed some old types include/myisammrg.h: Removed some old types include/mysql.h: Removed some old types Changed byte streams to use uchar* instead of char* include/mysql_com.h: Removed some old types Changed some string lengths to use size_t Changed some buffers to be uchar* to avoid casts include/queues.h: Removed some old types include/sql_common.h: Removed some old types include/sslopt-longopts.h: Removed some old types include/violite.h: Removed some old types Changed some string lengths to use size_t libmysql/client_settings.h: Removed some old types libmysql/libmysql.c: Removed some old types libmysql/manager.c: Removed some old types libmysqld/emb_qcache.cc: Removed some old types libmysqld/emb_qcache.h: Removed some old types libmysqld/lib_sql.cc: Removed some old types Removed some not needed casts Changed some buffers to be uchar* to avoid casts true -> TRUE, false -> FALSE mysys/array.c: Removed some old types mysys/charset.c: Changed some string lengths to use size_t mysys/checksum.c: Include zlib to get definition for crc32 Removed some old types mysys/default.c: Removed some old types Changed some string lengths to use size_t mysys/default_modify.c: Changed some string lengths to use size_t Removed some not needed casts mysys/hash.c: Removed some old types Changed some string lengths to use size_t Note: Prototype of hash_key() has changed which may cause problems if client uses hash_init() with a cast for the hash-get-key function. hash_element now takes 'ulong' as the index type (cleanup) mysys/list.c: Removed some old types mysys/mf_cache.c: Changed some string lengths to use size_t mysys/mf_dirname.c: Removed some old types Changed some string lengths to use size_t Added argument to dirname_part() to avoid calculation of length for 'to' mysys/mf_fn_ext.c: Removed some old types Updated parameters to dirname_part() mysys/mf_format.c: Removed some old types Changed some string lengths to use size_t mysys/mf_getdate.c: Removed some old types mysys/mf_iocache.c: Removed some old types Changed some string lengths to use size_t Changed calculation of 'max_length' to be done the same way in all functions mysys/mf_iocache2.c: Removed some old types Changed some string lengths to use size_t Clean up comments Removed not needed indentation mysys/mf_keycache.c: Removed some old types mysys/mf_keycaches.c: Removed some old types mysys/mf_loadpath.c: Removed some old types mysys/mf_pack.c: Removed some old types Changed some string lengths to use size_t Removed some not needed casts Removed very old VMS code Updated parameters to dirname_part() Use result of dirnam_part() to remove call to strcat() mysys/mf_path.c: Removed some old types mysys/mf_radix.c: Removed some old types mysys/mf_same.c: Removed some old types mysys/mf_sort.c: Removed some old types mysys/mf_soundex.c: Removed some old types mysys/mf_strip.c: Removed some old types mysys/mf_tempdir.c: Removed some old types mysys/mf_unixpath.c: Removed some old types mysys/mf_wfile.c: Removed some old types mysys/mulalloc.c: Removed some old types mysys/my_alloc.c: Removed some old types Changed some string lengths to use size_t Use void* as type for allocated memory area Removed some not needed casts Changed argument 'Size' to 'length' according coding guidelines mysys/my_chsize.c: Changed some buffers to be uchar* to avoid casts mysys/my_compress.c: More comments Removed some old types Changed string lengths to use size_t Changed arguments to my_uncompress() to make them easier to understand Changed packfrm()/unpackfrm() to not be depending on uint size (portability fix) Changed type of 'pack_data' argument to packfrm() to avoid casts. mysys/my_conio.c: Changed some string lengths to use size_t mysys/my_create.c: Removed some old types mysys/my_div.c: Removed some old types mysys/my_error.c: Removed some old types mysys/my_fopen.c: Removed some old types mysys/my_fstream.c: Removed some old types Changed some string lengths to use size_t writen -> written mysys/my_getopt.c: Removed some old types mysys/my_getwd.c: Removed some old types More comments mysys/my_init.c: Removed some old types mysys/my_largepage.c: Removed some old types Changed some string lengths to use size_t mysys/my_lib.c: Removed some old types mysys/my_lockmem.c: Removed some old types mysys/my_malloc.c: Removed some old types Changed malloc(), free() and related functions to use void * Changed all functions to use size_t mysys/my_memmem.c: Indentation cleanup mysys/my_once.c: Removed some old types Changed malloc(), free() and related functions to use void * mysys/my_open.c: Removed some old types mysys/my_pread.c: Removed some old types Changed all functions to use size_t Added comment for how my_pread() / my_pwrite() are supposed to work. Removed windows specific code to restore cursor position as this causes slowdown on windows and we should not mix read() and pread() calls anyway as this is not thread safe. (If we ever would really need this, it should be enabled only with a flag argument) mysys/my_quick.c: Removed some old types Changed all functions to use size_t mysys/my_read.c: Removed some old types Changed all functions to use size_t mysys/my_realloc.c: Removed some old types Use void* as type for allocated memory area Changed all functions to use size_t mysys/my_static.c: Removed some old types mysys/my_static.h: Removed some old types mysys/my_vle.c: Removed some old types mysys/my_wincond.c: Removed some old types mysys/my_windac.c: Removed some old types mysys/my_write.c: Removed some old types Changed all functions to use size_t mysys/ptr_cmp.c: Removed some old types Changed all functions to use size_t mysys/queues.c: Removed some old types mysys/safemalloc.c: Removed some old types Changed malloc(), free() and related functions to use void * Changed all functions to use size_t mysys/string.c: Removed some old types Changed all functions to use size_t mysys/testhash.c: Removed some old types mysys/thr_alarm.c: Removed some old types mysys/thr_lock.c: Removed some old types mysys/tree.c: Removed some old types mysys/trie.c: Removed some old types mysys/typelib.c: Removed some old types plugin/daemon_example/daemon_example.cc: Removed some old types regex/reginit.c: Removed some old types server-tools/instance-manager/buffer.cc: Changed some string lengths to use size_t Changed buffer to be of type uchar* server-tools/instance-manager/buffer.h: Changed some string lengths to use size_t Changed buffer to be of type uchar* server-tools/instance-manager/commands.cc: Removed some old types Changed some string lengths to use size_t Changed buffer to be of type uchar* server-tools/instance-manager/instance_map.cc: Removed some old types Changed some string lengths to use size_t Changed buffer to be of type uchar* server-tools/instance-manager/instance_options.cc: Changed buffer to be of type uchar* Replaced alloc_root + strcpy() with strdup_root() server-tools/instance-manager/mysql_connection.cc: Changed buffer to be of type uchar* server-tools/instance-manager/options.cc: Removed some old types server-tools/instance-manager/parse.cc: Changed some string lengths to use size_t server-tools/instance-manager/parse.h: Removed some old types Changed some string lengths to use size_t server-tools/instance-manager/protocol.cc: Changed some buffers to be uchar* to avoid casts Changed some string lengths to use size_t server-tools/instance-manager/protocol.h: Changed some string lengths to use size_t server-tools/instance-manager/user_map.cc: Removed some old types Changed some string lengths to use size_t sql/derror.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Changed some string lengths to use size_t sql/discover.cc: Changed in readfrm() and writefrom() the type for argument 'frmdata' to uchar** to avoid casts Changed some string lengths to use size_t Changed some buffers to be uchar* to avoid casts sql/event_data_objects.cc: Removed some old types Added missing casts for alloc() and sprintf() sql/event_db_repository.cc: Changed some buffers to be uchar* to avoid casts Added missing casts for sprintf() sql/event_queue.cc: Removed some old types sql/field.cc: Removed some old types Changed memory buffers to be uchar* Changed some string lengths to use size_t Removed a lot of casts Safety fix in Field_blob::val_decimal() to not access zero pointer sql/field.h: Removed some old types Changed memory buffers to be uchar* (except of store() as this would have caused too many other changes). Changed some string lengths to use size_t Removed some not needed casts Changed val_xxx(xxx, new_ptr) to take const pointers sql/field_conv.cc: Removed some old types Added casts required because memory area pointers are now uchar* sql/filesort.cc: Initalize variable that was used unitialized in error conditions sql/gen_lex_hash.cc: Removed some old types Changed memory buffers to be uchar* Changed some string lengths to use size_t Removed a lot of casts Safety fix in Field_blob::val_decimal() to not access zero pointer sql/gstream.h: Added required cast sql/ha_ndbcluster.cc: Removed some old types Updated hash-get-key function arguments Changed some buffers to be uchar* to avoid casts Added required casts Removed some not needed casts sql/ha_ndbcluster.h: Removed some old types sql/ha_ndbcluster_binlog.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Replaced sql_alloc() + memcpy() + set end 0 with sql_strmake() Changed some string lengths to use size_t Added missing casts for alloc() and sprintf() sql/ha_ndbcluster_binlog.h: Removed some old types sql/ha_ndbcluster_cond.cc: Removed some old types Removed some not needed casts sql/ha_ndbcluster_cond.h: Removed some old types sql/ha_partition.cc: Removed some old types Changed prototype for change_partition() to avoid casts sql/ha_partition.h: Removed some old types sql/handler.cc: Removed some old types Changed some string lengths to use size_t sql/handler.h: Removed some old types Changed some string lengths to use size_t Changed type for 'frmblob' parameter for discover() and ha_discover() to get fewer casts sql/hash_filo.h: Removed some old types Changed all functions to use size_t sql/hostname.cc: Removed some old types sql/item.cc: Removed some old types Changed some string lengths to use size_t Use strmake() instead of memdup() to create a null terminated string. Updated calls to new Field() sql/item.h: Removed some old types Changed malloc(), free() and related functions to use void * Changed some buffers to be uchar* to avoid casts sql/item_cmpfunc.cc: Removed some old types Changed some buffers to be uchar* to avoid casts sql/item_cmpfunc.h: Removed some old types sql/item_create.cc: Removed some old types sql/item_func.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Removed some not needed casts Added test for failing alloc() in init_result_field() Remove old confusing comment Fixed compiler warning sql/item_func.h: Removed some old types sql/item_row.cc: Removed some old types sql/item_row.h: Removed some old types sql/item_strfunc.cc: Include zlib (needed becasue we call crc32) Removed some old types sql/item_strfunc.h: Removed some old types Changed some types to match new function prototypes sql/item_subselect.cc: Removed some old types sql/item_subselect.h: Removed some old types sql/item_sum.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Removed some not needed casts sql/item_sum.h: Removed some old types sql/item_timefunc.cc: Removed some old types Changed some string lengths to use size_t sql/item_timefunc.h: Removed some old types sql/item_xmlfunc.cc: Changed some string lengths to use size_t sql/item_xmlfunc.h: Removed some old types sql/key.cc: Removed some old types Removed some not needed casts sql/lock.cc: Removed some old types Added some cast to my_multi_malloc() arguments for safety sql/log.cc: Removed some old types Changed some string lengths to use size_t Changed some buffers to be uchar* to avoid casts Changed usage of pwrite() to not assume it holds the cursor position for the file Made usage of my_read() safer sql/log_event.cc: Removed some old types Added checking of return value of malloc() in pack_info() Changed some buffers to be uchar* to avoid casts Removed some 'const' to avoid casts Added missing casts for alloc() and sprintf() Added required casts Removed some not needed casts Added some cast to my_multi_malloc() arguments for safety sql/log_event.h: Removed some old types Changed some buffers to be uchar* to avoid casts sql/log_event_old.cc: Changed some buffers to be uchar* to avoid casts Removed some not needed casts sql/log_event_old.h: Changed some buffers to be uchar* to avoid casts sql/mf_iocache.cc: Removed some old types sql/my_decimal.cc: Changed memory area to use uchar* sql/my_decimal.h: Changed memory area to use uchar* sql/mysql_priv.h: Removed some old types Changed malloc(), free() and related functions to use void * Changed some string lengths to use size_t Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid long overflow Changed some buffers to be uchar* to avoid casts sql/mysqld.cc: Removed some old types sql/net_serv.cc: Removed some old types Changed some string lengths to use size_t Changed some buffers to be uchar* to avoid casts Ensure that vio_read()/vio_write() return values are stored in a size_t variable Removed some not needed casts sql/opt_range.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Removed some not needed casts sql/opt_range.h: Removed some old types Changed some buffers to be uchar* to avoid casts sql/opt_sum.cc: Removed some old types Removed some not needed casts sql/parse_file.cc: Removed some old types Changed some string lengths to use size_t Changed alloc_root + memcpy + set end 0 -> strmake_root() sql/parse_file.h: Removed some old types sql/partition_info.cc: Removed some old types Added missing casts for alloc() Changed some buffers to be uchar* to avoid casts sql/partition_info.h: Changed some buffers to be uchar* to avoid casts sql/protocol.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Removed some not needed casts sql/protocol.h: Removed some old types Changed some buffers to be uchar* to avoid casts Changed some string lengths to use size_t sql/records.cc: Removed some old types sql/repl_failsafe.cc: Removed some old types Changed some string lengths to use size_t Added required casts sql/rpl_filter.cc: Removed some old types Updated hash-get-key function arguments Changed some string lengths to use size_t sql/rpl_filter.h: Changed some string lengths to use size_t sql/rpl_injector.h: Removed some old types sql/rpl_record.cc: Removed some old types Removed some not needed casts Changed some buffers to be uchar* to avoid casts sql/rpl_record.h: Removed some old types Changed some buffers to be uchar* to avoid casts sql/rpl_record_old.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Removed some not needed casts sql/rpl_record_old.h: Removed some old types Changed some buffers to be uchar* to avoid cast sql/rpl_rli.cc: Removed some old types sql/rpl_tblmap.cc: Removed some old types sql/rpl_tblmap.h: Removed some old types sql/rpl_utility.cc: Removed some old types sql/rpl_utility.h: Removed some old types Changed type of m_size from my_size_t to ulong to reflect that m_size is the number of elements in the array, not a string/memory length sql/set_var.cc: Removed some old types Updated parameters to dirname_part() sql/set_var.h: Removed some old types sql/slave.cc: Removed some old types Changed some string lengths to use size_t sql/slave.h: Removed some old types sql/sp.cc: Removed some old types Added missing casts for printf() sql/sp.h: Removed some old types Updated hash-get-key function arguments sql/sp_cache.cc: Removed some old types Added missing casts for printf() Updated hash-get-key function arguments sql/sp_head.cc: Removed some old types Added missing casts for alloc() and printf() Added required casts Updated hash-get-key function arguments sql/sp_head.h: Removed some old types sql/sp_pcontext.cc: Removed some old types sql/sp_pcontext.h: Removed some old types sql/sql_acl.cc: Removed some old types Changed some string lengths to use size_t Changed some buffers to be uchar* to avoid casts Removed some not needed casts Added required casts sql/sql_analyse.cc: Changed some buffers to be uchar* to avoid casts sql/sql_analyse.h: Changed some buffers to be uchar* to avoid casts sql/sql_array.h: Removed some old types sql/sql_base.cc: Removed some old types Updated hash-get-key function arguments sql/sql_binlog.cc: Removed some old types Added missing casts for printf() sql/sql_cache.cc: Removed some old types Updated hash-get-key function arguments Removed some not needed casts Changed some string lengths to use size_t sql/sql_cache.h: Removed some old types Removed reference to not existing function cache_key() Updated hash-get-key function arguments sql/sql_class.cc: Removed some old types Updated hash-get-key function arguments Added missing casts for alloc() Updated hash-get-key function arguments Moved THD::max_row_length() to table.cc (as it's not depending on THD) Removed some not needed casts sql/sql_class.h: Removed some old types Changed malloc(), free() and related functions to use void * Removed some not needed casts Changed some string lengths to use size_t Moved max_row_length and max_row_length_blob() to table.cc, as they are not depending on THD sql/sql_connect.cc: Removed some old types Added required casts sql/sql_db.cc: Removed some old types Removed some not needed casts Added some cast to my_multi_malloc() arguments for safety Added missing casts for alloc() sql/sql_delete.cc: Removed some old types sql/sql_handler.cc: Removed some old types Updated hash-get-key function arguments Added some cast to my_multi_malloc() arguments for safety sql/sql_help.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Removed some not needed casts sql/sql_insert.cc: Removed some old types Added missing casts for alloc() and printf() sql/sql_lex.cc: Removed some old types sql/sql_lex.h: Removed some old types Removed some not needed casts sql/sql_list.h: Removed some old types Removed some not needed casts sql/sql_load.cc: Removed some old types Removed compiler warning sql/sql_manager.cc: Removed some old types sql/sql_map.cc: Removed some old types sql/sql_map.h: Removed some old types sql/sql_olap.cc: Removed some old types sql/sql_parse.cc: Removed some old types Trivial move of code lines to make things more readable Changed some string lengths to use size_t Added missing casts for alloc() sql/sql_partition.cc: Removed some old types Removed compiler warnings about not used functions Changed some buffers to be uchar* to avoid casts Removed some not needed casts sql/sql_partition.h: Removed some old types Changed some buffers to be uchar* to avoid casts sql/sql_plugin.cc: Removed some old types Added missing casts for alloc() Updated hash-get-key function arguments sql/sql_prepare.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Added missing casts for alloc() and printf() sql-common/client.c: Removed some old types Changed some memory areas to use uchar* sql-common/my_user.c: Changed some string lengths to use size_t sql-common/pack.c: Changed some buffers to be uchar* to avoid casts sql/sql_repl.cc: Added required casts Changed some buffers to be uchar* to avoid casts Changed some string lengths to use size_t sql/sql_select.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Removed some old types sql/sql_select.h: Removed some old types Changed some buffers to be uchar* to avoid casts sql/sql_servers.cc: Removed some old types Updated hash-get-key function arguments sql/sql_show.cc: Removed some old types Added missing casts for alloc() Removed some not needed casts sql/sql_string.cc: Removed some old types Added required casts sql/sql_table.cc: Removed some old types Removed compiler warning about not used variable Changed some buffers to be uchar* to avoid casts Removed some not needed casts sql/sql_test.cc: Removed some old types sql/sql_trigger.cc: Removed some old types Added missing casts for alloc() sql/sql_udf.cc: Removed some old types Updated hash-get-key function arguments sql/sql_union.cc: Removed some old types sql/sql_update.cc: Removed some old types Removed some not needed casts sql/sql_view.cc: Removed some old types sql/sql_yacc.yy: Removed some old types Changed some string lengths to use size_t Added missing casts for alloc() sql/stacktrace.c: Removed some old types sql/stacktrace.h: Removed some old types sql/structs.h: Removed some old types sql/table.cc: Removed some old types Updated hash-get-key function arguments Changed some buffers to be uchar* to avoid casts Removed setting of LEX_STRING() arguments in declaration Added required casts More function comments Moved max_row_length() here from sql_class.cc/sql_class.h sql/table.h: Removed some old types Changed some string lengths to use size_t sql/thr_malloc.cc: Use void* as type for allocated memory area Changed all functions to use size_t sql/tzfile.h: Changed some buffers to be uchar* to avoid casts sql/tztime.cc: Changed some buffers to be uchar* to avoid casts Updated hash-get-key function arguments Added missing casts for alloc() Removed some not needed casts sql/uniques.cc: Removed some old types Removed some not needed casts sql/unireg.cc: Removed some old types Changed some buffers to be uchar* to avoid casts Removed some not needed casts Added missing casts for alloc() storage/archive/archive_reader.c: Removed some old types storage/archive/azio.c: Removed some old types Removed some not needed casts storage/archive/ha_archive.cc: Removed some old types Changed type for 'frmblob' in archive_discover() to match handler Updated hash-get-key function arguments Removed some not needed casts storage/archive/ha_archive.h: Removed some old types storage/blackhole/ha_blackhole.cc: Removed some old types storage/blackhole/ha_blackhole.h: Removed some old types storage/csv/ha_tina.cc: Removed some old types Updated hash-get-key function arguments Changed some buffers to be uchar* to avoid casts storage/csv/ha_tina.h: Removed some old types Removed some not needed casts storage/csv/transparent_file.cc: Removed some old types Changed type of 'bytes_read' to be able to detect read errors Fixed indentation storage/csv/transparent_file.h: Removed some old types storage/example/ha_example.cc: Removed some old types Updated hash-get-key function arguments storage/example/ha_example.h: Removed some old types storage/federated/ha_federated.cc: Removed some old types Updated hash-get-key function arguments Removed some not needed casts storage/federated/ha_federated.h: Removed some old types storage/heap/_check.c: Changed some buffers to be uchar* to avoid casts storage/heap/_rectest.c: Removed some old types storage/heap/ha_heap.cc: Removed some old types storage/heap/ha_heap.h: Removed some old types storage/heap/heapdef.h: Removed some old types storage/heap/hp_block.c: Removed some old types Changed some string lengths to use size_t storage/heap/hp_clear.c: Removed some old types storage/heap/hp_close.c: Removed some old types storage/heap/hp_create.c: Removed some old types storage/heap/hp_delete.c: Removed some old types storage/heap/hp_hash.c: Removed some old types storage/heap/hp_info.c: Removed some old types storage/heap/hp_open.c: Removed some old types storage/heap/hp_rfirst.c: Removed some old types storage/heap/hp_rkey.c: Removed some old types storage/heap/hp_rlast.c: Removed some old types storage/heap/hp_rnext.c: Removed some old types storage/heap/hp_rprev.c: Removed some old types storage/heap/hp_rrnd.c: Removed some old types storage/heap/hp_rsame.c: Removed some old types storage/heap/hp_scan.c: Removed some old types storage/heap/hp_test1.c: Removed some old types storage/heap/hp_test2.c: Removed some old types storage/heap/hp_update.c: Removed some old types storage/heap/hp_write.c: Removed some old types Changed some string lengths to use size_t storage/innobase/handler/ha_innodb.cc: Removed some old types Updated hash-get-key function arguments Added missing casts for alloc() and printf() Removed some not needed casts storage/innobase/handler/ha_innodb.h: Removed some old types storage/myisam/ft_boolean_search.c: Removed some old types storage/myisam/ft_nlq_search.c: Removed some old types storage/myisam/ft_parser.c: Removed some old types Changed some buffers to be uchar* to avoid casts storage/myisam/ft_static.c: Removed some old types storage/myisam/ft_stopwords.c: Removed some old types storage/myisam/ft_update.c: Removed some old types Changed some buffers to be uchar* to avoid casts storage/myisam/ftdefs.h: Removed some old types Changed some buffers to be uchar* to avoid casts storage/myisam/fulltext.h: Removed some old types storage/myisam/ha_myisam.cc: Removed some old types storage/myisam/ha_myisam.h: Removed some old types storage/myisam/mi_cache.c: Removed some old types Changed some buffers to be uchar* to avoid casts storage/myisam/mi_check.c: Removed some old types storage/myisam/mi_checksum.c: Removed some old types storage/myisam/mi_close.c: Removed some old types storage/myisam/mi_create.c: Removed some old types storage/myisam/mi_delete.c: Removed some old types storage/myisam/mi_delete_all.c: Removed some old types storage/myisam/mi_dynrec.c: Removed some old types storage/myisam/mi_extra.c: Removed some old types storage/myisam/mi_key.c: Removed some old types storage/myisam/mi_locking.c: Removed some old types storage/myisam/mi_log.c: Removed some old types storage/myisam/mi_open.c: Removed some old types Removed some not needed casts Check argument of my_write()/my_pwrite() in functions returning int Added casting of string lengths to size_t storage/myisam/mi_packrec.c: Removed some old types Changed some buffers to be uchar* to avoid casts storage/myisam/mi_page.c: Removed some old types storage/myisam/mi_preload.c: Removed some old types storage/myisam/mi_range.c: Removed some old types storage/myisam/mi_rfirst.c: Removed some old types storage/myisam/mi_rkey.c: Removed some old types storage/myisam/mi_rlast.c: Removed some old types storage/myisam/mi_rnext.c: Removed some old types storage/myisam/mi_rnext_same.c: Removed some old types storage/myisam/mi_rprev.c: Removed some old types storage/myisam/mi_rrnd.c: Removed some old types storage/myisam/mi_rsame.c: Removed some old types storage/myisam/mi_rsamepos.c: Removed some old types storage/myisam/mi_scan.c: Removed some old types storage/myisam/mi_search.c: Removed some old types storage/myisam/mi_static.c: Removed some old types storage/myisam/mi_statrec.c: Removed some old types storage/myisam/mi_test1.c: Removed some old types storage/myisam/mi_test2.c: Removed some old types storage/myisam/mi_test3.c: Removed some old types storage/myisam/mi_unique.c: Removed some old types storage/myisam/mi_update.c: Removed some old types storage/myisam/mi_write.c: Removed some old types storage/myisam/myisam_ftdump.c: Removed some old types storage/myisam/myisamchk.c: Removed some old types storage/myisam/myisamdef.h: Removed some old types storage/myisam/myisamlog.c: Removed some old types Indentation fix storage/myisam/myisampack.c: Removed some old types storage/myisam/rt_index.c: Removed some old types storage/myisam/rt_split.c: Removed some old types storage/myisam/sort.c: Removed some old types storage/myisam/sp_defs.h: Removed some old types storage/myisam/sp_key.c: Removed some old types storage/myisammrg/ha_myisammrg.cc: Removed some old types storage/myisammrg/ha_myisammrg.h: Removed some old types storage/myisammrg/myrg_close.c: Removed some old types storage/myisammrg/myrg_def.h: Removed some old types storage/myisammrg/myrg_delete.c: Removed some old types storage/myisammrg/myrg_open.c: Removed some old types Updated parameters to dirname_part() storage/myisammrg/myrg_queue.c: Removed some old types storage/myisammrg/myrg_rfirst.c: Removed some old types storage/myisammrg/myrg_rkey.c: Removed some old types storage/myisammrg/myrg_rlast.c: Removed some old types storage/myisammrg/myrg_rnext.c: Removed some old types storage/myisammrg/myrg_rnext_same.c: Removed some old types storage/myisammrg/myrg_rprev.c: Removed some old types storage/myisammrg/myrg_rrnd.c: Removed some old types storage/myisammrg/myrg_rsame.c: Removed some old types storage/myisammrg/myrg_update.c: Removed some old types storage/myisammrg/myrg_write.c: Removed some old types storage/ndb/include/util/ndb_opts.h: Removed some old types storage/ndb/src/cw/cpcd/main.cpp: Removed some old types storage/ndb/src/kernel/vm/Configuration.cpp: Removed some old types storage/ndb/src/mgmclient/main.cpp: Removed some old types storage/ndb/src/mgmsrv/InitConfigFileParser.cpp: Removed some old types Removed old disabled code storage/ndb/src/mgmsrv/main.cpp: Removed some old types storage/ndb/src/ndbapi/NdbBlob.cpp: Removed some old types storage/ndb/src/ndbapi/NdbOperationDefine.cpp: Removed not used variable storage/ndb/src/ndbapi/NdbOperationInt.cpp: Added required casts storage/ndb/src/ndbapi/NdbScanOperation.cpp: Added required casts storage/ndb/tools/delete_all.cpp: Removed some old types storage/ndb/tools/desc.cpp: Removed some old types storage/ndb/tools/drop_index.cpp: Removed some old types storage/ndb/tools/drop_tab.cpp: Removed some old types storage/ndb/tools/listTables.cpp: Removed some old types storage/ndb/tools/ndb_config.cpp: Removed some old types storage/ndb/tools/restore/consumer_restore.cpp: Changed some buffers to be uchar* to avoid casts with new defintion of packfrm() storage/ndb/tools/restore/restore_main.cpp: Removed some old types storage/ndb/tools/select_all.cpp: Removed some old types storage/ndb/tools/select_count.cpp: Removed some old types storage/ndb/tools/waiter.cpp: Removed some old types strings/bchange.c: Changed function to use uchar * and size_t strings/bcmp.c: Changed function to use uchar * and size_t strings/bmove512.c: Changed function to use uchar * and size_t strings/bmove_upp.c: Changed function to use uchar * and size_t strings/ctype-big5.c: Changed functions to use size_t Changed character length functions to return uint strings/ctype-bin.c: Changed functions to use size_t strings/ctype-cp932.c: Changed functions to use size_t Changed character length functions to return uint strings/ctype-czech.c: Fixed indentation Changed functions to use size_t strings/ctype-euc_kr.c: Changed functions to use size_t Changed character length functions to return uint strings/ctype-eucjpms.c: Changed functions to use size_t Changed character length functions to return uint unsigned char -> uchar strings/ctype-gb2312.c: Changed functions to use size_t Changed character length functions to return uint strings/ctype-gbk.c: Changed functions to use size_t Changed character length functions to return uint strings/ctype-latin1.c: Changed functions to use size_t Changed character length functions to return uint unsigned char -> uchar strings/ctype-mb.c: Changed functions to use size_t Changed character length functions to return uint strings/ctype-simple.c: Changed functions to use size_t Simpler loops for caseup/casedown unsigned int -> uint unsigned char -> uchar strings/ctype-sjis.c: Changed functions to use size_t Changed character length functions to return uint strings/ctype-tis620.c: Changed functions to use size_t Changed character length functions to return uint unsigned char -> uchar strings/ctype-uca.c: Changed functions to use size_t unsigned char -> uchar strings/ctype-ucs2.c: Moved inclusion of stdarg.h to other includes usigned char -> uchar Changed functions to use size_t Changed character length functions to return uint strings/ctype-ujis.c: Changed functions to use size_t Changed character length functions to return uint unsigned char -> uchar strings/ctype-utf8.c: Changed functions to use size_t unsigned char -> uchar Indentation fixes strings/ctype-win1250ch.c: Indentation fixes Changed functions to use size_t strings/ctype.c: Changed functions to use size_t strings/decimal.c: Changed type for memory argument to uchar * strings/do_ctype.c: Indentation fixes strings/my_strtoll10.c: unsigned char -> uchar strings/my_vsnprintf.c: Changed functions to use size_t strings/r_strinstr.c: Removed some old types Changed functions to use size_t strings/str_test.c: Removed some old types strings/strappend.c: Changed functions to use size_t strings/strcont.c: Removed some old types strings/strfill.c: Removed some old types strings/strinstr.c: Changed functions to use size_t strings/strlen.c: Changed functions to use size_t strings/strmake.c: Changed functions to use size_t strings/strnlen.c: Changed functions to use size_t strings/strnmov.c: Changed functions to use size_t strings/strto.c: unsigned char -> uchar strings/strtod.c: Changed functions to use size_t strings/strxnmov.c: Changed functions to use size_t strings/xml.c: Changed functions to use size_t Indentation fixes tests/mysql_client_test.c: Removed some old types tests/thread_test.c: Removed some old types vio/test-ssl.c: Removed some old types vio/test-sslclient.c: Removed some old types vio/test-sslserver.c: Removed some old types vio/vio.c: Removed some old types vio/vio_priv.h: Removed some old types Changed vio_read()/vio_write() to work with size_t vio/viosocket.c: Changed vio_read()/vio_write() to work with size_t Indentation fixes vio/viossl.c: Changed vio_read()/vio_write() to work with size_t Indentation fixes vio/viosslfactories.c: Removed some old types vio/viotest-ssl.c: Removed some old types win/README: More explanations
1735 lines
52 KiB
C++
1735 lines
52 KiB
C++
/* Copyright (C) 2004-2005 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
|
|
#define MYSQL_LEX 1
|
|
#include "mysql_priv.h"
|
|
#include "sp_head.h"
|
|
#include "sql_trigger.h"
|
|
#include "parse_file.h"
|
|
|
|
static const LEX_STRING triggers_file_type=
|
|
{ C_STRING_WITH_LEN("TRIGGERS") };
|
|
|
|
const char * const triggers_file_ext= ".TRG";
|
|
|
|
/*
|
|
Table of .TRG file field descriptors.
|
|
We have here only one field now because in nearest future .TRG
|
|
files will be merged into .FRM files (so we don't need something
|
|
like md5 or created fields).
|
|
*/
|
|
static File_option triggers_file_parameters[]=
|
|
{
|
|
{
|
|
{ C_STRING_WITH_LEN("triggers") },
|
|
my_offsetof(class Table_triggers_list, definitions_list),
|
|
FILE_OPTIONS_STRLIST
|
|
},
|
|
{
|
|
{ C_STRING_WITH_LEN("sql_modes") },
|
|
my_offsetof(class Table_triggers_list, definition_modes_list),
|
|
FILE_OPTIONS_ULLLIST
|
|
},
|
|
{
|
|
{ C_STRING_WITH_LEN("definers") },
|
|
my_offsetof(class Table_triggers_list, definers_list),
|
|
FILE_OPTIONS_STRLIST
|
|
},
|
|
{ { 0, 0 }, 0, FILE_OPTIONS_STRING }
|
|
};
|
|
|
|
File_option sql_modes_parameters=
|
|
{
|
|
{ C_STRING_WITH_LEN("sql_modes") },
|
|
my_offsetof(class Table_triggers_list, definition_modes_list),
|
|
FILE_OPTIONS_ULLLIST
|
|
};
|
|
|
|
/*
|
|
This must be kept up to date whenever a new option is added to the list
|
|
above, as it specifies the number of required parameters of the trigger in
|
|
.trg file.
|
|
*/
|
|
|
|
static const int TRG_NUM_REQUIRED_PARAMETERS= 4;
|
|
|
|
/*
|
|
Structure representing contents of .TRN file which are used to support
|
|
database wide trigger namespace.
|
|
*/
|
|
|
|
struct st_trigname
|
|
{
|
|
LEX_STRING trigger_table;
|
|
};
|
|
|
|
static const LEX_STRING trigname_file_type=
|
|
{ C_STRING_WITH_LEN("TRIGGERNAME") };
|
|
|
|
const char * const trigname_file_ext= ".TRN";
|
|
|
|
static File_option trigname_file_parameters[]=
|
|
{
|
|
{
|
|
{ C_STRING_WITH_LEN("trigger_table")},
|
|
offsetof(struct st_trigname, trigger_table),
|
|
FILE_OPTIONS_ESTRING
|
|
},
|
|
{ { 0, 0 }, 0, FILE_OPTIONS_STRING }
|
|
};
|
|
|
|
|
|
const LEX_STRING trg_action_time_type_names[]=
|
|
{
|
|
{ C_STRING_WITH_LEN("BEFORE") },
|
|
{ C_STRING_WITH_LEN("AFTER") }
|
|
};
|
|
|
|
const LEX_STRING trg_event_type_names[]=
|
|
{
|
|
{ C_STRING_WITH_LEN("INSERT") },
|
|
{ C_STRING_WITH_LEN("UPDATE") },
|
|
{ C_STRING_WITH_LEN("DELETE") }
|
|
};
|
|
|
|
|
|
class Handle_old_incorrect_sql_modes_hook: public Unknown_key_hook
|
|
{
|
|
private:
|
|
char *path;
|
|
public:
|
|
Handle_old_incorrect_sql_modes_hook(char *file_path)
|
|
:path(file_path)
|
|
{};
|
|
virtual bool process_unknown_string(char *&unknown_key, uchar* base,
|
|
MEM_ROOT *mem_root, char *end);
|
|
};
|
|
|
|
class Handle_old_incorrect_trigger_table_hook: public Unknown_key_hook
|
|
{
|
|
public:
|
|
Handle_old_incorrect_trigger_table_hook(char *file_path,
|
|
LEX_STRING *trigger_table_arg)
|
|
:path(file_path), trigger_table_value(trigger_table_arg)
|
|
{};
|
|
virtual bool process_unknown_string(char *&unknown_key, uchar* base,
|
|
MEM_ROOT *mem_root, char *end);
|
|
private:
|
|
char *path;
|
|
LEX_STRING *trigger_table_value;
|
|
};
|
|
|
|
/*
|
|
Create or drop trigger for table.
|
|
|
|
SYNOPSIS
|
|
mysql_create_or_drop_trigger()
|
|
thd - current thread context (including trigger definition in LEX)
|
|
tables - table list containing one table for which trigger is created.
|
|
create - whenever we create (TRUE) or drop (FALSE) trigger
|
|
|
|
NOTE
|
|
This function is mainly responsible for opening and locking of table and
|
|
invalidation of all its instances in table cache after trigger creation.
|
|
Real work on trigger creation/dropping is done inside Table_triggers_list
|
|
methods.
|
|
|
|
RETURN VALUE
|
|
FALSE Success
|
|
TRUE error
|
|
*/
|
|
bool mysql_create_or_drop_trigger(THD *thd, TABLE_LIST *tables, bool create)
|
|
{
|
|
/*
|
|
FIXME: The code below takes too many different paths depending on the
|
|
'create' flag, so that the justification for a single function
|
|
'mysql_create_or_drop_trigger', compared to two separate functions
|
|
'mysql_create_trigger' and 'mysql_drop_trigger' is not apparent.
|
|
This is a good candidate for a minor refactoring.
|
|
*/
|
|
TABLE *table;
|
|
bool result= TRUE;
|
|
String stmt_query;
|
|
|
|
DBUG_ENTER("mysql_create_or_drop_trigger");
|
|
|
|
/* Charset of the buffer for statement must be system one. */
|
|
stmt_query.set_charset(system_charset_info);
|
|
|
|
/*
|
|
QQ: This function could be merged in mysql_alter_table() function
|
|
But do we want this ?
|
|
*/
|
|
|
|
/*
|
|
Note that once we will have check for TRIGGER privilege in place we won't
|
|
need second part of condition below, since check_access() function also
|
|
checks that db is specified.
|
|
*/
|
|
if (!thd->lex->spname->m_db.length || create && !tables->db_length)
|
|
{
|
|
my_error(ER_NO_DB_ERROR, MYF(0));
|
|
DBUG_RETURN(TRUE);
|
|
}
|
|
|
|
/*
|
|
We don't allow creating triggers on tables in the 'mysql' schema
|
|
*/
|
|
if (create && !my_strcasecmp(system_charset_info, "mysql", tables->db))
|
|
{
|
|
my_error(ER_NO_TRIGGERS_ON_SYSTEM_SCHEMA, MYF(0));
|
|
DBUG_RETURN(TRUE);
|
|
}
|
|
|
|
/*
|
|
There is no DETERMINISTIC clause for triggers, so can't check it.
|
|
But a trigger can in theory be used to do nasty things (if it supported
|
|
DROP for example) so we do the check for privileges. For now there is
|
|
already a stronger test right above; but when this stronger test will
|
|
be removed, the test below will hold. Because triggers have the same
|
|
nature as functions regarding binlogging: their body is implicitly
|
|
binlogged, so they share the same danger, so trust_function_creators
|
|
applies to them too.
|
|
*/
|
|
if (!trust_function_creators && mysql_bin_log.is_open() &&
|
|
!(thd->security_ctx->master_access & SUPER_ACL))
|
|
{
|
|
my_error(ER_BINLOG_CREATE_ROUTINE_NEED_SUPER, MYF(0));
|
|
DBUG_RETURN(TRUE);
|
|
}
|
|
|
|
/*
|
|
We don't want perform our operations while global read lock is held
|
|
so we have to wait until its end and then prevent it from occurring
|
|
again until we are done. (Acquiring LOCK_open is not enough because
|
|
global read lock is held without holding LOCK_open).
|
|
*/
|
|
if (wait_if_global_read_lock(thd, 0, 1))
|
|
DBUG_RETURN(TRUE);
|
|
|
|
VOID(pthread_mutex_lock(&LOCK_open));
|
|
|
|
if (!create)
|
|
{
|
|
bool if_exists= thd->lex->drop_if_exists;
|
|
|
|
if (add_table_for_trigger(thd, thd->lex->spname, if_exists, & tables))
|
|
goto end;
|
|
|
|
if (!tables)
|
|
{
|
|
DBUG_ASSERT(if_exists);
|
|
/*
|
|
Since the trigger does not exist, there is no associated table,
|
|
and therefore :
|
|
- no TRIGGER privileges to check,
|
|
- no trigger to drop,
|
|
- no table to lock/modify,
|
|
so the drop statement is successful.
|
|
*/
|
|
result= FALSE;
|
|
/* Still, we need to log the query ... */
|
|
stmt_query.append(thd->query, thd->query_length);
|
|
goto end;
|
|
}
|
|
}
|
|
|
|
/*
|
|
Check that the user has TRIGGER privilege on the subject table.
|
|
*/
|
|
{
|
|
bool err_status;
|
|
TABLE_LIST **save_query_tables_own_last= thd->lex->query_tables_own_last;
|
|
thd->lex->query_tables_own_last= 0;
|
|
|
|
err_status= check_table_access(thd, TRIGGER_ACL, tables, 0);
|
|
|
|
thd->lex->query_tables_own_last= save_query_tables_own_last;
|
|
|
|
if (err_status)
|
|
goto end;
|
|
}
|
|
|
|
/* We should have only one table in table list. */
|
|
DBUG_ASSERT(tables->next_global == 0);
|
|
|
|
/* We do not allow creation of triggers on temporary tables. */
|
|
if (create && find_temporary_table(thd, tables->db, tables->table_name))
|
|
{
|
|
my_error(ER_TRG_ON_VIEW_OR_TEMP_TABLE, MYF(0), tables->alias);
|
|
goto end;
|
|
}
|
|
|
|
if (lock_table_names(thd, tables))
|
|
goto end;
|
|
|
|
/* We also don't allow creation of triggers on views. */
|
|
tables->required_type= FRMTYPE_TABLE;
|
|
|
|
if (reopen_name_locked_table(thd, tables))
|
|
{
|
|
unlock_table_name(thd, tables);
|
|
goto end;
|
|
}
|
|
table= tables->table;
|
|
|
|
if (!table->triggers)
|
|
{
|
|
if (!create)
|
|
{
|
|
my_error(ER_TRG_DOES_NOT_EXIST, MYF(0));
|
|
goto end;
|
|
}
|
|
|
|
if (!(table->triggers= new (&table->mem_root) Table_triggers_list(table)))
|
|
goto end;
|
|
}
|
|
|
|
result= (create ?
|
|
table->triggers->create_trigger(thd, tables, &stmt_query):
|
|
table->triggers->drop_trigger(thd, tables, &stmt_query));
|
|
|
|
end:
|
|
|
|
if (!result)
|
|
{
|
|
if (mysql_bin_log.is_open())
|
|
{
|
|
thd->clear_error();
|
|
|
|
/* Such a statement can always go directly to binlog, no trans cache. */
|
|
thd->binlog_query(THD::STMT_QUERY_TYPE,
|
|
stmt_query.ptr(), stmt_query.length(), FALSE, FALSE);
|
|
}
|
|
}
|
|
|
|
VOID(pthread_mutex_unlock(&LOCK_open));
|
|
start_waiting_global_read_lock(thd);
|
|
|
|
if (!result)
|
|
send_ok(thd);
|
|
|
|
DBUG_RETURN(result);
|
|
}
|
|
|
|
|
|
/*
|
|
Create trigger for table.
|
|
|
|
SYNOPSIS
|
|
create_trigger()
|
|
thd - current thread context (including trigger definition in
|
|
LEX)
|
|
tables - table list containing one open table for which the
|
|
trigger is created.
|
|
stmt_query - [OUT] after successful return, this string contains
|
|
well-formed statement for creating this trigger.
|
|
|
|
NOTE
|
|
- Assumes that trigger name is fully qualified.
|
|
- NULL-string means the following LEX_STRING instance:
|
|
{ str = 0; length = 0 }.
|
|
- In other words, definer_user and definer_host should contain
|
|
simultaneously NULL-strings (non-SUID/old trigger) or valid strings
|
|
(SUID/new trigger).
|
|
|
|
RETURN VALUE
|
|
False - success
|
|
True - error
|
|
*/
|
|
bool Table_triggers_list::create_trigger(THD *thd, TABLE_LIST *tables,
|
|
String *stmt_query)
|
|
{
|
|
LEX *lex= thd->lex;
|
|
TABLE *table= tables->table;
|
|
char file_buff[FN_REFLEN], trigname_buff[FN_REFLEN];
|
|
LEX_STRING file, trigname_file;
|
|
LEX_STRING *trg_def;
|
|
LEX_STRING definer_user;
|
|
LEX_STRING definer_host;
|
|
ulonglong *trg_sql_mode;
|
|
char trg_definer_holder[USER_HOST_BUFF_SIZE];
|
|
LEX_STRING *trg_definer;
|
|
Item_trigger_field *trg_field;
|
|
struct st_trigname trigname;
|
|
|
|
|
|
/* Trigger must be in the same schema as target table. */
|
|
if (my_strcasecmp(table_alias_charset, table->s->db.str,
|
|
lex->spname->m_db.str))
|
|
{
|
|
my_error(ER_TRG_IN_WRONG_SCHEMA, MYF(0));
|
|
return 1;
|
|
}
|
|
|
|
/* We don't allow creation of several triggers of the same type yet */
|
|
if (bodies[lex->trg_chistics.event][lex->trg_chistics.action_time] != 0)
|
|
{
|
|
my_error(ER_NOT_SUPPORTED_YET, MYF(0),
|
|
"multiple triggers with the same action time"
|
|
" and event for one table");
|
|
return 1;
|
|
}
|
|
|
|
if (!lex->definer)
|
|
{
|
|
/*
|
|
DEFINER-clause is missing.
|
|
|
|
If we are in slave thread, this means that we received CREATE TRIGGER
|
|
from the master, that does not support definer in triggers. So, we
|
|
should mark this trigger as non-SUID. Note that this does not happen
|
|
when we parse triggers' definitions during opening .TRG file.
|
|
LEX::definer is ignored in that case.
|
|
|
|
Otherwise, we should use CURRENT_USER() as definer.
|
|
|
|
NOTE: when CREATE TRIGGER statement is allowed to be executed in PS/SP,
|
|
it will be required to create the definer below in persistent MEM_ROOT
|
|
of PS/SP.
|
|
*/
|
|
|
|
if (!thd->slave_thread)
|
|
{
|
|
if (!(lex->definer= create_default_definer(thd)))
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
/*
|
|
If the specified definer differs from the current user, we should check
|
|
that the current user has SUPER privilege (in order to create trigger
|
|
under another user one must have SUPER privilege).
|
|
*/
|
|
|
|
if (lex->definer &&
|
|
(strcmp(lex->definer->user.str, thd->security_ctx->priv_user) ||
|
|
my_strcasecmp(system_charset_info,
|
|
lex->definer->host.str,
|
|
thd->security_ctx->priv_host)))
|
|
{
|
|
if (check_global_access(thd, SUPER_ACL))
|
|
{
|
|
my_error(ER_SPECIFIC_ACCESS_DENIED_ERROR, MYF(0), "SUPER");
|
|
return TRUE;
|
|
}
|
|
}
|
|
|
|
/*
|
|
Let us check if all references to fields in old/new versions of row in
|
|
this trigger are ok.
|
|
|
|
NOTE: We do it here more from ease of use standpoint. We still have to
|
|
do some checks on each execution. E.g. we can catch privilege changes
|
|
only during execution. Also in near future, when we will allow access
|
|
to other tables from trigger we won't be able to catch changes in other
|
|
tables...
|
|
|
|
Since we don't plan to access to contents of the fields it does not
|
|
matter that we choose for both OLD and NEW values the same versions
|
|
of Field objects here.
|
|
*/
|
|
old_field= new_field= table->field;
|
|
|
|
for (trg_field= (Item_trigger_field *)(lex->trg_table_fields.first);
|
|
trg_field; trg_field= trg_field->next_trg_field)
|
|
{
|
|
/*
|
|
NOTE: now we do not check privileges at CREATE TRIGGER time. This will
|
|
be changed in the future.
|
|
*/
|
|
trg_field->setup_field(thd, table, NULL);
|
|
|
|
if (!trg_field->fixed &&
|
|
trg_field->fix_fields(thd, (Item **)0))
|
|
return 1;
|
|
}
|
|
|
|
/*
|
|
Here we are creating file with triggers and save all triggers in it.
|
|
sql_create_definition_file() files handles renaming and backup of older
|
|
versions
|
|
*/
|
|
file.length= build_table_filename(file_buff, FN_REFLEN-1,
|
|
tables->db, tables->table_name,
|
|
triggers_file_ext, 0);
|
|
file.str= file_buff;
|
|
trigname_file.length= build_table_filename(trigname_buff, FN_REFLEN-1,
|
|
tables->db,
|
|
lex->spname->m_name.str,
|
|
trigname_file_ext, 0);
|
|
trigname_file.str= trigname_buff;
|
|
|
|
/* Use the filesystem to enforce trigger namespace constraints. */
|
|
if (!access(trigname_buff, F_OK))
|
|
{
|
|
my_error(ER_TRG_ALREADY_EXISTS, MYF(0));
|
|
return 1;
|
|
}
|
|
|
|
trigname.trigger_table.str= tables->table_name;
|
|
trigname.trigger_table.length= tables->table_name_length;
|
|
|
|
if (sql_create_definition_file(NULL, &trigname_file, &trigname_file_type,
|
|
(uchar*)&trigname, trigname_file_parameters, 0))
|
|
return 1;
|
|
|
|
/*
|
|
Soon we will invalidate table object and thus Table_triggers_list object
|
|
so don't care about place to which trg_def->ptr points and other
|
|
invariants (e.g. we don't bother to update names_list)
|
|
|
|
QQ: Hmm... probably we should not care about setting up active thread
|
|
mem_root too.
|
|
*/
|
|
if (!(trg_def= (LEX_STRING *)alloc_root(&table->mem_root,
|
|
sizeof(LEX_STRING))) ||
|
|
definitions_list.push_back(trg_def, &table->mem_root) ||
|
|
!(trg_sql_mode= (ulonglong*)alloc_root(&table->mem_root,
|
|
sizeof(ulonglong))) ||
|
|
definition_modes_list.push_back(trg_sql_mode, &table->mem_root) ||
|
|
!(trg_definer= (LEX_STRING*) alloc_root(&table->mem_root,
|
|
sizeof(LEX_STRING))) ||
|
|
definers_list.push_back(trg_definer, &table->mem_root))
|
|
goto err_with_cleanup;
|
|
|
|
*trg_sql_mode= thd->variables.sql_mode;
|
|
|
|
#ifndef NO_EMBEDDED_ACCESS_CHECKS
|
|
if (lex->definer && !is_acl_user(lex->definer->host.str,
|
|
lex->definer->user.str))
|
|
{
|
|
push_warning_printf(thd,
|
|
MYSQL_ERROR::WARN_LEVEL_NOTE,
|
|
ER_NO_SUCH_USER,
|
|
ER(ER_NO_SUCH_USER),
|
|
lex->definer->user.str,
|
|
lex->definer->host.str);
|
|
}
|
|
#endif /* NO_EMBEDDED_ACCESS_CHECKS */
|
|
|
|
if (lex->definer)
|
|
{
|
|
/* SUID trigger. */
|
|
|
|
definer_user= lex->definer->user;
|
|
definer_host= lex->definer->host;
|
|
|
|
trg_definer->str= trg_definer_holder;
|
|
trg_definer->length= strxmov(trg_definer->str, definer_user.str, "@",
|
|
definer_host.str, NullS) - trg_definer->str;
|
|
}
|
|
else
|
|
{
|
|
/* non-SUID trigger. */
|
|
|
|
definer_user.str= 0;
|
|
definer_user.length= 0;
|
|
|
|
definer_host.str= 0;
|
|
definer_host.length= 0;
|
|
|
|
trg_definer->str= (char*) "";
|
|
trg_definer->length= 0;
|
|
}
|
|
|
|
/*
|
|
Create well-formed trigger definition query. Original query is not
|
|
appropriated, because definer-clause can be not truncated.
|
|
*/
|
|
|
|
stmt_query->append(STRING_WITH_LEN("CREATE "));
|
|
|
|
if (trg_definer)
|
|
{
|
|
/*
|
|
Append definer-clause if the trigger is SUID (a usual trigger in
|
|
new MySQL versions).
|
|
*/
|
|
|
|
append_definer(thd, stmt_query, &definer_user, &definer_host);
|
|
}
|
|
|
|
stmt_query->append(thd->lex->stmt_definition_begin,
|
|
(char *) thd->lex->sphead->m_body_begin -
|
|
thd->lex->stmt_definition_begin +
|
|
thd->lex->sphead->m_body.length);
|
|
|
|
trg_def->str= stmt_query->c_ptr();
|
|
trg_def->length= stmt_query->length();
|
|
|
|
/* Create trigger definition file. */
|
|
|
|
if (!sql_create_definition_file(NULL, &file, &triggers_file_type,
|
|
(uchar*)this, triggers_file_parameters, 0))
|
|
return 0;
|
|
|
|
err_with_cleanup:
|
|
my_delete(trigname_buff, MYF(MY_WME));
|
|
return 1;
|
|
}
|
|
|
|
|
|
/*
|
|
Deletes the .TRG file for a table
|
|
|
|
SYNOPSIS
|
|
rm_trigger_file()
|
|
path - char buffer of size FN_REFLEN to be used
|
|
for constructing path to .TRG file.
|
|
db - table's database name
|
|
table_name - table's name
|
|
|
|
RETURN VALUE
|
|
False - success
|
|
True - error
|
|
*/
|
|
|
|
static bool rm_trigger_file(char *path, const char *db,
|
|
const char *table_name)
|
|
{
|
|
build_table_filename(path, FN_REFLEN-1, db, table_name, triggers_file_ext, 0);
|
|
return my_delete(path, MYF(MY_WME));
|
|
}
|
|
|
|
|
|
/*
|
|
Deletes the .TRN file for a trigger
|
|
|
|
SYNOPSIS
|
|
rm_trigname_file()
|
|
path - char buffer of size FN_REFLEN to be used
|
|
for constructing path to .TRN file.
|
|
db - trigger's database name
|
|
table_name - trigger's name
|
|
|
|
RETURN VALUE
|
|
False - success
|
|
True - error
|
|
*/
|
|
|
|
static bool rm_trigname_file(char *path, const char *db,
|
|
const char *trigger_name)
|
|
{
|
|
build_table_filename(path, FN_REFLEN-1,
|
|
db, trigger_name, trigname_file_ext, 0);
|
|
return my_delete(path, MYF(MY_WME));
|
|
}
|
|
|
|
|
|
/*
|
|
Helper function that saves .TRG file for Table_triggers_list object.
|
|
|
|
SYNOPSIS
|
|
save_trigger_file()
|
|
triggers Table_triggers_list object for which file should be saved
|
|
db Name of database for subject table
|
|
table_name Name of subject table
|
|
|
|
RETURN VALUE
|
|
FALSE Success
|
|
TRUE Error
|
|
*/
|
|
|
|
static bool save_trigger_file(Table_triggers_list *triggers, const char *db,
|
|
const char *table_name)
|
|
{
|
|
char file_buff[FN_REFLEN];
|
|
LEX_STRING file;
|
|
|
|
file.length= build_table_filename(file_buff, FN_REFLEN-1, db, table_name,
|
|
triggers_file_ext, 0);
|
|
file.str= file_buff;
|
|
return sql_create_definition_file(NULL, &file, &triggers_file_type,
|
|
(uchar*)triggers, triggers_file_parameters,
|
|
0);
|
|
}
|
|
|
|
|
|
/*
|
|
Drop trigger for table.
|
|
|
|
SYNOPSIS
|
|
drop_trigger()
|
|
thd - current thread context
|
|
(including trigger definition in LEX)
|
|
tables - table list containing one open table for which trigger
|
|
is dropped.
|
|
stmt_query - [OUT] after successful return, this string contains
|
|
well-formed statement for deleting this trigger.
|
|
|
|
RETURN VALUE
|
|
False - success
|
|
True - error
|
|
*/
|
|
bool Table_triggers_list::drop_trigger(THD *thd, TABLE_LIST *tables,
|
|
String *stmt_query)
|
|
{
|
|
LEX *lex= thd->lex;
|
|
LEX_STRING *name;
|
|
List_iterator_fast<LEX_STRING> it_name(names_list);
|
|
List_iterator<LEX_STRING> it_def(definitions_list);
|
|
List_iterator<ulonglong> it_mod(definition_modes_list);
|
|
List_iterator<LEX_STRING> it_definer(definers_list);
|
|
char path[FN_REFLEN];
|
|
|
|
stmt_query->append(thd->query, thd->query_length);
|
|
|
|
while ((name= it_name++))
|
|
{
|
|
it_def++;
|
|
it_mod++;
|
|
it_definer++;
|
|
|
|
if (my_strcasecmp(table_alias_charset, lex->spname->m_name.str,
|
|
name->str) == 0)
|
|
{
|
|
/*
|
|
Again we don't care much about other things required for
|
|
clean trigger removing since table will be reopened anyway.
|
|
*/
|
|
it_def.remove();
|
|
it_mod.remove();
|
|
it_definer.remove();
|
|
|
|
if (definitions_list.is_empty())
|
|
{
|
|
/*
|
|
TODO: Probably instead of removing .TRG file we should move
|
|
to archive directory but this should be done as part of
|
|
parse_file.cc functionality (because we will need it
|
|
elsewhere).
|
|
*/
|
|
if (rm_trigger_file(path, tables->db, tables->table_name))
|
|
return 1;
|
|
}
|
|
else
|
|
{
|
|
if (save_trigger_file(this, tables->db, tables->table_name))
|
|
return 1;
|
|
}
|
|
|
|
if (rm_trigname_file(path, tables->db, lex->spname->m_name.str))
|
|
return 1;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
my_message(ER_TRG_DOES_NOT_EXIST, ER(ER_TRG_DOES_NOT_EXIST), MYF(0));
|
|
return 1;
|
|
}
|
|
|
|
|
|
Table_triggers_list::~Table_triggers_list()
|
|
{
|
|
for (int i= 0; i < (int)TRG_EVENT_MAX; i++)
|
|
for (int j= 0; j < (int)TRG_ACTION_MAX; j++)
|
|
delete bodies[i][j];
|
|
|
|
if (record1_field)
|
|
for (Field **fld_ptr= record1_field; *fld_ptr; fld_ptr++)
|
|
delete *fld_ptr;
|
|
}
|
|
|
|
|
|
/*
|
|
Prepare array of Field objects referencing to TABLE::record[1] instead
|
|
of record[0] (they will represent OLD.* row values in ON UPDATE trigger
|
|
and in ON DELETE trigger which will be called during REPLACE execution).
|
|
|
|
SYNOPSIS
|
|
prepare_record1_accessors()
|
|
table - pointer to TABLE object for which we are creating fields.
|
|
|
|
RETURN VALUE
|
|
False - success
|
|
True - error
|
|
*/
|
|
bool Table_triggers_list::prepare_record1_accessors(TABLE *table)
|
|
{
|
|
Field **fld, **old_fld;
|
|
|
|
if (!(record1_field= (Field **)alloc_root(&table->mem_root,
|
|
(table->s->fields + 1) *
|
|
sizeof(Field*))))
|
|
return 1;
|
|
|
|
for (fld= table->field, old_fld= record1_field; *fld; fld++, old_fld++)
|
|
{
|
|
/*
|
|
QQ: it is supposed that it is ok to use this function for field
|
|
cloning...
|
|
*/
|
|
if (!(*old_fld= (*fld)->new_field(&table->mem_root, table,
|
|
table == (*fld)->table)))
|
|
return 1;
|
|
(*old_fld)->move_field_offset((my_ptrdiff_t)(table->record[1] -
|
|
table->record[0]));
|
|
}
|
|
*old_fld= 0;
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
/*
|
|
Adjust Table_triggers_list with new TABLE pointer.
|
|
|
|
SYNOPSIS
|
|
set_table()
|
|
new_table - new pointer to TABLE instance
|
|
*/
|
|
|
|
void Table_triggers_list::set_table(TABLE *new_table)
|
|
{
|
|
trigger_table= new_table;
|
|
for (Field **field= new_table->triggers->record1_field ; *field ; field++)
|
|
{
|
|
(*field)->table= (*field)->orig_table= new_table;
|
|
(*field)->table_name= &new_table->alias;
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
Check whenever .TRG file for table exist and load all triggers it contains.
|
|
|
|
SYNOPSIS
|
|
check_n_load()
|
|
thd - current thread context
|
|
db - table's database name
|
|
table_name - table's name
|
|
table - pointer to table object
|
|
names_only - stop after loading trigger names
|
|
|
|
RETURN VALUE
|
|
False - success
|
|
True - error
|
|
*/
|
|
|
|
bool Table_triggers_list::check_n_load(THD *thd, const char *db,
|
|
const char *table_name, TABLE *table,
|
|
bool names_only)
|
|
{
|
|
char path_buff[FN_REFLEN];
|
|
LEX_STRING path;
|
|
File_parser *parser;
|
|
LEX_STRING save_db;
|
|
|
|
DBUG_ENTER("Table_triggers_list::check_n_load");
|
|
|
|
path.length= build_table_filename(path_buff, FN_REFLEN-1,
|
|
db, table_name, triggers_file_ext, 0);
|
|
path.str= path_buff;
|
|
|
|
// QQ: should we analyze errno somehow ?
|
|
if (access(path_buff, F_OK))
|
|
DBUG_RETURN(0);
|
|
|
|
/*
|
|
File exists so we got to load triggers.
|
|
FIXME: A lot of things to do here e.g. how about other funcs and being
|
|
more paranoical ?
|
|
*/
|
|
|
|
if ((parser= sql_parse_prepare(&path, &table->mem_root, 1)))
|
|
{
|
|
if (is_equal(&triggers_file_type, parser->type()))
|
|
{
|
|
Table_triggers_list *triggers=
|
|
new (&table->mem_root) Table_triggers_list(table);
|
|
Handle_old_incorrect_sql_modes_hook sql_modes_hook(path.str);
|
|
|
|
if (!triggers)
|
|
DBUG_RETURN(1);
|
|
|
|
/*
|
|
We don't have the following attributes in old versions of .TRG file, so
|
|
we should initialize the list for safety:
|
|
- sql_modes;
|
|
- definers;
|
|
*/
|
|
triggers->definition_modes_list.empty();
|
|
triggers->definers_list.empty();
|
|
|
|
if (parser->parse((uchar*)triggers, &table->mem_root,
|
|
triggers_file_parameters,
|
|
TRG_NUM_REQUIRED_PARAMETERS,
|
|
&sql_modes_hook))
|
|
DBUG_RETURN(1);
|
|
|
|
List_iterator_fast<LEX_STRING> it(triggers->definitions_list);
|
|
LEX_STRING *trg_create_str;
|
|
ulonglong *trg_sql_mode;
|
|
|
|
if (triggers->definition_modes_list.is_empty() &&
|
|
!triggers->definitions_list.is_empty())
|
|
{
|
|
/*
|
|
It is old file format => we should fill list of sql_modes.
|
|
|
|
We use one mode (current) for all triggers, because we have not
|
|
information about mode in old format.
|
|
*/
|
|
if (!(trg_sql_mode= (ulonglong*)alloc_root(&table->mem_root,
|
|
sizeof(ulonglong))))
|
|
{
|
|
DBUG_RETURN(1); // EOM
|
|
}
|
|
*trg_sql_mode= global_system_variables.sql_mode;
|
|
while (it++)
|
|
{
|
|
if (triggers->definition_modes_list.push_back(trg_sql_mode,
|
|
&table->mem_root))
|
|
{
|
|
DBUG_RETURN(1); // EOM
|
|
}
|
|
}
|
|
it.rewind();
|
|
}
|
|
|
|
if (triggers->definers_list.is_empty() &&
|
|
!triggers->definitions_list.is_empty())
|
|
{
|
|
/*
|
|
It is old file format => we should fill list of definers.
|
|
|
|
If there is no definer information, we should not switch context to
|
|
definer when checking privileges. I.e. privileges for such triggers
|
|
are checked for "invoker" rather than for "definer".
|
|
*/
|
|
|
|
LEX_STRING *trg_definer;
|
|
|
|
if (! (trg_definer= (LEX_STRING*)alloc_root(&table->mem_root,
|
|
sizeof(LEX_STRING))))
|
|
DBUG_RETURN(1); // EOM
|
|
|
|
trg_definer->str= (char*) "";
|
|
trg_definer->length= 0;
|
|
|
|
while (it++)
|
|
{
|
|
if (triggers->definers_list.push_back(trg_definer,
|
|
&table->mem_root))
|
|
{
|
|
DBUG_RETURN(1); // EOM
|
|
}
|
|
}
|
|
|
|
it.rewind();
|
|
}
|
|
|
|
DBUG_ASSERT(triggers->definition_modes_list.elements ==
|
|
triggers->definitions_list.elements);
|
|
DBUG_ASSERT(triggers->definers_list.elements ==
|
|
triggers->definitions_list.elements);
|
|
|
|
table->triggers= triggers;
|
|
|
|
/*
|
|
Construct key that will represent triggers for this table in the set
|
|
of routines used by statement.
|
|
*/
|
|
triggers->sroutines_key.length= 1+strlen(db)+1+strlen(table_name)+1;
|
|
if (!(triggers->sroutines_key.str= (char*)
|
|
alloc_root(&table->mem_root, triggers->sroutines_key.length)))
|
|
DBUG_RETURN(1);
|
|
triggers->sroutines_key.str[0]= TYPE_ENUM_TRIGGER;
|
|
strxmov(triggers->sroutines_key.str+1, db, ".", table_name, NullS);
|
|
|
|
/*
|
|
TODO: This could be avoided if there is no triggers
|
|
for UPDATE and DELETE.
|
|
*/
|
|
if (!names_only && triggers->prepare_record1_accessors(table))
|
|
DBUG_RETURN(1);
|
|
|
|
List_iterator_fast<ulonglong> itm(triggers->definition_modes_list);
|
|
List_iterator_fast<LEX_STRING> it_definer(triggers->definers_list);
|
|
LEX *old_lex= thd->lex, lex;
|
|
sp_rcontext *save_spcont= thd->spcont;
|
|
ulong save_sql_mode= thd->variables.sql_mode;
|
|
LEX_STRING *on_table_name;
|
|
|
|
thd->lex= &lex;
|
|
|
|
save_db.str= thd->db;
|
|
save_db.length= thd->db_length;
|
|
thd->reset_db((char*) db, strlen(db));
|
|
while ((trg_create_str= it++))
|
|
{
|
|
trg_sql_mode= itm++;
|
|
LEX_STRING *trg_definer= it_definer++;
|
|
|
|
thd->variables.sql_mode= (ulong)*trg_sql_mode;
|
|
lex_start(thd, trg_create_str->str, trg_create_str->length);
|
|
|
|
thd->spcont= 0;
|
|
if (MYSQLparse((void *)thd) || thd->is_fatal_error)
|
|
{
|
|
/* Currently sphead is always deleted in case of a parse error */
|
|
DBUG_ASSERT(lex.sphead == 0);
|
|
goto err_with_lex_cleanup;
|
|
}
|
|
|
|
lex.sphead->set_info(0, 0, &lex.sp_chistics, (ulong) *trg_sql_mode);
|
|
|
|
triggers->bodies[lex.trg_chistics.event]
|
|
[lex.trg_chistics.action_time]= lex.sphead;
|
|
|
|
if (!trg_definer->length)
|
|
{
|
|
/*
|
|
This trigger was created/imported from the previous version of
|
|
MySQL, which does not support triggers definers. We should emit
|
|
warning here.
|
|
*/
|
|
|
|
push_warning_printf(thd, MYSQL_ERROR::WARN_LEVEL_WARN,
|
|
ER_TRG_NO_DEFINER, ER(ER_TRG_NO_DEFINER),
|
|
(const char*) db,
|
|
(const char*) lex.sphead->m_name.str);
|
|
|
|
/*
|
|
Set definer to the '' to correct displaying in the information
|
|
schema.
|
|
*/
|
|
|
|
lex.sphead->set_definer((char*) "", 0);
|
|
|
|
/*
|
|
Triggers without definer information are executed under the
|
|
authorization of the invoker.
|
|
*/
|
|
|
|
lex.sphead->m_chistics->suid= SP_IS_NOT_SUID;
|
|
}
|
|
else
|
|
lex.sphead->set_definer(trg_definer->str, trg_definer->length);
|
|
|
|
if (triggers->names_list.push_back(&lex.sphead->m_name,
|
|
&table->mem_root))
|
|
goto err_with_lex_cleanup;
|
|
|
|
if (!(on_table_name= (LEX_STRING*) alloc_root(&table->mem_root,
|
|
sizeof(LEX_STRING))))
|
|
goto err_with_lex_cleanup;
|
|
*on_table_name= lex.ident;
|
|
if (triggers->on_table_names_list.push_back(on_table_name, &table->mem_root))
|
|
goto err_with_lex_cleanup;
|
|
|
|
/*
|
|
Let us check that we correctly update trigger definitions when we
|
|
rename tables with triggers.
|
|
*/
|
|
DBUG_ASSERT(!my_strcasecmp(table_alias_charset, lex.query_tables->db, db) &&
|
|
!my_strcasecmp(table_alias_charset, lex.query_tables->table_name,
|
|
table_name));
|
|
|
|
if (names_only)
|
|
{
|
|
lex_end(&lex);
|
|
continue;
|
|
}
|
|
|
|
/*
|
|
Gather all Item_trigger_field objects representing access to fields
|
|
in old/new versions of row in trigger into lists containing all such
|
|
objects for the triggers with same action and timing.
|
|
*/
|
|
triggers->trigger_fields[lex.trg_chistics.event]
|
|
[lex.trg_chistics.action_time]=
|
|
(Item_trigger_field *)(lex.trg_table_fields.first);
|
|
/*
|
|
Also let us bind these objects to Field objects in table being
|
|
opened.
|
|
|
|
We ignore errors here, because if even something is wrong we still
|
|
will be willing to open table to perform some operations (e.g.
|
|
SELECT)...
|
|
Anyway some things can be checked only during trigger execution.
|
|
*/
|
|
for (Item_trigger_field *trg_field=
|
|
(Item_trigger_field *)(lex.trg_table_fields.first);
|
|
trg_field;
|
|
trg_field= trg_field->next_trg_field)
|
|
{
|
|
trg_field->setup_field(thd, table,
|
|
&triggers->subject_table_grants[lex.trg_chistics.event]
|
|
[lex.trg_chistics.action_time]);
|
|
}
|
|
|
|
lex_end(&lex);
|
|
}
|
|
thd->reset_db(save_db.str, save_db.length);
|
|
thd->lex= old_lex;
|
|
thd->spcont= save_spcont;
|
|
thd->variables.sql_mode= save_sql_mode;
|
|
|
|
DBUG_RETURN(0);
|
|
|
|
err_with_lex_cleanup:
|
|
// QQ: anything else ?
|
|
lex_end(&lex);
|
|
thd->lex= old_lex;
|
|
thd->spcont= save_spcont;
|
|
thd->variables.sql_mode= save_sql_mode;
|
|
thd->reset_db(save_db.str, save_db.length);
|
|
DBUG_RETURN(1);
|
|
}
|
|
|
|
/*
|
|
We don't care about this error message much because .TRG files will
|
|
be merged into .FRM anyway.
|
|
*/
|
|
my_error(ER_WRONG_OBJECT, MYF(0),
|
|
table_name, triggers_file_ext+1, "TRIGGER");
|
|
DBUG_RETURN(1);
|
|
}
|
|
|
|
DBUG_RETURN(1);
|
|
}
|
|
|
|
|
|
/*
|
|
Obtains and returns trigger metadata
|
|
|
|
SYNOPSIS
|
|
get_trigger_info()
|
|
thd - current thread context
|
|
event - trigger event type
|
|
time_type - trigger action time
|
|
name - returns name of trigger
|
|
stmt - returns statement of trigger
|
|
sql_mode - returns sql_mode of trigger
|
|
definer_user - returns definer/creator of trigger. The caller is
|
|
responsible to allocate enough space for storing definer
|
|
information.
|
|
|
|
RETURN VALUE
|
|
False - success
|
|
True - error
|
|
*/
|
|
|
|
bool Table_triggers_list::get_trigger_info(THD *thd, trg_event_type event,
|
|
trg_action_time_type time_type,
|
|
LEX_STRING *trigger_name,
|
|
LEX_STRING *trigger_stmt,
|
|
ulong *sql_mode,
|
|
LEX_STRING *definer)
|
|
{
|
|
sp_head *body;
|
|
DBUG_ENTER("get_trigger_info");
|
|
if ((body= bodies[event][time_type]))
|
|
{
|
|
*trigger_name= body->m_name;
|
|
*trigger_stmt= body->m_body;
|
|
*sql_mode= body->m_sql_mode;
|
|
|
|
if (body->m_chistics->suid == SP_IS_NOT_SUID)
|
|
{
|
|
definer->str[0]= 0;
|
|
definer->length= 0;
|
|
}
|
|
else
|
|
{
|
|
definer->length= strxmov(definer->str, body->m_definer_user.str, "@",
|
|
body->m_definer_host.str, NullS) - definer->str;
|
|
}
|
|
|
|
DBUG_RETURN(0);
|
|
}
|
|
DBUG_RETURN(1);
|
|
}
|
|
|
|
|
|
/*
|
|
Find trigger's table from trigger identifier and add it to
|
|
the statement table list.
|
|
|
|
SYNOPSIS
|
|
mysql_table_for_trigger()
|
|
thd - current thread context
|
|
trig - identifier for trigger
|
|
if_exists - treat a not existing trigger as a warning if TRUE
|
|
table - pointer to TABLE_LIST object for the table trigger (output)
|
|
|
|
RETURN VALUE
|
|
0 Success
|
|
1 Error
|
|
*/
|
|
|
|
int
|
|
add_table_for_trigger(THD *thd, sp_name *trig, bool if_exists,
|
|
TABLE_LIST **table)
|
|
{
|
|
LEX *lex= thd->lex;
|
|
char path_buff[FN_REFLEN];
|
|
LEX_STRING path;
|
|
File_parser *parser;
|
|
struct st_trigname trigname;
|
|
Handle_old_incorrect_trigger_table_hook trigger_table_hook(
|
|
path_buff, &trigname.trigger_table);
|
|
|
|
DBUG_ENTER("add_table_for_trigger");
|
|
DBUG_ASSERT(table != NULL);
|
|
|
|
path.length= build_table_filename(path_buff, FN_REFLEN-1,
|
|
trig->m_db.str, trig->m_name.str,
|
|
trigname_file_ext, 0);
|
|
path.str= path_buff;
|
|
|
|
if (access(path_buff, F_OK))
|
|
{
|
|
if (if_exists)
|
|
{
|
|
push_warning_printf(thd,
|
|
MYSQL_ERROR::WARN_LEVEL_NOTE,
|
|
ER_TRG_DOES_NOT_EXIST,
|
|
ER(ER_TRG_DOES_NOT_EXIST));
|
|
*table= NULL;
|
|
DBUG_RETURN(0);
|
|
}
|
|
|
|
my_error(ER_TRG_DOES_NOT_EXIST, MYF(0));
|
|
DBUG_RETURN(1);
|
|
}
|
|
|
|
if (!(parser= sql_parse_prepare(&path, thd->mem_root, 1)))
|
|
DBUG_RETURN(1);
|
|
|
|
if (!is_equal(&trigname_file_type, parser->type()))
|
|
{
|
|
my_error(ER_WRONG_OBJECT, MYF(0), trig->m_name.str, trigname_file_ext+1,
|
|
"TRIGGERNAME");
|
|
DBUG_RETURN(1);
|
|
}
|
|
|
|
if (parser->parse((uchar*)&trigname, thd->mem_root,
|
|
trigname_file_parameters, 1,
|
|
&trigger_table_hook))
|
|
DBUG_RETURN(1);
|
|
|
|
/* We need to reset statement table list to be PS/SP friendly. */
|
|
lex->query_tables= 0;
|
|
lex->query_tables_last= &lex->query_tables;
|
|
*table= sp_add_to_query_tables(thd, lex, trig->m_db.str,
|
|
trigname.trigger_table.str, TL_IGNORE);
|
|
|
|
if (! *table)
|
|
DBUG_RETURN(1);
|
|
|
|
DBUG_RETURN(0);
|
|
}
|
|
|
|
|
|
/*
|
|
Drop all triggers for table.
|
|
|
|
SYNOPSIS
|
|
drop_all_triggers()
|
|
thd - current thread context
|
|
db - schema for table
|
|
name - name for table
|
|
|
|
NOTE
|
|
The calling thread should hold the LOCK_open mutex;
|
|
|
|
RETURN VALUE
|
|
False - success
|
|
True - error
|
|
*/
|
|
|
|
bool Table_triggers_list::drop_all_triggers(THD *thd, char *db, char *name)
|
|
{
|
|
TABLE table;
|
|
char path[FN_REFLEN];
|
|
bool result= 0;
|
|
DBUG_ENTER("drop_all_triggers");
|
|
|
|
bzero(&table, sizeof(table));
|
|
init_alloc_root(&table.mem_root, 8192, 0);
|
|
|
|
safe_mutex_assert_owner(&LOCK_open);
|
|
|
|
if (Table_triggers_list::check_n_load(thd, db, name, &table, 1))
|
|
{
|
|
result= 1;
|
|
goto end;
|
|
}
|
|
if (table.triggers)
|
|
{
|
|
LEX_STRING *trigger;
|
|
List_iterator_fast<LEX_STRING> it_name(table.triggers->names_list);
|
|
|
|
while ((trigger= it_name++))
|
|
{
|
|
if (rm_trigname_file(path, db, trigger->str))
|
|
{
|
|
/*
|
|
Instead of immediately bailing out with error if we were unable
|
|
to remove .TRN file we will try to drop other files.
|
|
*/
|
|
result= 1;
|
|
continue;
|
|
}
|
|
}
|
|
|
|
if (rm_trigger_file(path, db, name))
|
|
{
|
|
result= 1;
|
|
goto end;
|
|
}
|
|
}
|
|
end:
|
|
if (table.triggers)
|
|
delete table.triggers;
|
|
free_root(&table.mem_root, MYF(0));
|
|
DBUG_RETURN(result);
|
|
}
|
|
|
|
|
|
/*
|
|
Update .TRG file after renaming triggers' subject table
|
|
(change name of table in triggers' definitions).
|
|
|
|
SYNOPSIS
|
|
change_table_name_in_triggers()
|
|
thd Thread context
|
|
db_name Database of subject table
|
|
old_table_name Old subject table's name
|
|
new_table_name New subject table's name
|
|
|
|
RETURN VALUE
|
|
FALSE Success
|
|
TRUE Failure
|
|
*/
|
|
|
|
bool
|
|
Table_triggers_list::change_table_name_in_triggers(THD *thd,
|
|
const char *db_name,
|
|
LEX_STRING *old_table_name,
|
|
LEX_STRING *new_table_name)
|
|
{
|
|
char path_buff[FN_REFLEN];
|
|
LEX_STRING *def, *on_table_name, new_def;
|
|
ulong save_sql_mode= thd->variables.sql_mode;
|
|
List_iterator_fast<LEX_STRING> it_def(definitions_list);
|
|
List_iterator_fast<LEX_STRING> it_on_table_name(on_table_names_list);
|
|
List_iterator_fast<ulonglong> it_mode(definition_modes_list);
|
|
uint on_q_table_name_len, before_on_len;
|
|
String buff;
|
|
|
|
DBUG_ASSERT(definitions_list.elements == on_table_names_list.elements &&
|
|
definitions_list.elements == definition_modes_list.elements);
|
|
|
|
while ((def= it_def++))
|
|
{
|
|
on_table_name= it_on_table_name++;
|
|
thd->variables.sql_mode= (ulong) *(it_mode++);
|
|
|
|
/* Construct CREATE TRIGGER statement with new table name. */
|
|
buff.length(0);
|
|
before_on_len= on_table_name->str - def->str;
|
|
buff.append(def->str, before_on_len);
|
|
buff.append(STRING_WITH_LEN("ON "));
|
|
append_identifier(thd, &buff, new_table_name->str, new_table_name->length);
|
|
buff.append(STRING_WITH_LEN(" "));
|
|
on_q_table_name_len= buff.length() - before_on_len;
|
|
buff.append(on_table_name->str + on_table_name->length,
|
|
def->length - (before_on_len + on_table_name->length));
|
|
/*
|
|
It is OK to allocate some memory on table's MEM_ROOT since this
|
|
table instance will be thrown out at the end of rename anyway.
|
|
*/
|
|
new_def.str= (char*) memdup_root(&trigger_table->mem_root, buff.ptr(),
|
|
buff.length());
|
|
new_def.length= buff.length();
|
|
on_table_name->str= new_def.str + before_on_len;
|
|
on_table_name->length= on_q_table_name_len;
|
|
*def= new_def;
|
|
}
|
|
|
|
thd->variables.sql_mode= save_sql_mode;
|
|
|
|
if (thd->is_fatal_error)
|
|
return TRUE; /* OOM */
|
|
|
|
if (save_trigger_file(this, db_name, new_table_name->str))
|
|
return TRUE;
|
|
if (rm_trigger_file(path_buff, db_name, old_table_name->str))
|
|
{
|
|
(void) rm_trigger_file(path_buff, db_name, new_table_name->str);
|
|
return TRUE;
|
|
}
|
|
return FALSE;
|
|
}
|
|
|
|
|
|
/*
|
|
Iterate though Table_triggers_list::names_list list and update .TRN files
|
|
after renaming triggers' subject table.
|
|
|
|
SYNOPSIS
|
|
change_table_name_in_trignames()
|
|
db_name Database of subject table
|
|
new_table_name New subject table's name
|
|
stopper Pointer to Table_triggers_list::names_list at
|
|
which we should stop updating.
|
|
|
|
RETURN VALUE
|
|
0 Success
|
|
non-0 Failure, pointer to Table_triggers_list::names_list element
|
|
for which update failed.
|
|
*/
|
|
|
|
LEX_STRING*
|
|
Table_triggers_list::change_table_name_in_trignames(const char *db_name,
|
|
LEX_STRING *new_table_name,
|
|
LEX_STRING *stopper)
|
|
{
|
|
char trigname_buff[FN_REFLEN];
|
|
struct st_trigname trigname;
|
|
LEX_STRING trigname_file;
|
|
LEX_STRING *trigger;
|
|
List_iterator_fast<LEX_STRING> it_name(names_list);
|
|
|
|
while ((trigger= it_name++) != stopper)
|
|
{
|
|
trigname_file.length= build_table_filename(trigname_buff, FN_REFLEN-1,
|
|
db_name, trigger->str,
|
|
trigname_file_ext, 0);
|
|
trigname_file.str= trigname_buff;
|
|
|
|
trigname.trigger_table= *new_table_name;
|
|
|
|
if (sql_create_definition_file(NULL, &trigname_file, &trigname_file_type,
|
|
(uchar*)&trigname, trigname_file_parameters,
|
|
0))
|
|
return trigger;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
/*
|
|
Update .TRG and .TRN files after renaming triggers' subject table.
|
|
|
|
SYNOPSIS
|
|
change_table_name()
|
|
thd Thread context
|
|
db Old database of subject table
|
|
old_table Old name of subject table
|
|
new_db New database for subject table
|
|
new_table New name of subject table
|
|
|
|
NOTE
|
|
This method tries to leave trigger related files in consistent state,
|
|
i.e. it either will complete successfully, or will fail leaving files
|
|
in their initial state.
|
|
Also this method assumes that subject table is not renamed to itself.
|
|
|
|
RETURN VALUE
|
|
FALSE Success
|
|
TRUE Error
|
|
*/
|
|
|
|
bool Table_triggers_list::change_table_name(THD *thd, const char *db,
|
|
const char *old_table,
|
|
const char *new_db,
|
|
const char *new_table)
|
|
{
|
|
TABLE table;
|
|
bool result= 0;
|
|
LEX_STRING *err_trigname;
|
|
DBUG_ENTER("change_table_name");
|
|
|
|
bzero(&table, sizeof(table));
|
|
init_alloc_root(&table.mem_root, 8192, 0);
|
|
|
|
safe_mutex_assert_owner(&LOCK_open);
|
|
|
|
DBUG_ASSERT(my_strcasecmp(table_alias_charset, db, new_db) ||
|
|
my_strcasecmp(table_alias_charset, old_table, new_table));
|
|
|
|
if (Table_triggers_list::check_n_load(thd, db, old_table, &table, TRUE))
|
|
{
|
|
result= 1;
|
|
goto end;
|
|
}
|
|
if (table.triggers)
|
|
{
|
|
LEX_STRING old_table_name= { (char *) old_table, strlen(old_table) };
|
|
LEX_STRING new_table_name= { (char *) new_table, strlen(new_table) };
|
|
/*
|
|
Since triggers should be in the same schema as their subject tables
|
|
moving table with them between two schemas raises too many questions.
|
|
(E.g. what should happen if in new schema we already have trigger
|
|
with same name ?).
|
|
*/
|
|
if (my_strcasecmp(table_alias_charset, db, new_db))
|
|
{
|
|
my_error(ER_TRG_IN_WRONG_SCHEMA, MYF(0));
|
|
result= 1;
|
|
goto end;
|
|
}
|
|
if (table.triggers->change_table_name_in_triggers(thd, db,
|
|
&old_table_name,
|
|
&new_table_name))
|
|
{
|
|
result= 1;
|
|
goto end;
|
|
}
|
|
if ((err_trigname= table.triggers->change_table_name_in_trignames(
|
|
db, &new_table_name, 0)))
|
|
{
|
|
/*
|
|
If we were unable to update one of .TRN files properly we will
|
|
revert all changes that we have done and report about error.
|
|
We assume that we will be able to undo our changes without errors
|
|
(we can't do much if there will be an error anyway).
|
|
*/
|
|
(void) table.triggers->change_table_name_in_trignames(db,
|
|
&old_table_name,
|
|
err_trigname);
|
|
(void) table.triggers->change_table_name_in_triggers(thd, db,
|
|
&new_table_name,
|
|
&old_table_name);
|
|
result= 1;
|
|
goto end;
|
|
}
|
|
}
|
|
end:
|
|
delete table.triggers;
|
|
free_root(&table.mem_root, MYF(0));
|
|
DBUG_RETURN(result);
|
|
}
|
|
|
|
|
|
bool Table_triggers_list::process_triggers(THD *thd, trg_event_type event,
|
|
trg_action_time_type time_type,
|
|
bool old_row_is_record1)
|
|
{
|
|
bool err_status= FALSE;
|
|
sp_head *sp_trigger= bodies[event][time_type];
|
|
|
|
if (sp_trigger)
|
|
{
|
|
Sub_statement_state statement_state;
|
|
|
|
if (old_row_is_record1)
|
|
{
|
|
old_field= record1_field;
|
|
new_field= trigger_table->field;
|
|
}
|
|
else
|
|
{
|
|
new_field= record1_field;
|
|
old_field= trigger_table->field;
|
|
}
|
|
#ifndef NO_EMBEDDED_ACCESS_CHECKS
|
|
Security_context *sctx= &sp_trigger->m_security_ctx;
|
|
Security_context *save_ctx= NULL;
|
|
|
|
|
|
if (sp_trigger->m_chistics->suid != SP_IS_NOT_SUID &&
|
|
sctx->change_security_context(thd,
|
|
&sp_trigger->m_definer_user,
|
|
&sp_trigger->m_definer_host,
|
|
&sp_trigger->m_db,
|
|
&save_ctx))
|
|
return TRUE;
|
|
|
|
/*
|
|
Fetch information about table-level privileges to GRANT_INFO structure for
|
|
subject table. Check of privileges that will use it and information about
|
|
column-level privileges will happen in Item_trigger_field::fix_fields().
|
|
*/
|
|
|
|
fill_effective_table_privileges(thd,
|
|
&subject_table_grants[event][time_type],
|
|
trigger_table->s->db.str,
|
|
trigger_table->s->table_name.str);
|
|
|
|
/* Check that the definer has TRIGGER privilege on the subject table. */
|
|
|
|
if (!(subject_table_grants[event][time_type].privilege & TRIGGER_ACL))
|
|
{
|
|
char priv_desc[128];
|
|
get_privilege_desc(priv_desc, sizeof(priv_desc), TRIGGER_ACL);
|
|
|
|
my_error(ER_TABLEACCESS_DENIED_ERROR, MYF(0), priv_desc,
|
|
thd->security_ctx->priv_user, thd->security_ctx->host_or_ip,
|
|
trigger_table->s->table_name.str);
|
|
|
|
sctx->restore_security_context(thd, save_ctx);
|
|
return TRUE;
|
|
}
|
|
#endif // NO_EMBEDDED_ACCESS_CHECKS
|
|
|
|
thd->reset_sub_statement_state(&statement_state, SUB_STMT_TRIGGER);
|
|
err_status= sp_trigger->execute_trigger
|
|
(thd, trigger_table->s->db.str, trigger_table->s->table_name.str,
|
|
&subject_table_grants[event][time_type]);
|
|
thd->restore_sub_statement_state(&statement_state);
|
|
|
|
#ifndef NO_EMBEDDED_ACCESS_CHECKS
|
|
sctx->restore_security_context(thd, save_ctx);
|
|
#endif // NO_EMBEDDED_ACCESS_CHECKS
|
|
}
|
|
|
|
return err_status;
|
|
}
|
|
|
|
|
|
/*
|
|
Mark fields of subject table which we read/set in its triggers as such.
|
|
|
|
SYNOPSIS
|
|
mark_fields_used()
|
|
thd Current thread context
|
|
event Type of event triggers for which we are going to inspect
|
|
|
|
DESCRIPTION
|
|
This method marks fields of subject table which are read/set in its
|
|
triggers as such (by properly updating TABLE::read_set/write_set)
|
|
and thus informs handler that values for these fields should be
|
|
retrieved/stored during execution of statement.
|
|
*/
|
|
|
|
void Table_triggers_list::mark_fields_used(trg_event_type event)
|
|
{
|
|
int action_time;
|
|
Item_trigger_field *trg_field;
|
|
|
|
for (action_time= 0; action_time < (int)TRG_ACTION_MAX; action_time++)
|
|
{
|
|
for (trg_field= trigger_fields[event][action_time]; trg_field;
|
|
trg_field= trg_field->next_trg_field)
|
|
{
|
|
/* We cannot mark fields which does not present in table. */
|
|
if (trg_field->field_idx != (uint)-1)
|
|
{
|
|
bitmap_set_bit(trigger_table->read_set, trg_field->field_idx);
|
|
if (trg_field->get_settable_routine_parameter())
|
|
bitmap_set_bit(trigger_table->write_set, trg_field->field_idx);
|
|
}
|
|
}
|
|
}
|
|
trigger_table->file->column_bitmaps_signal();
|
|
}
|
|
|
|
|
|
/*
|
|
Trigger BUG#14090 compatibility hook
|
|
|
|
SYNOPSIS
|
|
Handle_old_incorrect_sql_modes_hook::process_unknown_string()
|
|
unknown_key [in/out] reference on the line with unknown
|
|
parameter and the parsing point
|
|
base [in] base address for parameter writing (structure
|
|
like TABLE)
|
|
mem_root [in] MEM_ROOT for parameters allocation
|
|
end [in] the end of the configuration
|
|
|
|
NOTE: this hook process back compatibility for incorrectly written
|
|
sql_modes parameter (see BUG#14090).
|
|
|
|
RETURN
|
|
FALSE OK
|
|
TRUE Error
|
|
*/
|
|
|
|
#define INVALID_SQL_MODES_LENGTH 13
|
|
|
|
bool
|
|
Handle_old_incorrect_sql_modes_hook::process_unknown_string(char *&unknown_key,
|
|
uchar* base,
|
|
MEM_ROOT *mem_root,
|
|
char *end)
|
|
{
|
|
DBUG_ENTER("Handle_old_incorrect_sql_modes_hook::process_unknown_string");
|
|
DBUG_PRINT("info", ("unknown key: %60s", unknown_key));
|
|
|
|
if (unknown_key + INVALID_SQL_MODES_LENGTH + 1 < end &&
|
|
unknown_key[INVALID_SQL_MODES_LENGTH] == '=' &&
|
|
!memcmp(unknown_key, STRING_WITH_LEN("sql_modes")))
|
|
{
|
|
char *ptr= unknown_key + INVALID_SQL_MODES_LENGTH + 1;
|
|
|
|
DBUG_PRINT("info", ("sql_modes affected by BUG#14090 detected"));
|
|
push_warning_printf(current_thd,
|
|
MYSQL_ERROR::WARN_LEVEL_NOTE,
|
|
ER_OLD_FILE_FORMAT,
|
|
ER(ER_OLD_FILE_FORMAT),
|
|
(char *)path, "TRIGGER");
|
|
if (get_file_options_ulllist(ptr, end, unknown_key, base,
|
|
&sql_modes_parameters, mem_root))
|
|
{
|
|
DBUG_RETURN(TRUE);
|
|
}
|
|
/*
|
|
Set parsing pointer to the last symbol of string (\n)
|
|
1) to avoid problem with \0 in the junk after sql_modes
|
|
2) to speed up skipping this line by parser.
|
|
*/
|
|
unknown_key= ptr-1;
|
|
}
|
|
DBUG_RETURN(FALSE);
|
|
}
|
|
|
|
/*
|
|
Trigger BUG#15921 compatibility hook. For details see
|
|
Handle_old_incorrect_sql_modes_hook::process_unknown_string().
|
|
*/
|
|
|
|
#define INVALID_TRIGGER_TABLE_LENGTH 15
|
|
|
|
bool
|
|
Handle_old_incorrect_trigger_table_hook::
|
|
process_unknown_string(char *&unknown_key, uchar* base, MEM_ROOT *mem_root,
|
|
char *end)
|
|
{
|
|
DBUG_ENTER("Handle_old_incorrect_trigger_table_hook::process_unknown_string");
|
|
DBUG_PRINT("info", ("unknown key: %60s", unknown_key));
|
|
|
|
if (unknown_key + INVALID_TRIGGER_TABLE_LENGTH + 1 < end &&
|
|
unknown_key[INVALID_TRIGGER_TABLE_LENGTH] == '=' &&
|
|
!memcmp(unknown_key, STRING_WITH_LEN("trigger_table")))
|
|
{
|
|
char *ptr= unknown_key + INVALID_TRIGGER_TABLE_LENGTH + 1;
|
|
|
|
DBUG_PRINT("info", ("trigger_table affected by BUG#15921 detected"));
|
|
push_warning_printf(current_thd,
|
|
MYSQL_ERROR::WARN_LEVEL_NOTE,
|
|
ER_OLD_FILE_FORMAT,
|
|
ER(ER_OLD_FILE_FORMAT),
|
|
(char *)path, "TRIGGER");
|
|
|
|
if (!(ptr= parse_escaped_string(ptr, end, mem_root, trigger_table_value)))
|
|
{
|
|
my_error(ER_FPARSER_ERROR_IN_PARAMETER, MYF(0), "trigger_table",
|
|
unknown_key);
|
|
DBUG_RETURN(TRUE);
|
|
}
|
|
|
|
/* Set parsing pointer to the last symbol of string (\n). */
|
|
unknown_key= ptr-1;
|
|
}
|
|
DBUG_RETURN(FALSE);
|
|
}
|