mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 05:52:27 +01:00
ed9e73077d
Main problem: mysql 5.1 cannot read binlogs from 4.1. Subproblem 1: There is a mistake in sql_ex_info::init. The read_str() function updates its first argument to point to the next character to read. However, it is applied only to a copy of the buffer pointer, so the real buffer pointer is not updated. Fix 1: do not take a copy of the buffer pointer. The copy was needed because sql_ex_info::init does not use the const attribute on some of its arguments. So we add the const attribute, too. Subproblem 2: The first BINLOG statement is asserted to be a FORMAT_DESCRIPTION_LOG_EVENT, but 4.1 binlogs begin with START_EVENT_V3. Fix 2: allow START_EVENT_V3 too. mysql-test/suite/binlog/std_data/binlog_old_version_4_1.000001: New BitKeeper file ``mysql-test/suite/binlog/std_data/binlog_old_version_4_1.000001'' mysql-test/suite/binlog/r/binlog_old_versions.result: Updated result file. mysql-test/suite/binlog/t/binlog_old_versions.test: Added a test reading an old 4.1 binlog. sql/log_event.cc: 1. Added const keyword at the following places: - input buffer for pretty_print_str - input buffer for write_str - input buffer, end pointer, and return value from sql_ex_info::init 2. Fixed the bug by not taking a copy of buf before calling read_str in sql_ex_info::init(). sql/log_event.h: Added const keyword to fields of the sql_ex_info struct. Added const keyword to arguments and return value of sql_ex_info::init sql/sql_binlog.cc: The first BINLOG statement must describe the format for future BINLOG statements. Otherwise, we do not know how to read the BINLOG statement. Problem: only FORMAT_DESCRIPTION_EVENT is currently allowed as the first event. Binlogs from 4.1 begin with a START_EVENT_V3, which serves the same purpose. Fix: We now allow the first BINLOG statement to be a START_EVENT_V3, as well as a FORMAT_DESCRIPTION_EVENT.
71 lines
1.3 KiB
Text
71 lines
1.3 KiB
Text
DROP TABLE IF EXISTS t1, t2, t3;
|
|
==== Read modern binlog (version 5.1.23) ====
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a b
|
|
0 last_insert_id
|
|
1 one
|
|
3 last stm in trx: next event should be xid
|
|
4 four
|
|
674568 random
|
|
SELECT * FROM t2 ORDER BY a;
|
|
a b
|
|
3 first stm in trx
|
|
SELECT COUNT(*) FROM t3;
|
|
COUNT(*)
|
|
17920
|
|
DROP TABLE t1, t2, t3;
|
|
==== Read binlog from version 5.1.17 ====
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a b
|
|
0 last_insert_id
|
|
1 one
|
|
3 last stm in trx: next event should be xid
|
|
4 four
|
|
764247 random
|
|
SELECT * FROM t2 ORDER BY a;
|
|
a b
|
|
3 first stm in trx
|
|
SELECT COUNT(*) FROM t3;
|
|
COUNT(*)
|
|
17920
|
|
DROP TABLE t1, t2, t3;
|
|
==== Read binlog from version 4.1 ====
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a b
|
|
0 last_insert_id
|
|
4 four
|
|
190243 random
|
|
SELECT COUNT(*) FROM t3;
|
|
COUNT(*)
|
|
17920
|
|
DROP TABLE t1, t3;
|
|
==== Read binlog from alcatel tree (mysql-5.1-wl2325-5.0-drop6) ====
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a b
|
|
0 last_insert_id
|
|
1 one
|
|
3 last stm in trx: next event should be xid
|
|
4 four
|
|
781729 random
|
|
SELECT * FROM t2 ORDER BY a;
|
|
a b
|
|
3 first stm in trx
|
|
SELECT COUNT(*) FROM t3;
|
|
COUNT(*)
|
|
17920
|
|
DROP TABLE t1, t2, t3;
|
|
==== Read binlog from ndb tree (mysql-5.1-telco-6.1) ====
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a b
|
|
0 last_insert_id
|
|
1 one
|
|
3 last stm in trx: next event should be xid
|
|
4 four
|
|
703356 random
|
|
SELECT * FROM t2 ORDER BY a;
|
|
a b
|
|
3 first stm in trx
|
|
SELECT COUNT(*) FROM t3;
|
|
COUNT(*)
|
|
17920
|
|
DROP TABLE t1, t2, t3;
|