mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
e52ec3e6d5
Triggers in SBR mode." BUG#14914 "SP: Uses of session variables in routines are not always replicated" BUG#25167 "Dupl. usage of user-variables in trigger/function is not replicated correctly" User-defined variables used inside of stored functions/triggers in statements which did not update tables directly were not replicated. We also had problems with replication of user-defined variables which were used in triggers (or stored functions called from table-updating statements) more than once. This patch addresses the first issue by enabling logging of all references to user-defined variables in triggers/stored functions and not only references from table-updating statements. The second issue stemmed from the fact that for user-defined variables used from triggers or stored functions called from table-updating statements we were writing binlog events for each reference instead of only one event for the first reference. This problem is already solved for stored functions called from non-updating statements with help of "event unioning" mechanism. So the patch simply extends this mechanism to the case affected. It also fixes small problem in this mechanism which caused wrong logging of references to user-variables in cases when non-updating statement called several stored functions which used the same variable and some of these function calls were omitted from binlog as they were not updating any tables. mysql-test/r/rpl_user_variables.result: BUG#20141 - User-defined variables are not replicated properly for SF/Triggers in SBR mode. This patch adds the correct results for execution of the added test procedures to the rpl_user_variables test. mysql-test/t/rpl_user_variables.test: BUG#20141 - User-defined variables are not replicated properly for SF/Triggers in SBR mode. This patch adds additional tests to the rpl_user_variables test that test many of the different ways user-defined variables can be required to be replicated. sql/item_func.cc: BUG#20141 - User-defined variables are not replicated properly for SF/Triggers in SBR mode. To properly log accesses to user-defined variables from stored functions/triggers, the get_var_with_binlog() method needs to log references to such variables even from non-table-updating statements within them. sql/log.cc: BUG#20141 - User-defined variables are not replicated properly for SF/Triggers in SBR mode. This patch modifies the start_union_events method to accept the query id from a parameter. This allows callers to set the query_id to the id of the sub statement such as a trigger or stored function. Which permits the code to identify when a user defined variable has been used by the statement and this already present in THD::user_var_event. Note: The changes to sql_class.cc, sp_head.cc, and log.cc are designed to allow the proper replication of access to user-defined variables under a special test case (the last case shown in rpl_user_variables.test). sql/sp_head.cc: BUG#20141 - User-defined variables are not replicated properly for SF/Triggers in SBR mode. This patch modifies the code to allow for cases where events for function calls have a separate union for each event and thus cannot use the query_id of the caller as the start of the union. Thus, we use an artifically created query_id to set the start of the events. Note: The changes to sql_class.cc, sp_head.cc, and log.cc are designed to allow the proper replication of access to user-defined variables under a special test case (the last case shown in rpl_user_variables.test). sql/sql_class.cc: BUG#20141 - User-defined variables are not replicated properly for SF/Triggers in SBR mode. This patch adds the query_id parameter to the calls to mysql_bin_log.start_union_events(). Note: The changes to sql_class.cc, sp_head.cc, and log.cc are designed to allow the proper replication of access to user-defined variables under a special test case (the last case shown in rpl_user_variables.test). sql/sql_class.h: BUG#20141 - User-defined variables are not replicated properly for SF/Triggers in SBR mode. This patch adds the query_id parameter to the calls to mysql_bin_log.start_union_events().
361 lines
8.6 KiB
Text
361 lines
8.6 KiB
Text
#
|
|
# Test of replicating user variables
|
|
#
|
|
source include/master-slave.inc;
|
|
# Disable PS as the log positions differs
|
|
--disable_ps_protocol
|
|
|
|
|
|
# Clean up old slave's binlogs.
|
|
# The slave is started with --log-slave-updates
|
|
# and this test does SHOW BINLOG EVENTS on the slave's
|
|
# binlog. But previous tests can influence the current test's
|
|
# binlog (e.g. a temporary table in the previous test has not
|
|
# been explicitly deleted, or it has but the slave hasn't had
|
|
# enough time to catch it before STOP SLAVE,
|
|
# and at the beginning of the current
|
|
# test the slave immediately writes DROP TEMPORARY TABLE this_old_table).
|
|
# We wait for the slave to have written all he wants to the binlog
|
|
# (otherwise RESET MASTER may come too early).
|
|
save_master_pos;
|
|
connection slave;
|
|
sync_with_master;
|
|
reset master;
|
|
connection master;
|
|
|
|
create table t1(n char(30));
|
|
set @i1:=12345678901234, @i2:=-12345678901234, @i3:=0, @i4:=-1;
|
|
set @s1:='This is a test', @r1:=12.5, @r2:=-12.5;
|
|
set @n1:=null;
|
|
set @s2:='', @s3:='abc\'def', @s4:= 'abc\\def', @s5:= 'abc''def';
|
|
insert into t1 values (@i1), (@i2), (@i3), (@i4);
|
|
insert into t1 values (@r1), (@r2);
|
|
insert into t1 values (@s1), (@s2), (@s3), (@s4), (@s5);
|
|
insert into t1 values (@n1);
|
|
insert into t1 values (@n2); # not explicitely set before
|
|
insert into t1 values (@a:=0), (@a:=@a+1), (@a:=@a+1);
|
|
insert into t1 values (@a+(@b:=@a+1));
|
|
set @q:='abc';
|
|
insert t1 values (@q), (@q:=concat(@q, 'n1')), (@q:=concat(@q, 'n2'));
|
|
set @a:=5;
|
|
insert into t1 values (@a),(@a);
|
|
connection master1; # see if variable is reset in binlog when thread changes
|
|
insert into t1 values (@a),(@a),(@a*5);
|
|
select * from t1;
|
|
save_master_pos;
|
|
connection slave;
|
|
sync_with_master;
|
|
select * from t1;
|
|
--replace_column 2 # 5 #
|
|
show binlog events from 98;
|
|
#
|
|
# BUG19136: Crashing log-bin and uninitialized user variables in a derived table
|
|
# just to check nothing bad happens anymore
|
|
#
|
|
connection master;
|
|
insert into t1 select * FROM (select @var1 union select @var2) AS t2;
|
|
drop table t1;
|
|
save_master_pos;
|
|
|
|
--echo End of 4.1 tests.
|
|
|
|
# BUG#20141
|
|
# The following tests ensure that if user-defined variables are used in SF/Triggers
|
|
# that they are replicated correctly. These tests should be run in both SBR and RBR
|
|
# modes.
|
|
|
|
# This test uses a procedure that inserts data values based on the value of a
|
|
# user-defined variable. It also has a trigger that inserts data based on the
|
|
# same variable. Successful test runs show that the @var is replicated
|
|
# properly and that the procedure and trigger insert the correct data on the
|
|
# slave.
|
|
#
|
|
# The test of stored procedure was included for completeness. Replication of stored
|
|
# procedures was not directly affected by BUG#20141.
|
|
#
|
|
# This test was constructed for BUG#20141
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t20;
|
|
DROP TABLE IF EXISTS t21;
|
|
DROP PROCEDURE IF EXISTS test.insert;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t20 (a VARCHAR(20));
|
|
CREATE TABLE t21 (a VARCHAR(20));
|
|
DELIMITER |;
|
|
|
|
# Create a procedure that uses the @var for flow control
|
|
|
|
CREATE PROCEDURE test.insert()
|
|
BEGIN
|
|
IF (@VAR)
|
|
THEN
|
|
INSERT INTO test.t20 VALUES ('SP_TRUE');
|
|
ELSE
|
|
INSERT INTO test.t20 VALUES ('SP_FALSE');
|
|
END IF;
|
|
END|
|
|
|
|
# Create a trigger that uses the @var for flow control
|
|
|
|
CREATE TRIGGER test.insert_bi BEFORE INSERT
|
|
ON test.t20 FOR EACH ROW
|
|
BEGIN
|
|
IF (@VAR)
|
|
THEN
|
|
INSERT INTO test.t21 VALUES ('TRIG_TRUE');
|
|
ELSE
|
|
INSERT INTO test.t21 VALUES ('TRIG_FALSE');
|
|
END IF;
|
|
END|
|
|
DELIMITER ;|
|
|
|
|
sync_slave_with_master;
|
|
connection master;
|
|
|
|
# Set @var and call the procedure, repeat with different values
|
|
|
|
SET @VAR=0;
|
|
CALL test.insert();
|
|
SET @VAR=1;
|
|
CALL test.insert();
|
|
|
|
--echo On master: Check the tables for correct data
|
|
|
|
SELECT * FROM t20;
|
|
SELECT * FROM t21;
|
|
|
|
sync_slave_with_master;
|
|
|
|
--echo On slave: Check the tables for correct data and it matches master
|
|
|
|
SELECT * FROM t20;
|
|
SELECT * FROM t21;
|
|
connection master;
|
|
|
|
# Cleanup
|
|
|
|
DROP TABLE t20;
|
|
DROP TABLE t21;
|
|
DROP PROCEDURE test.insert;
|
|
|
|
# This test uses a stored function that uses user-defined variables to return data
|
|
# This test was constructed for BUG#20141
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP FUNCTION IF EXISTS test.square;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t1 (i INT);
|
|
|
|
# Create function that returns a value from @var. In this case, the square function
|
|
|
|
CREATE FUNCTION test.square() RETURNS INTEGER DETERMINISTIC RETURN (@var * @var);
|
|
|
|
sync_slave_with_master;
|
|
connection master;
|
|
|
|
# Set the @var to different values and insert them into a table
|
|
|
|
SET @var = 1;
|
|
INSERT INTO t1 VALUES (square());
|
|
SET @var = 2;
|
|
INSERT INTO t1 VALUES (square());
|
|
SET @var = 3;
|
|
INSERT INTO t1 VALUES (square());
|
|
SET @var = 4;
|
|
INSERT INTO t1 VALUES (square());
|
|
SET @var = 5;
|
|
INSERT INTO t1 VALUES (square());
|
|
|
|
--echo On master: Retrieve the values from the table
|
|
|
|
SELECT * FROM t1;
|
|
|
|
sync_slave_with_master;
|
|
|
|
--echo On slave: Retrieve the values from the table and verify they are the same as on master
|
|
|
|
SELECT * FROM t1;
|
|
|
|
connection master;
|
|
|
|
# Cleanup
|
|
|
|
DROP TABLE t1;
|
|
DROP FUNCTION test.square;
|
|
|
|
# This test uses stored functions that uses user-defined variables to return data
|
|
# based on the use of @vars inside a function body.
|
|
# This test was constructed for BUG#14914
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP FUNCTION IF EXISTS f1;
|
|
DROP FUNCTION IF EXISTS f2;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t1(a int);
|
|
DELIMITER |;
|
|
|
|
# Create a function that simply returns the value of an @var.
|
|
# Create a function that uses an @var for flow control, creates and uses another
|
|
# @var and sets its value to a value based on another @var.
|
|
|
|
CREATE FUNCTION f1() returns int deterministic
|
|
BEGIN
|
|
return @a;
|
|
END |
|
|
|
|
CREATE FUNCTION f2() returns int deterministic
|
|
BEGIN
|
|
IF (@b > 0) then
|
|
SET @c = (@a + @b);
|
|
else
|
|
SET @c = (@a - 1);
|
|
END if;
|
|
return @c;
|
|
END |
|
|
DELIMITER ;|
|
|
|
|
sync_slave_with_master;
|
|
connection master;
|
|
|
|
# Set an @var to a value and insert data into a table using the first function.
|
|
# Set two more @vars to some values and insert data into a table using the second function.
|
|
|
|
SET @a=500;
|
|
INSERT INTO t1 values(f1());
|
|
SET @b = 125;
|
|
SET @c = 1;
|
|
INSERT INTO t1 values(f2());
|
|
|
|
sync_slave_with_master;
|
|
|
|
--echo On master: Retrieve the values from the table
|
|
|
|
SELECT * from t1;
|
|
|
|
--echo On slave: Check the tables for correct data and it matches master
|
|
|
|
SELECT * from t1;
|
|
|
|
connection master;
|
|
|
|
# Cleanup
|
|
|
|
DROP TABLE t1;
|
|
DROP FUNCTION f1;
|
|
DROP FUNCTION f2;
|
|
|
|
# This test uses a function that changes a user-defined variable in its body. This test
|
|
# will ensure the @vars are replicated when needed and not interrupt the normal execution
|
|
# of the function on the slave. This also applies to triggers.
|
|
#
|
|
# This test was constructed for BUG#25167
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP TABLE IF EXISTS t2;
|
|
--enable_warnings
|
|
CREATE TABLE t1 (i int);
|
|
CREATE TABLE t2 (k int);
|
|
DELIMITER |;
|
|
|
|
# Create a trigger that inserts data into another table, changes the @var then inserts
|
|
# another row with the modified value.
|
|
|
|
CREATE trigger t1_bi before INSERT on t1 for each row
|
|
BEGIN
|
|
INSERT INTO t2 values (@a);
|
|
SET @a:=42;
|
|
INSERT INTO t2 values (@a);
|
|
END |
|
|
DELIMITER ;|
|
|
|
|
sync_slave_with_master;
|
|
connection master;
|
|
|
|
# Set the @var to a value then insert data into first table.
|
|
|
|
SET @a:=100;
|
|
INSERT INTO t1 values (5);
|
|
|
|
--echo On master: Check to see that data was inserted correctly in both tables
|
|
|
|
SELECT * from t1;
|
|
SELECT * from t2;
|
|
|
|
sync_slave_with_master;
|
|
|
|
--echo On slave: Check the tables for correct data and it matches master
|
|
|
|
SELECT * from t1;
|
|
SELECT * from t2;
|
|
|
|
connection master;
|
|
|
|
--echo End of 5.0 tests.
|
|
|
|
# Cleanup
|
|
|
|
DROP TABLE t1;
|
|
DROP TABLE t2;
|
|
|
|
# This test uses a stored function that uses user-defined variables to return data
|
|
# The test ensures the value of the user-defined variable is replicated correctly
|
|
# and in the correct order of assignment.
|
|
# This test was constructed for BUG#20141
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP FUNCTION IF EXISTS f1;
|
|
DROP FUNCTION IF EXISTS f2;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t1 (i INT);
|
|
|
|
# Create two functions. One simply returns the user-defined variable. The other
|
|
# returns a value based on the user-defined variable.
|
|
|
|
CREATE FUNCTION f1() RETURNS INT RETURN @a;
|
|
DELIMITER |;
|
|
CREATE FUNCTION f2() RETURNS INT
|
|
BEGIN
|
|
INSERT INTO t1 VALUES (10 + @a);
|
|
RETURN 0;
|
|
END|
|
|
DELIMITER ;|
|
|
|
|
sync_slave_with_master;
|
|
connection master;
|
|
|
|
# Set the variable and execute the functions.
|
|
|
|
SET @a:=123;
|
|
SELECT f1(), f2();
|
|
|
|
--echo On master: Check to see that data was inserted correctly
|
|
|
|
INSERT INTO t1 VALUES(f1());
|
|
SELECT * FROM t1;
|
|
|
|
sync_slave_with_master;
|
|
|
|
--echo On slave: Check the table for correct data and it matches master
|
|
|
|
SELECT * FROM t1;
|
|
|
|
connection master;
|
|
|
|
# Cleanup
|
|
|
|
DROP FUNCTION f1;
|
|
DROP FUNCTION f2;
|
|
DROP TABLE t1;
|
|
|
|
sync_slave_with_master;
|
|
stop slave;
|
|
|