mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
031f11717d
The easiest way to compile and test the server with UBSAN is to run: ./BUILD/compile-pentium64-ubsan and then run mysql-test-run. After this commit, one should be able to run this without any UBSAN warnings. There is still a few compiler warnings that should be fixed at some point, but these do not expose any real bugs. The 'special' cases where we disable, suppress or circumvent UBSAN are: - ref10 source (as here we intentionally do some shifts that UBSAN complains about. - x86 version of optimized int#korr() methods. UBSAN do not like unaligned memory access of integers. Fixed by using byte_order_generic.h when compiling with UBSAN - We use smaller thread stack with ASAN and UBSAN, which forced me to disable a few tests that prints the thread stack size. - Verifying class types does not work for shared libraries. I added suppression in mysql-test-run.pl for this case. - Added '#ifdef WITH_UBSAN' when using integer arithmetic where it is safe to have overflows (two cases, in item_func.cc). Things fixed: - Don't left shift signed values (byte_order_generic.h, mysqltest.c, item_sum.cc and many more) - Don't assign not non existing values to enum variables. - Ensure that bool and enum values are properly initialized in constructors. This was needed as UBSAN checks that these types has correct values when one copies an object. (gcalc_tools.h, ha_partition.cc, item_sum.cc, partition_element.h ...) - Ensure we do not called handler functions on unallocated objects or deleted objects. (events.cc, sql_acl.cc). - Fixed bugs in Item_sp::Item_sp() where we did not call constructor on Query_arena object. - Fixed several cast of objects to an incompatible class! (Item.cc, Item_buff.cc, item_timefunc.cc, opt_subselect.cc, sql_acl.cc, sql_select.cc ...) - Ensure we do not do integer arithmetic that causes over or underflows. This includes also ++ and -- of integers. (Item_func.cc, Item_strfunc.cc, item_timefunc.cc, sql_base.cc ...) - Added JSON_VALUE_UNITIALIZED to json_value_types and ensure that value_type is initialized to this instead of to -1, which is not a valid enum value for json_value_types. - Ensure we do not call memcpy() when second argument could be null. - Fixed that Item_func_str::make_empty_result() creates an empty string instead of a null string (safer as it ensures we do not do arithmetic on null strings). Other things: - Changed struct st_position to an OBJECT and added an initialization function to it to ensure that we do not copy or use uninitialized members. The change to a class was also motived that we used "struct st_position" and POSITION randomly trough the code which was confusing. - Notably big rewrite in sql_acl.cc to avoid using deleted objects. - Changed in sql_partition to use '^' instead of '-'. This is safe as the operator is either 0 or 0x8000000000000000ULL. - Added check for select_nr < INT_MAX in JOIN::build_explain() to avoid bug when get_select() could return NULL. - Reordered elements in POSITION for better alignment. - Changed sql_test.cc::print_plan() to use pointers instead of objects. - Fixed bug in find_set() where could could execute '1 << -1'. - Added variable have_sanitizer, used by mtr. (This variable was before only in 10.5 and up). It can now have one of two values: ASAN or UBSAN. - Moved ~Archive_share() from ha_archive.cc to ha_archive.h and marked it virtual. This was an effort to get UBSAN to work with loaded storage engines. I kept the change as the new place is better. - Added in CONNECT engine COLBLK::SetName(), to get around a wrong cast in tabutil.cpp. - Added HAVE_REPLICATION around usage of rgi_slave, to get embedded server to compile with UBSAN. (Patch from Marko). - Added #ifdef for powerpc64 to avoid a bug in old gcc versions related to integer arithmetic. Changes that should not be needed but had to be done to suppress warnings from UBSAN: - Added static_cast<<uint16_t>> around shift to get rid of a LOT of compiler warnings when using UBSAN. - Had to change some '/' of 2 base integers to shift to get rid of some compile time warnings. Reviewed by: - Json changes: Alexey Botchkov - Charset changes in ctype-uca.c: Alexander Barkov - InnoDB changes & Embedded server: Marko Mäkelä - sql_acl.cc changes: Vicențiu Ciorbaru - build_explain() changes: Sergey Petrunia
173 lines
5.1 KiB
C++
173 lines
5.1 KiB
C++
#ifndef PARTITION_ELEMENT_INCLUDED
|
|
#define PARTITION_ELEMENT_INCLUDED
|
|
|
|
/* Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
|
|
|
|
#include "my_base.h" /* ha_rows */
|
|
#include "handler.h" /* UNDEF_NODEGROUP */
|
|
|
|
/**
|
|
* An enum and a struct to handle partitioning and subpartitioning.
|
|
*/
|
|
enum partition_type {
|
|
NOT_A_PARTITION= 0,
|
|
RANGE_PARTITION,
|
|
HASH_PARTITION,
|
|
LIST_PARTITION,
|
|
VERSIONING_PARTITION
|
|
};
|
|
|
|
enum partition_state {
|
|
PART_NORMAL= 0,
|
|
PART_IS_DROPPED= 1,
|
|
PART_TO_BE_DROPPED= 2,
|
|
PART_TO_BE_ADDED= 3,
|
|
PART_TO_BE_REORGED= 4,
|
|
PART_REORGED_DROPPED= 5,
|
|
PART_CHANGED= 6,
|
|
PART_IS_CHANGED= 7,
|
|
PART_IS_ADDED= 8,
|
|
PART_ADMIN= 9
|
|
};
|
|
|
|
/*
|
|
This struct is used to keep track of column expressions as part
|
|
of the COLUMNS concept in conjunction with RANGE and LIST partitioning.
|
|
The value can be either of MINVALUE, MAXVALUE and an expression that
|
|
must be constant and evaluate to the same type as the column it
|
|
represents.
|
|
|
|
The data in this fixed in two steps. The parser will only fill in whether
|
|
it is a max_value or provide an expression. Filling in
|
|
column_value, part_info, partition_id, null_value is done by the
|
|
function fix_column_value_function. However the item tree needs
|
|
fixed also before writing it into the frm file (in add_column_list_values).
|
|
To distinguish between those two variants, fixed= 1 after the
|
|
fixing in add_column_list_values and fixed= 2 otherwise. This is
|
|
since the fixing in add_column_list_values isn't a complete fixing.
|
|
*/
|
|
|
|
typedef struct p_column_list_val
|
|
{
|
|
void* column_value;
|
|
Item* item_expression;
|
|
partition_info *part_info;
|
|
uint partition_id;
|
|
bool max_value; // MAXVALUE for RANGE type or DEFAULT value for LIST type
|
|
bool null_value;
|
|
char fixed;
|
|
} part_column_list_val;
|
|
|
|
|
|
/*
|
|
This struct is used to contain the value of an element
|
|
in the VALUES IN struct. It needs to keep knowledge of
|
|
whether it is a signed/unsigned value and whether it is
|
|
NULL or not.
|
|
*/
|
|
|
|
typedef struct p_elem_val
|
|
{
|
|
longlong value;
|
|
uint added_items;
|
|
bool null_value;
|
|
bool unsigned_flag;
|
|
part_column_list_val *col_val_array;
|
|
} part_elem_value;
|
|
|
|
struct st_ddl_log_memory_entry;
|
|
|
|
enum stat_trx_field
|
|
{
|
|
STAT_TRX_END= 0
|
|
};
|
|
|
|
class partition_element :public Sql_alloc
|
|
{
|
|
public:
|
|
enum elem_type_enum
|
|
{
|
|
CONVENTIONAL= 0,
|
|
CURRENT,
|
|
HISTORY
|
|
};
|
|
|
|
List<partition_element> subpartitions;
|
|
List<part_elem_value> list_val_list;
|
|
ha_rows part_max_rows;
|
|
ha_rows part_min_rows;
|
|
longlong range_value;
|
|
const char *partition_name;
|
|
const char *tablespace_name;
|
|
struct st_ddl_log_memory_entry *log_entry;
|
|
const char* part_comment;
|
|
const char* data_file_name;
|
|
const char* index_file_name;
|
|
handlerton *engine_type;
|
|
LEX_CSTRING connect_string;
|
|
enum partition_state part_state;
|
|
uint16 nodegroup_id;
|
|
bool has_null_value;
|
|
bool signed_flag; // Range value signed
|
|
bool max_value; // MAXVALUE range
|
|
uint32 id;
|
|
bool empty;
|
|
elem_type_enum type;
|
|
|
|
partition_element()
|
|
: part_max_rows(0), part_min_rows(0), range_value(0),
|
|
partition_name(NULL), tablespace_name(NULL),
|
|
log_entry(NULL), part_comment(NULL),
|
|
data_file_name(NULL), index_file_name(NULL),
|
|
engine_type(NULL), connect_string(null_clex_str), part_state(PART_NORMAL),
|
|
nodegroup_id(UNDEF_NODEGROUP), has_null_value(FALSE),
|
|
signed_flag(FALSE), max_value(FALSE),
|
|
id(UINT_MAX32),
|
|
empty(true),
|
|
type(CONVENTIONAL)
|
|
{}
|
|
partition_element(partition_element *part_elem)
|
|
: part_max_rows(part_elem->part_max_rows),
|
|
part_min_rows(part_elem->part_min_rows),
|
|
range_value(0), partition_name(NULL),
|
|
tablespace_name(part_elem->tablespace_name),
|
|
log_entry(NULL),
|
|
part_comment(part_elem->part_comment),
|
|
data_file_name(part_elem->data_file_name),
|
|
index_file_name(part_elem->index_file_name),
|
|
engine_type(part_elem->engine_type),
|
|
connect_string(null_clex_str),
|
|
part_state(part_elem->part_state),
|
|
nodegroup_id(part_elem->nodegroup_id),
|
|
has_null_value(FALSE),
|
|
signed_flag(part_elem->signed_flag),
|
|
max_value(part_elem->max_value),
|
|
id(part_elem->id),
|
|
empty(part_elem->empty),
|
|
type(CONVENTIONAL)
|
|
{}
|
|
~partition_element() {}
|
|
|
|
part_column_list_val& get_col_val(uint idx)
|
|
{
|
|
part_elem_value *ev= list_val_list.head();
|
|
DBUG_ASSERT(ev);
|
|
DBUG_ASSERT(ev->col_val_array);
|
|
return ev->col_val_array[idx];
|
|
}
|
|
};
|
|
|
|
#endif /* PARTITION_ELEMENT_INCLUDED */
|