mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 04:53:01 +01:00
1b34d593b5
------------------------------------------------------------ revno: 2476.784.3 committer: davi@moksha.local timestamp: Tue 2007-10-02 21:27:31 -0300 message: Bug#25858 Some DROP TABLE under LOCK TABLES can cause deadlocks When a client (connection) holds a lock on a table and attempts to drop (obtain a exclusive lock) on a second table that is already held by a second client and the second client then attempts to drop the table that is held by the first client, leads to a circular wait deadlock. This scenario is very similar to trying to drop (or rename) a table while holding read locks and are correctly forbidden. The solution is to allow a drop table operation to continue only if the table being dropped is write (exclusively) locked, or if the table is temporary, or if the client is not holding any locks. Using this scheme prevents the creation of a circular chain in which each client is waiting for one table that the next client in the chain is holding. This is incompatible change, as can be seen by number of tests cases that needed to be fixed, but is consistent with respect to behavior of the different scenarios in which the circular wait might happen. mysql-test/r/drop.result: Test case result for Bug#25858 mysql-test/r/group_by.result: Fix test case result wrt drop table under lock tables -- unlock tables before dropping table. mysql-test/r/insert_notembedded.result: Fix test case result wrt drop table under lock tables -- unlock tables before dropping table mysql-test/r/lock.result: Fix test case result wrt drop table under lock tables -- unlock tables before dropping table. mysql-test/r/lock_multi.result: Fix test case result wrt drop table under lock tables -- unlock tables before dropping table. mysql-test/r/myisam.result: Fix test case result wrt drop table under lock tables -- unlock tables before dropping table. mysql-test/r/view.result: Fix test case result wrt drop table under lock tables -- unlock tables before dropping table. mysql-test/t/drop.test: Add test case for Bug#25858 mysql-test/t/group_by.test: Fix test case: unlock tables in preparation for a drop table. In some circumstances, dropping tables while holding locks leads to a deadlock. mysql-test/t/insert_notembedded.test: Fix test case: unlock tables in preparation for a drop table. In some circumstances, dropping tables while holding locks leads to a deadlock. mysql-test/t/lock.test: Fix test case: unlock tables in preparation for a drop table. In some circumstances, dropping tables while holding locks leads to a deadlock. mysql-test/t/lock_multi.test: Fix test case: unlock tables in preparation for a drop table. In some circumstances, dropping tables while holding locks leads to a deadlock. mysql-test/t/myisam.test: Fix test case: unlock tables in preparation for a drop table. In some circumstances, dropping tables while holding locks leads to a deadlock. mysql-test/t/query_cache_notembedded.test: Fix test case: unlock tables in preparation for a drop table. In some circumstances, dropping tables while holding locks leads to a deadlock. mysql-test/t/view.test: Fix test case: unlock tables in preparation for a drop table. In some circumstances, dropping tables while holding locks leads to a deadlock. sql/lock.cc: When trying to obtain a name lock under lock tables, ensure that the table is properly exclusively locked and fail otherwise.
279 lines
7 KiB
Text
279 lines
7 KiB
Text
-- source include/have_query_cache.inc
|
|
-- source include/not_embedded.inc
|
|
|
|
# Save the initial number of concurrent sessions
|
|
--source include/count_sessions.inc
|
|
|
|
|
|
#
|
|
# Tests with query cache
|
|
#
|
|
set GLOBAL query_cache_size=1355776;
|
|
|
|
# Reset query cache variables.
|
|
|
|
flush query cache; # This crashed in some versions
|
|
flush query cache; # This crashed in some versions
|
|
reset query cache;
|
|
flush status;
|
|
--disable_warnings
|
|
drop table if exists t1, t2, t3, t11, t21;
|
|
--enable_warnings
|
|
#
|
|
# FLUSH QUERY CACHE
|
|
#
|
|
create table t1 (a int not null);
|
|
insert into t1 values (1),(2),(3);
|
|
create table t2 (a int not null);
|
|
insert into t2 values (1),(2),(3);
|
|
select * from t1;
|
|
select * from t2;
|
|
insert into t1 values (4);
|
|
show status like "Qcache_free_blocks";
|
|
flush query cache;
|
|
show status like "Qcache_free_blocks";
|
|
drop table t1, t2;
|
|
# With join results...
|
|
create table t1 (a text not null);
|
|
create table t11 (a text not null);
|
|
create table t2 (a text not null);
|
|
create table t21 (a text not null);
|
|
create table t3 (a text not null);
|
|
insert into t1 values("1111111111111111111111111111111111111111111111111111");
|
|
insert into t2 select * from t1;
|
|
insert into t1 select * from t2;
|
|
insert into t2 select * from t1;
|
|
insert into t1 select * from t2;
|
|
insert into t2 select * from t1;
|
|
insert into t1 select * from t2;
|
|
insert into t2 select * from t1;
|
|
insert into t1 select * from t2;
|
|
insert into t2 select * from t1;
|
|
insert into t1 select * from t2;
|
|
insert into t2 select * from t1;
|
|
insert into t1 select * from t2;
|
|
insert into t2 select * from t1;
|
|
insert into t1 select * from t2;
|
|
insert into t2 select * from t1;
|
|
# t11 and t21 must be over 4Kb (QUERY_CACHE_MIN_RESULT_DATA_SIZE)
|
|
insert into t11 select * from t1;
|
|
insert into t21 select * from t1;
|
|
insert into t1 select * from t2;
|
|
insert into t2 select * from t1;
|
|
insert into t1 select * from t2;
|
|
#results of t3 must be > 0.5Mb
|
|
insert into t3 select * from t1;
|
|
insert into t3 select * from t2;
|
|
insert into t3 select * from t1;
|
|
disable_result_log;
|
|
select * from t11;
|
|
select * from t21;
|
|
enable_result_log;
|
|
show status like "Qcache_total_blocks";
|
|
show status like "Qcache_free_blocks";
|
|
disable_result_log;
|
|
insert into t11 values("");
|
|
select * from t3;
|
|
enable_result_log;
|
|
show status like "Qcache_total_blocks";
|
|
show status like "Qcache_free_blocks";
|
|
flush query cache;
|
|
show status like "Qcache_total_blocks";
|
|
show status like "Qcache_free_blocks";
|
|
drop table t1, t2, t3, t11, t21;
|
|
|
|
#
|
|
# do not use QC if tables locked (Bug#12385)
|
|
#
|
|
connect (root,localhost,root,,test,$MASTER_MYPORT,$MASTER_MYSOCK);
|
|
connection root;
|
|
CREATE TABLE t1 ( a INT NOT NULL PRIMARY KEY AUTO_INCREMENT ) ENGINE =
|
|
MyISAM;
|
|
LOCK TABLE t1 READ LOCAL;
|
|
connect (root2,localhost,root,,test,$MASTER_MYPORT,$MASTER_MYSOCK);
|
|
connection root2;
|
|
INSERT INTO t1 VALUES (), (), ();
|
|
connection root;
|
|
SELECT * FROM t1;
|
|
connection root2;
|
|
SELECT * FROM t1;
|
|
connection root;
|
|
SELECT * FROM t1;
|
|
UNLOCK TABLES;
|
|
drop table t1;
|
|
connection default;
|
|
disconnect root;
|
|
disconnect root2;
|
|
|
|
#
|
|
# query in QC from normal execution and SP (Bug#6897)
|
|
# improved to also test Bug#3583 and Bug#12990
|
|
#
|
|
flush query cache;
|
|
reset query cache;
|
|
flush status;
|
|
delimiter //;
|
|
create table t1 (s1 int)//
|
|
create procedure f1 () begin
|
|
select sql_cache * from t1;
|
|
select sql_cache * from t1;
|
|
select sql_cache * from t1;
|
|
end;//
|
|
create procedure f2 () begin
|
|
select sql_cache * from t1 where s1=1;
|
|
select sql_cache * from t1;
|
|
end;//
|
|
create procedure f3 () begin
|
|
select sql_cache * from t1;
|
|
select sql_cache * from t1 where s1=1;
|
|
end;//
|
|
create procedure f4 () begin
|
|
select sql_cache * from t1;
|
|
select sql_cache * from t1 where s1=1;
|
|
select sql_cache * from t1;
|
|
select sql_cache * from t1 where s1=1;
|
|
select sql_cache * from t1 where s1=1;
|
|
end;//
|
|
delimiter ;//
|
|
call f1();
|
|
--replace_result 1 3
|
|
show status like "Qcache_queries_in_cache";
|
|
show status like "Qcache_inserts";
|
|
show status like "Qcache_hits";
|
|
call f1();
|
|
show status like "Qcache_queries_in_cache";
|
|
show status like "Qcache_inserts";
|
|
show status like "Qcache_hits";
|
|
call f1();
|
|
select sql_cache * from t1;
|
|
show status like "Qcache_queries_in_cache";
|
|
show status like "Qcache_inserts";
|
|
show status like "Qcache_hits";
|
|
insert into t1 values (1);
|
|
select sql_cache * from t1;
|
|
show status like "Qcache_queries_in_cache";
|
|
show status like "Qcache_inserts";
|
|
show status like "Qcache_hits";
|
|
call f1();
|
|
call f1();
|
|
select sql_cache * from t1;
|
|
show status like "Qcache_queries_in_cache";
|
|
show status like "Qcache_inserts";
|
|
show status like "Qcache_hits";
|
|
flush query cache;
|
|
reset query cache;
|
|
flush status;
|
|
select sql_cache * from t1;
|
|
select sql_cache * from t1 where s1=1;
|
|
call f1();
|
|
call f2();
|
|
call f3();
|
|
call f4();
|
|
call f4();
|
|
call f3();
|
|
call f2();
|
|
select sql_cache * from t1 where s1=1;
|
|
insert into t1 values (2);
|
|
call f1();
|
|
select sql_cache * from t1 where s1=1;
|
|
select sql_cache * from t1;
|
|
call f1();
|
|
call f3();
|
|
call f3();
|
|
call f1();
|
|
|
|
drop procedure f1;
|
|
drop procedure f2;
|
|
drop procedure f3;
|
|
drop procedure f4;
|
|
drop table t1;
|
|
|
|
#
|
|
# Bug#14767 INSERT in SF + concurrent SELECT with query cache
|
|
#
|
|
connection default;
|
|
SET @old_log_bin_trust_function_creators= @@global.log_bin_trust_function_creators;
|
|
SET GLOBAL log_bin_trust_function_creators = 1;
|
|
|
|
reset query cache;
|
|
--disable_warnings
|
|
drop function if exists f1;
|
|
--enable_warnings
|
|
create table t1 (id int);
|
|
delimiter |;
|
|
create function f1 ()
|
|
returns int
|
|
begin
|
|
declare i_var int;
|
|
set i_var = sleep(3);
|
|
insert into t1 values(3);
|
|
set i_var = sleep(3);
|
|
return 0;
|
|
end;|
|
|
delimiter ;|
|
|
|
|
connect (con1,localhost,root,,);
|
|
connect (con2,localhost,root,,);
|
|
|
|
connection con1;
|
|
send select f1();
|
|
connection con2;
|
|
select sleep(4);
|
|
select * from t1;
|
|
connection con1;
|
|
reap;
|
|
connection con2;
|
|
# This gives wrong result i.e. 't' table seems to be empty
|
|
select * from t1;
|
|
reset query cache;
|
|
select * from t1;
|
|
drop table t1;
|
|
drop function f1;
|
|
disconnect con1;
|
|
disconnect con2;
|
|
connection default;
|
|
|
|
set GLOBAL query_cache_size=0;
|
|
|
|
# End of 5.0 tests
|
|
|
|
SET @@global.log_bin_trust_function_creators = @old_log_bin_trust_function_creators;
|
|
|
|
#
|
|
# Bug #30269 Query cache eats memory
|
|
#
|
|
--disable_warnings
|
|
DROP DATABASE IF EXISTS bug30269;
|
|
--enable_warnings
|
|
FLUSH STATUS;
|
|
CREATE DATABASE bug30269;
|
|
USE bug30269;
|
|
CREATE TABLE test1 (id int, name varchar(23));
|
|
CREATE VIEW view1 AS SELECT * FROM test1;
|
|
INSERT INTO test1 VALUES (5, 'testit');
|
|
GRANT SELECT (id) ON TABLE bug30269.test1 TO 'bug30269'@'localhost';
|
|
GRANT SELECT ON TABLE bug30269.view1 TO 'bug30269'@'localhost';
|
|
set global query_cache_size= 81920;
|
|
connect (bug30269, localhost, bug30269,,);
|
|
connection bug30269;
|
|
USE bug30269;
|
|
show status like 'Qcache_queries_in_cache';
|
|
--echo # Select statement not stored in query cache because of column privileges.
|
|
SELECT id FROM test1 WHERE id>2;
|
|
show status like 'Qcache_queries_in_cache';
|
|
SELECT id FROM view1 WHERE id>2;
|
|
show status like 'Qcache_queries_in_cache';
|
|
|
|
connection default;
|
|
USE test;
|
|
DROP DATABASE bug30269;
|
|
disconnect bug30269;
|
|
DROP USER 'bug30269'@'localhost';
|
|
|
|
set GLOBAL query_cache_type=default;
|
|
set GLOBAL query_cache_limit=default;
|
|
set GLOBAL query_cache_min_res_unit=default;
|
|
set GLOBAL query_cache_size=default;
|
|
|
|
# Wait till we reached the initial number of concurrent sessions
|
|
--source include/wait_until_count_sessions.inc
|