mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 10:31:54 +01:00
a4c50983f4
This patch fixes three bugs as follows. First, aborting the server while purging
binary logs might generate orphan files due to how the purge operation was
implemented:
(purge routine - sql/log.cc - MYSQL_BIN_LOG::purge_logs)
1 - register the files to be removed in a temporary buffer.
2 - update the log-bin.index.
3 - flush the log-bin.index.
4 - erase the files whose names where register in the temporary buffer
in step 1.
Thus a failure while executing step 4 would generate an orphan file. Second,
a similar issue might happen while creating a new binary as follows:
(create routine - sql/log.cc - MYSQL_BIN_LOG::open)
1 - open the new log-bin.
2 - update the log-bin.index.
Thus a failure while executing step 1 would generate an orphan file.
To fix these issues, we record the files to be purged or created before really
removing or adding them. So if a failure happens such records can be used to
automatically remove dangling files. The new steps might be outlined as follows:
(purge routine - sql/log.cc - MYSQL_BIN_LOG::purge_logs)
1 - register the files to be removed in the log-bin.~rec~ placed in
the data directory.
2 - update the log-bin.index.
3 - flush the log-bin.index.
4 - delete the log-bin.~rec~.
(create routine - sql/log.cc - MYSQL_BIN_LOG::open)
1 - register the file to be created in the log-bin.~rec~
placed in the data directory.
2 - open the new log-bin.
3 - update the log-bin.index.
4 - delete the log-bin.~rec~.
(recovery routine - sql/log.cc - MYSQL_BIN_LOG::open_index_file)
1 - open the log-bin.index.
2 - open the log-bin.~rec~.
3 - for each file in log-bin.~rec~.
3.1 Check if the file is in the log-bin.index and if so ignore it.
3.2 Otherwise, delete it.
The third issue can be described as follows. The purge operation was allowing
to remove a file in use thus leading to the loss of data and possible
inconsistencies between the master and slave. Roughly, the routine was only
taking into account the dump threads and so if a slave was not connect the
file might be delete even though it was in use.
|
||
|---|---|---|
| .. | ||
| binlog_auto_increment_bug33029-master.opt | ||
| binlog_auto_increment_bug33029.test | ||
| binlog_base64_flag.test | ||
| binlog_database.test | ||
| binlog_delete_and_flush_index.test | ||
| binlog_grant.test | ||
| binlog_incident-master.opt | ||
| binlog_incident.test | ||
| binlog_index.test | ||
| binlog_innodb.test | ||
| binlog_innodb_row.test | ||
| binlog_killed.test | ||
| binlog_killed_simulate-master.opt | ||
| binlog_killed_simulate.test | ||
| binlog_mix_innodb_stat.test | ||
| binlog_mixed_failure_mixing_engines.test | ||
| binlog_multi_engine.test | ||
| binlog_old_versions.test | ||
| binlog_row_binlog-master.opt | ||
| binlog_row_binlog.test | ||
| binlog_row_ctype_cp932.test | ||
| binlog_row_ctype_ucs.test | ||
| binlog_row_drop_tmp_tbl.test | ||
| binlog_row_failure_mixing_engines.test | ||
| binlog_row_innodb_stat-master.opt | ||
| binlog_row_innodb_stat.test | ||
| binlog_row_insert_select.test | ||
| binlog_row_mix_innodb_myisam-master.opt | ||
| binlog_row_mix_innodb_myisam.test | ||
| binlog_row_mysqlbinlog_db_filter.test | ||
| binlog_row_mysqlbinlog_verbose.test | ||
| binlog_sql_mode.test | ||
| binlog_start_comment.test | ||
| binlog_statement_insert_delayed.test | ||
| binlog_stm_binlog-master.opt | ||
| binlog_stm_binlog.test | ||
| binlog_stm_blackhole.test | ||
| binlog_stm_ctype_cp932.test | ||
| binlog_stm_ctype_ucs.test | ||
| binlog_stm_do_db-master.opt | ||
| binlog_stm_do_db.test | ||
| binlog_stm_drop_tmp_tbl.test | ||
| binlog_stm_innodb_stat-master.opt | ||
| binlog_stm_innodb_stat.test | ||
| binlog_stm_insert_select.test | ||
| binlog_stm_mix_innodb_myisam-master.opt | ||
| binlog_stm_mix_innodb_myisam.test | ||
| binlog_stm_ps.test | ||
| binlog_stm_row.test | ||
| binlog_stm_unsafe_warning-master.opt | ||
| binlog_stm_unsafe_warning.test | ||
| binlog_tbl_metadata.test | ||
| binlog_tmp_table.test | ||
| binlog_truncate_innodb-master.opt | ||
| binlog_truncate_innodb.test | ||
| binlog_truncate_myisam.test | ||
| binlog_unsafe.test | ||
| disabled.def | ||