mariadb/storage/innobase/os
Marko Mäkelä 00f0c039d2 MDEV-15270 Mariabackup should not try to use doublewrite buffer
When Mariabackup gets a bad read of the first page of the system
tablespace file, it would inappropriately try to apply the doublewrite
buffer and write changes back to the data file (to the source file)!
This is very wrong and must be prevented.

The correct action would be to retry reading the system tablespace
as well as any other files whose first page was read incorrectly.
Fixing this was not attempted.

xb_load_tablespaces(): Shorten a bogus message to be more relevant.
The message can be displayed by --backup or --prepare.

xtrabackup_backup_func(), os_file_write_func(): Add a missing space
to a message.

Datafile::restore_from_doublewrite(): Do not even attempt the
operation in Mariabackup.

recv_init_crash_recovery_spaces(): Do not attempt to restore the
doublewrite buffer in Mariabackup (--prepare or --export), because
all pages should have been copied correctly in --backup already,
and because --backup should ignore the doublewrite buffer.

SysTablespace::read_lsn_and_check_flags(): Do not attempt to initialize
the doublewrite buffer in Mariabackup.

innodb_make_page_dirty(): Correct the bounds check.

Datafile::read_first_page(): Correct the name of the parameter.
2018-02-12 16:56:01 +02:00
..
os0event.cc Merge InnoDB 5.7 from mysql-5.7.9. 2016-09-02 13:22:28 +03:00
os0file.cc MDEV-15270 Mariabackup should not try to use doublewrite buffer 2018-02-12 16:56:01 +02:00
os0proc.cc Fix some integer type mismatch. 2017-05-10 12:45:46 +03:00
os0thread.cc Add ATTRIBUTE_NORETURN and ATTRIBUTE_COLD 2017-08-31 09:30:55 +03:00