mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 13:02:28 +01:00
e02749aaf5
numerous issues fixed: * buffer overflows * error conditions aren't checked (crash if file doesn't exist) * accessing random unallocated memory * hard-coded password * arbitrary hard-coded key id limit * incomprehensible error messages (for key_id == 0 it reported "The key could not be initialized", for syntax errors the message was "Wrong match of the keyID, see the template", for a key id larger than hard-coded limit the message was "No asked key", and there was an error "Is comment" for a comment). * tons of small mallocs, many are freed few lines down in the code * malloc(N) and new char[N] are used both, even in the same function * redundant memory copies * pcre - "I can solve it with regular expressions" - with incorrect regexes * parser context stored in a singleton * keys are stored as strings and are strlen-ed and hex2bin-ed on every get_key() request * lots of useless code (e.g. sprintf instead of a pointer assignment, checking of the file length to read a part of it in a fixed buffer, multiplying by sizeof(char) in many places, etc) * this list is not exhaustive |
||
|---|---|---|
| .. | ||
| crldir | ||
| ctype_upgrade | ||
| funcs_1 | ||
| mysql5613mysql | ||
| parts | ||
| temporal_upgrade | ||
| zoneinfo | ||
| 14897.frm | ||
| bad_gis_data.dat | ||
| bad_row_type.frm | ||
| bad_row_type.MYD | ||
| bad_row_type.MYI | ||
| binlog_savepoint.000001 | ||
| binlog_transaction.000001 | ||
| bug15328.cnf | ||
| bug16266.000001 | ||
| bug19371.frm | ||
| bug19371.MYD | ||
| bug19371.MYI | ||
| bug30435_5k.txt | ||
| bug30435_10k_items.txt | ||
| bug33029-slave-relay-bin.000001 | ||
| bug35469.dat | ||
| bug36055.frm | ||
| bug36055.MYD | ||
| bug36055.MYI | ||
| bug37631.frm | ||
| bug37631.MYD | ||
| bug37631.MYI | ||
| bug40482-bin.000001 | ||
| bug46565.ARZ | ||
| bug46565.frm | ||
| bug47012.ARM | ||
| bug47012.ARZ | ||
| bug47012.frm | ||
| bug47142_master-bin.000001 | ||
| bug47205.frm | ||
| bug48265.frm | ||
| bug48449.frm | ||
| bug48633.ARM | ||
| bug48633.ARZ | ||
| bug48633.frm | ||
| bug49823.CSM | ||
| bug49823.CSV | ||
| bug49823.frm | ||
| bug887051.txt | ||
| bug11747416_32228_binlog.000001 | ||
| cacert.pem | ||
| charset_utf8.txt | ||
| checkDBI_DBD-mysql.pl | ||
| client-cert.pem | ||
| client-key.pem | ||
| cluster_7022_table.frm | ||
| cluster_7022_table.MYD | ||
| cluster_7022_table.MYI | ||
| corrupt-relay-bin.000624 | ||
| corrupt_t1#P#p1.MYI | ||
| corrupt_t1.MYI | ||
| crl-ca-cert.pem | ||
| crl-client-cert.pem | ||
| crl-client-key.pem | ||
| crl-client-revoked.crl | ||
| crl-server-cert.pem | ||
| crl-server-key.pem | ||
| des_key_file | ||
| host_old.frm | ||
| host_old.MYD | ||
| host_old.MYI | ||
| Index.xml | ||
| init_file.dat | ||
| init_file_longline_3816.sql | ||
| intersect-bug50389.tsv | ||
| keys.txt | ||
| latin1.xml | ||
| loaddata1.dat | ||
| loaddata2.dat | ||
| loaddata3.dat | ||
| loaddata4.dat | ||
| loaddata5.dat | ||
| loaddata6.dat | ||
| loaddata7.dat | ||
| loaddata_dq.dat | ||
| loaddata_pair.dat | ||
| loaddata_utf8.dat | ||
| loadxml.dat | ||
| loadxml2.dat | ||
| long_table_name.frm | ||
| long_table_name.MYD | ||
| long_table_name.MYI | ||
| mariadb-5.5-binlog.000001 | ||
| master-bin.000001 | ||
| mdev-4645-binlog_checksum.binlog | ||
| mdev-4645-binlog_group_id.binlog | ||
| mdev-4645-binlog_group_id_checksum.binlog | ||
| mdev-4645-binlog_none.binlog | ||
| mdev5029_1.frm | ||
| mdev5029_2.frm | ||
| mdev5029_2.MAD | ||
| mdev5029_2.MAI | ||
| mdev6020-mysql-bin.000001 | ||
| Moscow_leap | ||
| mysql56datetime.frm | ||
| mysql56datetime.MYD | ||
| mysql56datetime.MYI | ||
| mysql56time.frm | ||
| mysql56time.MYD | ||
| mysql56time.MYI | ||
| mysql56timestamp.frm | ||
| mysql56timestamp.MYD | ||
| mysql56timestamp.MYI | ||
| new-format-relay-log-win.info | ||
| new-format-relay-log.info | ||
| numbers.txt | ||
| old-format-relay-log-win.info | ||
| old-format-relay-log.info | ||
| old_table-323.frm | ||
| onerow.xml | ||
| rpl_bug28618.dat | ||
| rpl_loaddata.dat | ||
| rpl_loaddata2.dat | ||
| rpl_mixed.dat | ||
| rpl_timezone.dat | ||
| rpl_timezone2.dat | ||
| server-cert.pem | ||
| server-key.pem | ||
| server8k-cert.pem | ||
| server8k-key.pem | ||
| t917689.ARZ | ||
| trunc_binlog.000001 | ||
| untrusted-cacert.pem | ||
| vchar.frm | ||
| warnings_loaddata.dat | ||
| words.dat | ||
| words2.dat | ||
| words3.dat | ||