mariadb/mysql-test/suite/versioning/t/debug.test
Aleksey Midenkov 92bfc0e8c4 MDEV-17554 Auto-create new partition for system versioned tables with history partitioned by INTERVAL/LIMIT
:: Syntax change ::

Keyword AUTO enables history partition auto-creation.

Examples:

    CREATE TABLE t1 (x int) WITH SYSTEM VERSIONING
    PARTITION BY SYSTEM_TIME INTERVAL 1 HOUR AUTO;

    CREATE TABLE t1 (x int) WITH SYSTEM VERSIONING
    PARTITION BY SYSTEM_TIME INTERVAL 1 MONTH
    STARTS '2021-01-01 00:00:00' AUTO PARTITIONS 12;

    CREATE TABLE t1 (x int) WITH SYSTEM VERSIONING
    PARTITION BY SYSTEM_TIME LIMIT 1000 AUTO;

Or with explicit partitions:

    CREATE TABLE t1 (x int) WITH SYSTEM VERSIONING
    PARTITION BY SYSTEM_TIME INTERVAL 1 HOUR AUTO
    (PARTITION p0 HISTORY, PARTITION pn CURRENT);

To disable or enable auto-creation one can use ALTER TABLE by adding
or removing AUTO from partitioning specification:

    CREATE TABLE t1 (x int) WITH SYSTEM VERSIONING
    PARTITION BY SYSTEM_TIME INTERVAL 1 HOUR AUTO;

    # Disables auto-creation:
    ALTER TABLE t1 PARTITION BY SYSTEM_TIME INTERVAL 1 HOUR;

    # Enables auto-creation:
    ALTER TABLE t1 PARTITION BY SYSTEM_TIME INTERVAL 1 HOUR AUTO;

If the rest of partitioning specification is identical to CREATE TABLE
no repartitioning will be done (for details see MDEV-27328).

:: Description ::

Before executing history-generating DML command (see the list of commands below)
add N history partitions, so that N would be sufficient for potentially
generated history. N > 1 may be required when history partitions are switched
by INTERVAL and current_timestamp is N times further than the interval
boundary of the last history partition.

If the last history partition equals or exceeds LIMIT records then new history
partition is created and selected as the working partition. According to
MDEV-28411 partitions cannot be switched (or created) while the command is
running. Thus LIMIT does not carry strict limitation and the history partition
size must be planned as LIMIT value plus average number of history one DML
command can generate.

Auto-creation is implemented by synchronous fast_alter_partition_table() call
from the thread of the executed DML command before the command itself is run
(by the fallback and retry mechanism similar to Discovery feature,
see Open_table_context).

The name for newly added partitions are generated like default partition names
with extension of MDEV-22155 (which avoids name clashes by extending assignment
counter to next free-enough gap).

These DML commands can trigger auto-creation:

    DELETE (including multitable DELETE, excluding DELETE HISTORY)
    UPDATE (including multitable UPDATE)
    REPLACE (including REPLACE .. SELECT)
    INSERT .. ON DUPLICATE KEY UPDATE (including INSERT .. SELECT .. ODKU)
    LOAD DATA .. REPLACE

:: Bug fixes ::

MDEV-23642 Locking timeout caused by auto-creation affects original DML

    The reasons for this are:

    - Do not disrupt main business process (the history is auxiliary service);

    - Consequences are non-fatal (history is not lost, but comes into wrong
      partition; fixed by partitioning rebuild);

    - There is more freedom for application to fail in this case or not: it may
      read warning info and find corresponding error number.

    - While non-failing command is easy to handle by an application and fail it,
      the opposite is hard to handle: there is no automatic actions to fix
      failed command and retry, DBA intervention is required and until then
      application is non-functioning.

MDEV-23639 Auto-create does not work under LOCK TABLES or inside triggers

    Don't do tdc_remove_table() for OT_ADD_HISTORY_PARTITION because it is
    not possible in locked tables mode.

    LTM_LOCK_TABLES mode (and LTM_PRELOCKED_UNDER_LOCK_TABLES) works out
    of the box as fast_alter_partition_table() can reopen tables via
    locked_tables_list.

    In LTM_PRELOCKED we reopen and relock table manually.

:: More fixes ::

* some_table_marked_for_reopen flag fix

  some_table_marked_for_reopen affets only reopen of
  m_locked_tables. I.e. Locked_tables_list::reopen_tables() reopens only
  tables from m_locked_tables.

* Unused can_recover_from_failed_open() condition

  Is recover_from_failed_open() can be really used after
  open_and_process_routine()?

:: Reviewed by ::

Sergei Golubchik <serg@mariadb.org>
2022-05-06 15:11:02 +03:00

108 lines
2.9 KiB
Text

--source include/have_debug.inc
--source include/have_partition.inc
--let $datadir=`select @@datadir`
create table t1 (a int);
show create table t1;
--error ER_VERS_NOT_SUPPORTED
create temporary table tt1 (a int) with system versioning;
set @old_dbug=@@global.debug_dbug;
set global debug_dbug='+d,sysvers_force';
create table t2 (a int);
show create table t2;
create temporary table tt2 (a int) with system versioning;
show create table tt2;
--connect con1, localhost, root
create table t3 (a int);
show create table t3;
create temporary table tt3 (a int) with system versioning;
show create table tt3;
--disconnect con1
--connection default
set debug_dbug='+d,sysvers_show';
show create table t3;
create table t4 (a int);
show create table t4;
drop table t1, t2, t3, t4;
set debug_dbug= @old_dbug;
set global debug_dbug= @old_dbug;
--echo #
--echo # MDEV-19525 remove ER_VERS_FIELD_WRONG_TYPE from init_from_binary_frm_image()
--echo #
create table t1 (x int) with system versioning;
set debug_dbug='+d,error_vers_wrong_type';
--replace_result $datadir ./
--error ER_NOT_FORM_FILE
show create table t1;
--replace_result $datadir ./
show warnings;
drop table t1;
set debug_dbug= @old_dbug;
--echo #
--echo # MDEV-17554 Auto-create new partition for system versioned tables
--echo # with history partitioned by INTERVAL/LIMIT
--echo #
call mtr.add_suppression("need more HISTORY partitions");
create or replace table t1 (x int) with system versioning
partition by system_time limit 1 auto partitions 2;
insert into t1 values (1);
update t1 set x= x + 1;
--connect con2, localhost, root
--connect con1, localhost, root
--disable_warnings
--echo # Both threads create partition simultaneously
--connection con1
set debug_sync= 'add_history_partition signal s1 wait_for s2';
send update t1 set x= x + 10;
--connection con2
set debug_sync= 'now wait_for s1';
flush tables t1;
set debug_sync= 'add_history_partition signal s2';
update t1 set x= x + 20;
--connection con1
reap;
--connection default
# 1 or 2 history rows may be created depending on which UPDATE finishes first (MDEV-28459)
# select partition_name, table_rows from information_schema.partitions
# where table_name = 't1';
# Fill empty partition for next UPDATE to trigger auto-create
update t1 set x= x + 2;
--echo # Second thread skips to reopen 3 times until first thread creates partition
--connection con1
set debug_sync= 'add_history_partition SIGNAL s1 WAIT_FOR s2';
send update t1 set x= x + 30;
--connection con2
set debug_sync= 'now WAIT_FOR s1';
set debug_sync= 'reopen_history_partition SIGNAL s2 EXECUTE 3';
update t1 set x= x + 40;
--connection con1
reap;
--connection default
# Same here (MDEV-28459)
# select partition_name, table_rows from information_schema.partitions
# where table_name = 't1';
--enable_warnings
--disconnect con1
--disconnect con2
set @@timestamp= default;
drop tables t1;
set debug_sync= 'reset';