mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 14:02:32 +01:00
eff3780dd8
Backport of: ------------------------------------------------------------ revno: 2630.4.1 committer: Dmitry Lenev <dlenev@mysql.com> branch nick: mysql-6.0-3726-w timestamp: Fri 2008-05-23 17:54:03 +0400 message: WL#3726 "DDL locking for all metadata objects". After review fixes in progress. ------------------------------------------------------------ This is the first patch in series. It transforms the metadata locking subsystem to use a dedicated module (mdl.h,cc). No significant changes in the locking protocol. The import passes the test suite with the exception of deprecated/removed 6.0 features, and MERGE tables. The latter are subject to a fix by WL#4144. Unfortunately, the original changeset comments got lost in a merge, thus this import has its own (largely insufficient) comments. This patch fixes Bug#25144 "replication / binlog with view breaks". Warning: this patch introduces an incompatible change: Under LOCK TABLES, it's no longer possible to FLUSH a table that was not locked for WRITE. Under LOCK TABLES, it's no longer possible to DROP a table or VIEW that was not locked for WRITE. ****** Backport of: ------------------------------------------------------------ revno: 2630.4.2 committer: Dmitry Lenev <dlenev@mysql.com> branch nick: mysql-6.0-3726-w timestamp: Sat 2008-05-24 14:03:45 +0400 message: WL#3726 "DDL locking for all metadata objects". After review fixes in progress. ****** Backport of: ------------------------------------------------------------ revno: 2630.4.3 committer: Dmitry Lenev <dlenev@mysql.com> branch nick: mysql-6.0-3726-w timestamp: Sat 2008-05-24 14:08:51 +0400 message: WL#3726 "DDL locking for all metadata objects" Fixed failing Windows builds by adding mdl.cc to the lists of files needed to build server/libmysqld on Windows. ****** Backport of: ------------------------------------------------------------ revno: 2630.4.4 committer: Dmitry Lenev <dlenev@mysql.com> branch nick: mysql-6.0-3726-w timestamp: Sat 2008-05-24 21:57:58 +0400 message: WL#3726 "DDL locking for all metadata objects". Fix for assert failures in kill.test which occured when one tried to kill ALTER TABLE statement on merge table while it was waiting in wait_while_table_is_used() for other connections to close this table. These assert failures stemmed from the fact that cleanup code in this case assumed that temporary table representing new version of table was open with adding to THD::temporary_tables list while code which were opening this temporary table wasn't always fulfilling this. This patch changes code that opens new version of table to always do this linking in. It also streamlines cleanup process for cases when error occurs while we have new version of table open. ****** WL#3726 "DDL locking for all metadata objects" Add libmysqld/mdl.cc to .bzrignore. ****** Backport of: ------------------------------------------------------------ revno: 2630.4.6 committer: Dmitry Lenev <dlenev@mysql.com> branch nick: mysql-6.0-3726-w timestamp: Sun 2008-05-25 00:33:22 +0400 message: WL#3726 "DDL locking for all metadata objects". Addition to the fix of assert failures in kill.test caused by changes for this worklog. Make sure we close the new table only once. .bzrignore: Add libmysqld/mdl.cc libmysqld/CMakeLists.txt: Added mdl.cc to the list of files needed for building of libmysqld. libmysqld/Makefile.am: Added files implementing new meta-data locking subsystem to the server. mysql-test/include/handler.inc: Use separate connection for waiting while threads performing DDL operations conflicting with open HANDLER tables reach blocked state. This is required because now we check and close tables open by HANDLER statements in this connection conflicting with DDL in another each time open_tables() is called and thus select from I_S which is used for waiting will unblock DDL operations if issued from connection with open HANDLERs. mysql-test/r/create.result: Adjusted test case after change in implementation of CREATE TABLE ... SELECT. We no longer have special check in open_table() which catches the case when we select from the table created. Instead we rely on unique_table() call which happens after opening and locking all tables. mysql-test/r/flush.result: FLUSH TABLES WITH READ LOCK can no longer happen under LOCK TABLES. Updated test accordingly. mysql-test/r/flush_table.result: Under LOCK TABLES we no longer allow to do FLUSH TABLES for tables locked for read. Updated test accordingly. mysql-test/r/handler_innodb.result: Use separate connection for waiting while threads performing DDL operations conflicting with open HANDLER tables reach blocked state. This is required because now we check and close tables open by HANDLER statements in this connection conflicting with DDL in another each time open_tables() is called and thus select from I_S which is used for waiting will unblock DDL operations if issued from connection with open HANDLERs. mysql-test/r/handler_myisam.result: Use separate connection for waiting while threads performing DDL operations conflicting with open HANDLER tables reach blocked state. This is required because now we check and close tables open by HANDLER statements in this connection conflicting with DDL in another each time open_tables() is called and thus select from I_S which is used for waiting will unblock DDL operations if issued from connection with open HANDLERs. mysql-test/r/information_schema.result: Additional test for WL#3726 "DDL locking for all metadata objects". Check that we use high-priority metadata lock requests when filling I_S tables. Rearrange tests to match 6.0 better (fewer merge conflicts). mysql-test/r/kill.result: Added tests checking that DDL and DML statements waiting for metadata locks can be interrupted by KILL command. mysql-test/r/lock.result: One no longer is allowed to do DROP VIEW under LOCK TABLES even if this view is locked by LOCK TABLES. The problem is that in such situation write locks on view are not mutually exclusive so upgrading metadata lock which is required for dropping of view will lead to deadlock. mysql-test/r/partition_column_prune.result: Update results (same results in 6.0), WL#3726 mysql-test/r/partition_pruning.result: Update results (same results in 6.0), WL#3726 mysql-test/r/ps_ddl.result: We no longer invalidate prepared CREATE TABLE ... SELECT statement if target table changes. This is OK since it is not strictly necessary. The first change is wrong, is caused by FLUSH TABLE now flushing all unused tables. This is a regression that Dmitri fixed in 6.0 in a follow up patch. mysql-test/r/sp.result: Under LOCK TABLES we no longer allow accessing views which were not explicitly locked. To access view we need to obtain metadata lock on it and doing this under LOCK TABLES may lead to deadlocks. mysql-test/r/view.result: One no longer is allowed to do DROP VIEW under LOCK TABLES even if this view is locked by LOCK TABLES. The problem is that in such situation even "write locks" on view are not mutually exclusive so upgrading metadata lock which is required for dropping of view will lead to deadlock mysql-test/r/view_grant.result: ALTER VIEW implementation was changed to open a view only after checking that user which does alter has appropriate privileges on it. This means that in case when user's privileges are insufficient for this we won't check that new view definer is the same as original one or user performing alter has SUPER privilege. Adjusted test case accordingly. mysql-test/r/view_multi.result: Added test case for bug#25144 "replication / binlog with view breaks". mysql-test/suite/rpl/t/disabled.def: Disable test for deprecated features (they don't work with new MDL). mysql-test/t/create.test: Adjusted test case after change in implementation of CREATE TABLE ... SELECT. We no longer have special check in open_table() which catches the case when we select from the table created. Instead we rely on unique_table() call which happens after opening and locking all tables. mysql-test/t/disabled.def: Disable merge.test, subject of WL#4144 mysql-test/t/flush.test: FLUSH TABLES WITH READ LOCK can no longer happen under LOCK TABLES. Updated test accordingly. mysql-test/t/flush_table.test: Under LOCK TABLES we no longer allow to do FLUSH TABLES for tables locked for read. Updated test accordingly. mysql-test/t/information_schema.test: Additional test for WL#3726 "DDL locking for all metadata objects". Check that we use high-priority metadata lock requests when filling I_S tables. Rearrange the results for easier merges with 6.0. mysql-test/t/kill.test: Added tests checking that DDL and DML statements waiting for metadata locks can be interrupted by KILL command. mysql-test/t/lock.test: One no longer is allowed to do DROP VIEW under LOCK TABLES even if this view is locked by LOCK TABLES. The problem is that in such situation write locks on view are not mutually exclusive so upgrading metadata lock which is required for dropping of view will lead to deadlock. mysql-test/t/lock_multi.test: Adjusted test case to the changes of status in various places caused by change in implementation FLUSH TABLES WITH READ LOCK, which is now takes global metadata lock before flushing tables and therefore waits on at these places. mysql-test/t/ps_ddl.test: We no longer invalidate prepared CREATE TABLE ... SELECT statement if target table changes. This is OK since it is not strictly necessary. The first change is wrong, is caused by FLUSH TABLE now flushing all unused tables. This is a regression that Dmitri fixed in 6.0 in a follow up patch. mysql-test/t/sp.test: Under LOCK TABLES we no longer allow accessing views which were not explicitly locked. To access view we need to obtain metadata lock on it and doing this under LOCK TABLES may lead to deadlocks. mysql-test/t/trigger_notembedded.test: Adjusted test case to the changes of status in various places caused by change in implementation FLUSH TABLES WITH READ LOCK, which is now takes global metadata lock before flushing tables and therefore waits on at these places. mysql-test/t/view.test: One no longer is allowed to do DROP VIEW under LOCK TABLES even if this view is locked by LOCK TABLES. The problem is that in such situation even "write locks" on view are not mutually exclusive so upgrading metadata lock which is required for dropping of view will lead to deadlock. mysql-test/t/view_grant.test: ALTER VIEW implementation was changed to open a view only after checking that user which does alter has appropriate privileges on it. This means that in case when user's privileges are insufficient for this we won't check that new view definer is the same as original one or user performing alter has SUPER privilege. Adjusted test case accordingly. mysql-test/t/view_multi.test: Added test case for bug#25144 "replication / binlog with view breaks". sql/CMakeLists.txt: Added mdl.cc to the list of files needed for building of server. sql/Makefile.am: Added files implementing new meta-data locking subsystem to the server. sql/event_db_repository.cc: Allocate metadata lock requests objects (MDL_LOCK) on execution memory root in cases when TABLE_LIST objects is also allocated there or on stack. sql/ha_ndbcluster.cc: Adjusted code to work nicely with new metadata locking subsystem. close_cached_tables() no longer has wait_for_placeholder argument. Instead of relying on this parameter and related behavior FLUSH TABLES WITH READ LOCK now takes global shared metadata lock. sql/ha_ndbcluster_binlog.cc: Adjusted code to work with new metadata locking subsystem. close_cached_tables() no longer has wait_for_placeholder argument. Instead of relying on this parameter and related behavior FLUSH TABLES WITH READ LOCK now takes global shared metadata lock. sql/handler.cc: update_frm_version(): Directly update TABLE_SHARE::mysql_version member instead of going through all TABLE instances for this table (old code was a legacy from pre-table-definition-cache days). sql/lock.cc: Use new metadata locking subsystem. Threw away most of functions related to name locking as now one is supposed to use metadata locking API instead. In lock_global_read_lock() and unlock_global_read_lock() in order to avoid problems with global read lock sneaking in at the moment when we perform FLUSH TABLES or ALTER TABLE under LOCK TABLES and when tables being reopened are protected only by metadata locks we also have to take global shared meta data lock. sql/log_event.cc: Adjusted code to work with new metadata locking subsystem. For tables open by slave thread for applying RBR events allocate memory for lock request object in the same chunk of memory as TABLE_LIST objects for them. In order to ensure that we keep these objects around until tables are open always close tables before calling Relay_log_info::clear_tables_to_lock(). Use new auxiliary Relay_log_info::slave_close_thread_tables() method to enforce this. sql/log_event_old.cc: Adjusted code to work with new metadata locking subsystem. Since for tables open by slave thread for applying RBR events memory for lock request object is allocated in the same chunk of memory as TABLE_LIST objects for them we have to ensure that we keep these objects around until tables are open. To ensure this we always close tables before calling Relay_log_info::clear_tables_to_lock(). To enfore this we use new auxiliary Relay_log_info::slave_close_thread_tables() method. sql/mdl.cc: Implemented new metadata locking subsystem and API described in WL3726 "DDL locking for all metadata objects". sql/mdl.h: Implemented new metadata locking subsystem and API described in WL3726 "DDL locking for all metadata objects". sql/mysql_priv.h: - close_thread_tables()/close_tables_for_reopen() now has one more argument which indicates that metadata locks should be released but not removed from the context in order to be used later in mdl_wait_for_locks() and tdc_wait_for_old_version(). - close_cached_table() routine is no longer public. - Thread waiting in wait_while_table_is_used() can be now killed so this function returns boolean to make caller aware of such situation. - We no longer have table cache as separate entity instead used and unused TABLE instances are linked to TABLE_SHARE objects in table definition cache. - Now third argument of open_table() is also used for requesting table repair or auto-discovery of table's new definition. So its type was changed from bool to enum. - Added tdc_open_view() function for opening view by getting its definition from disk (and table cache in future). - reopen_name_locked_table() no longer needs "link_in" argument as now we have exclusive metadata locks instead of dummy TABLE instances when this function is called. - find_locked_table() now takes head of list of TABLE instances instead of always scanning through THD::open_tables list. Also added find_write_locked_table() auxiliary. - reopen_tables(), close_cached_tables() no longer have mark_share_as_old and wait_for_placeholder arguments. Instead of relying on this parameters and related behavior FLUSH TABLES WITH READ LOCK now takes global shared metadata lock. - We no longer need drop_locked_tables() and abort_locked_tables(). - mysql_ha_rm_tables() now always assume that LOCK_open is not acquired by caller. - Added notify_thread_having_shared_lock() callback invoked by metadata locking subsystem when acquiring an exclusive lock, for each thread that has a conflicting shared metadata lock. - Introduced expel_table_from_cache() as replacement for remove_table_from_cache() (the main difference is that this new function assumes that caller follows metadata locking protocol and never waits). - Threw away most of functions related to name locking. One should use new metadata locking subsystem and API instead. sql/mysqld.cc: Got rid of call initializing/deinitializing table cache since now it is embedded into table definition cache. Added calls for initializing/ deinitializing metadata locking subsystem. sql/rpl_rli.cc: Introduced auxiliary Relay_log_info::slave_close_thread_tables() method which is used for enforcing that we always close tables open for RBR before deallocating TABLE_LIST elements and MDL_LOCK objects for them. sql/rpl_rli.h: Introduced auxiliary Relay_log_info::slave_close_thread_tables() method which is used for enforcing that we always close tables open for RBR before deallocating TABLE_LIST elements and MDL_LOCK objects for them. sql/set_var.cc: close_cached_tables() no longer has wait_for_placeholder argument. Instead of relying on this parameter and related behavior FLUSH TABLES WITH READ LOCK now takes global shared metadata lock. sql/sp_head.cc: For tables added to the statement's table list by prelocking algorithm we allocate these objects either on the same memory as corresponding table list elements or on THD::locked_tables_root (if we are building table list for LOCK TABLES). sql/sql_acl.cc: Allocate metadata lock requests objects (MDL_LOCK) on execution memory root in cases when we use stack TABLE_LIST objects to open tables. Got rid of redundant code by using unlock_locked_tables() function. sql/sql_base.cc: Changed code to use new MDL subsystem. Got rid of separate table cache. Now used and unused TABLE instances are linked to the TABLE_SHAREs in table definition cache. check_unused(): Adjusted code to the fact that we no longer have separate table cache. Removed dead code. table_def_free(): Free TABLE instances referenced from TABLE_SHARE objects before destroying table definition cache. get_table_share(): Added assert which ensures that noone will be able to access table (and its share) without acquiring some kind of metadata lock first. close_handle_and_leave_table_as_lock(): Adjusted code to the fact that TABLE instances now are linked to list in TABLE_SHARE. list_open_tables(): Changed this function to use table definition cache instead of table cache. free_cache_entry(): Unlink freed TABLE elements from the list of all TABLE instances for the table in TABLE_SHARE. kill_delayed_thread_for_table(): Added auxiliary for killing delayed insert threads for particular table. close_cached_tables(): Got rid of wait_for_refresh argument as we now rely on global shared metadata lock to prevent FLUSH WITH READ LOCK sneaking in when we are reopening tables. Heavily reworked this function to use new MDL code and not to rely on separate table cache entity. close_open_tables(): We no longer have separate table cache. close_thread_tables(): Release metadata locks after closing all tables. Added skip_mdl argument which allows us not to remove metadata lock requests from the context in case when we are going to use this requests later in mdl_wait_for_locks() and tdc_wait_for_old_versions(). close_thread_table()/close_table_for_reopen(): Since we no longer have separate table cache and all TABLE instances are linked to TABLE_SHARE objects in table definition cache we have to link/unlink TABLE object to/from appropriate lists in the share. name_lock_locked_table(): Moved redundant code to find_write_locked_table() function and adjusted code to the fact that wait_while_table_is_used() can now return with an error if our thread is killed. reopen_table_entry(): We no longer need "link_in" argument as with MDL we no longer call this function with dummy TABLE object pre-allocated and added to the THD::open_tables. Also now we add newly-open TABLE instance to the list of share's used TABLE instances. table_cache_insert_placeholder(): Got rid of name-locking legacy. lock_table_name_if_not_cached(): Moved to sql_table.cc the only place where it is used. It was also reimplemented using new MDL API. open_table(): - Reworked this function to use new MDL subsystem. - Changed code to deal with table definition cache directly instead of going through separate table cache. - Now third argument is also used for requesting table repair or auto-discovery of table's new definition. So its type was changed from bool to enum. find_locked_table()/find_write_locked_table(): Accept head of list of TABLE objects as first argument and use this list instead of always searching in THD::open_tables list. Also added auxiliary for finding write-locked locked tables. reopen_table(): Adjusted function to work with new MDL subsystem and to properly manuipulate with lists of used/unused TABLE instaces in TABLE_SHARE. reopen_tables(): Removed mark_share_as_old parameter. Instead of relying on it and related behavior FLUSH TABLES WITH READ LOCK now takes global shared metadata lock. Changed code after removing separate table cache. drop_locked_tables()/abort_locked_tables(): Got rid of functions which are no longer needed. unlock_locked_tables(): Moved this function from sql_parse.cc and changed it to release memory which was used for allocating metadata lock requests for tables open and locked by LOCK TABLES. tdc_open_view(): Intoduced function for opening a view by getting its definition from disk (and table cache in future). reopen_table_entry(): Introduced function for opening table definitions while holding exclusive metatadata lock on it. open_unireg_entry(): Got rid of this function. Most of its functionality is relocated to open_table() and open_table_fini() functions, and some of it to reopen_table_entry() and tdc_open_view(). Also code resposible for auto-repair and auto-discovery of tables was moved to separate function. open_table_entry_fini(): Introduced function which contains common actions which finalize process of TABLE object creation. auto_repair_table(): Moved code responsible for auto-repair of table being opened here. handle_failed_open_table_attempt() Moved code responsible for handling failing attempt to open table to one place (retry due to lock conflict/old version, auto-discovery and repair). open_tables(): - Flush open HANDLER tables if they have old version of if there is conflicting metadata lock against them (before this moment we had this code in open_table()). - When we open view which should be processed via derived table on the second execution of prepared statement or stored routine we still should call open_table() for it in order to obtain metadata lock on it and prepare its security context. - In cases when we discover that some special handling of failure to open table is needed call handle_failed_open_table_attempt() which handles all such scenarios. open_ltable(): Handling of various special scenarios of failure to open a table was moved to separate handle_failed_open_table_attempt() function. remove_db_from_cache(): Removed this function as it is no longer used. notify_thread_having_shared_lock(): Added callback which is invoked by MDL subsystem when acquiring an exclusive lock, for each thread that has a conflicting shared metadata lock. expel_table_from_cache(): Introduced function for removing unused TABLE instances. Unlike remove_table_from_cache() it relies on caller following MDL protocol and having appropriate locks when calling it and thus does not do any waiting if table is still in use. tdc_wait_for_old_version(): Added function which allows open_tables() to wait in cases when we discover that we should back-off due to presence of old version of table. abort_and_upgrade_lock(): Use new MDL calls. mysql_wait_completed_table(): Got rid of unused function. open_system_tables_for_read/for_update()/performance_schema_table(): Allocate MDL_LOCK objects on execution memory root in cases when TABLE_LIST objects for corresponding tables is allocated on stack. close_performance_schema_table(): Release metadata locks after closing tables. ****** Use I_P_List for free/used tables list in the table share. sql/sql_binlog.cc: Use Relay_log_info::slave_close_thread_tables() method to enforce that we always close tables open for RBR before deallocating TABLE_LIST elements and MDL_LOCK objects for them. sql/sql_class.cc: Added meta-data locking contexts as part of Open_tables_state context. Also introduced THD::locked_tables_root memory root which is to be used for allocating MDL_LOCK objects for tables in LOCK TABLES statement (end of lifetime for such objects is UNLOCK TABLES so we can't use statement or execution root for them). sql/sql_class.h: Added meta-data locking contexts as part of Open_tables_state context. Also introduced THD::locked_tables_root memory root which is to be used for allocating MDL_LOCK objects for tables in LOCK TABLES statement (end of lifetime for such objects is UNLOCK TABLES so we can't use statement or execution root for them). Note: handler_mdl_context and locked_tables_root and mdl_el_root will be removed by subsequent patches. sql/sql_db.cc: mysql_rm_db() does not really need to call remove_db_from_cache() as it drops each table in the database using mysql_rm_table_part2(), which performs all necessary operations on table (definition) cache. sql/sql_delete.cc: Use the new metadata locking API for TRUNCATE. sql/sql_handler.cc: Changed HANDLER implementation to use new metadata locking subsystem. Note that MDL_LOCK objects for HANDLER tables are allocated in the same chunk of heap memory as TABLE_LIST object for those tables. sql/sql_insert.cc: mysql_insert(): find_locked_table() now takes head of list of TABLE object as its argument instead of always scanning through THD::open_tables list. handle_delayed_insert(): Allocate metadata lock request object for table open by delayed insert thread on execution memroot. create_table_from_items(): We no longer allocate dummy TABLE objects for tables being created if they don't exist. As consequence reopen_name_locked_table() no longer has link_in argument. open_table() now has one more argument which is not relevant for temporary tables. sql/sql_parse.cc: - Moved unlock_locked_tables() routine to sql_base.cc and made available it in other files. Got rid of some redundant code by using this function. - Replaced boolean TABLE_LIST::create member with enum open_table_type member. - Use special memory root for allocating MDL_LOCK objects for tables open and locked by LOCK TABLES (these object should live till UNLOCK TABLES so we can't allocate them on statement nor execution memory root). Also properly set metadata lock upgradability attribure for those tables. - Under LOCK TABLES it is no longer allowed to flush tables which are not write-locked as this breaks metadata locking protocol and thus potentially might lead to deadlock. - Added auxiliary adjust_mdl_locks_upgradability() function. sql/sql_partition.cc: Adjusted code to the fact that reopen_tables() no longer has "mark_share_as_old" argument. Got rid of comments which are no longer true. sql/sql_plist.h: Added I_P_List template class for parametrized intrusive doubly linked lists and I_P_List_iterator for corresponding iterator. Unlike for I_List<> list elements of such list can participate in several lists. Unlike List<> such lists are doubly-linked and intrusive. sql/sql_plugin.cc: Allocate metadata lock requests objects (MDL_LOCK) on execution memory root in cases when we use stack TABLE_LIST objects to open tables. sql/sql_prepare.cc: Replaced boolean TABLE_LIST::create member with enum open_table_type member. This allows easily handle situation in which instead of opening the table we want only to take exclusive metadata lock on it. sql/sql_rename.cc: Use new metadata locking subsystem in implementation of RENAME TABLE. sql/sql_servers.cc: Allocate metadata lock requests objects (MDL_LOCK) on execution memory root in cases when we use stack TABLE_LIST objects to open tables. Got rid of redundant code by using unlock_locked_tables() function. sql/sql_show.cc: Acquire shared metadata lock when we are getting information for I_S table directly from TABLE_SHARE without doing full-blown table open. We use high priority lock request in this situation in order to avoid deadlocks. Also allocate metadata lock requests objects (MDL_LOCK) on execution memory root in cases when TABLE_LIST objects are also allocated there sql/sql_table.cc: mysql_rm_table(): Removed comment which is no longer relevant. mysql_rm_table_part2(): Now caller of mysql_ha_rm_tables() should not own LOCK_open. Adjusted code to use new metadata locking subsystem instead of name-locks. lock_table_name_if_not_cached(): Moved this function from sql_base.cc to this file and reimplemented it using metadata locking API. mysql_create_table(): Adjusted code to use new MDL API. wait_while_table_is_used(): Changed function to use new MDL subsystem. Made thread waiting in it killable (this also led to introduction of return value so caller can distinguish successful executions from situations when waiting was aborted). close_cached_tables(): Thread waiting in this function is killable now. As result it has return value for distinguishing between succes and failure. Got rid of redundant boradcast_refresh() call. prepare_for_repair(): Use MDL subsystem instead of name-locks. mysql_admin_table(): mysql_ha_rm_tables() now always assumes that caller doesn't own LOCK_open. mysql_repair_table(): We should mark all elements of table list as requiring upgradable metadata locks. mysql_create_table_like(): Use new MDL subsystem instead of name-locks. create_temporary_tables(): We don't need to obtain metadata locks when creating temporary table. mysql_fast_or_online_alter_table(): Thread waiting in wait_while_table_is_used() is now killable. mysql_alter_table(): Adjusted code to work with new MDL subsystem and to the fact that threads waiting in what_while_table_is_used() and close_cached_table() are now killable. sql/sql_test.cc: We no longer have separate table cache. TABLE instances are now associated with/linked to TABLE_SHARE objects in table definition cache. sql/sql_trigger.cc: Adjusted code to work with new metadata locking subsystem. Also reopen_tables() no longer has mark_share_as_old argument (Instead of relying on this parameter and related behavior FLUSH TABLES WITH READ LOCK now takes global shared metadata lock). sql/sql_udf.cc: Allocate metadata lock requests objects (MDL_LOCK) on execution memory root in cases when we use stack TABLE_LIST objects to open tables. sql/sql_update.cc: Adjusted code to work with new meta-data locking subsystem. sql/sql_view.cc: Added proper meta-data locking to implementations of CREATE/ALTER/DROP VIEW statements. Now we obtain exclusive meta-data lock on a view before creating/ changing/dropping it. This ensures that all concurrent statements that use this view will finish before our statement will proceed and therefore we will get correct order of statements in the binary log. Also ensure that TABLE_LIST::mdl_upgradable attribute is properly propagated for underlying tables of view. sql/table.cc: Added auxiliary alloc_mdl_locks() function for allocating metadata lock request objects for all elements of table list. sql/table.h: TABLE_SHARE: Got rid of unused members. Introduced members for storing lists of used and unused TABLE objects for this share. TABLE: Added members for linking TABLE objects into per-share lists of used and unused TABLE instances. Added member for holding pointer to metadata lock for this table. TABLE_LIST: Replaced boolean TABLE_LIST::create member with enum open_table_type member. This allows easily handle situation in which instead of opening the table we want only to take exclusive meta-data lock on it (we need this in order to handle ALTER VIEW and CREATE VIEW statements). Introduced new mdl_upgradable member for marking elements of table list for which we need to take upgradable shared metadata lock instead of plain shared metadata lock. Added pointer for holding pointer to MDL_LOCK for the table. Added auxiliary alloc_mdl_locks() function for allocating metadata lock requests objects for all elements of table list. Added auxiliary set_all_mdl_upgradable() function for marking all elements in table list as requiring upgradable metadata locks. storage/myisammrg/ha_myisammrg.cc: Allocate MDL_LOCK objects for underlying tables of MERGE table. To be reworked once Ingo pushes his patch for WL4144.
1534 lines
42 KiB
Text
1534 lines
42 KiB
Text
# Can't test with embedded server
|
|
-- source include/not_embedded.inc
|
|
|
|
# Save the initial number of concurrent sessions
|
|
--source include/count_sessions.inc
|
|
|
|
--disable_warnings
|
|
drop database if exists mysqltest;
|
|
drop view if exists v1,v2,v3;
|
|
--enable_warnings
|
|
|
|
|
|
# simple test of grants
|
|
grant create view on test.* to test@localhost;
|
|
show grants for test@localhost;
|
|
revoke create view on test.* from test@localhost;
|
|
show grants for test@localhost;
|
|
# The grant above creates a new user test@localhost, delete it
|
|
drop user test@localhost;
|
|
|
|
# grant create view test
|
|
#
|
|
connect (root,localhost,root,,test);
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
create table mysqltest.t1 (a int, b int);
|
|
create table mysqltest.t2 (a int, b int);
|
|
|
|
grant select on mysqltest.t1 to mysqltest_1@localhost;
|
|
grant create view,select on test.* to mysqltest_1@localhost;
|
|
|
|
connect (user1,localhost,mysqltest_1,,test);
|
|
connection user1;
|
|
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
create definer=root@localhost view v1 as select * from mysqltest.t1;
|
|
create view v1 as select * from mysqltest.t1;
|
|
# try to modify view without DROP privilege on it
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
alter view v1 as select * from mysqltest.t1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
create or replace view v1 as select * from mysqltest.t1;
|
|
# no CRETE VIEW privilege
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
create view mysqltest.v2 as select * from mysqltest.t1;
|
|
# no SELECT privilege
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
create view v2 as select * from mysqltest.t2;
|
|
|
|
connection root;
|
|
# check view definer information
|
|
show create view v1;
|
|
|
|
grant create view,drop,select on test.* to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
# following 'use' command is workaround of Bug#9582 and should be removed
|
|
# when that bug will be fixed
|
|
use test;
|
|
alter view v1 as select * from mysqltest.t1;
|
|
create or replace view v1 as select * from mysqltest.t1;
|
|
|
|
connection root;
|
|
revoke all privileges on mysqltest.t1 from mysqltest_1@localhost;
|
|
revoke all privileges on test.* from mysqltest_1@localhost;
|
|
|
|
drop database mysqltest;
|
|
drop view test.v1;
|
|
|
|
#
|
|
# grants per columns
|
|
#
|
|
# MERGE algorithm
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
create table mysqltest.t1 (a int, b int);
|
|
create view mysqltest.v1 (c,d) as select a+1,b+1 from mysqltest.t1;
|
|
grant select (c) on mysqltest.v1 to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
select c from mysqltest.v1;
|
|
# there are no privileges on column 'd'
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
select d from mysqltest.v1;
|
|
|
|
connection root;
|
|
revoke all privileges on mysqltest.v1 from mysqltest_1@localhost;
|
|
delete from mysql.user where user='mysqltest_1';
|
|
drop database mysqltest;
|
|
|
|
# TEMPORARY TABLE algorithm
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
create table mysqltest.t1 (a int, b int);
|
|
create algorithm=temptable view mysqltest.v1 (c,d) as select a+1,b+1 from mysqltest.t1;
|
|
grant select (c) on mysqltest.v1 to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
select c from mysqltest.v1;
|
|
# there are no privileges on column 'd'
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
select d from mysqltest.v1;
|
|
|
|
connection root;
|
|
revoke all privileges on mysqltest.v1 from mysqltest_1@localhost;
|
|
delete from mysql.user where user='mysqltest_1';
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# EXPLAIN rights
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
# prepare views and tables
|
|
create table mysqltest.t1 (a int, b int);
|
|
create table mysqltest.t2 (a int, b int);
|
|
create view mysqltest.v1 (c,d) as select a+1,b+1 from mysqltest.t1;
|
|
create algorithm=temptable view mysqltest.v2 (c,d) as select a+1,b+1 from mysqltest.t1;
|
|
create view mysqltest.v3 (c,d) as select a+1,b+1 from mysqltest.t2;
|
|
create algorithm=temptable view mysqltest.v4 (c,d) as select a+1,b+1 from mysqltest.t2;
|
|
grant select on mysqltest.v1 to mysqltest_1@localhost;
|
|
grant select on mysqltest.v2 to mysqltest_1@localhost;
|
|
grant select on mysqltest.v3 to mysqltest_1@localhost;
|
|
grant select on mysqltest.v4 to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
# all selects works
|
|
select c from mysqltest.v1;
|
|
select c from mysqltest.v2;
|
|
select c from mysqltest.v3;
|
|
select c from mysqltest.v4;
|
|
# test of show coluns
|
|
show columns from mysqltest.v1;
|
|
show columns from mysqltest.v2;
|
|
# but explain/show do not
|
|
--error ER_VIEW_NO_EXPLAIN
|
|
explain select c from mysqltest.v1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
show create view mysqltest.v1;
|
|
--error ER_VIEW_NO_EXPLAIN
|
|
explain select c from mysqltest.v2;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
show create view mysqltest.v2;
|
|
--error ER_VIEW_NO_EXPLAIN
|
|
explain select c from mysqltest.v3;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
show create view mysqltest.v3;
|
|
--error ER_VIEW_NO_EXPLAIN
|
|
explain select c from mysqltest.v4;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
show create view mysqltest.v4;
|
|
|
|
# allow to see one of underlying table
|
|
connection root;
|
|
grant select on mysqltest.t1 to mysqltest_1@localhost;
|
|
connection user1;
|
|
# EXPLAIN of view on above table works
|
|
explain select c from mysqltest.v1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
show create view mysqltest.v1;
|
|
explain select c from mysqltest.v2;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
show create view mysqltest.v2;
|
|
# but other EXPLAINs do not
|
|
--error ER_VIEW_NO_EXPLAIN
|
|
explain select c from mysqltest.v3;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
show create view mysqltest.v3;
|
|
--error ER_VIEW_NO_EXPLAIN
|
|
explain select c from mysqltest.v4;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
show create view mysqltest.v4;
|
|
|
|
# allow to see any view in mysqltest database
|
|
connection root;
|
|
grant show view on mysqltest.* to mysqltest_1@localhost;
|
|
connection user1;
|
|
explain select c from mysqltest.v1;
|
|
show create view mysqltest.v1;
|
|
explain select c from mysqltest.v2;
|
|
show create view mysqltest.v2;
|
|
explain select c from mysqltest.v3;
|
|
show create view mysqltest.v3;
|
|
explain select c from mysqltest.v4;
|
|
show create view mysqltest.v4;
|
|
|
|
connection root;
|
|
revoke all privileges on mysqltest.* from mysqltest_1@localhost;
|
|
delete from mysql.user where user='mysqltest_1';
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# UPDATE privileges on VIEW columns and whole VIEW
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
create table mysqltest.t1 (a int, b int, primary key(a));
|
|
insert into mysqltest.t1 values (10,2), (20,3), (30,4), (40,5), (50,10);
|
|
create table mysqltest.t2 (x int);
|
|
insert into mysqltest.t2 values (3), (4), (5), (6);
|
|
create view mysqltest.v1 (a,c) as select a, b+1 from mysqltest.t1;
|
|
create view mysqltest.v2 (a,c) as select a, b from mysqltest.t1;
|
|
create view mysqltest.v3 (a,c) as select a, b+1 from mysqltest.t1;
|
|
|
|
grant update (a) on mysqltest.v2 to mysqltest_1@localhost;
|
|
grant update on mysqltest.v1 to mysqltest_1@localhost;
|
|
grant select on mysqltest.* to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
use mysqltest;
|
|
# update with rights on VIEW column
|
|
update t2,v1 set v1.a=v1.a+v1.c where t2.x=v1.c;
|
|
select * from t1;
|
|
update v1 set a=a+c;
|
|
select * from t1;
|
|
# update with rights on whole VIEW
|
|
update t2,v2 set v2.a=v2.a+v2.c where t2.x=v2.c;
|
|
select * from t1;
|
|
update v2 set a=a+c;
|
|
select * from t1;
|
|
# no rights on column
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
update t2,v2 set v2.c=v2.a+v2.c where t2.x=v2.c;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
update v2 set c=a+c;
|
|
# no rights for view
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
update t2,v3 set v3.a=v3.a+v3.c where t2.x=v3.c;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
update v3 set a=a+c;
|
|
|
|
use test;
|
|
connection root;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# DELETE privileges on VIEW
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
create table mysqltest.t1 (a int, b int, primary key(a));
|
|
insert into mysqltest.t1 values (1,2), (2,3), (3,4), (4,5), (5,10);
|
|
create table mysqltest.t2 (x int);
|
|
insert into mysqltest.t2 values (3), (4), (5), (6);
|
|
create view mysqltest.v1 (a,c) as select a, b+1 from mysqltest.t1;
|
|
create view mysqltest.v2 (a,c) as select a, b+1 from mysqltest.t1;
|
|
|
|
grant delete on mysqltest.v1 to mysqltest_1@localhost;
|
|
grant select on mysqltest.* to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
use mysqltest;
|
|
# update with rights on VIEW column
|
|
delete from v1 where c < 4;
|
|
select * from t1;
|
|
delete v1 from t2,v1 where t2.x=v1.c;
|
|
select * from t1;
|
|
# no rights for view
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
delete v2 from t2,v2 where t2.x=v2.c;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
delete from v2 where c < 4;
|
|
|
|
use test;
|
|
connection root;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# insert privileges on VIEW
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
create table mysqltest.t1 (a int, b int, primary key(a));
|
|
insert into mysqltest.t1 values (1,2), (2,3);
|
|
create table mysqltest.t2 (x int, y int);
|
|
insert into mysqltest.t2 values (3,4);
|
|
create view mysqltest.v1 (a,c) as select a, b from mysqltest.t1;
|
|
create view mysqltest.v2 (a,c) as select a, b from mysqltest.t1;
|
|
|
|
grant insert on mysqltest.v1 to mysqltest_1@localhost;
|
|
grant select on mysqltest.* to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
use mysqltest;
|
|
# update with rights on VIEW column
|
|
insert into v1 values (5,6);
|
|
select * from t1;
|
|
insert into v1 select x,y from t2;
|
|
select * from t1;
|
|
# no rights for view
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
insert into v2 values (5,6);
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
insert into v2 select x,y from t2;
|
|
|
|
use test;
|
|
connection root;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# test of CREATE VIEW privileges if we have limited privileges
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
create table mysqltest.t1 (a int, b int);
|
|
create table mysqltest.t2 (a int, b int);
|
|
|
|
grant update on mysqltest.t1 to mysqltest_1@localhost;
|
|
grant update(b) on mysqltest.t2 to mysqltest_1@localhost;
|
|
grant create view,update on test.* to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
|
|
create view v1 as select * from mysqltest.t1;
|
|
create view v2 as select b from mysqltest.t2;
|
|
# There are not rights on mysqltest.v1
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
create view mysqltest.v1 as select * from mysqltest.t1;
|
|
# There are not any rights on mysqltest.t2.a
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
create view v3 as select a from mysqltest.t2;
|
|
|
|
# give CREATE VIEW privileges (without any privileges for result column)
|
|
connection root;
|
|
create table mysqltest.v3 (b int);
|
|
grant create view on mysqltest.v3 to mysqltest_1@localhost;
|
|
drop table mysqltest.v3;
|
|
connection user1;
|
|
create view mysqltest.v3 as select b from mysqltest.t2;
|
|
|
|
# give UPDATE privileges
|
|
connection root;
|
|
grant create view, update on mysqltest.v3 to mysqltest_1@localhost;
|
|
drop view mysqltest.v3;
|
|
connection user1;
|
|
create view mysqltest.v3 as select b from mysqltest.t2;
|
|
|
|
|
|
# Expression need select privileges
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
create view v4 as select b+1 from mysqltest.t2;
|
|
|
|
connection root;
|
|
grant create view,update,select on test.* to mysqltest_1@localhost;
|
|
connection user1;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
create view v4 as select b+1 from mysqltest.t2;
|
|
|
|
connection root;
|
|
grant update,select(b) on mysqltest.t2 to mysqltest_1@localhost;
|
|
connection user1;
|
|
create view v4 as select b+1 from mysqltest.t2;
|
|
|
|
connection root;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
drop view v1,v2,v4;
|
|
|
|
#
|
|
# user with global DB privileges
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
create table mysqltest.t1 (a int);
|
|
grant all privileges on mysqltest.* to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
use mysqltest;
|
|
create view v1 as select * from t1;
|
|
use test;
|
|
|
|
connection root;
|
|
revoke all privileges on mysqltest.* from mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# view definer grants revoking
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
create table mysqltest.t1 (a int, b int);
|
|
|
|
grant select on mysqltest.t1 to mysqltest_1@localhost;
|
|
grant create view,select on test.* to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
|
|
create view v1 as select * from mysqltest.t1;
|
|
|
|
connection root;
|
|
# check view definer information
|
|
show create view v1;
|
|
revoke select on mysqltest.t1 from mysqltest_1@localhost;
|
|
--error ER_VIEW_INVALID
|
|
select * from v1;
|
|
grant select on mysqltest.t1 to mysqltest_1@localhost;
|
|
select * from v1;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop view v1;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# rights on execution of view underlying functiond (Bug#9505)
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
use mysqltest;
|
|
create table t1 (a int);
|
|
insert into t1 values (1);
|
|
create table t2 (s1 int);
|
|
--disable_warnings
|
|
drop function if exists f2;
|
|
--enable_warnings
|
|
delimiter //;
|
|
create function f2 () returns int begin declare v int; select s1 from t2
|
|
into v; return v; end//
|
|
delimiter ;//
|
|
create algorithm=TEMPTABLE view v1 as select f2() from t1;
|
|
create algorithm=MERGE view v2 as select f2() from t1;
|
|
create algorithm=TEMPTABLE SQL SECURITY INVOKER view v3 as select f2() from t1;
|
|
create algorithm=MERGE SQL SECURITY INVOKER view v4 as select f2() from t1;
|
|
create SQL SECURITY INVOKER view v5 as select * from v4;
|
|
grant select on v1 to mysqltest_1@localhost;
|
|
grant select on v2 to mysqltest_1@localhost;
|
|
grant select on v3 to mysqltest_1@localhost;
|
|
grant select on v4 to mysqltest_1@localhost;
|
|
grant select on v5 to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
use mysqltest;
|
|
select * from v1;
|
|
select * from v2;
|
|
--error ER_VIEW_INVALID
|
|
select * from v3;
|
|
--error ER_VIEW_INVALID
|
|
select * from v4;
|
|
--error ER_VIEW_INVALID
|
|
select * from v5;
|
|
use test;
|
|
|
|
connection root;
|
|
drop view v1, v2, v3, v4, v5;
|
|
drop function f2;
|
|
drop table t1, t2;
|
|
use test;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# revertion of previous test, definer of view lost his/her rights to execute
|
|
# function
|
|
#
|
|
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
use mysqltest;
|
|
create table t1 (a int);
|
|
insert into t1 values (1);
|
|
create table t2 (s1 int);
|
|
--disable_warnings
|
|
drop function if exists f2;
|
|
--enable_warnings
|
|
delimiter //;
|
|
create function f2 () returns int begin declare v int; select s1 from t2
|
|
into v; return v; end//
|
|
delimiter ;//
|
|
grant select on t1 to mysqltest_1@localhost;
|
|
grant execute on function f2 to mysqltest_1@localhost;
|
|
grant create view on mysqltest.* to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
use mysqltest;
|
|
create algorithm=TEMPTABLE view v1 as select f2() from t1;
|
|
create algorithm=MERGE view v2 as select f2() from t1;
|
|
create algorithm=TEMPTABLE SQL SECURITY INVOKER view v3 as select f2() from t1;
|
|
create algorithm=MERGE SQL SECURITY INVOKER view v4 as select f2() from t1;
|
|
use test;
|
|
|
|
connection root;
|
|
create view v5 as select * from v1;
|
|
revoke execute on function f2 from mysqltest_1@localhost;
|
|
--error ER_VIEW_INVALID
|
|
select * from v1;
|
|
--error ER_VIEW_INVALID
|
|
select * from v2;
|
|
select * from v3;
|
|
select * from v4;
|
|
--error ER_VIEW_INVALID
|
|
select * from v5;
|
|
|
|
drop view v1, v2, v3, v4, v5;
|
|
drop function f2;
|
|
drop table t1, t2;
|
|
use test;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# definer/invoker rights for columns
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
use mysqltest;
|
|
create table t1 (a int);
|
|
create table v1 (a int);
|
|
insert into t1 values (1);
|
|
grant select on t1 to mysqltest_1@localhost;
|
|
grant select on v1 to mysqltest_1@localhost;
|
|
grant create view on mysqltest.* to mysqltest_1@localhost;
|
|
drop table v1;
|
|
|
|
connection user1;
|
|
use mysqltest;
|
|
create algorithm=TEMPTABLE view v1 as select *, a as b from t1;
|
|
create algorithm=MERGE view v2 as select *, a as b from t1;
|
|
create algorithm=TEMPTABLE SQL SECURITY INVOKER view v3 as select *, a as b from t1;
|
|
create algorithm=MERGE SQL SECURITY INVOKER view v4 as select *, a as b from t1;
|
|
create view v5 as select * from v1;
|
|
use test;
|
|
|
|
connection root;
|
|
revoke select on t1 from mysqltest_1@localhost;
|
|
--error ER_VIEW_INVALID
|
|
select * from v1;
|
|
--error ER_VIEW_INVALID
|
|
select * from v2;
|
|
select * from v3;
|
|
select * from v4;
|
|
--error ER_VIEW_INVALID
|
|
select * from v5;
|
|
|
|
#drop view v1, v2, v3, v4, v5;
|
|
drop table t1;
|
|
use test;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
use mysqltest;
|
|
create table t1 (a int);
|
|
insert into t1 values (1);
|
|
create algorithm=TEMPTABLE view v1 as select *, a as b from t1;
|
|
create algorithm=MERGE view v2 as select *, a as b from t1;
|
|
create algorithm=TEMPTABLE SQL SECURITY INVOKER view v3 as select *, a as b from t1;
|
|
create algorithm=MERGE SQL SECURITY INVOKER view v4 as select *, a as b from t1;
|
|
create SQL SECURITY INVOKER view v5 as select * from v4;
|
|
grant select on v1 to mysqltest_1@localhost;
|
|
grant select on v2 to mysqltest_1@localhost;
|
|
grant select on v3 to mysqltest_1@localhost;
|
|
grant select on v4 to mysqltest_1@localhost;
|
|
grant select on v5 to mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
use mysqltest;
|
|
select * from v1;
|
|
select * from v2;
|
|
--error ER_VIEW_INVALID
|
|
select * from v3;
|
|
--error ER_VIEW_INVALID
|
|
select * from v4;
|
|
--error ER_VIEW_INVALID
|
|
select * from v5;
|
|
use test;
|
|
|
|
connection root;
|
|
drop view v1, v2, v3, v4, v5;
|
|
drop table t1;
|
|
use test;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# Bug#14256 definer in view definition is not fully qualified
|
|
#
|
|
--disable_warnings
|
|
drop view if exists v1;
|
|
drop table if exists t1;
|
|
--enable_warnings
|
|
|
|
# Backup anonymous users and remove them. (They get in the way of
|
|
# the one we test with here otherwise.)
|
|
create table t1 as select * from mysql.user where user='';
|
|
delete from mysql.user where user='';
|
|
flush privileges;
|
|
|
|
# Create the test user
|
|
grant all on test.* to 'test14256'@'%';
|
|
|
|
connect (test14256,localhost,test14256,,test);
|
|
connection test14256;
|
|
use test;
|
|
|
|
create view v1 as select 42;
|
|
show create view v1;
|
|
|
|
select definer into @v1def1 from information_schema.views
|
|
where table_schema = 'test' and table_name='v1';
|
|
drop view v1;
|
|
|
|
create definer=`test14256`@`%` view v1 as select 42;
|
|
show create view v1;
|
|
|
|
select definer into @v1def2 from information_schema.views
|
|
where table_schema = 'test' and table_name='v1';
|
|
drop view v1;
|
|
|
|
select @v1def1, @v1def2, @v1def1=@v1def2;
|
|
|
|
connection root;
|
|
disconnect test14256;
|
|
drop user test14256;
|
|
|
|
# Restore the anonymous users.
|
|
insert into mysql.user select * from t1;
|
|
flush privileges;
|
|
|
|
drop table t1;
|
|
|
|
#
|
|
# Bug#14726 freeing stack variable in case of an error of opening a view when
|
|
# we have locked tables with LOCK TABLES statement.
|
|
#
|
|
connection root;
|
|
--disable_warnings
|
|
create database mysqltest;
|
|
--enable_warnings
|
|
|
|
use mysqltest;
|
|
CREATE TABLE t1 (i INT);
|
|
CREATE VIEW v1 AS SELECT * FROM t1;
|
|
SHOW CREATE VIEW v1;
|
|
GRANT SELECT, LOCK TABLES ON mysqltest.* TO mysqltest_1@localhost;
|
|
|
|
connection user1;
|
|
|
|
use mysqltest;
|
|
LOCK TABLES v1 READ;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SHOW CREATE TABLE v1;
|
|
UNLOCK TABLES;
|
|
use test;
|
|
|
|
connection root;
|
|
use test;
|
|
drop user mysqltest_1@localhost;
|
|
drop database mysqltest;
|
|
|
|
#
|
|
# switch to default connection
|
|
#
|
|
disconnect user1;
|
|
disconnect root;
|
|
connection default;
|
|
|
|
#
|
|
# DEFINER information check
|
|
#
|
|
create definer=some_user@`` sql security invoker view v1 as select 1;
|
|
create definer=some_user@localhost sql security invoker view v2 as select 1;
|
|
show create view v1;
|
|
show create view v2;
|
|
drop view v1;
|
|
drop view v2;
|
|
|
|
#
|
|
# Bug#18681 View privileges are broken
|
|
#
|
|
CREATE DATABASE mysqltest1;
|
|
CREATE USER readonly@localhost;
|
|
CREATE TABLE mysqltest1.t1 (x INT);
|
|
INSERT INTO mysqltest1.t1 VALUES (1), (2);
|
|
CREATE SQL SECURITY INVOKER VIEW mysqltest1.v_t1 AS SELECT * FROM mysqltest1.t1;
|
|
CREATE SQL SECURITY DEFINER VIEW mysqltest1.v_ts AS SELECT * FROM mysqltest1.t1;
|
|
CREATE SQL SECURITY DEFINER VIEW mysqltest1.v_ti AS SELECT * FROM mysqltest1.t1;
|
|
CREATE SQL SECURITY DEFINER VIEW mysqltest1.v_tu AS SELECT * FROM mysqltest1.t1;
|
|
CREATE SQL SECURITY DEFINER VIEW mysqltest1.v_tus AS SELECT * FROM mysqltest1.t1;
|
|
CREATE SQL SECURITY DEFINER VIEW mysqltest1.v_td AS SELECT * FROM mysqltest1.t1;
|
|
CREATE SQL SECURITY DEFINER VIEW mysqltest1.v_tds AS SELECT * FROM mysqltest1.t1;
|
|
GRANT SELECT, INSERT, UPDATE, DELETE ON mysqltest1.v_t1 TO readonly@localhost;
|
|
GRANT SELECT ON mysqltest1.v_ts TO readonly@localhost;
|
|
GRANT INSERT ON mysqltest1.v_ti TO readonly@localhost;
|
|
GRANT UPDATE ON mysqltest1.v_tu TO readonly@localhost;
|
|
GRANT UPDATE,SELECT ON mysqltest1.v_tus TO readonly@localhost;
|
|
GRANT DELETE ON mysqltest1.v_td TO readonly@localhost;
|
|
GRANT DELETE,SELECT ON mysqltest1.v_tds TO readonly@localhost;
|
|
|
|
connect (n1,localhost,readonly,,);
|
|
connection n1;
|
|
|
|
--error ER_VIEW_INVALID
|
|
SELECT * FROM mysqltest1.v_t1;
|
|
--error ER_VIEW_INVALID
|
|
INSERT INTO mysqltest1.v_t1 VALUES(4);
|
|
--error ER_VIEW_INVALID
|
|
DELETE FROM mysqltest1.v_t1 WHERE x = 1;
|
|
--error ER_VIEW_INVALID
|
|
UPDATE mysqltest1.v_t1 SET x = 3 WHERE x = 2;
|
|
--error ER_VIEW_INVALID
|
|
UPDATE mysqltest1.v_t1 SET x = 3;
|
|
--error ER_VIEW_INVALID
|
|
DELETE FROM mysqltest1.v_t1;
|
|
--error ER_VIEW_INVALID
|
|
SELECT 1 FROM mysqltest1.v_t1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM mysqltest1.t1;
|
|
|
|
SELECT * FROM mysqltest1.v_ts;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM mysqltest1.v_ts, mysqltest1.t1 WHERE mysqltest1.t1.x = mysqltest1.v_ts.x;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM mysqltest1.v_ti;
|
|
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
INSERT INTO mysqltest1.v_ts VALUES (100);
|
|
INSERT INTO mysqltest1.v_ti VALUES (100);
|
|
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
UPDATE mysqltest1.v_ts SET x= 200 WHERE x = 100;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
UPDATE mysqltest1.v_ts SET x= 200;
|
|
UPDATE mysqltest1.v_tu SET x= 200 WHERE x = 100;
|
|
UPDATE mysqltest1.v_tus SET x= 200 WHERE x = 100;
|
|
UPDATE mysqltest1.v_tu SET x= 200;
|
|
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
DELETE FROM mysqltest1.v_ts WHERE x= 200;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
DELETE FROM mysqltest1.v_ts;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
DELETE FROM mysqltest1.v_td WHERE x= 200;
|
|
DELETE FROM mysqltest1.v_tds WHERE x= 200;
|
|
DELETE FROM mysqltest1.v_td;
|
|
|
|
connection default;
|
|
disconnect n1;
|
|
DROP VIEW mysqltest1.v_tds;
|
|
DROP VIEW mysqltest1.v_td;
|
|
DROP VIEW mysqltest1.v_tus;
|
|
DROP VIEW mysqltest1.v_tu;
|
|
DROP VIEW mysqltest1.v_ti;
|
|
DROP VIEW mysqltest1.v_ts;
|
|
DROP VIEW mysqltest1.v_t1;
|
|
DROP TABLE mysqltest1.t1;
|
|
DROP USER readonly@localhost;
|
|
DROP DATABASE mysqltest1;
|
|
|
|
#
|
|
# Bug#14875 Bad view DEFINER makes SHOW CREATE VIEW fail
|
|
#
|
|
CREATE TABLE t1 (a INT PRIMARY KEY);
|
|
INSERT INTO t1 VALUES (1), (2), (3);
|
|
CREATE DEFINER = 'no-such-user'@localhost VIEW v AS SELECT a from t1;
|
|
#--warning ER_VIEW_OTHER_USER
|
|
SHOW CREATE VIEW v;
|
|
--error ER_NO_SUCH_USER
|
|
SELECT * FROM v;
|
|
DROP VIEW v;
|
|
DROP TABLE t1;
|
|
USE test;
|
|
|
|
#
|
|
# Bug#20363 Create view on just created view is now denied
|
|
#
|
|
eval CREATE USER mysqltest_db1@localhost identified by 'PWD';
|
|
eval GRANT ALL ON mysqltest_db1.* TO mysqltest_db1@localhost WITH GRANT OPTION;
|
|
|
|
# The session with the non root user is needed.
|
|
--replace_result $MASTER_MYPORT MYSQL_PORT $MASTER_MYSOCK MYSQL_SOCK
|
|
connect (session1,localhost,mysqltest_db1,PWD,test);
|
|
|
|
CREATE SCHEMA mysqltest_db1 ;
|
|
USE mysqltest_db1 ;
|
|
|
|
CREATE TABLE t1 (f1 INTEGER);
|
|
|
|
CREATE VIEW view1 AS
|
|
SELECT * FROM t1;
|
|
SHOW CREATE VIEW view1;
|
|
|
|
CREATE VIEW view2 AS
|
|
SELECT * FROM view1;
|
|
--echo # Here comes a suspicious warning
|
|
SHOW CREATE VIEW view2;
|
|
--echo # But the view view2 is usable
|
|
SELECT * FROM view2;
|
|
|
|
CREATE VIEW view3 AS
|
|
SELECT * FROM view2;
|
|
|
|
SELECT * from view3;
|
|
|
|
connection default;
|
|
disconnect session1;
|
|
DROP VIEW mysqltest_db1.view3;
|
|
DROP VIEW mysqltest_db1.view2;
|
|
DROP VIEW mysqltest_db1.view1;
|
|
DROP TABLE mysqltest_db1.t1;
|
|
DROP SCHEMA mysqltest_db1;
|
|
DROP USER mysqltest_db1@localhost;
|
|
#
|
|
# Bug#20482 failure on Create join view with sources views/tables
|
|
# in different schemas
|
|
#
|
|
--disable_warnings
|
|
CREATE DATABASE test1;
|
|
CREATE DATABASE test2;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE test1.t0 (a VARCHAR(20));
|
|
CREATE TABLE test2.t1 (a VARCHAR(20));
|
|
CREATE VIEW test2.t3 AS SELECT * FROM test1.t0;
|
|
CREATE OR REPLACE VIEW test.v1 AS
|
|
SELECT ta.a AS col1, tb.a AS col2 FROM test2.t3 ta, test2.t1 tb;
|
|
|
|
DROP VIEW test.v1;
|
|
DROP VIEW test2.t3;
|
|
DROP TABLE test2.t1, test1.t0;
|
|
DROP DATABASE test2;
|
|
DROP DATABASE test1;
|
|
|
|
|
|
#
|
|
# Bug#20570 CURRENT_USER() in a VIEW with SQL SECURITY DEFINER returns
|
|
# invoker name
|
|
#
|
|
--disable_warnings
|
|
DROP VIEW IF EXISTS v1;
|
|
DROP VIEW IF EXISTS v2;
|
|
DROP VIEW IF EXISTS v3;
|
|
DROP FUNCTION IF EXISTS f1;
|
|
DROP FUNCTION IF EXISTS f2;
|
|
DROP PROCEDURE IF EXISTS p1;
|
|
--enable_warnings
|
|
|
|
CREATE SQL SECURITY DEFINER VIEW v1 AS SELECT CURRENT_USER() AS cu;
|
|
|
|
CREATE FUNCTION f1() RETURNS VARCHAR(77) SQL SECURITY INVOKER
|
|
RETURN CURRENT_USER();
|
|
CREATE SQL SECURITY DEFINER VIEW v2 AS SELECT f1() AS cu;
|
|
|
|
CREATE PROCEDURE p1(OUT cu VARCHAR(77)) SQL SECURITY INVOKER
|
|
SET cu= CURRENT_USER();
|
|
delimiter |;
|
|
CREATE FUNCTION f2() RETURNS VARCHAR(77) SQL SECURITY INVOKER
|
|
BEGIN
|
|
DECLARE cu VARCHAR(77);
|
|
CALL p1(cu);
|
|
RETURN cu;
|
|
END|
|
|
delimiter ;|
|
|
CREATE SQL SECURITY DEFINER VIEW v3 AS SELECT f2() AS cu;
|
|
|
|
CREATE USER mysqltest_u1@localhost;
|
|
GRANT ALL ON test.* TO mysqltest_u1@localhost;
|
|
|
|
connect (conn1, localhost, mysqltest_u1,,);
|
|
|
|
--echo
|
|
--echo The following tests should all return 1.
|
|
--echo
|
|
SELECT CURRENT_USER() = 'mysqltest_u1@localhost';
|
|
SELECT f1() = 'mysqltest_u1@localhost';
|
|
CALL p1(@cu);
|
|
SELECT @cu = 'mysqltest_u1@localhost';
|
|
SELECT f2() = 'mysqltest_u1@localhost';
|
|
SELECT cu = 'root@localhost' FROM v1;
|
|
SELECT cu = 'root@localhost' FROM v2;
|
|
SELECT cu = 'root@localhost' FROM v3;
|
|
|
|
disconnect conn1;
|
|
connection default;
|
|
|
|
DROP VIEW v3;
|
|
DROP FUNCTION f2;
|
|
DROP PROCEDURE p1;
|
|
DROP FUNCTION f1;
|
|
DROP VIEW v2;
|
|
DROP VIEW v1;
|
|
DROP USER mysqltest_u1@localhost;
|
|
|
|
|
|
#
|
|
# Bug#17254 Error for DEFINER security on VIEW provides too much info
|
|
#
|
|
connect (root,localhost,root,,);
|
|
connection root;
|
|
CREATE DATABASE db17254;
|
|
USE db17254;
|
|
CREATE TABLE t1 (f1 INT);
|
|
INSERT INTO t1 VALUES (10),(20);
|
|
CREATE USER def_17254@localhost;
|
|
GRANT SELECT ON db17254.* TO def_17254@localhost;
|
|
CREATE USER inv_17254@localhost;
|
|
GRANT SELECT ON db17254.t1 TO inv_17254@localhost;
|
|
GRANT CREATE VIEW ON db17254.* TO def_17254@localhost;
|
|
|
|
connect (def,localhost,def_17254,,db17254);
|
|
connection def;
|
|
CREATE VIEW v1 AS SELECT * FROM t1;
|
|
|
|
connection root;
|
|
DROP USER def_17254@localhost;
|
|
|
|
connect (inv,localhost,inv_17254,,db17254);
|
|
connection inv;
|
|
--echo for a user
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM v1;
|
|
|
|
connection root;
|
|
--echo for a superuser
|
|
--error ER_NO_SUCH_USER
|
|
SELECT * FROM v1;
|
|
DROP USER inv_17254@localhost;
|
|
DROP DATABASE db17254;
|
|
disconnect def;
|
|
disconnect inv;
|
|
|
|
|
|
#
|
|
# Bug#24404 strange bug with view+permission+prepared statement
|
|
#
|
|
--disable_warnings
|
|
DROP DATABASE IF EXISTS mysqltest_db1;
|
|
DROP DATABASE IF EXISTS mysqltest_db2;
|
|
--enable_warnings
|
|
--error 0,ER_CANNOT_USER
|
|
DROP USER mysqltest_u1;
|
|
--error 0,ER_CANNOT_USER
|
|
DROP USER mysqltest_u2;
|
|
|
|
CREATE USER mysqltest_u1@localhost;
|
|
CREATE USER mysqltest_u2@localhost;
|
|
|
|
CREATE DATABASE mysqltest_db1;
|
|
CREATE DATABASE mysqltest_db2;
|
|
|
|
GRANT ALL ON mysqltest_db1.* TO mysqltest_u1@localhost WITH GRANT OPTION;
|
|
GRANT ALL ON mysqltest_db2.* TO mysqltest_u2@localhost;
|
|
|
|
connect (conn1, localhost, mysqltest_u1, , mysqltest_db1);
|
|
|
|
CREATE TABLE t1 (i INT);
|
|
INSERT INTO t1 VALUES (1);
|
|
|
|
# Use view with subquery for better coverage.
|
|
CREATE VIEW v1 AS SELECT i FROM t1 WHERE 1 IN (SELECT * FROM t1);
|
|
|
|
CREATE TABLE t2 (s CHAR(7));
|
|
INSERT INTO t2 VALUES ('public');
|
|
|
|
GRANT SELECT ON v1 TO mysqltest_u2@localhost;
|
|
GRANT SELECT ON t2 TO mysqltest_u2@localhost;
|
|
|
|
connect (conn2, localhost, mysqltest_u2, , mysqltest_db2);
|
|
|
|
SELECT * FROM mysqltest_db1.v1, mysqltest_db1.t2;
|
|
PREPARE stmt1 FROM "SELECT * FROM mysqltest_db1.t2";
|
|
EXECUTE stmt1;
|
|
PREPARE stmt2 FROM "SELECT * FROM mysqltest_db1.v1, mysqltest_db1.t2";
|
|
EXECUTE stmt2;
|
|
|
|
connection conn1;
|
|
# Make table 't2' private.
|
|
REVOKE SELECT ON t2 FROM mysqltest_u2@localhost;
|
|
UPDATE t2 SET s = 'private' WHERE s = 'public';
|
|
|
|
connection conn2;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM mysqltest_db1.v1, mysqltest_db1.t2;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
EXECUTE stmt1;
|
|
# Original bug was here: the statement didn't fail.
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
EXECUTE stmt2;
|
|
|
|
# Cleanup.
|
|
disconnect conn2;
|
|
disconnect conn1;
|
|
connection default;
|
|
REVOKE ALL ON mysqltest_db1.* FROM mysqltest_u1@localhost;
|
|
REVOKE ALL ON mysqltest_db2.* FROM mysqltest_u2@localhost;
|
|
DROP DATABASE mysqltest_db1;
|
|
DROP DATABASE mysqltest_db2;
|
|
DROP USER mysqltest_u1@localhost;
|
|
DROP USER mysqltest_u2@localhost;
|
|
|
|
#
|
|
# Bug#26813 The SUPER privilege is wrongly required to alter a view created
|
|
# by another user.
|
|
#
|
|
connection root;
|
|
CREATE DATABASE db26813;
|
|
USE db26813;
|
|
CREATE TABLE t1(f1 INT, f2 INT);
|
|
CREATE VIEW v1 AS SELECT f1 FROM t1;
|
|
CREATE VIEW v2 AS SELECT f1 FROM t1;
|
|
CREATE VIEW v3 AS SELECT f1 FROM t1;
|
|
CREATE USER u26813@localhost;
|
|
GRANT DROP ON db26813.v1 TO u26813@localhost;
|
|
GRANT CREATE VIEW ON db26813.v2 TO u26813@localhost;
|
|
GRANT DROP, CREATE VIEW ON db26813.v3 TO u26813@localhost;
|
|
GRANT SELECT ON db26813.t1 TO u26813@localhost;
|
|
|
|
connect (u1,localhost,u26813,,db26813);
|
|
connection u1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
ALTER VIEW v1 AS SELECT f2 FROM t1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
ALTER VIEW v2 AS SELECT f2 FROM t1;
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
ALTER VIEW v3 AS SELECT f2 FROM t1;
|
|
|
|
connection root;
|
|
SHOW CREATE VIEW v3;
|
|
|
|
DROP USER u26813@localhost;
|
|
DROP DATABASE db26813;
|
|
disconnect u1;
|
|
|
|
--echo #
|
|
--echo # Bug#29908 A user can gain additional access through the ALTER VIEW.
|
|
--echo #
|
|
connection root;
|
|
CREATE DATABASE mysqltest_29908;
|
|
USE mysqltest_29908;
|
|
CREATE TABLE t1(f1 INT, f2 INT);
|
|
CREATE USER u29908_1@localhost;
|
|
CREATE DEFINER = u29908_1@localhost VIEW v1 AS SELECT f1 FROM t1;
|
|
CREATE DEFINER = u29908_1@localhost SQL SECURITY INVOKER VIEW v2 AS
|
|
SELECT f1 FROM t1;
|
|
GRANT SELECT, DROP, CREATE VIEW, SHOW VIEW ON mysqltest_29908.v1 TO u29908_1@localhost;
|
|
GRANT SELECT, DROP, CREATE VIEW, SHOW VIEW ON mysqltest_29908.v2 TO u29908_1@localhost;
|
|
GRANT SELECT ON mysqltest_29908.t1 TO u29908_1@localhost;
|
|
CREATE USER u29908_2@localhost;
|
|
GRANT SELECT, DROP, CREATE VIEW ON mysqltest_29908.v1 TO u29908_2@localhost;
|
|
GRANT SELECT, DROP, CREATE VIEW, SHOW VIEW ON mysqltest_29908.v2 TO u29908_2@localhost;
|
|
GRANT SELECT ON mysqltest_29908.t1 TO u29908_2@localhost;
|
|
|
|
connect (u2,localhost,u29908_2,,mysqltest_29908);
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
ALTER VIEW v1 AS SELECT f2 FROM t1;
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
ALTER VIEW v2 AS SELECT f2 FROM t1;
|
|
SHOW CREATE VIEW v2;
|
|
|
|
connect (u1,localhost,u29908_1,,mysqltest_29908);
|
|
ALTER VIEW v1 AS SELECT f2 FROM t1;
|
|
SHOW CREATE VIEW v1;
|
|
ALTER VIEW v2 AS SELECT f2 FROM t1;
|
|
SHOW CREATE VIEW v2;
|
|
|
|
connection root;
|
|
ALTER VIEW v1 AS SELECT f1 FROM t1;
|
|
SHOW CREATE VIEW v1;
|
|
ALTER VIEW v2 AS SELECT f1 FROM t1;
|
|
SHOW CREATE VIEW v2;
|
|
|
|
DROP USER u29908_1@localhost;
|
|
DROP USER u29908_2@localhost;
|
|
DROP DATABASE mysqltest_29908;
|
|
disconnect u1;
|
|
disconnect u2;
|
|
--echo #######################################################################
|
|
|
|
#
|
|
# Bug#24040 Create View don't succed with "all privileges" on a database.
|
|
#
|
|
|
|
# Prepare.
|
|
|
|
--disable_warnings
|
|
DROP DATABASE IF EXISTS mysqltest1;
|
|
DROP DATABASE IF EXISTS mysqltest2;
|
|
--enable_warnings
|
|
|
|
CREATE DATABASE mysqltest1;
|
|
CREATE DATABASE mysqltest2;
|
|
|
|
# Test.
|
|
|
|
CREATE TABLE mysqltest1.t1(c1 INT);
|
|
CREATE TABLE mysqltest1.t2(c2 INT);
|
|
CREATE TABLE mysqltest1.t3(c3 INT);
|
|
CREATE TABLE mysqltest1.t4(c4 INT);
|
|
|
|
INSERT INTO mysqltest1.t1 VALUES (11), (12), (13), (14);
|
|
INSERT INTO mysqltest1.t2 VALUES (21), (22), (23), (24);
|
|
INSERT INTO mysqltest1.t3 VALUES (31), (32), (33), (34);
|
|
INSERT INTO mysqltest1.t4 VALUES (41), (42), (43), (44);
|
|
|
|
GRANT SELECT ON mysqltest1.t1 TO mysqltest_u1@localhost;
|
|
GRANT INSERT ON mysqltest1.t2 TO mysqltest_u1@localhost;
|
|
GRANT SELECT, UPDATE ON mysqltest1.t3 TO mysqltest_u1@localhost;
|
|
GRANT SELECT, DELETE ON mysqltest1.t4 TO mysqltest_u1@localhost;
|
|
|
|
GRANT ALL PRIVILEGES ON mysqltest2.* TO mysqltest_u1@localhost;
|
|
|
|
--connect (bug24040_con,localhost,mysqltest_u1,,mysqltest2)
|
|
--echo
|
|
--echo ---> connection: bug24040_con
|
|
|
|
SELECT * FROM mysqltest1.t1;
|
|
INSERT INTO mysqltest1.t2 VALUES(25);
|
|
UPDATE mysqltest1.t3 SET c3 = 331 WHERE c3 = 31;
|
|
DELETE FROM mysqltest1.t4 WHERE c4 = 44;
|
|
|
|
CREATE VIEW v1 AS SELECT * FROM mysqltest1.t1;
|
|
CREATE VIEW v2 AS SELECT * FROM mysqltest1.t2;
|
|
CREATE VIEW v3 AS SELECT * FROM mysqltest1.t3;
|
|
CREATE VIEW v4 AS SELECT * FROM mysqltest1.t4;
|
|
|
|
SELECT * FROM v1;
|
|
INSERT INTO v2 VALUES(26);
|
|
UPDATE v3 SET c3 = 332 WHERE c3 = 32;
|
|
DELETE FROM v4 WHERE c4 = 43;
|
|
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
CREATE VIEW v12 AS SELECT c1, c2 FROM mysqltest1.t1, mysqltest1.t2;
|
|
CREATE VIEW v13 AS SELECT c1, c3 FROM mysqltest1.t1, mysqltest1.t3;
|
|
CREATE VIEW v14 AS SELECT c1, c4 FROM mysqltest1.t1, mysqltest1.t4;
|
|
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
CREATE VIEW v21 AS SELECT c2, c1 FROM mysqltest1.t2, mysqltest1.t1;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
CREATE VIEW v23 AS SELECT c2, c3 FROM mysqltest1.t2, mysqltest1.t3;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
CREATE VIEW v24 AS SELECT c2, c4 FROM mysqltest1.t2, mysqltest1.t4;
|
|
|
|
CREATE VIEW v31 AS SELECT c3, c1 FROM mysqltest1.t3, mysqltest1.t1;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
CREATE VIEW v32 AS SELECT c3, c2 FROM mysqltest1.t3, mysqltest1.t2;
|
|
CREATE VIEW v34 AS SELECT c3, c4 FROM mysqltest1.t3, mysqltest1.t4;
|
|
|
|
CREATE VIEW v41 AS SELECT c4, c1 FROM mysqltest1.t4, mysqltest1.t1;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
CREATE VIEW v42 AS SELECT c4, c2 FROM mysqltest1.t4, mysqltest1.t2;
|
|
CREATE VIEW v43 AS SELECT c4, c3 FROM mysqltest1.t4, mysqltest1.t3;
|
|
|
|
--connection default
|
|
--echo
|
|
--echo ---> connection: default
|
|
|
|
SELECT * FROM mysqltest1.t1;
|
|
SELECT * FROM mysqltest1.t2;
|
|
SELECT * FROM mysqltest1.t3;
|
|
SELECT * FROM mysqltest1.t4;
|
|
|
|
# Cleanup.
|
|
|
|
disconnect bug24040_con;
|
|
|
|
DROP DATABASE mysqltest1;
|
|
DROP DATABASE mysqltest2;
|
|
DROP USER mysqltest_u1@localhost;
|
|
|
|
|
|
#
|
|
# Bug#41354 Access control is bypassed when all columns of a view are
|
|
# selected by * wildcard
|
|
|
|
CREATE DATABASE db1;
|
|
USE db1;
|
|
CREATE TABLE t1(f1 INT, f2 INT);
|
|
CREATE VIEW v1 AS SELECT f1, f2 FROM t1;
|
|
|
|
GRANT SELECT (f1) ON t1 TO foo;
|
|
GRANT SELECT (f1) ON v1 TO foo;
|
|
|
|
connect (addconfoo, localhost, foo,,);
|
|
connection addconfoo;
|
|
USE db1;
|
|
|
|
SELECT f1 FROM t1;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
SELECT f2 FROM t1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM t1;
|
|
|
|
SELECT f1 FROM v1;
|
|
--error ER_COLUMNACCESS_DENIED_ERROR
|
|
SELECT f2 FROM v1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM v1;
|
|
|
|
connection default;
|
|
disconnect root;
|
|
disconnect addconfoo;
|
|
USE test;
|
|
REVOKE SELECT (f1) ON db1.t1 FROM foo;
|
|
REVOKE SELECT (f1) ON db1.v1 FROM foo;
|
|
DROP USER foo;
|
|
DROP VIEW db1.v1;
|
|
DROP TABLE db1.t1;
|
|
DROP DATABASE db1;
|
|
|
|
--echo End of 5.0 tests.
|
|
|
|
|
|
#
|
|
# Test that ALTER VIEW accepts DEFINER and ALGORITHM, see bug#16425.
|
|
#
|
|
connection default;
|
|
--disable_warnings
|
|
DROP VIEW IF EXISTS v1;
|
|
DROP TABLE IF EXISTS t1;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t1 (i INT);
|
|
CREATE VIEW v1 AS SELECT * FROM t1;
|
|
|
|
ALTER VIEW v1 AS SELECT * FROM t1;
|
|
SHOW CREATE VIEW v1;
|
|
ALTER DEFINER=no_such@user_1 VIEW v1 AS SELECT * FROM t1;
|
|
SHOW CREATE VIEW v1;
|
|
ALTER ALGORITHM=MERGE VIEW v1 AS SELECT * FROM t1;
|
|
SHOW CREATE VIEW v1;
|
|
ALTER ALGORITHM=TEMPTABLE DEFINER=no_such@user_2 VIEW v1 AS SELECT * FROM t1;
|
|
SHOW CREATE VIEW v1;
|
|
|
|
DROP VIEW v1;
|
|
DROP TABLE t1;
|
|
|
|
#
|
|
# Bug#37191: Failed assertion in CREATE VIEW
|
|
#
|
|
CREATE USER mysqluser1@localhost;
|
|
CREATE DATABASE mysqltest1;
|
|
|
|
USE mysqltest1;
|
|
|
|
CREATE TABLE t1 ( a INT );
|
|
CREATE TABLE t2 ( b INT );
|
|
|
|
INSERT INTO t1 VALUES (1), (2);
|
|
INSERT INTO t2 VALUES (1), (2);
|
|
|
|
GRANT CREATE VIEW ON mysqltest1.* TO mysqluser1@localhost;
|
|
|
|
GRANT SELECT ON t1 TO mysqluser1@localhost;
|
|
GRANT INSERT ON t2 TO mysqluser1@localhost;
|
|
|
|
--connect (connection1, localhost, mysqluser1, , mysqltest1)
|
|
|
|
--echo This would lead to failed assertion.
|
|
CREATE VIEW v1 AS SELECT a, b FROM t1, t2;
|
|
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM v1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT b FROM v1;
|
|
|
|
--disconnect connection1
|
|
--connection default
|
|
|
|
DROP TABLE t1, t2;
|
|
DROP VIEW v1;
|
|
DROP DATABASE mysqltest1;
|
|
DROP USER mysqluser1@localhost;
|
|
USE test;
|
|
|
|
--echo End of 5.1 tests.
|
|
|
|
#
|
|
# Bug#36086: SELECT * from views don't check column grants
|
|
#
|
|
CREATE USER mysqluser1@localhost;
|
|
CREATE DATABASE mysqltest1;
|
|
|
|
USE mysqltest1;
|
|
|
|
CREATE TABLE t1 ( a INT, b INT );
|
|
CREATE TABLE t2 ( a INT, b INT );
|
|
|
|
CREATE VIEW v1 AS SELECT a, b FROM t1;
|
|
|
|
GRANT SELECT( a ) ON v1 TO mysqluser1@localhost;
|
|
GRANT UPDATE( b ) ON t2 TO mysqluser1@localhost;
|
|
|
|
--connect (connection1, localhost, mysqluser1, , test)
|
|
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SELECT * FROM mysqltest1.v1;
|
|
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
CREATE VIEW v1 AS SELECT * FROM mysqltest1.t2;
|
|
|
|
--disconnect connection1
|
|
|
|
--connection default
|
|
|
|
DROP TABLE t1, t2;
|
|
DROP VIEW v1;
|
|
DROP DATABASE mysqltest1;
|
|
DROP USER mysqluser1@localhost;
|
|
|
|
#
|
|
# Bug#35600 Security breach via view, I_S table and prepared
|
|
# statement/stored procedure
|
|
#
|
|
CREATE USER mysqluser1@localhost;
|
|
CREATE DATABASE mysqltest1;
|
|
|
|
USE mysqltest1;
|
|
|
|
CREATE VIEW v1 AS SELECT * FROM information_schema.tables LIMIT 1;
|
|
CREATE ALGORITHM = TEMPTABLE VIEW v2 AS SELECT 1 AS A;
|
|
|
|
CREATE VIEW test.v3 AS SELECT 1 AS a;
|
|
|
|
--connection default
|
|
GRANT SELECT ON mysqltest1.* to mysqluser1@localhost;
|
|
GRANT ALL ON test.* TO mysqluser1@localhost;
|
|
|
|
--connect (connection1, localhost, mysqluser1, , test)
|
|
PREPARE stmt_v1 FROM "SELECT * FROM mysqltest1.v1";
|
|
PREPARE stmt_v2 FROM "SELECT * FROM mysqltest1.v2";
|
|
|
|
--connection default
|
|
REVOKE SELECT ON mysqltest1.* FROM mysqluser1@localhost;
|
|
|
|
--connection connection1
|
|
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
EXECUTE stmt_v1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
EXECUTE stmt_v2;
|
|
--disconnect connection1
|
|
|
|
--connect (connection2, localhost, mysqluser1,,)
|
|
PREPARE stmt FROM "SELECT a FROM v3";
|
|
EXECUTE stmt;
|
|
--disconnect connection2
|
|
|
|
--connection default
|
|
DROP VIEW v1, v2;
|
|
DROP DATABASE mysqltest1;
|
|
DROP VIEW test.v3;
|
|
DROP USER mysqluser1@localhost;
|
|
USE test;
|
|
|
|
--echo #
|
|
--echo # Bug#35996: SELECT + SHOW VIEW should be enough to display view
|
|
--echo # definition
|
|
--echo #
|
|
-- source include/not_embedded.inc
|
|
CREATE USER mysqluser1@localhost;
|
|
CREATE DATABASE mysqltest1;
|
|
CREATE DATABASE mysqltest2;
|
|
GRANT USAGE, SELECT, CREATE VIEW, SHOW VIEW
|
|
ON mysqltest2.* TO mysqluser1@localhost;
|
|
|
|
USE mysqltest1;
|
|
|
|
CREATE TABLE t1( a INT );
|
|
CREATE TABLE t2( a INT, b INT );
|
|
CREATE FUNCTION f1() RETURNS INT RETURN 1;
|
|
CREATE VIEW v1 AS SELECT 1 AS a;
|
|
CREATE VIEW v2 AS SELECT 1 AS a, 2 AS b;
|
|
|
|
GRANT SELECT ON TABLE t1 TO mysqluser1@localhost;
|
|
GRANT SELECT (a, b) ON TABLE t2 TO mysqluser1@localhost;
|
|
GRANT EXECUTE ON FUNCTION f1 TO mysqluser1@localhost;
|
|
GRANT SELECT ON TABLE v1 TO mysqluser1@localhost;
|
|
GRANT SELECT (a, b) ON TABLE v2 TO mysqluser1@localhost;
|
|
|
|
CREATE VIEW v_t1 AS SELECT * FROM t1;
|
|
CREATE VIEW v_t2 AS SELECT * FROM t2;
|
|
CREATE VIEW v_f1 AS SELECT f1() AS a;
|
|
CREATE VIEW v_v1 AS SELECT * FROM v1;
|
|
CREATE VIEW v_v2 AS SELECT * FROM v2;
|
|
|
|
GRANT SELECT, SHOW VIEW ON v_t1 TO mysqluser1@localhost;
|
|
GRANT SELECT, SHOW VIEW ON v_t2 TO mysqluser1@localhost;
|
|
GRANT SELECT, SHOW VIEW ON v_f1 TO mysqluser1@localhost;
|
|
GRANT SELECT, SHOW VIEW ON v_v1 TO mysqluser1@localhost;
|
|
GRANT SELECT, SHOW VIEW ON v_v2 TO mysqluser1@localhost;
|
|
|
|
--connect (connection1, localhost, mysqluser1,, mysqltest2)
|
|
CREATE VIEW v_mysqluser1_t1 AS SELECT * FROM mysqltest1.t1;
|
|
CREATE VIEW v_mysqluser1_t2 AS SELECT * FROM mysqltest1.t2;
|
|
CREATE VIEW v_mysqluser1_f1 AS SELECT mysqltest1.f1() AS a;
|
|
CREATE VIEW v_mysqluser1_v1 AS SELECT * FROM mysqltest1.v1;
|
|
CREATE VIEW v_mysqluser1_v2 AS SELECT * FROM mysqltest1.v2;
|
|
|
|
SHOW CREATE VIEW mysqltest1.v_t1;
|
|
SHOW CREATE VIEW mysqltest1.v_t2;
|
|
SHOW CREATE VIEW mysqltest1.v_f1;
|
|
SHOW CREATE VIEW mysqltest1.v_v1;
|
|
SHOW CREATE VIEW mysqltest1.v_v2;
|
|
|
|
SHOW CREATE VIEW v_mysqluser1_t1;
|
|
SHOW CREATE VIEW v_mysqluser1_t2;
|
|
SHOW CREATE VIEW v_mysqluser1_f1;
|
|
SHOW CREATE VIEW v_mysqluser1_v1;
|
|
SHOW CREATE VIEW v_mysqluser1_v2;
|
|
|
|
--connection default
|
|
REVOKE SELECT ON TABLE t1 FROM mysqluser1@localhost;
|
|
REVOKE SELECT (a) ON TABLE t2 FROM mysqluser1@localhost;
|
|
REVOKE EXECUTE ON FUNCTION f1 FROM mysqluser1@localhost;
|
|
REVOKE SELECT ON TABLE v1 FROM mysqluser1@localhost;
|
|
|
|
--connection connection1
|
|
SHOW CREATE VIEW mysqltest1.v_t1;
|
|
SHOW CREATE VIEW mysqltest1.v_t2;
|
|
SHOW CREATE VIEW mysqltest1.v_f1;
|
|
SHOW CREATE VIEW mysqltest1.v_v1;
|
|
SHOW CREATE VIEW mysqltest1.v_v2;
|
|
|
|
SHOW CREATE VIEW v_mysqluser1_t1;
|
|
SHOW CREATE VIEW v_mysqluser1_t2;
|
|
SHOW CREATE VIEW v_mysqluser1_f1;
|
|
SHOW CREATE VIEW v_mysqluser1_v1;
|
|
SHOW CREATE VIEW v_mysqluser1_v2;
|
|
|
|
--connection default
|
|
--echo # Testing the case when the views reference missing objects.
|
|
--echo # Obviously, there are no privileges to check for, so we
|
|
--echo # need only each object type once.
|
|
DROP TABLE t1;
|
|
DROP FUNCTION f1;
|
|
DROP VIEW v1;
|
|
|
|
--connection connection1
|
|
SHOW CREATE VIEW mysqltest1.v_t1;
|
|
SHOW CREATE VIEW mysqltest1.v_f1;
|
|
SHOW CREATE VIEW mysqltest1.v_v1;
|
|
|
|
SHOW CREATE VIEW v_mysqluser1_t1;
|
|
SHOW CREATE VIEW v_mysqluser1_f1;
|
|
SHOW CREATE VIEW v_mysqluser1_v1;
|
|
|
|
--connection default
|
|
REVOKE SHOW VIEW ON v_t1 FROM mysqluser1@localhost;
|
|
REVOKE SHOW VIEW ON v_f1 FROM mysqluser1@localhost;
|
|
REVOKE SHOW VIEW ON v_v1 FROM mysqluser1@localhost;
|
|
|
|
--connection connection1
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SHOW CREATE VIEW mysqltest1.v_t1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SHOW CREATE VIEW mysqltest1.v_f1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
SHOW CREATE VIEW mysqltest1.v_v1;
|
|
SHOW CREATE VIEW v_mysqluser1_t1;
|
|
SHOW CREATE VIEW v_mysqluser1_f1;
|
|
SHOW CREATE VIEW v_mysqluser1_v1;
|
|
|
|
--disconnect connection1
|
|
--connection default
|
|
DROP USER mysqluser1@localhost;
|
|
DROP DATABASE mysqltest1;
|
|
DROP DATABASE mysqltest2;
|
|
USE test;
|
|
|
|
CREATE TABLE t1( a INT );
|
|
CREATE DEFINER = no_such_user@no_such_host VIEW v1 AS SELECT * FROM t1;
|
|
SHOW CREATE VIEW v1;
|
|
DROP TABLE t1;
|
|
DROP VIEW v1;
|
|
|
|
# Wait till we reached the initial number of concurrent sessions
|
|
--source include/wait_until_count_sessions.inc
|
|
|
|
--echo #
|
|
--echo # Bug #46019: ERROR 1356 When selecting from within another
|
|
--echo # view that has Group By
|
|
--echo #
|
|
CREATE DATABASE mysqltest1;
|
|
USE mysqltest1;
|
|
|
|
CREATE TABLE t1 (a INT);
|
|
|
|
CREATE SQL SECURITY INVOKER VIEW v1 AS SELECT a FROM t1 GROUP BY a;
|
|
CREATE SQL SECURITY INVOKER VIEW v2 AS SELECT a FROM v1;
|
|
|
|
CREATE USER mysqluser1;
|
|
|
|
GRANT SELECT ON TABLE t1 TO mysqluser1;
|
|
GRANT SELECT, SHOW VIEW ON TABLE v1 TO mysqluser1;
|
|
GRANT SELECT, SHOW VIEW ON TABLE v2 TO mysqluser1;
|
|
|
|
--connect (mysqluser1, localhost, mysqluser1,,mysqltest1)
|
|
SELECT a FROM v1;
|
|
SELECT a FROM v2;
|
|
|
|
--connection default
|
|
--disconnect mysqluser1
|
|
DROP USER mysqluser1;
|
|
DROP DATABASE mysqltest1;
|