mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 13:02:28 +01:00
26565ae1d6
- Fix for LP#700623 "Aria recovery: ma_blockrec.c:3930: _ma_update_at_original_place: Assertion `block->org_bitmap_value == _ma_bitmap_get_page_bits(info, &info->s->bitmap, page)' failed" - Issue was that when deleting a tail page where all index entries where full, the page was marked wrongly in the bitmap. - If debug_assert_if_crashed_table is set, we now crash when we find Aria corrupted. - Write more information if we find something wrong with the bitmap. - Fixed that REPAIR also can fix wrong create_rename_lsn issues (a very unlikely event) - Define STATE_CRASHED_FLAGS as set of all CRASHED flags (to simplify code) storage/maria/ha_maria.cc: Mark the normal page cache (not the page cache for the logs) so that we can request extra debugging for it. Copy the value of debug_assert_if_crashed_table to maria_assert_if_crashed_table so that we can request a crash at exactly the point where we find Aria corrupted. Use STATE_CRASHED_FLAGS storage/maria/ma_bitmap.c: Made bits_to_txt extern so that we can use this in maria_chk Added extra information to the log files to be able to easier find bitmap failures in recovery. (When compiling with -DEXTRA_DEBUG_BITMAP) Added _ma_get_bitmap_description() to request a clear text description of the bitmap. Simplify _ma_check_bitmap_data(), as we know the bitmap pattern in the caller. storage/maria/ma_blockrec.c: In delete_head_or_tail(), fixed a bug where we sent wrong information to _ma_bitmap_set() if the directory was full for a page that should be freed. This fixed LP#700623 (failure in bitmap found during recovery) storage/maria/ma_blockrec.h: Added definitions for _ma_get_bitmap_description() and bits_to_txt storage/maria/ma_check.c: Simplify call to _ma_check_bitmap_data(). Write more information if we find something wrong with the bitmap. Moved getting clear text information about the bitmap to ma_bitmap.c::_ma_get_bitmap_description() storage/maria/ma_checkpoint.c: More asserts storage/maria/ma_create.c: Fix wrong create_rename_lsn during repair. (Create_rename_lsn can be too big if someone restores an old maria_log_file after an Aria file was created) storage/maria/ma_delete.c: Call _ma_set_fatal_error() in case of crashed file Remove not needed test of save_errno == HA_ERR_KEY_NOT_FOUND. (Handled by other code storage/maria/ma_extra.c: Call _ma_set_fatal_error() in case of crashed file Reset share->bitmap.changed_not_flushed to not cause new ASSERTS to trigger. Added _ma_file_callback_to_id() for writing share->id to log file in case of DEBUG logging. storage/maria/ma_init.c: Destroy also translog if it's readonly (as when called by maria_read_log -d) storage/maria/ma_key.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_key_recover.c: STATE_CRASHED -> STATE_CRASHED_FLAGS storage/maria/ma_keycache.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_locking.c: Call _ma_set_fatal_error() in case of crashed file. Added _ma_set_fatal_error() storage/maria/ma_open.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_page.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_pagecache.c: Added extra information to log file to simply debugging of bitmap errors. storage/maria/ma_pagecache.h: Added extra_debug flag to allow marking of row and index cache for extra logging (for debugging). storage/maria/ma_panic.c: Flush both data and index blocks in case of HA_PANIC_CLOSE Fixed wrong position of 'break'. (Not critical for MariaDB as MariaDB never uses this code) storage/maria/ma_recovery_util.c: Avoid writing extra not needed \n to DBUG log. storage/maria/ma_rkey.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_search.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_static.c: Define maria_assert_if_crashed_table storage/maria/ma_update.c: Call _ma_set_fatal_error() in case of crashed file. The new code also avoids a problem where we before would print the error twice. storage/maria/ma_write.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/maria_chk.c: STATE_CRASHED -> STATE_CRASHED_FLAGS storage/maria/maria_def.h: Added STATE_CRASHED_PRINTED to avoid giving error message about crash twice. Added STATE_CRASHED_FLAGS to be able to easily detect and set all CRASHED related flags. Added prototypes for new functions. storage/myisam/mi_panic.c: Fixed wrong position of 'break'. (Not critical for MariaDB as MariaDB never uses this code)
202 lines
6.7 KiB
C
202 lines
6.7 KiB
C
/* Copyright (C) 2006 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/* Read record based on a key */
|
|
|
|
#include "maria_def.h"
|
|
#include "ma_rt_index.h"
|
|
|
|
/**
|
|
Read a record using key
|
|
|
|
@note
|
|
Ordinary search_flag is 0 ; Give error if no record with key
|
|
*/
|
|
|
|
int maria_rkey(MARIA_HA *info, uchar *buf, int inx, const uchar *key_data,
|
|
key_part_map keypart_map, enum ha_rkey_function search_flag)
|
|
{
|
|
uchar *key_buff;
|
|
MARIA_SHARE *share= info->s;
|
|
MARIA_KEYDEF *keyinfo;
|
|
HA_KEYSEG *last_used_keyseg;
|
|
uint32 nextflag;
|
|
MARIA_KEY key;
|
|
DBUG_ENTER("maria_rkey");
|
|
DBUG_PRINT("enter", ("base: 0x%lx buf: 0x%lx inx: %d search_flag: %d",
|
|
(long) info, (long) buf, inx, search_flag));
|
|
|
|
if ((inx = _ma_check_index(info,inx)) < 0)
|
|
DBUG_RETURN(my_errno);
|
|
|
|
info->update&= (HA_STATE_CHANGED | HA_STATE_ROW_CHANGED);
|
|
info->last_key_func= search_flag;
|
|
keyinfo= info->last_key.keyinfo;
|
|
|
|
key_buff= info->lastkey_buff+info->s->base.max_key_length;
|
|
|
|
if (info->once_flags & USE_PACKED_KEYS)
|
|
{
|
|
info->once_flags&= ~USE_PACKED_KEYS; /* Reset flag */
|
|
/*
|
|
key is already packed!; This happens when we are using a MERGE TABLE
|
|
In this key 'key_part_map' is the length of the key !
|
|
*/
|
|
bmove(key_buff, key_data, keypart_map);
|
|
key.data= key_buff;
|
|
key.keyinfo= keyinfo;
|
|
key.data_length= keypart_map;
|
|
key.ref_length= 0;
|
|
key.flag= 0;
|
|
|
|
last_used_keyseg= keyinfo->seg + info->last_used_keyseg;
|
|
}
|
|
else
|
|
{
|
|
DBUG_ASSERT(keypart_map);
|
|
/* Save the packed key for later use in the second buffer of lastkey. */
|
|
_ma_pack_key(info, &key, inx, key_buff, key_data,
|
|
keypart_map, &last_used_keyseg);
|
|
/* Save packed_key_length for use by the MERGE engine. */
|
|
info->pack_key_length= key.data_length;
|
|
info->last_used_keyseg= (uint16) (last_used_keyseg -
|
|
keyinfo->seg);
|
|
DBUG_EXECUTE("key", _ma_print_key(DBUG_FILE, &key););
|
|
}
|
|
|
|
if (fast_ma_readinfo(info))
|
|
goto err;
|
|
if (share->lock_key_trees)
|
|
rw_rdlock(&keyinfo->root_lock);
|
|
|
|
nextflag= maria_read_vec[search_flag] | key.flag;
|
|
if (search_flag != HA_READ_KEY_EXACT ||
|
|
((keyinfo->flag & (HA_NOSAME | HA_NULL_PART)) != HA_NOSAME))
|
|
nextflag|= SEARCH_SAVE_BUFF;
|
|
|
|
switch (keyinfo->key_alg) {
|
|
#ifdef HAVE_RTREE_KEYS
|
|
case HA_KEY_ALG_RTREE:
|
|
if (maria_rtree_find_first(info, &key, nextflag) < 0)
|
|
{
|
|
_ma_set_fatal_error(share, HA_ERR_CRASHED);
|
|
info->cur_row.lastpos= HA_OFFSET_ERROR;
|
|
}
|
|
break;
|
|
#endif
|
|
case HA_KEY_ALG_BTREE:
|
|
default:
|
|
if (!_ma_search(info, &key, nextflag, info->s->state.key_root[inx]))
|
|
{
|
|
MARIA_KEY lastkey;
|
|
lastkey.keyinfo= keyinfo;
|
|
lastkey.data= info->lastkey_buff;
|
|
/*
|
|
Found a key, but it might not be usable. We cannot use rows that
|
|
are inserted by other threads after we got our table lock
|
|
("concurrent inserts"). The record may not even be present yet.
|
|
Keys are inserted into the index(es) before the record is
|
|
inserted into the data file.
|
|
*/
|
|
if ((*share->row_is_visible)(info))
|
|
break;
|
|
|
|
/* The key references a concurrently inserted record. */
|
|
if (search_flag == HA_READ_KEY_EXACT &&
|
|
last_used_keyseg == keyinfo->seg + keyinfo->keysegs)
|
|
{
|
|
/* Simply ignore the key if it matches exactly. (Bug #29838) */
|
|
my_errno= HA_ERR_KEY_NOT_FOUND;
|
|
info->cur_row.lastpos= HA_OFFSET_ERROR;
|
|
break;
|
|
}
|
|
|
|
do
|
|
{
|
|
uint not_used[2];
|
|
/*
|
|
Skip rows that are inserted by other threads since we got
|
|
a lock. Note that this can only happen if we are not
|
|
searching after a full length exact key, because the keys
|
|
are sorted according to position.
|
|
*/
|
|
lastkey.data_length= info->last_key.data_length;
|
|
lastkey.ref_length= info->last_key.ref_length;
|
|
lastkey.flag= info->last_key.flag;
|
|
if (_ma_search_next(info, &lastkey, maria_readnext_vec[search_flag],
|
|
info->s->state.key_root[inx]))
|
|
break; /* purecov: inspected */
|
|
/*
|
|
Check that the found key does still match the search.
|
|
_ma_search_next() delivers the next key regardless of its
|
|
value.
|
|
*/
|
|
if (!(nextflag & (SEARCH_BIGGER | SEARCH_SMALLER)) &&
|
|
ha_key_cmp(keyinfo->seg, info->last_key.data, key.data,
|
|
key.data_length, SEARCH_FIND, not_used))
|
|
{
|
|
/* purecov: begin inspected */
|
|
my_errno= HA_ERR_KEY_NOT_FOUND;
|
|
info->cur_row.lastpos= HA_OFFSET_ERROR;
|
|
break;
|
|
/* purecov: end */
|
|
}
|
|
} while (!(*share->row_is_visible)(info));
|
|
}
|
|
}
|
|
if (share->lock_key_trees)
|
|
rw_unlock(&keyinfo->root_lock);
|
|
|
|
if (info->cur_row.lastpos == HA_OFFSET_ERROR)
|
|
{
|
|
fast_ma_writeinfo(info);
|
|
goto err;
|
|
}
|
|
|
|
/* Calculate length of the found key; Used by maria_rnext_same */
|
|
if ((keyinfo->flag & HA_VAR_LENGTH_KEY))
|
|
info->last_rkey_length= _ma_keylength_part(keyinfo, info->lastkey_buff,
|
|
last_used_keyseg);
|
|
else
|
|
info->last_rkey_length= key.data_length;
|
|
|
|
/* Check if we don't want to have record back, only error message */
|
|
if (!buf)
|
|
{
|
|
fast_ma_writeinfo(info);
|
|
DBUG_RETURN(0);
|
|
}
|
|
if (!(*info->read_record)(info, buf, info->cur_row.lastpos))
|
|
{
|
|
info->update|= HA_STATE_AKTIV; /* Record is read */
|
|
DBUG_RETURN(0);
|
|
}
|
|
|
|
info->cur_row.lastpos= HA_OFFSET_ERROR; /* Didn't find row */
|
|
|
|
err:
|
|
/* Store last used key as a base for read next */
|
|
memcpy(info->last_key.data, key_buff, key.data_length);
|
|
info->last_key.data_length= key.data_length;
|
|
info->last_key.ref_length= info->s->base.rec_reflength;
|
|
info->last_key.flag= 0;
|
|
/* Create key with rowid 0 */
|
|
bzero((char*) info->last_key.data + info->last_key.data_length,
|
|
info->s->base.rec_reflength);
|
|
|
|
if (search_flag == HA_READ_AFTER_KEY)
|
|
info->update|=HA_STATE_NEXT_FOUND; /* Previous gives last row */
|
|
DBUG_RETURN(my_errno);
|
|
} /* _ma_rkey */
|