mirror of
https://github.com/MariaDB/server.git
synced 2025-01-27 17:33:44 +01:00
fbe81e3c97
of sync In RBR, sometimes the table->s->last_null_bit_pos can be zero. This has impact at the slave when it compares records fetched from the storage engine against records in the binary log event. If last_null_bit_pos is zero the slave, while comparing in log_event.cc:record_compare function, would set all bits in the last null_byte to 1 (assumed all 8 were unused) . Thence it would loose the ability to distinguish records that were similar in contents except for the fact that some field was null in one record, but not in the other. Ultimately this would cause wrong matches, and in the specific case depicted in the bug report the same record would be updated twice, resulting in a lost update. Additionally, in the record_compare function the slave was setting the X bit unconditionally. There are cases that the X bit does not exist in the record header. This could also lead to wrong matches between records. We fix both by conditionally resetting the bits: (i) unused null_bits are set if last_null_bit_pos > 0; (ii) X bit is set if HA_OPTION_PACK_RECORD is in use. mysql-test/extra/rpl_tests/rpl_record_compare.test: Shared part of the test case for MyISAM and InnoDB. mysql-test/suite/rpl/t/rpl_row_rec_comp_innodb.test: InnoDB test case. mysql-test/suite/rpl/t/rpl_row_rec_comp_myisam.test: MyISAM test case. Added also coverage for Field_bits case. sql/log_event.cc: Deployed conditional setting of unused bits at record_compare. sql/log_event_old.cc: Same change as in log_event.cc. |
||
|---|---|---|
| .. | ||
| rpl_auto_increment.test | ||
| rpl_auto_increment_insert_view.test | ||
| rpl_auto_increment_invoke_trigger.test | ||
| rpl_autoinc_func_invokes_trigger.test | ||
| rpl_blackhole.test | ||
| rpl_charset.test | ||
| rpl_commit_after_flush.test | ||
| rpl_conflicts.test | ||
| rpl_ddl.test | ||
| rpl_deadlock.test | ||
| rpl_delete_no_where.test | ||
| rpl_EE_err.test | ||
| rpl_extraMaster_Col.test | ||
| rpl_extraSlave_Col.test | ||
| rpl_failed_optimize.test | ||
| rpl_flsh_tbls.test | ||
| rpl_foreign_key.test | ||
| rpl_get_master_version_and_clock.test | ||
| rpl_insert_delayed.test | ||
| rpl_insert_id.test | ||
| rpl_insert_id_pk.test | ||
| rpl_insert_ignore.test | ||
| rpl_loaddata.test | ||
| rpl_loadfile.test | ||
| rpl_log.test | ||
| rpl_max_relay_size.test | ||
| rpl_mixing_engines.inc | ||
| rpl_mixing_engines.test | ||
| rpl_multi_query.test | ||
| rpl_multi_update.test | ||
| rpl_multi_update2.test | ||
| rpl_multi_update3.test | ||
| rpl_ndb_2multi_basic.test | ||
| rpl_ndb_2multi_eng.test | ||
| rpl_ndb_apply_status.test | ||
| rpl_not_null.test | ||
| rpl_partition.test | ||
| rpl_record_compare.test | ||
| rpl_relayrotate.test | ||
| rpl_reset_slave.test | ||
| rpl_row_001.test | ||
| rpl_row_basic.test | ||
| rpl_row_blob.test | ||
| rpl_row_delayed_ins.test | ||
| rpl_row_func003.test | ||
| rpl_row_sp002.test | ||
| rpl_row_sp003.test | ||
| rpl_row_sp006.test | ||
| rpl_row_sp007.test | ||
| rpl_row_tabledefs.test | ||
| rpl_row_UUID.test | ||
| rpl_set_null.test | ||
| rpl_stm_000001.test | ||
| rpl_stm_EE_err2.test | ||
| rpl_sv_relay_space.test | ||
| rpl_tmp_table_and_DDL.test | ||
| rpl_trig004.test | ||
| rpl_truncate.test | ||
| rpl_truncate_helper.test | ||