mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 21:12:26 +01:00
6e69536956
Problem 1: tests often fail in pushbuild with a timeout when waiting for the slave to start/stop/receive error. Fix 1: Updated the wait_for_slave_* macros in the following way: - The timeout is increased by a factor ten - Refactored the macros so that wait_for_slave_param does the work for the other macros. Problem 2: Tests are often incorrectly written, lacking a source include/wait_for_slave_to_[start|stop].inc. Fix 2: Improved the chance to get it right by adding include/start_slave.inc and include/stop_slave.inc, and updated tests to use these. Problem 3: The the built-in test language command wait_for_slave_to_stop is a misnomer (does not wait for the slave io thread) and does not give as much debug info in case of failure as the otherwise equivalent macro source include/wait_for_slave_sql_to_stop.inc Fix 3: Replaced all calls to the built-in command by a call to the macro. Problem 4: Some, but not all, of the wait_for_slave_* macros had an implicit connection slave. This made some tests confusing to read, and made it more difficult to use the macro in circular replication scenarios, where the connection named master needs to wait. Fix 4: Removed the implicit connection slave from all wait_for_slave_* macros, and updated tests to use an explicit connection slave where necessary. Problem 5: The macros wait_slave_status.inc and wait_show_pattern.inc were unused. Moreover, using them is difficult and error-prone. Fix 5: remove these macros. Problem 6: log_bin_trust_function_creators_basic failed when running tests because it assumed @@global.log_bin_trust_function_creators=1, and some tests modified this variable without resetting it to its original value. Fix 6: All tests that use this variable have been updated so that they reset the value at end of test. mysql-test/extra/rpl_tests/rpl_extraMaster_Col.test: Replaced wait_for_slave_to_stop by include/wait_for_slave_sql_to_stop.inc mysql-test/extra/rpl_tests/rpl_extraSlave_Col.test: Replaced wait_for_slave_to_stop by include/wait_for_slave_sql_to_stop.inc Added connection slave since includ/wait_for_slave_sql_to_stop.inc does not do that anymore. mysql-test/extra/rpl_tests/rpl_log.test: Replaced start slave+wait_slave_status by start_slave.inc mysql-test/include/reset_master_and_slave.inc: replaced start/stop slave by start_slave.inc/stop_slave.inc mysql-test/include/sync_slave_io_with_master.inc: Improved comments and error message. mysql-test/include/wait_for_slave_io_to_stop.inc: Refactored to use wait_for_slave_param.inc. Removed connection slave. mysql-test/include/wait_for_slave_param.inc: - Improved usage instructions - Added more debug info in case of timeout - Added parameters $slave_param_comparison, $slave_timeout, $slave_keep_connection, $slave_error_message mysql-test/include/wait_for_slave_sql_error.inc: Refactored to use wait_for_slave_param.inc. Removed connection slave. mysql-test/include/wait_for_slave_sql_to_start.inc: Refactored to use wait_for_slave_param.inc. Removed connection slave. mysql-test/include/wait_for_slave_sql_to_stop.inc: Refactored to use wait_for_slave_param.inc. Removed connection slave. mysql-test/include/wait_for_slave_to_start.inc: Refactored to use wait_for_slave_param.inc. Removed connection slave. mysql-test/include/wait_for_slave_to_stop.inc: Refactored to use wait_for_slave_param.inc. Removed connection slave. mysql-test/include/wait_show_pattern.inc: Removed unused (and error-prone) file mysql-test/include/wait_slave_status.inc: Removed unused (and error-prone) file mysql-test/suite/binlog/t/binlog_auto_increment_bug33029.test: Renamed $keep_connection to $slave_keep_connection. mysql-test/suite/rpl/t/rpl_bug26395.test: Replace stop slave by stop_slave.inc mysql-test/suite/rpl/t/rpl_circular_for_4_hosts.test: Replace start/stop slave by start_slave.inc/stop_slave.inc. Replace wait_for_slave_param by wait_for_slave_sql_to_stop.inc. mysql-test/suite/rpl/t/rpl_dual_pos_advance.test: Renamed $keep_connection to $slave_keep_connection. mysql-test/suite/rpl/t/rpl_flushlog_loop.test: Replace wait_slave_status by start_slave.inc mysql-test/suite/rpl/t/rpl_idempotency.test: Added connection slave since wait_for_slave_sql_to_stop.inc does not do that any more. mysql-test/suite/rpl/t/rpl_incident.test: Replaced wait_for_slave_to_stop by wait_for_slave_sql_to_stop.inc mysql-test/suite/rpl/t/rpl_init_slave.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. Replaced save_master_pos;connection slave;sync_with_master by sync_slave_with_master. mysql-test/suite/rpl/t/rpl_log_pos.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. Replaced wait_for_slave_param by other wait_for_slave_* macros. mysql-test/suite/rpl/t/rpl_packet.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. mysql-test/suite/rpl/t/rpl_row_inexist_tbl.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. mysql-test/suite/rpl/t/rpl_row_stop_middle_update.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. mysql-test/suite/rpl/t/rpl_row_until.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. Replaced save_master_pos;connection slave;sync_with_master by sync_slave_with_master. mysql-test/suite/rpl/t/rpl_server_id1.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. mysql-test/suite/rpl/t/rpl_slave_grp_exec.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. mysql-test/suite/rpl/t/rpl_slave_skip.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. mysql-test/suite/rpl/t/rpl_slave_status.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. mysql-test/suite/rpl/t/rpl_sp.test: Restore @@global.log_bin_trust_function_creators at end of test. mysql-test/suite/rpl/t/rpl_sp_effects.test: Restore @@global.log_bin_trust_function_creators at end of test. mysql-test/suite/rpl/t/rpl_stm_until.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. Replaced save_master_pos;connection slave;sync_with_master by sync_slave_with_master. mysql-test/suite/rpl_ndb/t/rpl_ndb_basic.test: Replaced start slave by start_slave.inc. Added explicit connection slave since wait_for_slave_sql_to_stop.inc does not do that anymore. mysql-test/t/disabled.def: Disabled failing test. mysql-test/t/func_time.test: Restore @@global.log_bin_trust_function_creators at end of test. mysql-test/t/grant.test: Restore @@global.log_bin_trust_function_creators at end of test. mysql-test/t/grant2.test: Restore @@global.log_bin_trust_function_creators at end of test. mysql-test/t/innodb_notembedded.test: Restore @@global.log_bin_trust_function_creators at end of test. mysql-test/t/log_bin_trust_function_creators_func.test: Restore @@global.log_bin_trust_function_creators at end of test. Clean up at end of test by dropping the created user. mysql-test/t/query_cache.test: Restore @@global.log_bin_trust_function_creators at end of test. mysql-test/t/query_cache_notembedded.test: Restore @@global.log_bin_trust_function_creators at end of test. mysql-test/t/rpl_init_slave_func.test: Replaced start/stop slave by start_slave.inc/stop_slave.inc. mysql-test/t/timezone2.test: Restore @@global.log_bin_trust_function_creators at end of test.
233 lines
5.5 KiB
Text
233 lines
5.5 KiB
Text
stop slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
start slave;
|
|
==== 0. Setting it all up ====
|
|
SET BINLOG_FORMAT=STATEMENT;
|
|
**** On Master ****
|
|
CREATE TABLE t1 (a INT);
|
|
CREATE TABLE logtbl (sect INT, test INT, count INT);
|
|
INSERT INTO t1 VALUES (1),(2),(3);
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
#### 1. Using statement mode ####
|
|
==== 1.1. Simple test ====
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
a
|
|
7
|
|
SELECT FOUND_ROWS() INTO @a;
|
|
INSERT INTO logtbl VALUES(1,1,@a);
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
a
|
|
1
|
|
SELECT FOUND_ROWS() INTO @a;
|
|
INSERT INTO logtbl VALUES(1,2,@a);
|
|
SELECT * FROM logtbl WHERE sect = 1 ORDER BY sect,test;
|
|
sect test count
|
|
1 1 183
|
|
1 2 3
|
|
**** On Slave ****
|
|
SELECT * FROM logtbl WHERE sect = 1 ORDER BY sect,test;
|
|
sect test count
|
|
1 1 183
|
|
1 2 3
|
|
==== 1.2. Stored procedure ====
|
|
**** On Master ****
|
|
CREATE PROCEDURE calc_and_log(sect INT, test INT) BEGIN
|
|
DECLARE cnt INT;
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
SELECT FOUND_ROWS() INTO cnt;
|
|
INSERT INTO logtbl VALUES(sect,test,cnt);
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
SELECT FOUND_ROWS() INTO cnt;
|
|
INSERT INTO logtbl VALUES(sect,test+1,cnt);
|
|
END $$
|
|
CALL calc_and_log(2,1);
|
|
a
|
|
1
|
|
a
|
|
7
|
|
CREATE PROCEDURE just_log(sect INT, test INT, found_rows INT) BEGIN
|
|
INSERT INTO logtbl VALUES (sect,test,found_rows);
|
|
END $$
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
a
|
|
7
|
|
SELECT FOUND_ROWS() INTO @found_rows;
|
|
CALL just_log(2,3,@found_rows);
|
|
SELECT * FROM logtbl WHERE sect = 2 ORDER BY sect,test;
|
|
sect test count
|
|
2 1 3
|
|
2 2 183
|
|
2 3 183
|
|
**** On Slave ****
|
|
SELECT * FROM logtbl WHERE sect = 2 ORDER BY sect,test;
|
|
sect test count
|
|
2 1 3
|
|
2 2 183
|
|
2 3 183
|
|
==== 1.3. Stored functions ====
|
|
**** On Master ****
|
|
CREATE FUNCTION log_rows(sect INT, test INT, found_rows INT)
|
|
RETURNS INT
|
|
BEGIN
|
|
INSERT INTO logtbl VALUES(sect,test,found_rows);
|
|
RETURN found_rows;
|
|
END $$
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
a
|
|
7
|
|
SELECT FOUND_ROWS() INTO @found_rows;
|
|
SELECT log_rows(3,1,@found_rows), log_rows(3,2,@found_rows);
|
|
log_rows(3,1,@found_rows) log_rows(3,2,@found_rows)
|
|
183 183
|
|
SELECT * FROM logtbl WHERE sect = 3 ORDER BY sect,test;
|
|
sect test count
|
|
3 1 183
|
|
3 2 183
|
|
**** On Slave ****
|
|
SELECT * FROM logtbl WHERE sect = 3 ORDER BY sect,test;
|
|
sect test count
|
|
3 1 183
|
|
3 2 183
|
|
==== 1.9. Cleanup ====
|
|
**** On Master ****
|
|
DELETE FROM logtbl;
|
|
DROP PROCEDURE just_log;
|
|
DROP PROCEDURE calc_and_log;
|
|
DROP FUNCTION log_rows;
|
|
**** Resetting master and slave ****
|
|
include/stop_slave.inc
|
|
RESET SLAVE;
|
|
RESET MASTER;
|
|
include/start_slave.inc
|
|
#### 2. Using mixed mode ####
|
|
==== 2.1. Checking a procedure ====
|
|
**** On Master ****
|
|
SET BINLOG_FORMAT=MIXED;
|
|
CREATE PROCEDURE just_log(sect INT, test INT) BEGIN
|
|
INSERT INTO logtbl VALUES (sect,test,FOUND_ROWS());
|
|
END $$
|
|
**** On Master 1 ****
|
|
SET BINLOG_FORMAT=MIXED;
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
a
|
|
7
|
|
CALL just_log(1,1);
|
|
**** On Master ****
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
a
|
|
7
|
|
CALL just_log(1,2);
|
|
**** On Master 1 ****
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
a
|
|
1
|
|
CALL just_log(1,3);
|
|
**** On Master ****
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
a
|
|
7
|
|
CALL just_log(1,4);
|
|
SELECT * FROM logtbl WHERE sect = 1 ORDER BY sect,test;
|
|
sect test count
|
|
1 1 183
|
|
1 2 183
|
|
1 3 3
|
|
1 4 183
|
|
**** On Slave ****
|
|
SELECT * FROM logtbl WHERE sect = 1 ORDER BY sect,test;
|
|
sect test count
|
|
1 1 183
|
|
1 2 183
|
|
1 3 3
|
|
1 4 183
|
|
==== 2.1. Checking a stored function ====
|
|
**** On Master ****
|
|
CREATE FUNCTION log_rows(sect INT, test INT)
|
|
RETURNS INT
|
|
BEGIN
|
|
DECLARE found_rows INT;
|
|
SELECT FOUND_ROWS() INTO found_rows;
|
|
INSERT INTO logtbl VALUES(sect,test,found_rows);
|
|
RETURN found_rows;
|
|
END $$
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
a
|
|
1
|
|
SELECT log_rows(2,1), log_rows(2,2);
|
|
log_rows(2,1) log_rows(2,2)
|
|
3 3
|
|
CREATE TABLE t2 (a INT, b INT);
|
|
CREATE TRIGGER t2_tr BEFORE INSERT ON t2 FOR EACH ROW
|
|
BEGIN
|
|
INSERT INTO logtbl VALUES (NEW.a, NEW.b, FOUND_ROWS());
|
|
END $$
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
a
|
|
1
|
|
INSERT INTO t2 VALUES (2,3), (2,4);
|
|
DROP TRIGGER t2_tr;
|
|
CREATE TRIGGER t2_tr BEFORE INSERT ON t2 FOR EACH ROW
|
|
BEGIN
|
|
DECLARE dummy INT;
|
|
SELECT log_rows(NEW.a, NEW.b) INTO dummy;
|
|
END $$
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
a
|
|
7
|
|
INSERT INTO t2 VALUES (2,5), (2,6);
|
|
DROP TRIGGER t2_tr;
|
|
CREATE PROCEDURE log_me_inner(sect INT, test INT)
|
|
BEGIN
|
|
DECLARE dummy INT;
|
|
SELECT log_rows(sect, test) INTO dummy;
|
|
SELECT log_rows(sect, test+1) INTO dummy;
|
|
END $$
|
|
CREATE PROCEDURE log_me(sect INT, test INT)
|
|
BEGIN
|
|
CALL log_me_inner(sect,test);
|
|
END $$
|
|
CREATE TRIGGER t2_tr BEFORE INSERT ON t2 FOR EACH ROW
|
|
BEGIN
|
|
CALL log_me(NEW.a, NEW.b);
|
|
END $$
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
a
|
|
7
|
|
INSERT INTO t2 VALUES (2,5), (2,6);
|
|
SELECT * FROM logtbl WHERE sect = 2 ORDER BY sect,test;
|
|
sect test count
|
|
2 1 3
|
|
2 2 3
|
|
2 3 3
|
|
2 4 3
|
|
2 5 183
|
|
2 5 183
|
|
2 6 183
|
|
2 6 0
|
|
2 6 183
|
|
2 7 0
|
|
SELECT * FROM logtbl WHERE sect = 2 ORDER BY sect,test;
|
|
sect test count
|
|
2 1 3
|
|
2 2 3
|
|
2 3 3
|
|
2 4 3
|
|
2 5 183
|
|
2 5 183
|
|
2 6 183
|
|
2 6 0
|
|
2 6 183
|
|
2 7 0
|
|
DROP TABLE t1, t2, logtbl;
|
|
DROP PROCEDURE just_log;
|
|
DROP PROCEDURE log_me;
|
|
DROP PROCEDURE log_me_inner;
|
|
DROP FUNCTION log_rows;
|