mirror of
https://github.com/MariaDB/server.git
synced 2025-01-22 14:54:20 +01:00
7be4bc4e55
The following is an excerption from the WL.
1. Change so that MIXED is default format
1.1 to change the default for command line --binlog-format
1.2 to alter global_system_variables.binlog_format calculation
basing on command line --binlog-format parameter and
its default.
2. Change test suite so that more testing is done by MIXED format.
2.1 to check if there are test cases requiring --binlog-foramt=statement via
`source include/have_binlog_format_statement.inc' and affected by
altering the latter to be "mixed".
2.2 to check the content of such vulnerable cases to find if
extending to the mixed does not modify results. In that case simply
substitute source arguments as explained.
2.3 if a test in mixed mode deals with features triggering
row-binlogging then if necessary we can switch explicitly
to statement mode or create another test to run with
non-recommended STATEMENT mode
Particullarily, extracting INSERT DELAYED
binlogging subtest for statement mode is performed, and
the snippet is moved into a separate test file.
Note that since now all three modes verify this use case
through 3 different tests.
No changes in item 3 of HLD appeared to be needed.
26 lines
910 B
Text
26 lines
910 B
Text
# Requires statement logging
|
|
-- source include/have_binlog_format_mixed_or_statement.inc
|
|
# TODO: Create row based version once $MYSQL_BINLOG has new RB version
|
|
# Embedded server does not support binlogging
|
|
--source include/not_embedded.inc
|
|
|
|
# Check that user variables are binlogged correctly (BUG#3875)
|
|
create table t1 (a varchar(50));
|
|
reset master;
|
|
SET TIMESTAMP=10000;
|
|
SET @`a b`='hello';
|
|
INSERT INTO t1 VALUES(@`a b`);
|
|
set @var1= "';aaa";
|
|
SET @var2=char(ascii('a'));
|
|
insert into t1 values (@var1),(@var2);
|
|
--replace_column 2 # 5 #
|
|
--replace_regex /table_id: [0-9]+/table_id: #/
|
|
show binlog events from 102;
|
|
# more important than SHOW BINLOG EVENTS, mysqlbinlog (where we
|
|
# absolutely need variables names to be quoted and strings to be
|
|
# escaped).
|
|
--replace_result $MYSQL_TEST_DIR MYSQL_TEST_DIR
|
|
--exec $MYSQL_BINLOG --short-form $MYSQLTEST_VARDIR/log/master-bin.000001
|
|
drop table t1;
|
|
|
|
# End of 4.1 tests
|