mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 10:31:54 +01:00
26565ae1d6
- Fix for LP#700623 "Aria recovery: ma_blockrec.c:3930: _ma_update_at_original_place: Assertion `block->org_bitmap_value == _ma_bitmap_get_page_bits(info, &info->s->bitmap, page)' failed" - Issue was that when deleting a tail page where all index entries where full, the page was marked wrongly in the bitmap. - If debug_assert_if_crashed_table is set, we now crash when we find Aria corrupted. - Write more information if we find something wrong with the bitmap. - Fixed that REPAIR also can fix wrong create_rename_lsn issues (a very unlikely event) - Define STATE_CRASHED_FLAGS as set of all CRASHED flags (to simplify code) storage/maria/ha_maria.cc: Mark the normal page cache (not the page cache for the logs) so that we can request extra debugging for it. Copy the value of debug_assert_if_crashed_table to maria_assert_if_crashed_table so that we can request a crash at exactly the point where we find Aria corrupted. Use STATE_CRASHED_FLAGS storage/maria/ma_bitmap.c: Made bits_to_txt extern so that we can use this in maria_chk Added extra information to the log files to be able to easier find bitmap failures in recovery. (When compiling with -DEXTRA_DEBUG_BITMAP) Added _ma_get_bitmap_description() to request a clear text description of the bitmap. Simplify _ma_check_bitmap_data(), as we know the bitmap pattern in the caller. storage/maria/ma_blockrec.c: In delete_head_or_tail(), fixed a bug where we sent wrong information to _ma_bitmap_set() if the directory was full for a page that should be freed. This fixed LP#700623 (failure in bitmap found during recovery) storage/maria/ma_blockrec.h: Added definitions for _ma_get_bitmap_description() and bits_to_txt storage/maria/ma_check.c: Simplify call to _ma_check_bitmap_data(). Write more information if we find something wrong with the bitmap. Moved getting clear text information about the bitmap to ma_bitmap.c::_ma_get_bitmap_description() storage/maria/ma_checkpoint.c: More asserts storage/maria/ma_create.c: Fix wrong create_rename_lsn during repair. (Create_rename_lsn can be too big if someone restores an old maria_log_file after an Aria file was created) storage/maria/ma_delete.c: Call _ma_set_fatal_error() in case of crashed file Remove not needed test of save_errno == HA_ERR_KEY_NOT_FOUND. (Handled by other code storage/maria/ma_extra.c: Call _ma_set_fatal_error() in case of crashed file Reset share->bitmap.changed_not_flushed to not cause new ASSERTS to trigger. Added _ma_file_callback_to_id() for writing share->id to log file in case of DEBUG logging. storage/maria/ma_init.c: Destroy also translog if it's readonly (as when called by maria_read_log -d) storage/maria/ma_key.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_key_recover.c: STATE_CRASHED -> STATE_CRASHED_FLAGS storage/maria/ma_keycache.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_locking.c: Call _ma_set_fatal_error() in case of crashed file. Added _ma_set_fatal_error() storage/maria/ma_open.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_page.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_pagecache.c: Added extra information to log file to simply debugging of bitmap errors. storage/maria/ma_pagecache.h: Added extra_debug flag to allow marking of row and index cache for extra logging (for debugging). storage/maria/ma_panic.c: Flush both data and index blocks in case of HA_PANIC_CLOSE Fixed wrong position of 'break'. (Not critical for MariaDB as MariaDB never uses this code) storage/maria/ma_recovery_util.c: Avoid writing extra not needed \n to DBUG log. storage/maria/ma_rkey.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_search.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/ma_static.c: Define maria_assert_if_crashed_table storage/maria/ma_update.c: Call _ma_set_fatal_error() in case of crashed file. The new code also avoids a problem where we before would print the error twice. storage/maria/ma_write.c: Call _ma_set_fatal_error() in case of crashed file storage/maria/maria_chk.c: STATE_CRASHED -> STATE_CRASHED_FLAGS storage/maria/maria_def.h: Added STATE_CRASHED_PRINTED to avoid giving error message about crash twice. Added STATE_CRASHED_FLAGS to be able to easily detect and set all CRASHED related flags. Added prototypes for new functions. storage/myisam/mi_panic.c: Fixed wrong position of 'break'. (Not critical for MariaDB as MariaDB never uses this code)
110 lines
3.1 KiB
C
110 lines
3.1 KiB
C
/* Copyright (C) 2006 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/* Initialize an maria-database */
|
|
|
|
#include "maria_def.h"
|
|
#include <ft_global.h>
|
|
#include "ma_blockrec.h"
|
|
#include "trnman_public.h"
|
|
#include "ma_checkpoint.h"
|
|
#include <hash.h>
|
|
|
|
void history_state_free(MARIA_STATE_HISTORY_CLOSED *closed_history)
|
|
{
|
|
MARIA_STATE_HISTORY *history, *next;
|
|
|
|
/*
|
|
Free all active history
|
|
In case of maria_open() this list should be empty as the history is moved
|
|
to handler->share.
|
|
*/
|
|
for (history= closed_history->state_history; history ; history= next)
|
|
{
|
|
next= history->next;
|
|
my_free(history, MYF(0));
|
|
}
|
|
my_free(closed_history, MYF(0));
|
|
}
|
|
|
|
|
|
static int dummy_maria_create_trn_hook(MARIA_HA *info __attribute__((unused)))
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
Initialize maria
|
|
|
|
SYNOPSIS
|
|
maria_init()
|
|
|
|
TODO
|
|
Open log files and do recovery if need
|
|
|
|
RETURN
|
|
0 ok
|
|
# error number
|
|
*/
|
|
|
|
int maria_init(void)
|
|
{
|
|
DBUG_ASSERT(maria_block_size &&
|
|
maria_block_size % MARIA_MIN_KEY_BLOCK_LENGTH == 0);
|
|
if (!maria_inited)
|
|
{
|
|
maria_inited= TRUE;
|
|
pthread_mutex_init(&THR_LOCK_maria,MY_MUTEX_INIT_SLOW);
|
|
_ma_init_block_record_data();
|
|
trnman_end_trans_hook= _ma_trnman_end_trans_hook;
|
|
maria_create_trn_hook= dummy_maria_create_trn_hook;
|
|
my_handler_error_register();
|
|
}
|
|
hash_init(&maria_stored_state, &my_charset_bin, 32,
|
|
0, sizeof(LSN), 0, (hash_free_key) history_state_free, 0);
|
|
DBUG_PRINT("info",("dummy_transaction_object: %p",
|
|
&dummy_transaction_object));
|
|
return 0;
|
|
}
|
|
|
|
|
|
void maria_end(void)
|
|
{
|
|
if (maria_inited)
|
|
{
|
|
TrID trid;
|
|
maria_inited= maria_multi_threaded= FALSE;
|
|
ft_free_stopwords();
|
|
ma_checkpoint_end();
|
|
if ((trid= trnman_get_max_trid()) > max_trid_in_control_file)
|
|
{
|
|
/*
|
|
Store max transaction id into control file, in case logs are removed
|
|
by user, or maria_chk wants to check tables (it cannot access max trid
|
|
from the log, as it cannot process REDOs).
|
|
*/
|
|
(void)ma_control_file_write_and_force(last_checkpoint_lsn, last_logno,
|
|
trid, recovery_failures);
|
|
}
|
|
trnman_destroy();
|
|
if (translog_status == TRANSLOG_OK || translog_status == TRANSLOG_READONLY)
|
|
translog_destroy();
|
|
end_pagecache(maria_log_pagecache, TRUE);
|
|
end_pagecache(maria_pagecache, TRUE);
|
|
ma_control_file_end();
|
|
pthread_mutex_destroy(&THR_LOCK_maria);
|
|
hash_free(&maria_stored_state);
|
|
}
|
|
}
|