mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
ae9724cce1
NDB table". SQL-layer was not marking fields which were used in triggers as such. As result these fields were not always properly retrieved/stored by handler layer. So one might got wrong values or lost changes in triggers for NDB, Federated and possibly InnoDB tables. This fix solves the problem by marking fields used in triggers appropriately. Also this patch contains the following cleanup of ha_ndbcluster code: We no longer rely on reading LEX::sql_command value in handler in order to determine if we can enable optimization which allows us to handle REPLACE statement in more efficient way by doing replaces directly in write_row() method without reporting error to SQL-layer. Instead we rely on SQL-layer informing us whether this optimization applicable by calling handler::extra() method with HA_EXTRA_WRITE_CAN_REPLACE flag. As result we no longer apply this optimzation in cases when it should not be used (e.g. if we have on delete triggers on table) and use in some additional cases when it is applicable (e.g. for LOAD DATA REPLACE). Finally this patch includes fix for bug#20728 "REPLACE does not work correctly for NDB table with PK and unique index". This was yet another problem which was caused by improper field mark-up. During row replacement fields which weren't explicity used in REPLACE statement were not marked as fields to be saved (updated) so they have retained values from old row version. The fix is to mark all table fields as set for REPLACE statement. Note that in 5.1 we already solve this problem by notifying handler that it should save values from all fields only in case when real replacement happens. include/my_base.h: Added HA_EXTRA_WRITE_CAN_REPLACE, HA_EXTRA_WRITE_CANNOT_REPLACE - new parameters for ha_extra() method. We use them to inform handler that write_row() which tries to insert new row into the table and encounters some already existing row with same primary/unique key can replace old row with new row instead of reporting error. mysql-test/r/federated.result: Additional test for bug#18437 "Wrong values inserted with a before update trigger on NDB table". mysql-test/r/ndb_replace.result: Added test for bug #20728 "REPLACE does not work correctly for NDB table with PK and unique index". Updated wrong results from older test. mysql-test/t/federated.test: Additional test for bug#18437 "Wrong values inserted with a before update trigger on NDB table". mysql-test/t/ndb_replace.test: Added test for bug #20728 "REPLACE does not work correctly for NDB table with PK and unique index". sql/ha_ndbcluster.cc: We no longer rely on reading LEX::sql_command value in handler in order to determine if we can enable optimization which allows us to handle REPLACE statement in more efficient way by doing replaces directly in write_row() method without reporting error to SQL-layer. Instead we rely on SQL-layer informing us whether this optimization applicable by calling handler::extra() method with HA_EXTRA_WRITE_CAN_REPLACE flag. As result we no longer apply this optimization in cases when it should not be used (e.g. if we have on delete triggers on table) and use in some additional cases when it is applicable (e.g. for LOAD DATA REPLACE). sql/item.cc: Item_trigger_field::setup_field(): Added comment explaining why we don't set Field::query_id in this method. sql/mysql_priv.h: mysql_alter_table() function no longer takes handle_duplicates argument. Added declaration of mark_fields_used_by_triggers_for_insert_stmt() function. sql/sql_delete.cc: Mark fields which are used by ON DELETE triggers so handler will retrieve values for these fields. sql/sql_insert.cc: Explicitly inform handler that we are doing REPLACE (using ha_extra() method) in cases when it can promote insert operation done by write_row() to replace. Also when we do REPLACE we want to store values for all columns so we should inform handler about it. Finally we should mark fields used by ON UPDATE/ON DELETE triggers as such so handler can properly retrieve/restore values in these fields during execution of REPLACE and INSERT ... ON DUPLICATE KEY UPDATE statements. sql/sql_load.cc: Explicitly inform handler that we are doing LOAD DATA REPLACE (using ha_extra() method) in cases when it can promote insert operation done by write_row() to replace. Also when we do replace we want to save (replace) values for all columns so we should inform handler about it. Finally to properly execute LOAD DATA for table with triggers we should mark fields used by ON INSERT triggers as such so handler can properly store values for these fields. sql/sql_parse.cc: mysql_alter_table() function no longer takes handle_duplicates argument. sql/sql_table.cc: Got rid of handle_duplicates argument in mysql_alter_table() and copy_data_between_tables() functions. These functions were always called with handle_duplicates == DUP_ERROR and thus contained dead (and probably incorrect) code. sql/sql_trigger.cc: Added Table_triggers_list::mark_fields_used() method which is used to mark fields read/set by triggers as such so handlers will be able properly retrieve/store values in these fields. sql/sql_trigger.h: Table_triggers_list: Added mark_fields_used() method which is used to mark fields read/set by triggers as such so handlers will be able properly retrieve/store values in these fields. To implement this method added 'trigger_fields' member which is array of lists linking items for all fields used in triggers grouped by event and action time. sql/sql_update.cc: Mark fields which are used by ON UPDATE triggers so handler will retrieve and save values for these fields. mysql-test/r/ndb_trigger.result: Added test for bug#18437 "Wrong values inserted with a before update trigger on NDB table". mysql-test/t/ndb_trigger.test: Added test for bug#18437 "Wrong values inserted with a before update trigger on NDB table".
92 lines
3.1 KiB
Text
92 lines
3.1 KiB
Text
# Tests which involve triggers and NDB storage engine
|
|
--source include/have_ndb.inc
|
|
--source include/not_embedded.inc
|
|
|
|
#
|
|
# Test for bug#18437 "Wrong values inserted with a before update
|
|
# trigger on NDB table". SQL-layer didn't properly inform handler
|
|
# about fields which were read and set in triggers. In some cases
|
|
# this resulted in incorrect (garbage) values of OLD variables and
|
|
# lost changes to NEW variables.
|
|
# You can find similar tests for ON INSERT triggers in federated.test
|
|
# since this engine so far is the only engine in MySQL which cares
|
|
# about field mark-up during handler::write_row() operation.
|
|
#
|
|
|
|
--disable_warnings
|
|
drop table if exists t1, t2, t3;
|
|
--enable_warnings
|
|
|
|
create table t1 (id int primary key, a int not null, b decimal (63,30) default 0) engine=ndb;
|
|
create table t2 (op char(1), a int not null, b decimal (63,30));
|
|
create table t3 select 1 as i;
|
|
|
|
delimiter //;
|
|
create trigger t1_bu before update on t1 for each row
|
|
begin
|
|
insert into t2 values ("u", old.a, old.b);
|
|
set new.b = old.b + 10;
|
|
end;//
|
|
create trigger t1_bd before delete on t1 for each row
|
|
begin
|
|
insert into t2 values ("d", old.a, old.b);
|
|
end;//
|
|
delimiter ;//
|
|
insert into t1 values (1, 1, 1.05), (2, 2, 2.05), (3, 3, 3.05), (4, 4, 4.05);
|
|
|
|
# Check that usual update works as it should
|
|
update t1 set a=5 where a != 3;
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
delete from t2;
|
|
# Check that everything works for multi-update
|
|
update t1, t3 set a=6 where a = 5;
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
delete from t2;
|
|
# Check for delete
|
|
delete from t1 where a != 3;
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
delete from t2;
|
|
# Check for multi-delete
|
|
insert into t1 values (1, 1, 1.05), (2, 2, 2.05), (4, 4, 4.05);
|
|
delete t1 from t1, t3 where a != 3;
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
delete from t2;
|
|
# Check for insert ... on duplicate key update
|
|
insert into t1 values (4, 4, 4.05);
|
|
insert into t1 (id, a) values (4, 1), (3, 1) on duplicate key update a= a + 1;
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
delete from t2;
|
|
# Check for insert ... select ... on duplicate key update
|
|
delete from t3;
|
|
insert into t3 values (4), (3);
|
|
insert into t1 (id, a) (select i, 1 from t3) on duplicate key update a= a + 1;
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
delete from t2;
|
|
# Check for replace
|
|
replace into t1 (id, a) values (4, 1), (3, 1);
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
delete from t1;
|
|
delete from t2;
|
|
# Check for replace ... select ...
|
|
insert into t1 values (3, 1, 1.05), (4, 1, 2.05);
|
|
replace into t1 (id, a) (select i, 2 from t3);
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
delete from t1;
|
|
delete from t2;
|
|
# Check for load data replace
|
|
insert into t1 values (3, 1, 1.05), (5, 2, 2.05);
|
|
load data infile '../std_data_ln/loaddata5.dat' replace into table t1 fields terminated by '' enclosed by '' ignore 1 lines (id, a);
|
|
select * from t1 order by id;
|
|
select * from t2 order by op, a, b;
|
|
|
|
drop tables t1, t2, t3;
|
|
|
|
--echo End of 5.0 tests
|