mirror of
https://github.com/MariaDB/server.git
synced 2025-01-31 02:51:44 +01:00
1eee3a3fb7
There are two bugs related to failed ADD INDEX and the InnoDB table cache eviction. dict_table_close(): Try dropping failed ADD INDEX when releasing the last table handle, not when releasing the last-but-one. dict_table_remove_from_cache_low(): Do not invoke row_merge_drop_indexes() after freeing all index metadata. Instead, directly invoke row_merge_drop_indexes_dict() to remove the metadata from the persistent data dictionary and to free the index pages.
66 lines
1.6 KiB
Text
66 lines
1.6 KiB
Text
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
SET @save_tdc= @@GLOBAL.table_definition_cache;
|
|
SET @save_toc= @@GLOBAL.table_open_cache;
|
|
|
|
# InnoDB plugin essentially ignores table_definition_cache size
|
|
# and hard-wires it to 400, which also is the minimum allowed value.
|
|
SET GLOBAL table_definition_cache= 400;
|
|
SET GLOBAL table_open_cache= 1024;
|
|
|
|
CREATE TABLE to_be_evicted(a INT PRIMARY KEY, b INT NOT NULL) ENGINE=InnoDB;
|
|
INSERT INTO to_be_evicted VALUES(1,2),(2,1);
|
|
|
|
connect(ddl,localhost,root,,);
|
|
SET DEBUG_SYNC = 'row_log_apply_before SIGNAL scanned WAIT_FOR got_duplicate';
|
|
--send
|
|
ALTER TABLE to_be_evicted ADD UNIQUE INDEX(b);
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC = 'now WAIT_FOR scanned';
|
|
|
|
# During the ADD UNIQUE INDEX, start a transaction that inserts a duplicate
|
|
# and then hogs the table lock, so that the unique index cannot be dropped.
|
|
BEGIN;
|
|
INSERT INTO to_be_evicted VALUES(3, 2);
|
|
SET DEBUG_SYNC = 'now SIGNAL got_duplicate';
|
|
|
|
connection ddl;
|
|
--error ER_DUP_ENTRY
|
|
reap;
|
|
|
|
disconnect ddl;
|
|
connection default;
|
|
# Release the table lock.
|
|
COMMIT;
|
|
SET DEBUG_SYNC = RESET;
|
|
|
|
# Allow cache eviction.
|
|
FLUSH TABLES;
|
|
--disable_query_log
|
|
|
|
# Pollute the cache with many tables, so that our table will be evicted.
|
|
let $N=1000;
|
|
let $loop=$N;
|
|
while ($loop)
|
|
{
|
|
eval CREATE TABLE t_$loop(id INT)ENGINE=InnoDB;
|
|
dec $loop;
|
|
}
|
|
|
|
# Hopefully let InnoDB evict the tables.
|
|
sleep 10;
|
|
|
|
let $loop=$N;
|
|
while ($loop)
|
|
{
|
|
eval DROP TABLE t_$loop;
|
|
dec $loop;
|
|
}
|
|
|
|
SET GLOBAL table_definition_cache= @save_tdc;
|
|
SET GLOBAL table_open_cache= @save_toc;
|
|
|
|
DROP TABLE to_be_evicted;
|