mirror of
https://github.com/MariaDB/server.git
synced 2025-01-23 07:14:17 +01:00
f3985c649d
General overview: The logic for switching to row format when binlog_format=MIXED had numerous flaws. The underlying problem was the lack of a consistent architecture. General purpose of this changeset: This changeset introduces an architecture for switching to row format when binlog_format=MIXED. It enforces the architecture where it has to. It leaves some bugs to be fixed later. It adds extensive tests to verify that unsafe statements work as expected and that appropriate errors are produced by problems with the selection of binlog format. It was not practical to split this into smaller pieces of work. Problem 1: To determine the logging mode, the code has to take several parameters into account (namely: (1) the value of binlog_format; (2) the capabilities of the engines; (3) the type of the current statement: normal, unsafe, or row injection). These parameters may conflict in several ways, namely: - binlog_format=STATEMENT for a row injection - binlog_format=STATEMENT for an unsafe statement - binlog_format=STATEMENT for an engine only supporting row logging - binlog_format=ROW for an engine only supporting statement logging - statement is unsafe and engine does not support row logging - row injection in a table that does not support statement logging - statement modifies one table that does not support row logging and one that does not support statement logging Several of these conflicts were not detected, or were detected with an inappropriate error message. The problem of BUG#39934 was that no appropriate error message was written for the case when an engine only supporting row logging executed a row injection with binlog_format=ROW. However, all above cases must be handled. Fix 1: Introduce new error codes (sql/share/errmsg.txt). Ensure that all conditions are detected and handled in decide_logging_format() Problem 2: The binlog format shall be determined once per statement, in decide_logging_format(). It shall not be changed before or after that. Before decide_logging_format() is called, all information necessary to determine the logging format must be available. This principle ensures that all unsafe statements are handled in a consistent way. However, this principle is not followed: thd->set_current_stmt_binlog_row_based_if_mixed() is called in several places, including from code executing UPDATE..LIMIT, INSERT..SELECT..LIMIT, DELETE..LIMIT, INSERT DELAYED, and SET @@binlog_format. After Problem 1 was fixed, that caused inconsistencies where these unsafe statements would not print the appropriate warnings or errors for some of the conflicts. Fix 2: Remove calls to THD::set_current_stmt_binlog_row_based_if_mixed() from code executed after decide_logging_format(). Compensate by calling the set_current_stmt_unsafe() at parse time. This way, all unsafe statements are detected by decide_logging_format(). Problem 3: INSERT DELAYED is not unsafe: it is logged in statement format even if binlog_format=MIXED, and no warning is printed even if binlog_format=STATEMENT. This is BUG#45825. Fix 3: Made INSERT DELAYED set itself to unsafe at parse time. This allows decide_logging_format() to detect that a warning should be printed or the binlog_format changed. Problem 4: LIMIT clause were not marked as unsafe when executed inside stored functions/triggers/views/prepared statements. This is BUG#45785. Fix 4: Make statements containing the LIMIT clause marked as unsafe at parse time, instead of at execution time. This allows propagating unsafe-ness to the view.
157 lines
4.8 KiB
Text
157 lines
4.8 KiB
Text
stop slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
start slave;
|
|
drop table if exists t1;
|
|
"*** Test 1) Test UDFs via loadable libraries ***
|
|
"Running on the master"
|
|
CREATE FUNCTION myfunc_double RETURNS REAL SONAME "UDF_EXAMPLE_LIB";
|
|
affected rows: 0
|
|
CREATE FUNCTION myfunc_int RETURNS INTEGER SONAME "UDF_EXAMPLE_LIB";
|
|
affected rows: 0
|
|
CREATE FUNCTION myfunc_nonexist RETURNS INTEGER SONAME "UDF_EXAMPLE_LIB";
|
|
ERROR HY000: Can't find symbol 'myfunc_nonexist' in library
|
|
SELECT * FROM mysql.func ORDER BY name;
|
|
name ret dl type
|
|
myfunc_double 1 UDF_LIB function
|
|
myfunc_int 2 UDF_LIB function
|
|
affected rows: 2
|
|
"Running on the slave"
|
|
SELECT * FROM mysql.func ORDER BY name;
|
|
name ret dl type
|
|
myfunc_double 1 UDF_LIB function
|
|
myfunc_int 2 UDF_LIB function
|
|
affected rows: 2
|
|
"Running on the master"
|
|
CREATE TABLE t1(sum INT, price FLOAT(24)) ENGINE=MyISAM;
|
|
affected rows: 0
|
|
INSERT INTO t1 VALUES(myfunc_int(100), myfunc_double(50.00));
|
|
affected rows: 1
|
|
INSERT INTO t1 VALUES(myfunc_int(10), myfunc_double(5.00));
|
|
affected rows: 1
|
|
INSERT INTO t1 VALUES(myfunc_int(200), myfunc_double(25.00));
|
|
affected rows: 1
|
|
INSERT INTO t1 VALUES(myfunc_int(1), myfunc_double(500.00));
|
|
affected rows: 1
|
|
SELECT * FROM t1 ORDER BY sum;
|
|
sum price
|
|
1 48.5
|
|
10 48.75
|
|
100 48.6
|
|
200 49
|
|
affected rows: 4
|
|
"Running on the slave"
|
|
SELECT * FROM t1 ORDER BY sum;
|
|
sum price
|
|
1 48.5
|
|
10 48.75
|
|
100 48.6
|
|
200 49
|
|
affected rows: 4
|
|
SELECT myfunc_int(25);
|
|
myfunc_int(25)
|
|
25
|
|
affected rows: 1
|
|
SELECT myfunc_double(75.00);
|
|
myfunc_double(75.00)
|
|
50.00
|
|
affected rows: 1
|
|
"Running on the master"
|
|
DROP FUNCTION myfunc_double;
|
|
affected rows: 0
|
|
DROP FUNCTION myfunc_int;
|
|
affected rows: 0
|
|
SELECT * FROM mysql.func ORDER BY name;
|
|
name ret dl type
|
|
affected rows: 0
|
|
"Running on the slave"
|
|
SELECT * FROM mysql.func ORDER BY name;
|
|
name ret dl type
|
|
affected rows: 0
|
|
"Running on the master"
|
|
DROP TABLE t1;
|
|
affected rows: 0
|
|
"*** Test 2) Test UDFs with SQL body ***
|
|
"Running on the master"
|
|
CREATE FUNCTION myfuncsql_int(i INT) RETURNS INTEGER DETERMINISTIC RETURN i;
|
|
affected rows: 0
|
|
CREATE FUNCTION myfuncsql_double(d DOUBLE) RETURNS INTEGER DETERMINISTIC RETURN d * 2.00;
|
|
affected rows: 0
|
|
SELECT db, name, type, param_list, body, comment FROM mysql.proc WHERE db = 'test' AND name LIKE 'myfuncsql%' ORDER BY name;
|
|
db name type param_list body comment
|
|
test myfuncsql_double FUNCTION d DOUBLE RETURN d * 2.00
|
|
test myfuncsql_int FUNCTION i INT RETURN i
|
|
affected rows: 2
|
|
"Running on the slave"
|
|
SELECT db, name, type, param_list, body, comment FROM mysql.proc WHERE db = 'test' AND name LIKE 'myfuncsql%' ORDER BY name;
|
|
db name type param_list body comment
|
|
test myfuncsql_double FUNCTION d DOUBLE RETURN d * 2.00
|
|
test myfuncsql_int FUNCTION i INT RETURN i
|
|
affected rows: 2
|
|
"Running on the master"
|
|
CREATE TABLE t1(sum INT, price FLOAT(24)) ENGINE=MyISAM;
|
|
affected rows: 0
|
|
INSERT INTO t1 VALUES(myfuncsql_int(100), myfuncsql_double(50.00));
|
|
affected rows: 1
|
|
INSERT INTO t1 VALUES(myfuncsql_int(10), myfuncsql_double(5.00));
|
|
affected rows: 1
|
|
INSERT INTO t1 VALUES(myfuncsql_int(200), myfuncsql_double(25.00));
|
|
affected rows: 1
|
|
INSERT INTO t1 VALUES(myfuncsql_int(1), myfuncsql_double(500.00));
|
|
affected rows: 1
|
|
SELECT * FROM t1 ORDER BY sum;
|
|
sum price
|
|
1 1000
|
|
10 10
|
|
100 100
|
|
200 50
|
|
affected rows: 4
|
|
"Running on the slave"
|
|
SELECT * FROM t1 ORDER BY sum;
|
|
sum price
|
|
1 1000
|
|
10 10
|
|
100 100
|
|
200 50
|
|
affected rows: 4
|
|
"Running on the master"
|
|
ALTER FUNCTION myfuncsql_int COMMENT "This was altered.";
|
|
affected rows: 0
|
|
ALTER FUNCTION myfuncsql_double COMMENT "This was altered.";
|
|
affected rows: 0
|
|
SELECT db, name, type, param_list, body, comment FROM mysql.proc WHERE db = 'test' AND name LIKE 'myfuncsql%' ORDER BY name;
|
|
db name type param_list body comment
|
|
test myfuncsql_double FUNCTION d DOUBLE RETURN d * 2.00 This was altered.
|
|
test myfuncsql_int FUNCTION i INT RETURN i This was altered.
|
|
affected rows: 2
|
|
"Running on the slave"
|
|
SELECT db, name, type, param_list, body, comment FROM mysql.proc WHERE db = 'test' AND name LIKE 'myfuncsql%' ORDER BY name;
|
|
db name type param_list body comment
|
|
test myfuncsql_double FUNCTION d DOUBLE RETURN d * 2.00 This was altered.
|
|
test myfuncsql_int FUNCTION i INT RETURN i This was altered.
|
|
affected rows: 2
|
|
SELECT myfuncsql_int(25);
|
|
myfuncsql_int(25)
|
|
25
|
|
affected rows: 1
|
|
SELECT myfuncsql_double(75.00);
|
|
myfuncsql_double(75.00)
|
|
150
|
|
affected rows: 1
|
|
"Running on the master"
|
|
DROP FUNCTION myfuncsql_double;
|
|
affected rows: 0
|
|
DROP FUNCTION myfuncsql_int;
|
|
affected rows: 0
|
|
SELECT db, name, type, param_list, body, comment FROM mysql.proc WHERE db = 'test' AND name LIKE 'myfuncsql%' ORDER BY name;
|
|
db name type param_list body comment
|
|
affected rows: 0
|
|
"Running on the slave"
|
|
SELECT db, name, type, param_list, body, comment FROM mysql.proc WHERE db = 'test' AND name LIKE 'myfuncsql%' ORDER BY name;
|
|
db name type param_list body comment
|
|
affected rows: 0
|
|
"Running on the master"
|
|
DROP TABLE t1;
|
|
affected rows: 0
|