mariadb/mysys
Marc Alff 41dc34d60b Bug#58052 Binary log IO not being accounted for properly
Before this fix, file io for the binary log file was not accounted properly,
and showed no io at all.

This bug was due to the following issues:

1) file io for the binlog was instrumented:
- sometime as "wait/io/file/sql/binlog"
- sometime as "wait/io/file/sql/MYSQL_LOG"
leading to inconsistent event_names.

2) the binlog file itself was using an IO_CACHE,
but the IO_CACHE implementation in mysys/mf_iocache.c was
not instrumented to make performance schema calls to record file io.

3) The "wait/io/file/sql/MYSQL_LOG" instrumentation was used
for several log files, such as:
- the binary log
- the slow log
- the query log
which caused file io in these different log files to be accounted
against the same instrument.
The instrumentation needs to have a finer grain and report io
in different event_names, because each file really serves a different purpose.

With this fix:
- the IO_CACHE implementation is now instrumented
- the "wait/io/file/sql/MYSQL_LOG" instrument has been removed
- binlog io is now always instrumented with "wait/io/file/sql/binlog"
- the slow log is instrumented with a new name, "wait/io/file/sql/slow_log"
- the query log is instrumented with a new name, "wait/io/file/sql/query_log"
2010-11-12 07:23:26 +01:00
..
array.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
base64.c fixed compilation warnings. addendum to the fix for bug 29125 2009-03-20 16:27:53 +02:00
ChangeLog
charset-def.c Backporting WL#1213 2010-02-24 13:15:34 +04:00
charset.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
checksum.c WL#5498: Remove dead and unused source code 2010-07-23 17:09:27 -03:00
CMakeLists.txt Patch for Bug#55854 (MySQL AB should not be AUTHOR, copyright incorrect). 2010-08-12 19:19:57 +04:00
default.c BUG#57108: mysqld crashes when I attempt to install plugin 2010-11-04 11:00:59 +01:00
errors.c Merge of mysql-5.1-bugteam into mysql-trunk-merge. 2010-07-20 16:30:10 -03:00
hash.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
lf_alloc-pin.c WL#5498: Remove dead and unused source code 2010-07-23 17:13:36 -03:00
lf_dynarray.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
lf_hash.c WL#5498: Remove dead and unused source code 2010-07-23 17:13:36 -03:00
list.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
Makefile.am WL#5498: Remove dead and unused source code 2010-07-23 17:14:35 -03:00
md5.c Bug #42434: license of mysys MD5 implementation is not GPL-compatible 2009-03-09 20:57:03 +02:00
mf_arr_appstr.c Bug #20748: Configuration files should not be read more than once 2007-11-07 15:23:50 -07:00
mf_brkhant.c Many files: 2006-12-23 20:17:15 +01:00
mf_cache.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
mf_dirname.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:26:38 -03:00
mf_fn_ext.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:26:38 -03:00
mf_format.c BUG#43949 Initialization of slave produces a warning message in Valgrind 2009-04-19 02:21:33 +01:00
mf_getdate.c Merge from 5.0-bugteam 2009-05-13 08:48:00 -07:00
mf_iocache.c Bug#58052 Binary log IO not being accounted for properly 2010-11-12 07:23:26 +01:00
mf_iocache2.c WL#5498: Remove dead and unused source code 2010-07-23 17:16:29 -03:00
mf_keycache.c WL#5498: Remove dead and unused source code 2010-07-23 17:15:41 -03:00
mf_keycaches.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
mf_loadpath.c Merge of mysql-5.1-bugteam into mysql-trunk-merge. 2010-07-02 16:38:04 -03:00
mf_pack.c Merge of mysql-trunk-bugfixing into mysql-trunk-merge. 2010-07-15 10:47:50 -03:00
mf_path.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:13:30 -03:00
mf_qsort.c Fix for bug #31207: Test "join_nested" shows different strategy on IA64 2007-10-17 20:08:58 +04:00
mf_qsort2.c Many files: 2006-12-23 20:17:15 +01:00
mf_radix.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
mf_same.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
mf_sort.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
mf_soundex.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
mf_tempdir.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:13:30 -03:00
mf_tempfile.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:17:56 -03:00
mf_unixpath.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:16:06 -03:00
mf_wcomp.c Many files: 2006-12-23 20:17:15 +01:00
mulalloc.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
my_access.c Merge mysql.com:/home/kent/bk/main/mysql-5.0 2006-12-23 20:20:40 +01:00
my_aes.c my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
my_alarm.c Many files: 2006-12-23 20:17:15 +01:00
my_alloc.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_atomic.c WL#5498: Remove dead and unused source code 2010-07-23 17:18:36 -03:00
my_bit.c WL#5498: Remove dead and unused source code 2010-07-23 17:18:36 -03:00
my_bitmap.c WL#5498: Remove dead and unused source code 2010-07-23 17:09:27 -03:00
my_chsize.c This is the downport of 2009-09-11 22:26:35 +02:00
my_compress.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_conio.c Bug#29125 Windows Server X64: so many compiler warnings 2009-02-13 11:41:47 -05:00
my_copy.c Merge of mysql-5.1-bugteam into mysql-trunk-merge. 2010-07-20 16:30:10 -03:00
my_crc32.c Many files: 2006-12-23 20:17:15 +01:00
my_create.c WL#5161 : Cross-platform build with CMake 2009-11-09 12:32:48 +01:00
my_delete.c Backport of revid:ingo.struewing@sun.com-20091223200354-r2uzbdkj2v6yv111 2010-06-25 19:32:59 +04:00
my_div.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
my_error.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_file.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_fopen.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_fstream.c Backport of: 2009-11-24 16:54:59 +03:00
my_gethostbyname.c Merge of mysql-5.1-bugteam into mysql-5.5-bugteam. 2010-10-19 12:30:06 -02:00
my_gethwaddr.c Merge of mysql-5.1-bugteam into mysql-5.5-bugteam. 2010-10-20 12:48:19 -02:00
my_getncpus.c WL#2595 kernel-independent atomic operations 2009-11-17 17:11:32 -07:00
my_getopt.c Bug#54569 Some options are not allowed to take argument when passed with loose- prefix 2010-10-25 14:30:07 +02:00
my_getpagesize.c Many files: 2006-12-23 20:17:15 +01:00
my_getsystime.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:13:30 -03:00
my_getwd.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:26:38 -03:00
my_handler.c WL#5498: Remove dead and unused source code 2010-07-23 17:16:29 -03:00
my_handler_errors.h WL#5016: Fix header file include guards 2009-09-23 23:32:31 +02:00
my_init.c Merging with mysql-5.5-stage. 2010-08-16 14:50:27 +02:00
my_largepage.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_lib.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:26:38 -03:00
my_libwrap.c Many files: 2006-12-23 20:17:15 +01:00
my_lock.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:26:38 -03:00
my_lockmem.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_malloc.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_memmem.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
my_mess.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:13:30 -03:00
my_mkdir.c Merge mysql.com:/home/kent/bk/main/mysql-5.0 2006-12-23 20:20:40 +01:00
my_mmap.c Backport of revid:ingo.struewing@sun.com-20091223200354-r2uzbdkj2v6yv111 2010-06-25 19:32:59 +04:00
my_new.cc Bug#43461: invalid comparison with string literal in default.c 2009-03-19 17:20:15 -03:00
my_once.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_open.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_port.c my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
my_pread.c WL#2360 Performance schema 2009-12-09 20:19:51 -07:00
my_pthread.c WL#5498: Remove dead and unused source code 2010-07-23 17:17:55 -03:00
my_quick.c This is the downport of 2009-09-11 22:26:35 +02:00
my_rdtsc.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:13:30 -03:00
my_read.c This is the downport of 2009-09-11 22:26:35 +02:00
my_redel.c Merge of mysql-5.1-bugteam into mysql-trunk-merge. 2010-07-20 16:30:10 -03:00
my_rename.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:13:30 -03:00
my_seek.c This is the downport of 2009-09-11 22:26:35 +02:00
my_sleep.c WL#5486: Remove code for unsupported platforms 2010-07-15 08:13:30 -03:00
my_static.c WL#5498: Remove dead and unused source code 2010-07-23 17:14:35 -03:00
my_static.h WL#5498: Remove dead and unused source code 2010-07-23 17:14:35 -03:00
my_symlink.c Bug#39102 valgrind build does not compile in realpath, which make DATA/INDEX DIR fail 2008-10-27 19:25:11 +04:00
my_symlink2.c Merge mysql.com:/home/svoj/devel/mysql/BUG32111/mysql-5.0-engines 2007-11-12 15:26:37 +04:00
my_sync.c Merge of mysql-5.1-bugteam into mysql-5.5-bugteam. 2010-10-19 15:05:25 -02:00
my_thr_init.c Bug #55345, "mysql_library_init causes segfault if executed after calling mysql_library_end" 2010-08-22 20:41:42 -05:00
my_timer_cycles.il WL#2373 Use cycle counter for timing 2009-11-24 16:36:31 -07:00
my_wincond.c A follow-up to the patch for bug #56405 "Deadlock in the MDL deadlock 2010-10-04 13:03:11 +02:00
my_windac.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
my_winerr.c This is the downport of 2009-09-11 22:26:35 +02:00
my_winfile.c Bug#55629 5.5.x goes into infinite loop and high cpu after 2010-10-05 14:18:16 +02:00
my_winthread.c A follow-up to the patch for bug #56405 "Deadlock in the MDL deadlock 2010-10-04 13:03:11 +02:00
my_write.c This is the downport of 2009-09-11 22:26:35 +02:00
mysys_priv.h merge 2010-01-11 17:46:16 +01:00
ptr_cmp.c WL#5105, review fix 2009-11-20 20:01:43 +01:00
queues.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
rijndael.c WL#5498: Remove dead and unused source code 2010-07-23 17:09:27 -03:00
sha1.c Bug #56427 : Replace copyright notice removed from SHA1 code 2010-10-05 17:03:04 +03:00
stacktrace.c Merge from mysql-5.1-bugteam to mysql-5.5-bugteam 2010-11-08 10:55:23 +01:00
string.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
test_charset.c WL#5498: Remove dead and unused source code 2010-07-23 17:09:27 -03:00
test_dir.c Merge mysql.com:/home/kent/bk/main/mysql-5.0 2006-12-23 20:20:40 +01:00
test_xml.c Many files: 2006-12-23 20:17:15 +01:00
testhash.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
thr_alarm.c WL#5498: Remove dead and unused source code 2010-07-23 17:09:27 -03:00
thr_lock.c Auto-merge from mysql-5.5-merge. 2010-08-30 18:07:40 +04:00
thr_mutex.c Merge of mysql-5.1-bugteam into mysql-5.5-bugteam. 2010-10-20 12:48:19 -02:00
thr_rwlock.c A follow-up to the patch for bug #56405 "Deadlock in the MDL deadlock 2010-10-04 13:03:11 +02:00
tree.c Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled 2010-07-08 18:20:08 -03:00
typelib.c Fix C++ style comments, they cause syntax errors in C file. 2010-03-13 22:17:47 +01:00